525a45f22f
loplugin:unnecessaryvirtual in framework
...
Change-Id: I893bf955e45e661e3ec440dbd530fca22931c23b
Reviewed-on: https://gerrit.libreoffice.org/30666
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-11-08 06:11:28 +00:00
291d8d4f94
SafeMode: Add indicator to window title when in Safe Mode
...
Change-Id: I1d8350315768093b4c4af1cd8b732602c5217edb
Reviewed-on: https://gerrit.libreoffice.org/30518
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2016-11-03 12:20:11 +00:00
d164f7e93e
coverity#1374317 Uncaught exception
...
Change-Id: I37a7b2f12cec522e116ccf4b1aa550ad2cba14ea
2016-10-27 21:32:18 +01:00
5d5564fa7a
coverity#1374282 Uncaught exception
...
Change-Id: I1b31825ec27d2395ca030ca79b6c932b7814d901
2016-10-26 09:56:30 +01:00
4846c0fed9
Open menu: Simplify inserting menu entries
...
Change-Id: Ia75f2fe349580003b16735fccf429392d0cf8363
Reviewed-on: https://gerrit.libreoffice.org/30082
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de >
2016-10-20 10:02:54 +00:00
e8667a596d
deal with even more typos in comment plus bin these ****fences*****
...
Change-Id: I9ed2db862797f7ffedf6ae0b27ba99c54882a981
Reviewed-on: https://gerrit.libreoffice.org/29501
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Andras Timar <andras.timar@collabora.com >
2016-10-03 17:30:28 +00:00
f0249a88fc
Fix typos
...
Change-Id: I6730c6c5eab9157533822e5045e9f86109062580
Reviewed-on: https://gerrit.libreoffice.org/29433
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2016-10-03 11:21:52 +00:00
91dd2db17b
loplugin:override: No more need for the "MSVC dtor override" workaround
...
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
aa0d0536a4
tdf#97527 - vcl: reference-count Menu
...
some places are marked with "dodgy"- need to check those to see
what is going on, because they are leaving dangling pointers behind
in the Menu class
Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b
Reviewed-on: https://gerrit.libreoffice.org/26516
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-06-23 06:28:00 +00:00
2c8fe2e737
update unusedmethods plugin to deal with constructors
...
and fix the operator< implementations in some of the other
plugins too.
Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-18 10:03:44 +00:00
cd96f8998d
Avoid reserved identifiers
...
Change-Id: I13bbc627ba058143862a77d27bbca85f2d961d60
2016-04-12 20:03:44 +02:00
f045c536db
clang-tidy performance-unnecessary-value-param in framework
...
Change-Id: I80987ea1bfac7478574de46ee30fc58fcc17eb68
2016-04-12 11:56:07 +02:00
4c7ec9f112
cleanup: remove unused com/sun/star/uno includes
...
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.
Add a few missing includes provided by them.
Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-12 06:38:26 +00:00
b0e678c861
FwkTabWindow is unused since d6d86237b1b438919609988049ac4a152612fee1
...
Change-Id: Ifad573ac687548a889165012e7b7bb2f4b82750c
2016-04-12 00:43:06 +03:00
8c7e9633d3
Remove obsolete comment
...
Change-Id: I43b65f48d75e293c3fe721e6d5a401f1e176df12
2016-04-11 16:58:46 +02:00
396ed6ff96
Drop unused uses of TransactionBase
...
Change-Id: I606fc8e06823df9caf8786b1ae4d432c061ddc80
2016-04-08 09:20:11 +02:00
4be81de0d6
Resolve OUStringList typedef
...
Change-Id: Ifb5dc5128b5619abb83eea427c7fb1115fd825f3
2016-04-07 21:44:02 +02:00
02041335d8
vector::clear is just fine
...
Change-Id: I5d8ec98d437913861b584cf3077618a2d6b0a0be
2016-04-07 21:32:41 +02:00
b24937c114
Remove junk that erroneously remained in previous commit
...
Change-Id: I18ca0d4daf44eafe88d6f812fa17576edbfb8dfd
2016-04-07 21:21:10 +02:00
9a2dea0640
dllexport class deriving from template means trouble with MSVC
...
Change-Id: I9d170168eac26c52fd6ca8d22124e8ff78b81226
2016-04-07 21:15:55 +02:00
f57c9921de
Get rid of BaseHash wrapper (to unbreak Windows build)
...
Change-Id: Ieae7d6af7a4753958ebf2aeae9d2ae6fafe5efe9
2016-04-07 18:14:53 +02:00
e2ef269916
Fold PropertySetHelper into its only use, Frame
...
Change-Id: I148e15c2c91a985cd110f5589adbf26c102b1cfb
2016-04-07 17:33:26 +02:00
bfb9612226
tdf#97499 Fixed containers parameters clearing #3
...
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4
Reviewed-on: https://gerrit.libreoffice.org/23752
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-04-04 05:46:34 +00:00
f7a75a66fa
cleanup: remove unused Reference.h(xx) includes
...
and unused using-declarations from Reference.h
Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2016-04-02 19:01:24 +00:00
2f804099b7
loplugin:constantparam in framework
...
Change-Id: I7b7914365ef5d5c6f120f34c93f359c156aa6a02
2016-03-23 10:19:43 +02:00
21b92f386c
MenuDispatcher::m_pMenuManager is always nullptr
...
... as shown by 7da15debe39b50255cc08b3fef7ae38185a9174f.
Which means that MenuManager is unused, and MenuDispatcher
does nothing useful.
Change-Id: Ic85619531054a573d971d38b52609e1cbcaf780c
Reviewed-on: https://gerrit.libreoffice.org/23117
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2016-03-10 15:23:31 +00:00
db8067145f
loplugin:write only fields
...
Change-Id: I44f249a17d0a510ec63a488b656d57a1a392f821
2016-02-22 14:34:21 +02:00
b14224fe97
loplugin:unusedmethods
...
using an idea from dtardon:
<dtardon> noelgrandin, hi. could you try to run the unusedmethods clang
plugin with "make build-nocheck"? that would catch functions that are
only used in tests. e.g., i just removed the whole o3tl::range class,
which has not been used in many years, but htere was a test for it...
<noelgrandin> dtardon, interesting idea! Sure, I can do that.
Change-Id: I5653953a426a2186a1e43017212d87ffce520387
Reviewed-on: https://gerrit.libreoffice.org/22041
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2016-02-08 06:08:14 +00:00
40f9ae367c
Modified state icons not packaged into zip
...
It seems that images must be mentioned in some src file.
Unfortunately had to copy the save icon in place of the
modified icon in galaxy, to satisfy the resource compiler.
Change-Id: If3fa7a8a194a0289c79fa10987138dfb35eaeca2
2016-01-13 00:58:57 +02:00
13e894bb52
loplugin:unusedmethods unused return value in framework
...
Change-Id: I6e02f34702ba59a961c3fec3d025e775f4e26760
2016-01-11 13:14:08 +02:00
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com >
2016-01-10 14:17:20 +00:00
fb8a3fac5d
loplugin:nullptr: More NULL -> nullptr automatic rewrite
...
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-10 08:06:06 +01:00
1d5c39192e
new loplugin:unusedfields
...
run it over the framework module
Change-Id: I1220a4be0936ba30136ce22ffd78633c8a7b9d35
2015-11-20 10:12:58 +02:00
a3eec8a043
Toolbar: Add 'Save As' to 'Save' dropdown
...
Change-Id: I6597ae5569b29d09a8c44fc9a55b71166aa37b05
2015-11-19 13:39:17 +01:00
06c5c63020
loplugin:nullptr (automatic rewrite)
...
Change-Id: Ie178c474921c1695927a9b01a9972baf09fbb73d
2015-11-10 10:31:27 +01:00
7408498de3
loplugin:stringconstant
...
Change-Id: I865efc1884b82d430fe7df2e432d43f5425a83d4
2015-11-02 14:50:33 +02:00
d191d1f9b6
com::sun::star->css in framework
...
Change-Id: If5a77db83fcbef5ed436f2043ddeb7c515a840dc
Reviewed-on: https://gerrit.libreoffice.org/19356
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-14 06:37:16 +00:00
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
a0649f316e
Fix typos
...
Change-Id: Id94c03249b2752e88499628b3ad12936b361bb2f
Reviewed-on: https://gerrit.libreoffice.org/18950
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
Tested-by: Oliver Specht <oliver.specht@cib.de >
2015-10-01 11:26:35 +00:00
58aea3f36c
loplugin:unusedmethods
...
- improvements to the plugin to find more method calls
- improvements to python script to remove more false+
- fix the FORCE_COMPILE_ALL build flag to include code in
the $WORKDIR
Change-Id: I4d6015dcb9b9d60c26f0bcee8abad807177a7836
Reviewed-on: https://gerrit.libreoffice.org/19064
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-10-01 10:43:24 +00:00
34180700b2
loplugin:removeunusedmethods, remove unused stuff
...
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
99bfc363a6
convert Link<> to typed
...
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-20 06:37:36 +00:00
9af27324f5
convert Link<> to typed
...
Change-Id: I38f2c15b4f8bb1d7187b019d26a2644b087898c1
Reviewed-on: https://gerrit.libreoffice.org/18357
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-07 06:56:57 +00:00
5beffcf3f1
convert Link<> to typed
...
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83
Reviewed-on: https://gerrit.libreoffice.org/18258
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-09-03 07:20:27 +00:00
431f2ce818
framework: tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants.
Change-Id: I6acff50f23bcbac58c689caf2a7f07dbd5404e57
Reviewed-on: https://gerrit.libreoffice.org/17734
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-14 10:46:14 +00:00
26c106a5ae
append '(Remote)' in the titlebar when remote file is opened
...
Change-Id: Idf0a9594406601154319ae17e42ece4bf2d56dc9
2015-08-14 08:45:20 +02:00
2886f830a9
idl,framework,forms: inline some use-once typedefs
...
Change-Id: Icb4908c274ec0778af7ed9fe2d935bf6723fedfb
2015-08-04 08:55:56 +02:00
5256953397
inline some use-once typedefs
...
Change-Id: I55cc82c8e180cce371c996690608090b1bfdfda4
Reviewed-on: https://gerrit.libreoffice.org/17494
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-03 12:16:13 +00:00
f5deb46349
remove some unused typedefs
...
Change-Id: I98c1e7eaa66b7afb05255a017a3de54714637501
Reviewed-on: https://gerrit.libreoffice.org/17491
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-03 08:53:21 +00:00
a45827b230
loplugin:unusedmethods
...
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-30 06:23:00 +00:00
