Commit Graph

9996 Commits

Author SHA1 Message Date
ad9cfbcf02 Don't exclude a var from loplugin:salbool merely because of use in >>=
Change-Id: I1b8a3dfa1dc6b351ab0903a74eae19dfa6d0888d
2017-01-05 09:17:47 +01:00
9ae8e4d356 Base SvxLineEndWindow on ToolbarPopup
Fixes size and position issues under gtk3/wayland

Change-Id: I357a5935e2b44fd3d5effde8cf7d3499e26384db
2017-01-05 00:11:29 +02:00
835556b51a Prefix SvxLineEndWindow members
Change-Id: I0cfe88c65cc75757938a9f8004c219fbe39f88dd
2017-01-05 00:11:29 +02:00
9e4ae869f4 Get rid of SvxLineEndWindow resizing
Change-Id: I0135f084f64b9709688f0f9205940baf193c5d83
2017-01-05 00:11:29 +02:00
a487e548a0 Use command labels for the color popup title
Change-Id: I2f61e25ef4451775320f8fa1761a951ab94af7d5
2017-01-05 00:11:28 +02:00
59ad262ab9 last bitmaps that pMaskColor arg was used on converted to true transparency
Change-Id: I99bb32355bc53e2c870f84e60fc1e35b9dfe8270
2017-01-04 20:34:55 +00:00
4d1cbb7e89 drop unused SplitWindow::ImplDrawButtonRect
Change-Id: I0ccb4adfec39f8717d5921e04809af65be066d0a
2017-01-04 20:34:55 +00:00
8077cc31a0 all users of InsertFromHorizontalBitmap use all args
Change-Id: I458036b084645af509d64a78f5389415dfc4115a
2017-01-04 20:34:55 +00:00
9e7b0ef950 follow up remove unused autohide leftovers
Change-Id: Ic7281e915075519c300a330557399111838d7d34
2017-01-04 16:50:44 +00:00
b4a31534b9 drop AutoHide code
only used from reportdesign and that appears to be overlooked from an earlier
eradication program

Change-Id: I196fd7ccbc909c935daf534d55e6b39de8510f23
2017-01-04 16:50:44 +00:00
4ad249af88 tdf#105093 sd PDF export: handle embedded videos
In practie embedded files always have a temp file URL, so from the PDF
export's point of view they are still URLs, just at the end the contents
of the URL is embedded to the PDF, not just the URL itself.

So add a SetScreenStream() that's similar to SetScreenURL(), but it's
for embedded, not linked videos.

Change-Id: Ifcc60357ef0f5fed0bdec02e0c84cb16ee147781
Reviewed-on: https://gerrit.libreoffice.org/32727
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04 16:27:44 +00:00
da7b100184 tdf#97228 Moved class ControlCacheKey in a seperate include file.
class ControlCacheKey defined in include/vcl/salnativewidgets.hxx is used
only by vcl therefore it is moved to a seperate include file named
ControlCacheKey.hxx which is inside vcl/inc/ControlCacheKey.hxx.

This header file contains the definition of the the class ControlCacheKey.

Since this class uses an object of another class named Size which is
defined in gen.hxx therefore this is included in ControlCacheKey.hxx.

All the files that references the class ControlCacheKey includes
ControlCacheKey.hxx with the syntax: #include "ControlCacheKey.hxx"

Change-Id: I7d7b3e1cf6950a953e6bbed670c1914826b2bacd
Reviewed-on: https://gerrit.libreoffice.org/32422
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-01-04 16:02:26 +00:00
0e71075bb7 Related: tdf#104841 sw PDF export: handle linked videos on non-first pages
Be explicit about the page number, this way a video on the second page
doesn't end up as an annotation for the first page. (In the Impress case
each slide is exported separately, so there this wasn't a problem.)

Change-Id: I83ba9cb4a3b2a6734bd88a138654e391199651c6
Reviewed-on: https://gerrit.libreoffice.org/32696
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-04 08:15:51 +00:00
909164e474 tdf#39674: translated German to English in svdtrans.cxx
Change-Id: Ic46e747a9dbec99e6037c6b35e175ce5b1efdd82
Reviewed-on: https://gerrit.libreoffice.org/32594
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-03 14:55:11 +00:00
1b5e144b4e SetPin and IsPinned are in an always-false circular isolated relationship
Change-Id: I4fb3aaa8a5e8c62091fbc542deae6af3a113a608
2017-01-03 14:12:25 +00:00
19ce5fa563 WB_PINABLE isn't set anywhere
Change-Id: I6acc4b9dc87dd6023b5ad7013bc27180d6e0db6c
2017-01-03 14:12:25 +00:00
803f474337 Mark [Scoped]VclPtrInstance as SAL_WARN_UNUSED
Stack-allocated instances of the non-Instance [Scoped]VclPtr variants are
occasionally used merely for the side-effect of holding objects alive (like
css::uno::Reference and rtl::Reference, which are also not SAL_WARN_UNUSED for
that reason).

Change-Id: I37ebfaf028a646cb2777c0baf0d99992057a22bd
2017-01-03 14:35:38 +01:00
f82cd9c786 Hold SfxInfoBarWindow by VclPtr
In SfxInfoBarContainerWindow::removeInfoBar, disposeAndClear is already called
on the removed member (once found), so the ScopedVclPtr (also calling
disposeAndClear when going out of scope) should not be necessary.

Change-Id: Ibf4d19ebd5f1a6217e1d18ef0458c9b865667898
2017-01-03 14:32:24 +01:00
e4a84c625f default copy ctor and assignment operator are good enough
and block default move equivalents

Change-Id: I360860512d2c88f8688685f4e751ded6335549da
Reviewed-on: https://gerrit.libreoffice.org/32656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-03 09:58:27 +00:00
0621795c54 Move documentation for parameter of SfxObjectShell::GetTitle() to include file
A re-design of this API would be a good idea.

Is this function ever called with some specific max length that would
not be one of the magic values? Probably the sanest would be to turn
the magic value constants into a normal (scoped) enum, and have two
separate functions: One that takes no parameter and returns the whole
title (and then let the caller take care of truncating as necessary),
and one that takes such an enum and returns a correspondingly mangled
title. The less magic and defaulted parameters the better.

Change-Id: I9e3aa95fae981c5ed48300b753556fa9074c1166
2017-01-03 10:24:47 +02:00
f97cd16ea4 coverity#1371220 Missing move assignment operator
Change-Id: Ie2947ea621da7ffc6c9530f007e1acdd4efb50cb
Reviewed-on: https://gerrit.libreoffice.org/32650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02 18:23:50 +00:00
9d6a749bc6 tdf#104841 sd PDF export: handle linked videos
Use the screen annotation markup for this purpose.

Change-Id: I129111cbe08c19c2f3b3ae046408ff9b2a28520c
Reviewed-on: https://gerrit.libreoffice.org/32654
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-01-02 17:42:02 +00:00
d09888b835 use std::unique_ptr
Change-Id: I1c4f81e0ba0529b9e365c6ddb3d77a8a6a6d5741
Reviewed-on: https://gerrit.libreoffice.org/32649
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-02 16:35:58 +00:00
136f5a209e Prefer prefix ++/-- operators for non-primitive types.
Change-Id: I9be657cd0b5ed964db8db2ca28fd2874ae5406aa
cppcheck: performance
Reviewed-on: https://gerrit.libreoffice.org/32431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02 10:36:33 +00:00
970edf67d2 noone cares about the return from WriteGraphic either
Change-Id: Ia91a8b4ae7768bd1623b8e2b545fcc9beff1fbc7
2017-01-01 21:03:49 +00:00
0a599225bc noone cares about the return from ReadGraphic
Change-Id: Ifd86dee6f2657155faaa31a229feb16178d89f34
2017-01-01 21:02:44 +00:00
a3eaeff2db don't need to forward declare ImageList here
Change-Id: Id0477b52a004a9a24e4733aa4916cd1b011c6fdd
2017-01-01 20:48:47 +00:00
9bbc168c29 fdo#39674: translated German to English in svdmodel.cxx
Change-Id: I48992d2738de40060239b4c25c4adbe64c97b4be
Reviewed-on: https://gerrit.libreoffice.org/32537
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-01 19:38:12 +00:00
a29bd2dabb cleanup tailing backslashes
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-30 18:48:24 +00:00
394f65f212 RSC_ACCEL isn't in use anymore
Change-Id: I581d55adfbae078c154eaf41cf98c2be0f5dfd5d
2016-12-30 16:43:13 +00:00
1fec83409c no use of RSC_KEYCODE appears to remain
Change-Id: I968093ef9a9a5647f410432918a60dbc2331192a
2016-12-30 16:40:29 +00:00
73545e2efa RscImageListFlags is newly unused
Change-Id: Ic6ed613496ce1903f752ae3b6258121870f99558
2016-12-30 16:33:32 +00:00
21f934a7c5 ImageLists no longer loaded from resource files
Change-Id: I5bf1c75dce7bc9af6aaa92447fab7239dff4b676
2016-12-30 16:33:32 +00:00
b8e27d5da6 unwind this ImageList
after discovering one of the referenced images was missing

Change-Id: I25321ee436976415313fb004e798fad897673ee5
Reviewed-on: https://gerrit.libreoffice.org/32511
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-30 15:00:49 +00:00
6f4d538ede this can be local
Change-Id: I8084e8c33a930f13cf7f1212a086a9f1ad1bdfb4
2016-12-27 16:31:58 +00:00
e61fe745d1 tdf#97228 Move include file include/vcl/BitmapProcessor.hxx to vcl/inc/
Adapt users, all in vcl, accordingly.

Change-Id: I4531840091da73fa8fc29175407fa8a737deac18
Reviewed-on: https://gerrit.libreoffice.org/32442
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2016-12-27 10:53:16 +00:00
833e6ca9d2 use std::vector instead of naked array in SfxItemPool
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4
Reviewed-on: https://gerrit.libreoffice.org/32384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-26 18:35:59 +00:00
c61981c193 use the existing namespace map for the oox namespace export
Change-Id: I7909b08db556c6c65c1547303f2b899c30feaba4
Reviewed-on: https://gerrit.libreoffice.org/32425
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-26 02:04:39 +00:00
2dc821572e HasImageAtPos takes an id not a pos
so rename it

Change-Id: Id83a11d31d1d51f414e6a98ebb71a227c7fe448f
2016-12-24 17:09:36 +00:00
995dca0837 remove unused ImageList member
since

commit 284ca1a5840c5fcbf4f9d1eff02ae607cdc2c222
Author: Noel Grandin <noelgrandin@gmail.com>
Date:   Sat May 28 14:38:03 2016 +0200

    Convert RSC_TOOLBOX to scoped enum

    and drop unused (in .src files) constants

Change-Id: I0e05389e1bbd5f74ff3b3cd9f1f16cfd54b992c2
2016-12-23 20:58:21 +00:00
7a339a03d2 unwind AVMEDIA_IMGLST/AVMEDIA_IMGLST_L ImageLists
Change-Id: Idf115c12c5da138141010673ed2bf0525aec6aaa
2016-12-23 20:40:22 +00:00
5f116966de tdf#87700 command to rotate 180 degrees
added command to rotate an image 180 degrees in Writer

Change-Id: I4a1e40f4c3475aceb24edd44691a74372f61b49a
Reviewed-on: https://gerrit.libreoffice.org/30074
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-23 18:29:37 +00:00
cfcbbfaeb4 remove unnecessary casting in BrowseBox::pDataWin member
Change-Id: I1187691c19808c53ff3839cfd8892ab06d36053e
Reviewed-on: https://gerrit.libreoffice.org/32381
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23 11:56:20 +00:00
c4c23515d6 merge svx::sidebar::BulletsSettings with svx::sidebar::BulletsSettings_Impl
Change-Id: I7cf6bb4cf3aa532718753904c2100882b0df6775
Reviewed-on: https://gerrit.libreoffice.org/32373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23 11:43:10 +00:00
46d3163f77 loplugin:unusedmethods
Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5
Reviewed-on: https://gerrit.libreoffice.org/32336
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-23 04:46:35 +00:00
cf6f3ad82b unwind RID_SVXIMGLIST_FMEXPL ImageList
Change-Id: If9d733c5242e2f2b9947b251cfe832d1c10bd4bd
Reviewed-on: https://gerrit.libreoffice.org/32350
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-22 18:30:05 +00:00
cc15806b52 convert BasePrimitive2D::get2DDecomposition to use a visitor
which lets us avoid constructing the decomposition when we are only
interesting in the bounding box, e.g. for hit testing

Change-Id: Icd8d430b75d207063f1db70e5a0822d5d82a7d00
Reviewed-on: https://gerrit.libreoffice.org/30835
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:44:08 +00:00
41f7878ccb convert BmpFilter to scoped enum
Change-Id: I22c5b49f108d4ce103dea5098a2a0dc9d6bc854c
Reviewed-on: https://gerrit.libreoffice.org/32292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:43:35 +00:00
7444355f1d convert VclButtonBoxStyle to scoped enum
Change-Id: If3d02c9be54a509f85214acbf4a1e6cfd8955dc4
Reviewed-on: https://gerrit.libreoffice.org/32291
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:43:22 +00:00
21907d647c convert VclSizeGroupMode to scoped enum
Change-Id: Id731fb3d5f9eb5ddaa3af41b010bff340f1077ce
Reviewed-on: https://gerrit.libreoffice.org/32290
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-22 06:43:06 +00:00