Commit Graph

102 Commits

Author SHA1 Message Date
1617eef124 loplugin:countusersofdefaultparams in include/sot..svl
Change-Id: Idb022a4a6fb950f1b259abbba57daed9401732d9
Reviewed-on: https://gerrit.libreoffice.org/31038
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21 12:09:24 +00:00
389999abdb make comphelper::containerToSequence a little smarter
So we don't have to specify the source and destination type as often.

Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624
Reviewed-on: https://gerrit.libreoffice.org/30700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09 07:48:18 +00:00
4d87443bf5 loplugin:constantparam
Change-Id: Idbe8c8e6b3d44cacce296ec8c79b2b244281057c
Reviewed-on: https://gerrit.libreoffice.org/29321
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-30 06:57:26 +00:00
1658bd231b loplugin:unusedenumvalues
Change-Id: I9dcc9f73af6db5b4f7cc946bc28931e5c230b34c
Reviewed-on: https://gerrit.libreoffice.org/29012
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-19 10:44:05 +00:00
b647996a9b replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.

Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-15 12:01:11 +02:00
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
cb958bb5e0 loplugin:constantparam in sot..svl
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882
Reviewed-on: https://gerrit.libreoffice.org/28769
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09 11:27:23 +00:00
33b38082ca put StreamMode masks in scope of enum class
Change-Id: I77682f7e289a59b986bb84edf014029a20266470
Reviewed-on: https://gerrit.libreoffice.org/28420
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-27 12:06:15 +00:00
52b91f3454 new loplugin fragiledestructor
fix up a small number of places that it finds

Change-Id: Iedc91e141edfb28f727454f698cd2155a7fd5bf4
Reviewed-on: https://gerrit.libreoffice.org/26566
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12 08:45:14 +00:00
2bcafc519e loplugin:passstuffbyref also for {css::uno,rtl}::Reference
Change-Id: Ifc0f5788c906b2c014f277b2d290c33806c357ab
2016-07-07 18:59:55 +02:00
48a8d6d843 loplugin:singlevalfields in various
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e
Reviewed-on: https://gerrit.libreoffice.org/26738
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28 11:21:17 +00:00
2c8fe2e737 update unusedmethods plugin to deal with constructors
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18 10:03:44 +00:00
412cfb531b convert EXCHG_OUT_ACTION_FLAG to scoped enum
and split it off into its own field and parameter

Change-Id: Ib13dea5e9475a74cd66a0da4e5ec50a51fbda9d5
Reviewed-on: https://gerrit.libreoffice.org/24926
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13 08:15:19 +00:00
890e13344b loplugin:constantparam in sot
Change-Id: I8bf1ee672f035831d197e4a65bd40bae41278da0
Reviewed-on: https://gerrit.libreoffice.org/23800
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04 14:02:28 +00:00
2a78e3eb92 loplugin:constantparam in sot
Change-Id: I380b5a824b1bc8cd322471519d2d87ab7f2bca1c
Reviewed-on: https://gerrit.libreoffice.org/23320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17 10:33:08 +00:00
f731ecfd7b sot: accept JPEG as a clipboard format where we accept PNG already
Change-Id: I64602d31e8aa873e2280f86eaf618dd6007acaf1
2016-01-19 13:49:29 +01:00
fa7c7b1601 loplugin:unusedmethods unused return value in include/sot
Change-Id: I8da6d5f60b6c65ff0da8659045da1cd7666fb1d9
2016-01-13 08:44:45 +02:00
3b7150c0ab SotFactory is in fact not used: remove + cleanup
Also SotData_Impl is used only in exchange.cxx now. Move there.

Change-Id: I548095c2226d92aea4193bb1a3671e2381996435
2016-01-05 20:41:12 +01:00
5b22663e37 Make SotFactory private to sot/ and clean a bit
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2016-01-05 20:41:11 +01:00
ec3f724158 loplugin:unusedfields
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-30 10:34:38 +02:00
234884c09d loplugin:unusedfields in include/sot,include/svl,include/svtools
Change-Id: Ia2dd13c2c48b127ab85311a668fa1f37608d360a
2015-11-25 08:25:09 +02:00
fa91dd31f3 5th step to remove tools/rtti.hxx
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11 10:49:30 +00:00
bf6d72afea Missing includes
Restored some missing includes and
refactored sot/formats.hxx.

Change-Id: I11b7102b06889f426f5e0f3efa3a835c6e774d88
Reviewed-on: https://gerrit.libreoffice.org/19891
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
2015-11-10 22:18:45 +00:00
e246e5e3cf loplugin:nullptr (automatic rewrite)
Change-Id: I147f1ca886d5194d0e7180c427923225ef4ef927
2015-11-10 10:31:40 +01:00
d1eb389d70 sal_uLong/long to ErrCode
Change-Id: I2ba2d867785765e4850c60070e86419f66e25f57
2015-10-27 13:59:09 +01:00
f8dac0391c Use mutable instead of const_cast'ing this
Change-Id: I790cd140166bf0041abebbe0c4d9c15e931628f1
2015-10-27 13:59:08 +01:00
c06e2fcc2c com::sun::star->css in include/sot to include/typelib
Change-Id: I9cd92b53370a6b6018d2f7c648890f9c014a27de
2015-10-23 10:48:50 +02:00
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
34180700b2 loplugin:removeunusedmethods, remove unused stuff
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
2015-09-29 15:08:43 +02:00
403c13487c loplugin:unusedmethods
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba
Reviewed-on: https://gerrit.libreoffice.org/17506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 09:39:22 +00:00
f17f89aadc include: inline some use-once typedefs
Change-Id: I064e95c72e5f67178cf2875f457adac241cee529
2015-08-04 08:55:57 +02:00
8b7ec376c3 -Werror,-Wunused-private-field
Change-Id: I59979f84602276c9a8aa1ffc1d145c1ef8f0a31f
2015-08-03 21:03:01 +02:00
a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
64bc8b45b5 i#107734 Support for Math Input Panel in Windows 7
The patch introduces a new command .uno:ImportMathClipboard to module Math.
It imports MathML content from clipboard and transforms it to Starmath
It handles clipboard MIME type 'application/mathml+xml' and
plain text, which can be interpreted as MathML segment.
It partly solves issues #i14252, #i34781, and #i53509 too.
Review by: Hanya <hanya.runo@gmail.com>
(cherry picked from commit 9ec2148653436be8612273439180749e71e2ce58)

Conflicts:
	dtrans/source/win32/ftransl/ftransl.cxx
	officecfg/registry/data/org/openoffice/Office/UI/MathCommands.xcu
	sot/inc/sot/formats.hxx
	sot/source/base/exchange.cxx
	starmath/sdi/smath.sdi
	starmath/source/view.cxx

Change-Id: I6cb5e8f737ee2e39f9ce96aba841db347a8806e4
2015-07-08 16:57:49 +02:00
c4379aacbe loplugin:unusedmethods sot
Change-Id: I14e8bb3e4e38ade1044ce1c50c9676a65152724c
Reviewed-on: https://gerrit.libreoffice.org/16733
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06 11:45:28 +00:00
9136f2344a expand out some sot macros
Change-Id: Ic583fe767e5f85628f8270ec740ce3e72fe56ded
Reviewed-on: https://gerrit.libreoffice.org/16722
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-03 10:46:06 +00:00
d3d4b86919 loplugin:unusedmethods tools
Change-Id: I45f5489233879126d4f9ee3d01db504d950bb597
Reviewed-on: https://gerrit.libreoffice.org/16656
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-02 06:37:53 +00:00
4e99430e63 remove custom RTTI from SotFactory
unused

Change-Id: I22f55aa403cd97ce2c5bf6a521c14a693e4373a7
2015-06-29 10:05:35 +02:00
329350919e remove custom RTTI from SvDataCopyStream
nothing is using it, except perhaps for XFillExchangeData, which was
using it incorrectly :-(

Change-Id: Ib9246a20bc97ad91d3e3e97fa642217686fc8c46
2015-06-29 10:05:35 +02:00
efdd215124 callcatcher: update unused code
Change-Id: I8563922204d3ec93bf138cbd1aaba620c0215bf7
2015-05-08 09:47:35 +01:00
65ab049bcf error: class 'SotStorage' is implicitly friends with itself
Change-Id: Id05657c866f872846676bb8d8c7ab009292569ab
2015-05-07 11:33:32 +02:00
9b1b3c9fdd Reduce enum class StorageMode to bool transacted
Change-Id: I04e53d7de9f2f26e9338a82f7d5ae5dab1682712
2015-05-07 11:05:07 +02:00
79d853e318 StorageMode::DiskspannedMode is effectively unused
Change-Id: I977b0a51a609d3cbc30abd308715f91cad2cfdfa
2015-05-07 11:05:06 +02:00
8a91528a3e StorageMode::CreateUnpacked is never used
Change-Id: I7285c90c82b04e3ebb2db371b675689de9c183d7
2015-05-07 11:05:06 +02:00
bd9f5783ab SotStorage ctor nStorageMode param is effectively only used as bool transacted
Change-Id: I3458ae46c256206e31ad268f47e8b92a30f3738e
2015-05-07 11:05:06 +02:00
76c50eddb0 Remove unused SotStorage ctor nStorageMode param
Change-Id: I6af399ef26d3f3ee97a49592cf97c590c0781eb0
2015-05-07 11:05:05 +02:00
66335d3898 Remove unused SotStorage::OpenSotStream nStorageMode param
Change-Id: Ieda14d984f1614056c701a50ce637ea6fe9620f3
2015-05-07 11:05:05 +02:00
9e90401a21 Remove unused SotStorageStream ctor nStorageMode param
Change-Id: I5f114f4ca92d991d17ad871d11a78a5306191f9c
2015-05-07 11:05:05 +02:00
0241519f32 Unwind SotStorageStreamRef typedef
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-07 11:05:04 +02:00