Commit Graph

637 Commits

Author SHA1 Message Date
19ce5fa563 WB_PINABLE isn't set anywhere
Change-Id: I6acc4b9dc87dd6023b5ad7013bc27180d6e0db6c
2017-01-03 14:12:25 +00:00
394f65f212 RSC_ACCEL isn't in use anymore
Change-Id: I581d55adfbae078c154eaf41cf98c2be0f5dfd5d
2016-12-30 16:43:13 +00:00
1fec83409c no use of RSC_KEYCODE appears to remain
Change-Id: I968093ef9a9a5647f410432918a60dbc2331192a
2016-12-30 16:40:29 +00:00
73545e2efa RscImageListFlags is newly unused
Change-Id: Ic6ed613496ce1903f752ae3b6258121870f99558
2016-12-30 16:33:32 +00:00
21f934a7c5 ImageLists no longer loaded from resource files
Change-Id: I5bf1c75dce7bc9af6aaa92447fab7239dff4b676
2016-12-30 16:33:32 +00:00
4956fd64e1 tools: Kill empty enum LockType
It seems unused in the first place.

Change-Id: I556ae97b86498c63315f1f1bbe8d55fdbb10c1aa
Reviewed-on: https://gerrit.libreoffice.org/32218
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-20 12:40:42 +00:00
554ff8ef0f coverity#1371265 Missing move assignment operator
Change-Id: I5b7c6992e92e4d096b8230774ed8f4bfaaad5831
2016-12-12 10:29:21 +00:00
c43fdd0d17 tools: document our favorite rectangle class too
Change-Id: Id7698a1e2a8fc1ca6bf35868311fc5b284d45145
2016-12-07 14:46:05 +01:00
a08cb3b52e convert PolyFlags to scoped enum
and remove the XPolyFlags enum, which has the same values and was being
converted to PolyFlags anyhow

Change-Id: Iaead84933c79a7603698a4e50257dd944df89c41
Reviewed-on: https://gerrit.libreoffice.org/31627
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07 10:34:17 +00:00
70f05aa69a convert PolyStyle to scoped enum
Change-Id: Ia35fdbb5e40888db9558988ac069741b31721f0e
Reviewed-on: https://gerrit.libreoffice.org/31633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06 05:31:18 +00:00
aa54f8aa09 convert EscapeType to scoped enum
Change-Id: Ic688a9803772a7ce39d03374986118d85807c18c
2016-12-05 12:49:02 +02:00
50151db9f7 convert FSysStyle to o3tl::typed_flags
Change-Id: I58a63a0e6f619442f21827064644ecd8ca57b8ff
2016-12-05 12:49:02 +02:00
bfde4866e0 convert DecodeMechanism to scoped enum
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05 12:49:02 +02:00
803215142e convert INetURLObject::EncodeMechanism to scoped enum
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05 12:49:02 +02:00
74314b11a4 Drop a bunch of font metrics flags
These flags mean nothing these days, there are either always true or
always false, since we no longer support bitmap or Type 1 fonts.

Change-Id: Ie14ca480225a6346d868a44e58e7666c3a06931d
Reviewed-on: https://gerrit.libreoffice.org/31346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-29 13:38:48 +00:00
6c60aa313c introduce DBG_UNHANDLED_EXCEPTION_WHEN for calls with an explanatory message
Change-Id: Ic80f2ed2c0fdff20d1ee1968bec2840bf914fb5e
2016-11-25 16:26:42 +01:00
6f71fa11c0 vcl makes no use of menu Get/Set DefaultItem
this is exposed through uno however, so move it into VCLXMenu to continue to
support it doing nothing of great value there

Change-Id: I6888e61cbec85faa2d1fcca8731ab42023e594c6
2016-11-24 14:56:13 +00:00
7cca2c7fb3 new loplugin finalprotected
look for final classes, and make sure they don't have protected members

Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4
Reviewed-on: https://gerrit.libreoffice.org/30895
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16 09:10:16 +00:00
3c73942c8c loplugin:countusersofdefaultparams in include/svx..unotools
Change-Id: I02e933da66241e99e3b81d90d679f1502bab3fef
Reviewed-on: https://gerrit.libreoffice.org/30866
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-16 06:32:00 +00:00
cd61f3eb3d Make sure not to compare different subclasses of Pair
(A related option would be to make those subclasses derive privately from Pair,
but there are a few places that generically operate on any Pair instances, like
Pair::Read/WritePair or SvxShape::ForceMetricToItemPoolMetric/100th_mm.)

Change-Id: I6c638fe65ee5684593fdeab29b144f547e173f4e
2016-11-09 12:17:04 +01:00
0f96b3f33f loplugin:unnecessaryvirtual in test..vbahelper
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965
Reviewed-on: https://gerrit.libreoffice.org/30649
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07 10:11:33 +00:00
7abd369964 loplugin:unusedmethods
Change-Id: Ie1f840c3ec9a2d5888f95cf05e531a8a9464bf2e
Reviewed-on: https://gerrit.libreoffice.org/30524
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04 07:13:58 +00:00
e5c1e15eda loplugin:expandablemethods in toolkit..tools
Change-Id: I7221bf131d28804ee93474b11973bbc066cc2764
Reviewed-on: https://gerrit.libreoffice.org/30268
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26 06:50:03 +00:00
cdd3963a3a no RSWND anymore
Change-Id: I5547a0d19ae60ea06dd666c77deaf0de910975d0
2016-10-25 11:41:23 +01:00
00c4595646 no WindowResHeader, no RscWindowFlags
Change-Id: Id41e9414237c849c211785151e9170c71a449238
2016-10-25 11:41:23 +01:00
2b6abbaa24 can drop RSC_WINDOW now
Change-Id: Ic60b35eb78ebd3e934cbf45c2184edf59c971a53
2016-10-25 11:41:23 +01:00
f615d6195a can drop RSC_CONTROL now
Change-Id: I651b9d2ead019507b8e48c4e19797bf8f8b9a438
2016-10-25 11:41:23 +01:00
3c4f6b7804 no FixedText loaded from .src now
Change-Id: Ic377c5238e1763a2defdce72bbe893e826aae5ac
2016-10-25 11:41:23 +01:00
dcd099d335 nothing uses RSC_BUTTON anymore now
Change-Id: I016d1507fcadf5da1207241c6feec1a03188eef7
2016-10-25 11:41:23 +01:00
cd6e8837c1 no PushButton loaded from .src now
Change-Id: Ib866107995ab0496cf4f37a5e780458031d2fc25
2016-10-25 11:41:23 +01:00
f23297e111 no Edit controls loaded from .src now
Change-Id: I42c7377c101c642ea39028e05e4ffd58fc7435d7
2016-10-25 11:41:23 +01:00
30a458d7e1 no ListBox loaded from .src now
Change-Id: I7d30c38777f6a36c991271a3617d3f75c83cd490
2016-10-25 11:41:23 +01:00
eac3793d4d no FixedImage is loaded from .src anymore
Change-Id: I7c5acd18b14822d6344af3709c6d8cfb343104ef
2016-10-24 15:06:41 +01:00
602274c77f no ImageButton loaded from .src now
Change-Id: If6f6718e1e6d756b99a499deafa4310c76a75ad3
2016-10-24 13:04:38 +01:00
ece0ff48fa loplugin:expandablemethodds in include/tools..unotools
Change-Id: I5607d4a2a81de1a3ae329acd1e90280a21522f06
Reviewed-on: https://gerrit.libreoffice.org/30097
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21 06:17:24 +00:00
398d641664 tdf#89307: Removed T* SvRef::opeartor &()
Usage has been replaced with SvRef::get() or removed where applicable.

Change-Id: I49f108910b668466134c40940b53fc3ab2acd816
Reviewed-on: https://gerrit.libreoffice.org/29780
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-18 09:27:56 +00:00
292560a957 loplugin:unusedmethods
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4
Reviewed-on: https://gerrit.libreoffice.org/29968
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18 06:15:55 +00:00
ad067cb0c7 remove StringListResource in favour of ResStringArray...
and turn local resources used as lists of strings into
string array resources

Change-Id: I9d67a790659963bca87aacba1c052d7b244b4e21
2016-10-12 14:03:00 +01:00
3abc986877 GetAutoHelpId logically can only return an empty string now
Change-Id: Ie7368f083a5aa6bcfb249375fbae1f4cd92e02ba
2016-10-12 11:38:00 +01:00
540b7d3ae4 drop RSC_DOCKINGWINDOW*
Change-Id: Ibcddc2def40e15f4a2f92fec13c1c3fd2f824d68
2016-10-12 11:38:00 +01:00
c3c008f360 drop unused defines and enums
Change-Id: Ifc81443047380221a7329be5b6b094ee8bc76451
2016-10-12 11:38:00 +01:00
4cc4df51d9 no toolboxes are loaded from .src anymore
Change-Id: Ia2eabf157845b9b6b00b745332a558ffdd1e0ec7
2016-10-12 11:38:00 +01:00
41683b9a85 use more 'nullptr' in SvRef templates
Change-Id: Idfe140863b7ec51230110d942c5732e18f411192
Reviewed-on: https://gerrit.libreoffice.org/29701
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-12 06:38:11 +00:00
6cded5c853 Demonstrate that SvRef ==/!= are acceptable as member functions
Change-Id: I30771393bc16f2320cd89f018ff93c756913b70d
2016-10-11 08:52:41 +02:00
9f7f5b5f91 no numericfield, spinfield or spinbutton loaded from .src now
Change-Id: I90e4390d1fadcbb18036861dc9b9d39fa8a73551
2016-10-10 14:56:58 +01:00
f004aa9951 tdf#89307: Removed SvRef::operator T*()
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-10 08:48:30 +00:00
cc589883a9 rename SetResMgr to ClearResMgr
since that is it's only use.
Also clean up the comment block nearby.

Change-Id: Iff67aeec176963132bb8a1e64e0c81853f0912d7
Reviewed-on: https://gerrit.libreoffice.org/29654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10 08:13:00 +00:00
365d1ec278 no ComboBoxes loaded from .src anymore
Change-Id: Ic497dddfe326e9cc06e71c39284b2848d17ae0c8
2016-10-09 20:52:00 +01:00
c65386cec9 no radiobuttons or checkboxes loaded from src files anymore
Change-Id: Ie10ebcf56a6145c8edeb903bed1beb0cf5cf8a7a
2016-10-08 21:00:11 +01:00
face6b6977 TOOLS: Remove SvStream::ImpInit()
Change-Id: I7a089e77586041bce662c33a5610df122d5a74be
Reviewed-on: https://gerrit.libreoffice.org/27940
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-08 19:53:47 +00:00