Commit Graph

169 Commits

Author SHA1 Message Date
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
59e8f814b0 coverity#1132662 Dereference after null check
Change-Id: Ifbaa05e70c8958d0289047efb75a13e0b8a13a4b
2014-07-18 15:36:19 +01:00
c6ff610688 Notify screen readers when selection changes in listboxes
When you change selections in listboxes without dropdown fuctionality
an accessilble event needs to be sent, this does not happen today.
An example of such listbox is the Suggestions in the Spelling and
Grammar dialog.

Change-Id: I6100c88ae5398d8bf3f511aee7b35e88fbf151f5
Reviewed-on: https://gerrit.libreoffice.org/10087
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-07-04 18:51:58 +00:00
cfdc2cf64a fix some more indent and strip ::rtl::
Change-Id: I8a4f220e6e07babbb2fa8f8dcab524ba90e62986
2014-07-02 12:14:25 +01:00
192e087f97 Related: #i124856# guard against crash
Patch By: hanya
Review By: jsc

(cherry picked from commit efe87c0d84e5f76034378d48d0d1fc2025a37645)

Conflicts:
	accessibility/source/standard/vclxaccessiblebox.cxx

Change-Id: I24fd4278406dacea33230cc1bf1528e3c5aaedf2
2014-07-02 12:14:24 +01:00
0f1d72510a fix some mangled indentation
Change-Id: I09be3a66562e1c5c1c2b27c670672f63b0a652b0
2014-07-02 12:14:24 +01:00
e62764108a hmm, that's not right
Change-Id: Id714a54b08127c594c108c824bb0dedd74bb5c06
2014-06-20 21:00:15 +01:00
3258c4f7b7 Dropdown combo-/listboxes should support accessible action togglePopup
At least VoiceOver needs it to be able to open the dropdown in a native
way (through AXShowMenu). The list still isn't accessible on mac but
that is an other issue.

Change-Id: I825b54536dfc9743b722eb55873bde3d5eef953d
Reviewed-on: https://gerrit.libreoffice.org/9833
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-20 16:18:09 +00:00
9b25820648 fdo#74681: quick help may be used as accessible text
In case a tool box item does not contain some text to be used as the
accessible item name, use the quick help text.

Change-Id: I9caadb0989729787d8572f4007652bcab02b0412
2014-06-16 17:40:50 +02:00
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
af047fc242 accessibility: sal_Bool->bool
Change-Id: Id44e7a88ba4118259c990a2c6997230586d378bb
2014-04-15 09:02:33 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
86a32589e9 Find places where OUString and OString are passed by value.
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
d47ca30f1c No need for implGetBounds to be SAL_CALL
Change-Id: I4eb1f998de57a4ceeb7990c6e4a964ce0d07ea88
2014-03-11 15:35:52 +01:00
acca15f7a0 accessibility: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I7f8848adf245a4fdf56bff67cc15ee0efb818c43
2014-03-10 17:39:51 +01:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
994a359649 Revert "Let's use RADIO_BUTTON and CHECK_BUTTON roles"
This reverts commit 97d4f7e07462cbc33e8ebf0bc2bbf8a17c232d50, which appears to
be incomplete: CHECK_BUTTON is not defined anywhere.
2014-02-26 22:36:49 +01:00
97d4f7e074 Let's use RADIO_BUTTON and CHECK_BUTTON roles
Thank you Caolán and Niklas for your support!

Change-Id: Ied978b36cc309b2668889d878a309d1a1400633a
2014-02-26 22:31:14 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
09a1c9d31f cppcheck: duplicateIf
- replace duplicate TIB_DROPDOWN test with TIB_DROPDOWN + TIB_DROPDOWNONLY
- consider also TIB_RADIOCHECK as AccessibleRole::TOGGLE_BUTTON

Change-Id: Id159349ae1515681f47c373ba3d839ed406284ab
Reviewed-on: https://gerrit.libreoffice.org/8164
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:06:44 -06:00
2e821e4741 Remove visual noise from accessibility
Change-Id: I876e5c4d1991b35c1dc2cea709d8a2ddf781b012
Reviewed-on: https://gerrit.libreoffice.org/8225
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-25 16:18:25 +00:00
33740b7d5a Replace exisiting TriState, AutoState with more generic TriState
Change-Id: Ida05478aae5a379775c671e0c2f2851d820d78be
2014-02-24 12:27:32 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
da13dd9a35 Related: fdo#74242 #i104470# we now have a seperate CARET_CHANGED event
so cursoring left and right in normal non-multiline edit widgets should
give a11y cursor-changed events

Change-Id: I91e86e43d049793912b3ffcc2802bb9aa4b3857c
2014-02-19 11:07:12 +00:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
2b04d0a17f Avoid unnecessary heap allocation
Change-Id: I7bc1a0960cc100c51b90c50838a5ef620f3c763f
2014-02-07 18:43:30 +01:00
59238ef422 Related: #i123862# use O*String's isEmpty() method...
to check for emptiness in modules starting with 'a'

Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 40b2ffbb1036c2f2db50965525009213d8fd6343)

Conflicts:
	accessibility/source/extended/accessibleiconchoicectrl.cxx
	accessibility/source/extended/textwindowaccessibility.cxx
	accessibility/source/standard/vclxaccessiblebox.cxx
	accessibility/source/standard/vclxaccessibletoolboxitem.cxx
	automation/source/server/recorder.cxx
	automation/source/server/statemnt.cxx
	avmedia/source/framework/mediacontrol.cxx
	avmedia/source/framework/soundhandler.cxx
	avmedia/source/gstreamer/gstplayer.cxx
	avmedia/source/viewer/mediawindow.cxx

Change-Id: I8e6d6754282634f6931a2e7f73f08f70c23d452e
2014-02-04 12:14:11 +00:00
bfe5448939 bool improvements
Change-Id: I09ac60e907b7c0a78934dce05343e2ba2b6df49f
2014-01-28 20:26:30 +01:00
05534b5523 Resolves: #i124008# listbox entry's are selected automatically...
on mouse over instead of mouse click

(cherry picked from commit ae97dcb5b8d2dead81b007c5c71daf608f0c7bc3)

Change-Id: Ib1ce0db60785ddc96473ef4ce88b578287956164
2014-01-28 11:37:23 +00:00
2a77e7a310 coverity#1158122 : Explicit null dereferenced
Change-Id: I6ffec6e69ca5ddb01998653d2f7637ed062bdc80
2014-01-19 15:14:55 -06:00
8db51361dc coverity#1132662 Dereference after null check
Change-Id: Iaccf8bb7903702d2bed3c4fc2195172e18ead6c7
2014-01-19 15:11:09 -06:00
9fd10cca8e coverity#1132661 Dereference after null check
Change-Id: Ida147599810b0aff4a7ebd00b90475b1c6cd1366
2014-01-19 15:07:28 -06:00
382421189f Improve exception message
Change-Id: I06ffe3088546d55b29d61ccfae16937d8a7ce9e8
2013-11-27 09:15:14 +01:00
1533129759 Revert sense in VCLXAccessibleBox::getAccessibleActionCount again
...this had been switched from "m_bIsDropDownBox ? 1 : 0" to "m_bIsDropDownBox ?
0 : 1" in efb23f29983f87104a684e7fab00b84fc59d131d "Integrate branch of
IAccessible2" for no apparent reason and broke JunitTest_testtools_unoapi.

Change-Id: I276d2f452648387a5fa693349cf868787b2d48e1
2013-11-27 09:12:38 +01:00
383c7a4b90 statement aligned as second statement in if body but not in a statement block
Change-Id: I237148ec56164994e5c3168ef5b7dfc56588cad9
2013-11-26 14:41:27 +01:00
efb23f2998 Integrate branch of IAccessible2
(cherry picked from commit e2f90c93c97f3cf137c348ed302c6470f398aa70)

Change-Id: I44ce0d69f3e7364038b00b1ba0f0d27e60132a37

WaE: Prevent uninitialized variable warnings.

(cherry picked from commit b989f4074ea70729d527b307bfbe49e01a0d3646)
2013-11-26 10:24:24 +00:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
7cfd340e92 Fix crash & reduce nesting.
Change-Id: Ifbfe401cd69678c278394d190a37cc41a28d5c56
2013-07-17 13:27:46 +02:00
35b45e6915 VCLXAccessibleTabPageWindow: unhandled IndexOutOfBoundsException
... due to GetPagePos returning -1, work around that (can be easily
triggered in template manager).

Change-Id: Ic1334b224730d79e533539a24f115dc9aa2e9570
2013-06-20 17:01:32 +02:00
0f200cc30e fdo#63154: Change Min/Max/Abs for std::min/max/abs
Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-20 11:09:54 +00:00
7f51d6fa0d coverity#707601 Uninitialized pointer field
Change-Id: I1b7c13be91bd2047a4141b6d7d8e4363b0ddcf4f
Reviewed-on: https://gerrit.libreoffice.org/2211
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:34:48 +00:00
2c570973cc coverity#707602 Uninitialized pointer field
Change-Id: I70fa5899f3bb1eeb22eb18d77f2c816ec60aa97c
Reviewed-on: https://gerrit.libreoffice.org/2212
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:33:52 +00:00
de3fc38adf coverity#707600 Uninitialized pointer field
Change-Id: I8894efd7549299903f0ca4c223a3dff60a9db536
Reviewed-on: https://gerrit.libreoffice.org/2210
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-18 15:33:12 +00:00
d204c1a47e Remove last RTL_CONSTASCII_* from accessibility
Change-Id: Icb8f66c9f6ad70828aa55580a1f3aae8b2af1593
Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1500
Reviewed-by: Olivier Hallot <olivier.hallot@alta.org.br>
Tested-by: Olivier Hallot <olivier.hallot@alta.org.br>
2012-12-29 15:29:18 +00:00
70626249cd API CHANGE a11y unpublishing and add/removeListener rename.
The a11y API has never really been picked up by tools vendors, let's
not tie ourselves up here for no good reason.

This unpublishes all css::accessibility, and dependend API.

With that, we can change the rather unfortunately-named add/
removeEventListener to be add/removeAccessibleEventListener, thus
not conflicting with the XComponent methods of the same name.

Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
2012-11-29 16:58:16 +01:00
7470cc532f fdo#46808, Adapt reflection::ProxyFactory UNO service to new style
The service is deprecated, but we still have a handful of in-tree
users, and converting it lets me thread XComponentContext through
a bunch of classes.

Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-28 13:06:18 +01:00
9955dbebbd AllSettings with LanguageTag
Change-Id: I710ae66e51139662eb442b681fdf9cc9d158551d
2012-11-22 12:34:59 +01:00
06ec1c0895 Merge branch 'master' into feature/killsdf
Conflicts:
	Repository.mk
	RepositoryFixes.mk
	connectivity/prj/build.lst
	extensions/prj/build.lst
	filter/prj/build.lst
	fpicker/prj/build.lst
	l10ntools/StaticLibrary_transex.mk
	saxon/build.xml
	shell/prj/build.lst
	solenv/gbuild/AllLangResTarget.mk
	solenv/gbuild/Configuration.mk
	solenv/gbuild/UI.mk
	ucb/source/ucp/webdav/webdavcontent.cxx
2012-11-11 18:24:14 +01:00