Commit Graph

118 Commits

Author SHA1 Message Date
bbf2ba5650 WaE: -Werror=unused-parameter
Change-Id: I064c738b371999bb73726bde3669c710742fae80
2014-08-07 18:52:04 +01:00
26ed25538f New files missing from prev commit
Change-Id: I9889e97a7f9e70d8b2d82e26d9e0f971a943d007
2014-08-07 18:46:21 +02:00
9c9f0ea2c3 Include RTTI in generated vtables for ubsan's vptr-based checks
...though only on gcc3_linux_x86-64 for now.

Change-Id: Id90554425e78b38a5a97149f2a7d3ac04cbe0c9b
2014-08-07 18:21:19 +02:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
8a85f9f29f Drop unnecessary nFPR parameter
...as passing (an upper bound on) the number of vector registers used in %al is
only required for variable-argument function calls, according to
<http://www.x86-64.org/documentation/abi.pdf> "System V Application Binary
Interface: AMD64 Architecture Processor Supplement, Draft Version 0.99.6."

Unclear why this got added in f424e55b4e66ffbee5b34f45ef5ea18d77c4d15c
"INTEGRATION: CWS sixtyfour11," maybe on the basis of "doesn't hurt."

Change-Id: If6f8359d5bf6458274905d64adf82634bf90a24d
2014-07-07 12:01:03 +02:00
aa04177e7c Drop unused nGPR parameter
Change-Id: I60026ccc9c752389260a6b4e6255c53981eea4ba
2014-07-07 12:01:01 +02:00
e19670ac3c fix build
Change-Id: Ic301459b751585a91aa4d6667fbe512d13bbb458
2014-06-11 09:51:24 +01:00
d2725abf5d Fix build on FreeBSD with libc++
Change-Id: Ib51b05eb3f7c5d1288bee0f9f738ab1f37251c3e
Reviewed-on: https://gerrit.libreoffice.org/9722
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-11 08:19:19 +00:00
14ab8c3f1d bridges: remove SAL_THROW macro
Change-Id: I2daafd711aedab17b6c13fde95c8af5f49d38a7c
2014-06-05 08:17:49 +02:00
26cf118247 Fix undefined misaligned writes
Change-Id: I8ad64babd43c2a692c305f3fa56331edb6d502ee
2014-05-23 16:50:16 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
08947735f9 Work around Clang -fsanitize=address inline asm error
Change-Id: Ia37b21af217af9b24522da28e817b4cb6ca2f8c9
2014-05-15 15:13:54 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
f598a018f1 Clean up function declarations
Change-Id: I5d3ed0a266f327dbc8d506090221c43ef89fbcc0
2014-04-08 10:35:57 +02:00
6660b9d2c5 Remove visual noise from bridges
Change-Id: I53fa23d335ff62795f09f9838d4064cea71aeb65
Reviewed-on: https://gerrit.libreoffice.org/8237
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 05:21:45 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
9e77c2fb7c Remove UNOIDL "array" and "union" vaporware remnants
...and deprecate what cannot be removed for compatibility.

Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
fc320c41b5 bool improvements
Change-Id: I215bb8c484785175c297953a2ef385b2caf87bee
2014-01-28 20:26:30 +01:00
6455415c7c Use proper bool operations
Change-Id: Ibd904ce1061814e06cd64db607de6f5cfeed1c2a
2014-01-10 17:11:43 +01:00
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
e036d4b706 Spell "indices" correctly
Change-Id: I63b1de195bf2f3f8bfd185181f48b1520cdd849f
2013-10-02 21:57:42 +03:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
c17f01753c ...and similarly for __cxa_allocate_exception and __cxa_throw
Change-Id: I87ae299aac97180f0587c553d85b051decca155c
2013-06-20 15:59:09 +02:00
5ba3d1740b Clean up declaration of __cxa_get_globals
At least Clang trunk towards 3.4 now rejects incompatible declarations of the
same extern "C" function in different namespaces, so that trick of getting at
the function that is exported by libstdc++ but only rudimentarily if at all
exposed in cxxabi.h no longer worked.

TODO: This change should be reflected in any other bridges where it is relevant,
too.

Change-Id: Ie3ccbdb7d75cc98636d02c0435958532620724f2
2013-06-20 14:02:48 +02:00
c759d349f2 optimization fix to UNO bridge's callVirtualMethod() for generic x86_64
if the pCallStack variable is optimized out then any assumptions of the
method's inlined assembler about stack layout collapse. Adding a pseudo
dependency to the pCallStack variable solves that problem

(cherry picked from commit 254359b9ed96152091b8f7a74a3442cf6c553e04)

Conflicts:
	bridges/source/cpp_uno/gcc3_freebsd_x86-64/uno2cpp.cxx
	bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx

Change-Id: I5ba7713c2630bb3ecc4343632e796c38541bcd0e
2013-05-29 10:03:27 +01:00
d77d01b84a add some documentation links to the assembler needed for the UNO bridges
ceterum censeo: good old C-linkage interoperability would be much more robust,
reliable and easier to maintain compared to the current UNO-bridges approach
of emulating the behaviour of the individual compiler, linker, dylib, unwind, etc.
environments and thus being extremely platform specific. What an incredible waste
of energy for little (if any) gain. SCNR.
(cherry picked from commit c9fe5d026f2081d493a198a33cf3b1d558166965)

Conflicts:
	bridges/source/cpp_uno/gcc3_freebsd_x86-64/call.s

Change-Id: I728bce449e8e56572f31b50fb1452d1c2f9d7fea
2013-05-09 15:54:23 +01:00
7dac241ca0 Remove RTL_CONSTASCII_(U)STRINGPARAM in bridges
Change-Id: Id8777ee7f587846399e95cf3b1b37d669a76bae5
Reviewed-on: https://gerrit.libreoffice.org/3139
Reviewed-by: Christina Roßmanith <ChrRossmanith@web.de>
Tested-by: Christina Roßmanith <ChrRossmanith@web.de>
2013-04-02 20:25:44 +00:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
17ff7b41d1 re-base on ALv2 code. Includes:
Patches contributed by: Armin Le Grand.
    #118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
    http://svn.apache.org/viewvc?view=revision&revision=1195906
    #118485# - Styles for OLEs are not saved.
    http://svn.apache.org/viewvc?view=revision&revision=1182166
    #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
    http://svn.apache.org/viewvc?view=revision&revision=1293316
    #119337# Solves the wrong get/setPropertyValue calls in
    SvxShapeText (and thus in SvxOle2Shape)
    http://svn.apache.org/viewvc?view=revision&revision=1344156

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i117717#: remove wrong assertion
    http://svn.apache.org/viewvc?view=revision&revision=1172349

    Patch contributed by Herbert Duerr
    goodbye Registration and License dialogs, don't let the door hit you
    http://svn.apache.org/viewvc?view=revision&revision=1172613
    help gcc 4.6.0 on 32bit ubuntu 11.10"
    http://svn.apache.org/viewvc?view=revision&revision=1245357

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

Revert "sb140: #i117082# avoid unncessary static class data members
    commit 21d97438e2944861e26e4984195f959a0cce1e41.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
2012-11-15 16:06:08 +00:00
10511acd08 Revert "sb140: #i117295# use rtl::Static"
This reverts commit d3794d2d8ab2ee3f8118d61538bb753335b37f23.

Conflicts:
	bridges/source/cpp_uno/cc50_solaris_intel/except.cxx
	bridges/source/cpp_uno/cc50_solaris_sparc/except.cxx
	bridges/source/cpp_uno/gcc3_ios_arm/except.cxx
	bridges/source/cpp_uno/gcc3_linux_arm/except.cxx
	bridges/source/cpp_uno/gcc3_linux_x86-64/except.cxx
2012-11-15 16:06:07 +00:00
61c0a3a63d switch bridges to gbuild
Change-Id: Ia19ff61f1f7fb446298472acd6722b57ddaeddec
2012-09-22 08:15:30 +02:00
bdc909b07d re-base on ALv2 code. 2012-06-19 18:00:37 +01:00
54e9a28390 typo: paramters, paramaters -> parameters
Change-Id: If58683331c50f2a95204e8e2dea11edbef3ccb63
2012-06-19 16:44:08 +02:00
08a38341e0 WaE: Clang unused variable 2012-04-25 10:07:01 +02:00
a8e489495a Hack around different __cxa_* declarations in different GCC versions 2012-03-30 16:41:06 +02:00
166be18da0 Missing includes 2012-03-30 14:01:54 +02:00
fa09866ccb Adapt cpp_uno/gcc3_linux_x86-64 to GCC 4.7 cxxabi.h
...the same way cpp_uno/mingw_intel was already adapted.
2012-03-30 14:01:52 +02:00
7c9e637bde alloca(3) needs stdlib.h on *BSD because there is no alloca.h 2012-03-29 23:47:07 +02:00
3db7c67ddd Mark all registered as clobbered that are not saved across call 2012-03-29 17:52:47 +02:00
0fdbb5b0ea Make cpp_uno/gcc3_linux_x86-64 bridge work with GCC 4.7
See comment in callvirtualmethod.cxx for details.
2012-03-29 17:52:47 +02:00
9377bb4dcc Some cppcheck cleaning 2012-02-05 10:19:40 +01:00
0439af27e1 Code cleanup: ( () ) replaced by (()) 2012-01-26 17:41:07 +00:00
7c704c78d3 Removed some unused parameters; added SAL_UNUSED_PARAMETER.
SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones.  To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.
2012-01-21 15:21:16 +01:00
697415eb4e WaE and build errors with OSL_DEBUG_LEVEL == 2 2012-01-05 09:18:15 +00:00
7113c7152d catch by constant reference 2011-11-30 11:27:42 +09:00
4dc45a2854 remove include of pch header in bridge 2011-11-27 12:56:37 -06:00
9550bed8aa Adapted numbering of reordered asm parameters. 2011-10-19 00:22:34 +02:00
bf1f0183d5 Some fixes for "clang version 3.1 (trunk 142234)" (with --enable-werror, on Linux x86_64). 2011-10-18 23:10:56 +02:00
be6a8677a6 OSL_TRACE: Remove trailing newlines
Done with perl regex:
s/(\n\s*OSL_TRACE\(\s*\"[^\n]+?)\s*(\\n)+(\"[^\n]*\)\;\n)/$1$3/gs;

- removed trailing whitespaces and (multiple) newlines
2011-09-21 09:28:39 +02:00