We must not export label position properties for doughnut charts, else
MS Office would think the file is corrupt.
Change-Id: Icfab257ffb6da945b8add661e6455aa66cc475ab
"Automatic" fill in docx and xlsx should be solid white, whereas in
pptx it is no fill (transparent).
Change-Id: I7e64f2f895e4c4ed072a234e622a348599456f37
Originally it was a pptx document, but switched to docx because reloading
an impress document in cppunit currently mysteriously crashes.
Change-Id: I3e9ba6b9a4dc7d3c0ca1d59a073dc8a4cca4008c
It needs to be set, so that the chart has colors. It was grey before.
The bug was fixed already in aacfd5038d05a02f8b1eade3a5896d3d7e959f3d,
which got pushed sooner, so this commit only changes
the property name from 'INVALID' to 'FillTransparenceGradientName'.
Change-Id: If06899258a4307d583480538338480ba5bb830b9
Right now, we skip hidden data series when importing OOXML charts into
our internal data table. This of course means that if/when we add support
for hidden columns in the internal data table, we may want to change this.
Change-Id: Ida1b77821fbc2f8f937244576b52521b59d6ab89
Not a direct test for the reported bug, but to ensure that the reworked
properties survive import and export.
Change-Id: I6c5a4c98eca5180251f04a24346290dedc44447a
I've switched from using a Draw document to Writer document due to some
instability with Draw instance in our cppunit run. The bug is reproducible
either way.
The test is disabled for now, since the bug has yet to be fixed.
Change-Id: I49e0417e1ecbc70f40aab8531237ae98ae58bdd3
Problem Description: Docx file containing a chart (line chart / scatter chart)which has used a builtin
marker'x' gets corrupted when we save it in LO.The reason was that while exporting LO was writing the
marker information 'x' as 'X' which MS Word doesn't recognize.‒<c:marker><c:symbol val="X" />. Also
the size of the marker was coming 1 less than the actual value. Ex: if size is 7 then it was being
written as 6.
Solution: During export I have made changes so that now LO writes 'x' in the tag information
‒<c:marker> <c:symbol val="x" />. Now the size of the marker is also being correctly exported.
Change-Id: I26b747f9576625bf3acb941322ae418a0bbc6b64
Reviewed-on: https://gerrit.libreoffice.org/9273
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
- Docx file with chart in footer/header or .bin file referred in chart
was getting corrupted.
- Embedded file for footer.xml was not grabbaged.
- .bin embedded files were not grab baged.
- Added grab bag support for both case.
- Added UT to check .bin files are grab baged properly.
Reviewed on:
https://gerrit.libreoffice.org/8674
Change-Id: I221e3867798fc2a3a42f6385d687e80b80a3678f
3D Rotation is lost after Round trip for pie chart.
XML Difference:
Original:
<c:rotX val="40"/>
<c:rotY val="30"/>
Round Trip:
<c:rotX val="310"/>
<c:rotY val="0"/>
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: I60132fef071e0573b17c35f509f3a74bd4ffcc66
1. Open DOCX file containing Charts
2. Save this file into DOCX format.
3. LO crashed while saving/exporting to DOCX format.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: I14d4f2c214ce3513b4bd14831771d72498e4486d
Problem Description:
- If the document contains more than one charts together.
ex.Bar & Line chart
- In that case, LO writes idx & order val equal to 0,
instead of 1 for second chart series.
- After roundtrip, the document get corrupted.
Implementation:
- Added varible to take the series count
in case of multiple chart.
Note:
- Some of the UT's are failing when --enable-dbgutil is enabled.
Change-Id: I40606b4d69026939fa19ae534dd7b2bb36ec97fc
Problem:
- Pie chart with data labels files gets corrupt because of label position is
bestFit in original file.
- But after round trip, data labels position gets changes to top, left and right.
For some data labels postion value is missing.
Implementaion:
- In LO, while converting data label from model, the position gets changed.
So we are ignoring this hack for Pie chart.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: Ic51845cd6f39bc905439eea8971e878607d25dac
Issue :
- If there is a scenario where a chart is followed by a shape
(may it be in the footer or on a different page )
which is being exported as an alternate content then, the
docPr Id is being repeated, ECMA 20.4.2.5 says that the
docPr Id should be unique.
- Two different variables were been used as counters for the
docPr Id, hence there were repitions in the docPr Id.
Implementation :
- ensured that a single counter is used to track the docPr Id.
Conflicts:
chart2/qa/extras/chart2export.cxx
Reviewed on:
https://gerrit.libreoffice.org/7916
Change-Id: I1c105be184d045ef058423f03259eb8c634fcbbe
3D Rotation is lost after Round trip for bar chart.
XML Difference:
Original:
<c:rotX val="30"/>
<c:rotY val="50"/>
Round Trip:
<c:rotX val="42"/>
<c:rotY val="42"/>
Implementation:
The RightAngledAxes should set first then the RotationVertical and RotationHorizontal
because the RightAngledAxes is needed while setting Rotation.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: I64f3b6e56f8515bf6c3d935c59dfaf1d440dba31
Fixed import and export for chart wall Bitmap Fill in DOCX
Added UT for the same.
Conflicts:
oox/source/export/chartexport.cxx
Change-Id: Id066b0e4c2007fcdfdbbfa67b40307463bf0cfe7
Fixed import and export for chart wall Gradient Fill in DOCX
Added UT for the same.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: Ie6caa2b238aeb70f7225145da8c5c78003e73002
During export access properties stored during import
and write back those. Currently we just support basic chart
display unit information such as builtinunit, there are more
properties ex. custUnit, dispUnitsLbl, extLst.
which are pending.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: I87e0a8322fc0b0c3df2b8053b7f29fffea611040
Reviewed-on: https://gerrit.libreoffice.org/7722
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Unit test added to check whether Up Down Bars preserved after Round trip.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: Ia427410cf76bc8cd998f399da8e9ad1f9712a076
For labels under one series, there were child tags created for every
data label individually.
for example, if under one series there are five labels, then under
<dLbls> there were 5 <dLbl> tags created separately.
This issue is resolved now.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: I7ae214f413bc27728df8a3d4cb8f4d703cba2f77
During export access properties stored during import and write
back those. Currently we just support basic chart data table information
such as border and outline, there are more properties, which are pending.
Conflicts:
chart2/qa/extras/chart2export.cxx
Change-Id: Icbc1245fc829f49833a8c307e029c3dd3dc2e0bd
While exporting chart "crosses" position values were
not handled properly in chartexport.
Fixed this issue by handling "autozero" value for c:crosses.
Added unit test.
Change-Id: I3489908d4c3d4b41a04debfecf95e65f373649ce
