Commit Graph

118 Commits

Author SHA1 Message Date
43d23a24fd opengl charts: Move the init from sc to chart2, to have the right parent.
Conflicts:
	chart2/source/view/charttypes/GL3DBarChart.cxx

Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-08-29 17:40:25 +02:00
cc827ab81d Revert "opengl charts: Move the init from sc to chart2 ...
This reverts commit 46cea34638b371570073c0e86f79969753c543ed.

Conflicts:
	chart2/source/view/charttypes/GL3DBarChart.cxx

Change-Id: Ia29ea6a95b8b9eb870d14538d0cadaa40472582f
2014-07-23 22:19:58 +02:00
46cea34638 opengl charts: Move the init from sc to chart2, to have the right parent.
Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-07-20 09:54:05 +02:00
3575dba98d remove whitespaces
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
fb06300b73 fix windows build
Change-Id: I0de216a8c6259ba6ec825f85f52e2f48b97510d7
2014-06-21 04:46:14 +02:00
7fd1fd1dea remove unneeded code for 3D charts in controller
Change-Id: I5c1f624cc05a90878f717abc8ffb0b2220ce94d5
2014-06-21 04:21:41 +02:00
0d8908b359 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part16
Change-Id: I78b3a0151397d4e69521e6b2451e93ea6e463376
2014-05-18 00:36:10 +02:00
4cbfbf4597 m_bOwnershipIsWellKnown is unused
Change-Id: I4dee9c4ce674249fca590e1c6d86685ed86da885
2014-05-12 09:46:36 +01:00
7209f84fd3 coverity#736136 Dereference null return value
Change-Id: I7668c95e2d40bb4e1e8e24627038b92f93b0008f
2014-05-08 09:56:21 +01:00
45e7b4c18d chart::ChartController::queryGL3DChart(): crash on concurrent model close
As seen in JunitTest_chart2_unoapi
[sch.ChXChartDocument::com::sun:🫘:XPropertySet]
it is possible that one thread closes the model while the main thread
tries to paint the chart via timeout.
In  chart::ChartController::modeChanged() It's not obviously possible
to lock m_aModelMutex since that might deadlock with SolarMutex.

6  in SolarMutexGuard::SolarMutexGuard (this=0x2b742f846cc0) at /include/vcl/svapp.hxx:1579
7  in (anonymous namespace)::Frame::isActionLocked (this=0x1dbe1b0) at /framework/source/services/frame.cxx:2597
8  in (anonymous namespace)::Frame::close (this=0x1dbe1b0, bDeliverOwnership=0 '\000') at /framework/source/services/frame.cxx:1773
9  in chart::ChartController::notifyClosing (this=0x1e4ec00, rSource=...) at /chart2/source/controller/main/ChartController.cxx:877
10 in apphelper::CloseableLifeTimeManager::impl_doClose (this=0x1e03b98) at /chart2/source/tools/LifeTime.cxx:368
11 in apphelper::CloseableLifeTimeManager::g_close_endTryClose_doClose (this=0x1e03b98) at /chart2/source/tools/LifeTime.cxx:311
12 in chart::ChartModel::close (this=0x1e03ac0, bDeliverOwnership=1 '\001') at /chart2/source/model/main/ChartModel.cxx:654

main thread:

21 in chart::ChartController::TheModel::getModel (this=0x0) at /chart2/source/controller/main/ChartController.hxx:470
22 in chart::ChartController::queryGL3DChart (this=0x1e4ec00) at /chart2/source/controller/main/ChartController.cxx:1398
23 in chart::ChartController::modeChanged (this=0x1e4ec00, rEvent=...) at /chart2/source/controller/main/ChartController.cxx:486
24 in chart::ChartView::impl_notifyModeChangeListener (this=0x1e149f0, rNewMode="valid") at /chart2/source/view/main/ChartView.cxx:2823
25 in chart::ChartView::impl_updateView (this=0x1e149f0) at /chart2/source/view/main/ChartView.cxx:2730
26 in chart::ChartView::update (this=0x1e149f0) at /chart2/source/view/main/ChartView.cxx:2861
27 in chart::ChartController::execute_Paint (this=0x1e4ec00, rRect=Rectangle = {...}) at /chart2/source/controller/main/ChartController_Window.cxx:493
28 in chart::ChartWindow::Paint (this=0x201c970, rRect=Rectangle = {...}) at /chart2/source/controller/main/ChartWindow.cxx:83

Change-Id: Ib99edbb9862bc9dab76ed3e0c21eca5589fe7fdb
2014-05-03 00:48:13 +02:00
899c018a2f chart2: use constructor feature for ChartController
Change-Id: Ie6c5c0e20ae2b2f38f176dee90c33e5baba100a5
2014-04-25 10:51:25 +02:00
97a5ba4a71 remove comments why a file gets included
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
329332ba52 chart2: sal_Bool->bool
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
8d202fa72f typo: paramter -> parameter 2014-04-14 12:32:54 +02:00
ba1452c261 Several more Window events to intercept for the GL3D chart.
But not painting or resizing events. Those are generic enough that no
branching is needed.

Change-Id: I0fb186da61c583c5326d2608b2153aced3fab77b
2014-04-11 09:36:40 -04:00
a3354ecf4f Separate mouse event handlers for GL3D bar chart.
They are just skeletons for now.

Change-Id: I7e5e95ad8a2809125cbcf3affd17e663aafa99b0
2014-04-11 09:36:40 -04:00
4b243d2201 whitespace cleanup in chart2
Change-Id: I85fdb62ff0e6606e2ac8537f477e7cb5bec3827a
2014-04-06 17:19:55 +02:00
5b5e626503 Remove remaining DBG_CTOR etc. remnants from chart2
Change-Id: Iaf07f77b4228d4debb2620625b14ce7dc41e3a98
2014-03-28 15:23:09 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
0309070fb2 coverity#737027 Uncaught exception
Change-Id: I96b07d58233cf19708bbda68bcb19f5d7f6404df
2014-02-13 14:56:18 +00:00
5d061edbd7 coverity#737024 Uncaught exception
Change-Id: Ifdb5fb60c436e847ba85d690f8ca0087bd516ab7
2014-02-13 14:56:18 +00:00
d5d2e280bd bool improvements
Change-Id: I4fb554a0b703b29cb2dc70fc11111a4f2fa9af8e
2014-01-28 20:26:30 +01:00
401f01caf5 use ChartModel instead of XModel in a few places
This allows us easier implementation of some advanced features. Mainly
the 4D chartting will now be able to work without several ugly layers of
UNO.

Change-Id: I74d07229eaef921c508f3bab8fae6d6075ad737a
2013-11-19 13:47:36 +01:00
dd9c97d587 fdo#62475 removed pointless comments
Change-Id: I3f5e86dba2df950aeb12c895f52d99274c0959aa
Reviewed-on: https://gerrit.libreoffice.org/5148
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-29 11:34:33 +00:00
5efc15f000 reduce use of UniString from ResID ctor
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-28 16:45:48 +01:00
b5d481e2b9 fdo#66422 Vertical grid toolbar button - choice major/minor/off
Added toolbar button for vertical grid. Icon was already prepared.
Changed the button behavior for vertical and horizontal grid button
from just on -> off to cycle through major -> major&minor -> off.

Change-Id: I147fc97ab43db31f08a2e98f7b68422fb168f042
2013-07-04 20:21:47 +02:00
7302c4f649 Change series and trendline pop-up to support more trendlines.
Conflicts:
	chart2/source/controller/main/ChartController_Window.cxx

Change-Id: I70eb06d74670f54fa3792723711e9f73700f12ba
2013-07-03 21:46:46 +02:00
01fc2a65b2 Cleanup ChartController
Change-Id: Ife0289003afe8f10db7ce3f6d9207087a5ac8e76
2013-07-03 21:46:45 +02:00
97f1db8cdb Resolves: #i119999# Single ESC to leave Chart OLE mode after creation
Patch by: Tan Li
Review by: alg

(cherry picked from commit a3677e22a4c4ea24d2a66cefcae0872e94e1c1ea)

Conflicts:
	chart2/source/controller/main/ChartController.cxx

Change-Id: I2e87bd49ec750026ad74ca0256b63ba5f4228355
2013-05-11 20:26:43 +01:00
07b5102e7b There are many ships in the port of Hamburg but "ownership" is not one
Change-Id: I971390d084b08293b21fdc35beb74482a1560bb8
2013-03-25 23:58:12 +02:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
ce90f99a2d fixes for where fast string operator+ is not perfectly source compatible
Change-Id: I80af0399037e4f68113338139e7f2ad2400e65ab
2012-12-03 18:04:24 +01:00
1e34ec4c18 OUString cleanup in Chart2
Include C2U macro and rtl cleanup

Change-Id: I4543a3a6d6a6971d2c31b8dc36bd2ec95bd892d4
2012-10-08 21:41:03 +05:30
63c508e3e8 re-base on ALv2 code. Includes:
118568: switch to using ucpp
    Patch contributed by Juergen Schmidt
    http://svn.apache.org/viewvc?view=revision&revision=1209396
2012-07-18 09:29:19 +01:00
4dd7c0369d Various Clang 3.1 -Wunsued-variable, -Wconstant-conversion
Change-Id: I0799f22685609201dfb524c373d065b6184ed53c
2012-07-18 08:23:28 +02:00
0a321bfc80 targeted string re-work
Change-Id: I8e6b9ac1e9382e7dcd51421263e1fb51605565ca
2012-06-01 06:30:58 -05:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
6294d8f4df Update DeleteYErrorbar function to handle X and Y bars. 2012-03-23 02:55:32 +01:00
1e27c77338 Add FormatXErrorBar, DeleteXErrorBar menu entries in chart.
-Update ModelState to reflect the changes.
2012-03-23 02:55:31 +01:00
2971651cd9 Add chart insert X errorbar toolbar and popup menu entries.
- Dispatch the commands to the proper functions.
2012-03-23 02:55:29 +01:00
2a1d5a428d Make executeDispatch_InsertYErrorBars a generic function.
- Make the function usable for XError and YError bars.
- Rename executeDispatch_InsertYErrorBars to executeDispatch_InsertErrorBars.
- Add a new parameter that control the error bar direction.
- Update arguments in callers.
2012-03-23 02:55:29 +01:00
7d42654aa4 Merge InsertMenu_YErrorBar and InsertYErrorBar commands in chart controller. 2012-03-23 02:55:29 +01:00
ca939177d6 remove C2U usage, string literal OUString ctors will do the job
and this also avoids reaching the parse recursion limit with clang,
because all the macros C2U expands to, although clang's limit is
probably tad a bit low
2012-03-12 13:35:59 +01:00
0eac98aa74 Fix for fdo43460 Part V getLength to isEmpty
Part V
Module
chart2
2011-12-13 00:36:43 +04:00
1aae826501 catch by const reference 2011-11-29 10:07:04 +09:00
6da8379e14 remove include of pch header in chart2 2011-11-27 12:59:19 -06:00
b0a7f87a86 catch by const reference 2011-06-21 09:11:10 +01:00
3471d7eef3 overly static 2011-06-01 15:16:58 +01:00
a64076a069 Replace DBG_* with OSL_* in calc/chart2 2011-05-27 06:03:36 +02:00