Commit Graph

2220 Commits

Author SHA1 Message Date
0309070fb2 coverity#737027 Uncaught exception
Change-Id: I96b07d58233cf19708bbda68bcb19f5d7f6404df
2014-02-13 14:56:18 +00:00
5d061edbd7 coverity#737024 Uncaught exception
Change-Id: Ifdb5fb60c436e847ba85d690f8ca0087bd516ab7
2014-02-13 14:56:18 +00:00
a1b1625cfd cid#707669 uninitialized pointer value
Change-Id: I252f88ba76d9b927d472655d2bee71cc85b22452
2014-02-12 15:10:48 +02:00
83055835b1 fdo#74112 Preserve Chart displayunits properties during ODF import/export.
Change-Id: I38508b71ee5b3b966e1d36b0d253304fe17c0ec0
Reviewed-on: https://gerrit.libreoffice.org/7721
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-11 23:23:40 +00:00
5718b17d2d Related: #i123862# use O*String's isEmpty() method...
to check for emptiness in chart2 module

Patch-by: j.nitschke@ok.de
Review-by: hdu@apache.org
(cherry picked from commit 17b6784443432419e9aa9fddf56e5fa6c3ce4c60)

Conflicts:
	chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
	chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
	chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
	chart2/source/controller/dialogs/ChartTypeDialogController.cxx
	chart2/source/controller/dialogs/DataBrowserModel.cxx
	chart2/source/controller/dialogs/ObjectNameProvider.cxx
	chart2/source/controller/dialogs/res_ErrorBar.cxx
	chart2/source/controller/dialogs/tp_DataSource.cxx
	chart2/source/controller/dialogs/tp_RangeChooser.cxx
	chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
	chart2/source/controller/itemsetwrapper/ErrorBarItemConverter.cxx
	chart2/source/controller/itemsetwrapper/StatisticsItemConverter.cxx
	chart2/source/controller/main/ChartController.cxx
	chart2/source/controller/main/ChartController_TextEdit.cxx
	chart2/source/controller/main/ChartController_Tools.cxx
	chart2/source/controller/main/ChartController_Window.cxx
	chart2/source/controller/main/ControllerCommandDispatch.cxx
	chart2/source/controller/main/DrawCommandDispatch.cxx
	chart2/source/controller/main/ElementSelector.cxx
	chart2/source/controller/main/ObjectHierarchy.cxx
	chart2/source/controller/main/SelectionHelper.cxx
	chart2/source/controller/main/StatusBarCommandDispatch.cxx
	chart2/source/controller/main/UndoCommandDispatch.cxx
	chart2/source/model/filter/XMLFilter.cxx
	chart2/source/model/main/ChartModel_Persistence.cxx
	chart2/source/tools/ExplicitCategoriesProvider.cxx
	chart2/source/tools/InternalDataProvider.cxx
	chart2/source/tools/NamedProperties.cxx
	chart2/source/tools/ObjectIdentifier.cxx
	chart2/source/tools/PropertyHelper.cxx
	chart2/source/tools/RegressionCurveHelper.cxx
	chart2/source/tools/WrappedProperty.cxx
	chart2/source/tools/XMLRangeHelper.cxx
	chart2/source/view/axes/VCartesianAxis.cxx
	chart2/source/view/main/ChartView.cxx
	chart2/source/view/main/ShapeFactory.cxx
	chart2/source/view/main/VLegend.cxx
	chart2/source/view/main/VTitle.cxx

Change-Id: Ia013e3d1d215f7391d5bee4b4e80eedc2a3a724f
2014-02-10 11:43:46 +00:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
042fec5bf2 forgot the new files
Change-Id: I63bdb340aa06b072541bb8b0ed975457c504c9a2
2014-02-09 14:20:36 +01:00
ec4b0ed8e0 improve dialogs for mapped properties
Change-Id: I87e07a30743de0fc30d0caafd35192b18caf3dae
2014-02-09 14:16:42 +01:00
8cb2877b2d add the time based charting stuff to the ui files
Change-Id: I5ffb382f61e56d1c07dfb945f08fa354aea9d5fc
2014-02-09 14:16:41 +01:00
95141bfd30 Typos
Change-Id: I8316213889280b8f8622fb5196b6a36e81d8e6f1
2014-02-09 10:02:51 +01:00
85cdb06fd5 sal_Bool -> bool
Change-Id: Ifc80202e0865b59931af6e50d3d60f5021f8b52e
2014-02-07 18:43:32 +01:00
16738ab4d8 coverity#1158121 Unchecked dynamic_cast
Change-Id: I961c3da368c1f2bffb4c116c325a82cf7619cf15
2014-02-07 12:24:43 +00:00
33dc343268 coverity#1158125 Unchecked dynamic_cast
Change-Id: Id560c9d5941ba679b92aaa2b2db0fb34a23d7a5f
2014-02-07 12:24:43 +00:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
61e28e86ed add a way to dump chart content to console
CTRL + F12 will dump the chart with the XShapeDumper

Change-Id: I1f40ddf7f51c2038be7af8fc56f626393f11da90
2014-02-06 16:15:05 +01:00
b37bce11cf Resolves: rhbz#975421 wrong chart direction in Farsi
Where Farsi (and apparenly Moroccon) are RTL but have LTR
math and charts should reportedly follow the math direction

Change-Id: Ib60eaaaa90fe46ef240030a91169fdff3f736329
2014-02-06 15:11:59 +00:00
d2d5864462 TabControl::DeactivatePage should return bool
Change-Id: I9fb774a235db2b9bc759976d2d3f84363ed944ec
2014-02-06 15:44:03 +01:00
51a68b4992 Doxygen warnings corrected
* Doxygen spits out a lot of warnings about not being able to find
  match function signatures, etc. This is because in some headers we
  have a using namespace statement, in others it gets confused between
  ::Window and Window (!).

* Wrong use of tags:
  + Lots of @seealso - should be @see
  + Wrong usage of @overload - corrected with the right function
    signature
  + HTML tags that doxygen doesn't recognize removed

Change-Id: I1c2eed941619b8764dbfcfc5ab38027518cdf261
2014-02-05 09:14:53 +00:00
186b4ebc99 convert specialised SvStream::operator>> methods to ReadXXX methods
as preparation for converting the SvStream::operator>> methods on
primitive types

Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9
Reviewed-on: https://gerrit.libreoffice.org/7798
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-02-04 22:50:39 +00:00
f985e3add3 fix ambiguities
Change-Id: I27c8ef11a0eedbcaf29865dff83841675b775171
2014-02-04 15:52:23 +00:00
f79bfd0ac5 convert chart type dialog to .ui
Change-Id: I6da39b06629e3913048a48490f45863de24c4f15
2014-02-04 09:21:00 +00:00
498c878ddc coverity#707670 : Uninitialized scalar field
Change-Id: I8815381cc1a9801ff5f5ecfac06ada234d5bc363
2014-01-31 23:54:18 -06:00
c74006b1c8 coverity#707668 : Uninitialized scalar field
Change-Id: I3527de5f4a00d2fa2aa3b01a82d7c91a24547b86
2014-01-31 23:41:52 -06:00
90d39a8a22 Resolves: #i124085# disabled CF_DIBV5...
(no advantages but some problems), increased png support

(cherry picked from commit c991f7cae8dcb306cb0d1f32bc5fcd8ea0a1ea81)

Change-Id: I52bef1295b32eb3692a0428c96edd0c55287f34a
2014-01-30 09:21:30 +00:00
9c5593bebf start time based onlz after dialog is closed
everything else seems to result in serious bugs!!

Change-Id: I1afbdb7623f877781c7ef362d87608a1e2aba72e
2014-01-29 08:09:34 +01:00
d70331f9de first step for mapped properties
Only FillColor in bubble charts is supported right now.

Change-Id: If6ad0220c15e06a9a57c554f6243fd9908b2651b
2014-01-29 08:09:33 +01:00
262fccfccd fix the time based rendering
I managed to screw it up already. I really need some sleep.

Change-Id: Ie1f13496cd36a6f48b2b094ac302f293d5fd5383
2014-01-29 08:09:32 +01:00
750b46025c give up with the nice solutions and enjoy the ugly hack
I was always hitting a corner case so it seems that this need some
drastic measures.

Change-Id: I3fdd278b9c3fed178513d653ef24ad8adf20cbd2
2014-01-29 08:09:30 +01:00
46574ef1a2 add time based option to UI
we still need to notify ChartModel but I have no idea how

Change-Id: Iac5e09f2bdbcb1d4bc18d4a9dcc30db3a7ab36af
2014-01-29 08:09:29 +01:00
d5d2e280bd bool improvements
Change-Id: I4fb554a0b703b29cb2dc70fc11111a4f2fa9af8e
2014-01-28 20:26:30 +01:00
a2a0e1b2a5 coverity#704212 Logically dead code
Change-Id: I1f915b4419ae754a3827c2c662e5799bade66835
2014-01-28 11:29:16 +00:00
8534438397 coverity#1158136 Unchecked dynamic_cast
Change-Id: I8d4e7c497430faacd0d8f1138b9af8b2f11127a0
2014-01-25 20:56:31 +00:00
336b25e622 fdo#63154 Removed unused solar.h reference in chart2
Change-Id: I4a16cd5492ced3c067fb037f31cb74a6d8068de1
Reviewed-on: https://gerrit.libreoffice.org/7603
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-24 16:10:03 +00:00
ebf5e613a5 SfxNoLayoutSingleTabDialog not needed anymore
all single tab dialogs are .ui enabled now.

So now we can remove SfxNoLayoutSingleTabDialog and merge SfxSingleTabDialog
and ~SfxNoLayoutSingleTabDialogBase together

Change-Id: If0acc792d85b7d399572257d7e9b0e12993ba3fe
2014-01-23 16:02:10 +00:00
9f476dd17c coverity#705785 Dereference before null check
Change-Id: If83916c580c3c6ef64104c4052e87dc4ee168f17
2014-01-19 19:35:28 -06:00
910b7bf6c6 coverity#704562 : Dereference after null check
Change-Id: Icf5e2242f73c519de91508eb912a38b21ac9a9d6
2014-01-19 19:35:28 -06:00
1f63b4f3d6 Fix build error.
Change-Id: Ide87ccfe71f42d77246b6b3a2e864b5c89d80647
2014-01-17 12:49:19 -05:00
ed1878d27e -Werror,-Wunused-function
Change-Id: Ia6c6d6fe484789722987cea7d8b4b4bfc1c28953
2014-01-17 18:45:17 +01:00
9c4032921c Convert chart data source tab page & dialog to .ui
Conflicts:
	chart2/source/controller/dialogs/dlg_DataSource.cxx
	chart2/source/controller/inc/dlg_DataSource.hxx

Change-Id: Ic3e3adc578156161f16254862e1ca33a8ad9e1f6
Reviewed-on: https://gerrit.libreoffice.org/7255
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-17 16:09:50 +00:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
2054af83fe fdo#72520 : Added property to store external data path in chart.
-  added new property entry to store xlsx external data for chart.

Change-Id: I3695865ad7e888359d1048e9bc380cba26108636
Reviewed-on: https://gerrit.libreoffice.org/7212
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-01-16 01:46:40 +00:00
3bf277a044 bool improvements
Change-Id: Ia30628e093a885165b2d8a7b1a999c0dc7ee65cd
2014-01-14 18:11:10 +01:00
76702bc75d Bin leftover printf
Change-Id: I5469199841dc56e93ff82fe5c3b722d43e766240
2014-01-11 11:03:49 +02:00
7b2d1ee505 Resolves: fdo#72814 Fix Chart Data Ranges Dialog
revert part of b193123b8e658d2eb25af5debe9de9e1b2386ef8

That "hidden" column conatined data which is important to make the dialog work.
If the hidden data is causing a11y problems then it needs to be reworked in a
different way rather than removed in one place but still being looked for in
another

Change-Id: I2990ac940a52d97da193af2147f2b61281e11020
2014-01-10 20:22:19 +00:00
f7936b021f Do not use SvxShapeCollection directly.
Change-Id: I1dd51df0e78a3cc89cdfcaec91ffd9a753393e2e
2014-01-08 14:30:53 +01:00
db666bdf0c convert data range tabdialog to .ui
Change-Id: I70e9064a13a751f6b0dae153522953eaf2ac53a5
2014-01-07 09:43:15 +00:00
44029ade1b convert chart shape paragraph dialog to .ui
Change-Id: I5682ccdaa7d0f877310b937ad12ceeeb0b91c350
2014-01-04 19:37:53 +00:00
204c2a1a02 convert chart shape character dialog to .ui
Change-Id: I03917fdceebdf5bd06c04f5719615092ee166852
2014-01-04 19:22:15 +00:00
1cedea0eef WaE: C4805: '!=' : unsafe mix of type 'sal_Bool' and type 'bool' in operation
Change-Id: If67bcfa3f3faaf7ed48493a0f8281fba70431abf
2014-01-03 15:42:55 +02:00
ce4db6fe77 Convert chart range chooser tab page to .ui
Change-Id: Ibe80ec369b8efcded6cf9ce31f7c7d66e3e61dc0
Reviewed-on: https://gerrit.libreoffice.org/7224
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-29 16:53:05 +00:00