Commit Graph

513 Commits

Author SHA1 Message Date
b4454c19c4 Generally better to have DLLPUBLIC class with some DLLPRIVATE members
...in the same vein as 80a1a2599e04142683d2286d0e32d0e13fb45de3.

Change-Id: I181d54475d82e2a01a56f48a13ac42dbad876d2c
2014-08-18 18:38:23 +02:00
5021f29841 Remove some unused code
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3
Reviewed-on: https://gerrit.libreoffice.org/10593
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 14:20:36 +00:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
7649a14222 Make these non-inline.
Change-Id: I0de443a78e3024c7d3834f964a92f5ccdabe3cc3
2014-07-03 15:29:41 -04:00
6c4e21a234 bnc#812796: Correctly handle static value array for OOXML charts.
We need to pass the role of the data sequence in order to avoid unreliable
guess work when importing static value array.

Also, not all Excel's scatter plots have real numeric X values; some have
textural X values in which case Excel switch to generating 1, 2, 3, ... as
X values.  When importing to our chart implementation, using "categories" role
in such cases instead of "values-x" results in a more faithful chart rendering.

Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-07-02 20:56:31 -04:00
3575dba98d remove whitespaces
Change-Id: I05ef3c1ffd4e2179e0142a21abf8a4578718102e
2014-07-02 23:03:07 +02:00
8918dabbee coverity#705359 Mixing enum types
and

coverity#705361 Mixing enum types
coverity#705362 Mixing enum types

Change-Id: I557d7178277e5d497e3bbab12b75724c05653f57
2014-07-02 14:00:41 +01:00
aa6495b6fa Better way to dump the content of InternalData.
Row levels are currently not dumped, but that may change later.

Change-Id: I849f8b65d6f419bc4d97e2af2d456e73c7e9a355
2014-06-26 14:26:50 -04:00
8192df3887 Clarify the code a little more.
Change-Id: Idc0ff4913695ade9543cd30511aff61d24e7c495
2014-06-26 11:26:15 -04:00
78751ce780 Add class descriptions. These two classes' roles were not very clear.
Change-Id: Ib45c9037f2c4b3ee5bfed79f3c93e5020bac477b
2014-06-25 20:12:46 -04:00
9af5c13851 Re-use DataSeriesHelper::getRole().
Change-Id: Ia880bc03400d4cbf4c3033e01affafccc0a384fb
2014-06-24 22:05:20 -04:00
349132616d Let's remove these lcl_ fetish.
These are not even static local functions anyway, which was what
lcl_ prefix was originally used for.

Change-Id: I0e6b6cebbcf7cdfb449cf17320fb362fc73d92a8
2014-06-24 18:46:46 -04:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
439550c9f1 remove unnecessary and unused chart debug functionality
Change-Id: Ic8100b2afebe469709723b324394e08b7669d911
2014-06-07 04:48:16 +02:00
f282994626 coverity#706261 Uncaught exception
Change-Id: Ife4d1e828cc2b52c54e425ec7af533ebdacd0f1e
2014-05-28 13:49:50 +01:00
eaa3f8e160 drop unused template
Change-Id: I3668d9b5cff71aae1598f87f09ab82bf66ace71e
2014-05-23 20:38:14 +01:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
4cbfbf4597 m_bOwnershipIsWellKnown is unused
Change-Id: I4dee9c4ce674249fca590e1c6d86685ed86da885
2014-05-12 09:46:36 +01:00
65f127f687 chart2: move RegressionCalculationHelper.hxx to inc
Change-Id: Ie49a9e20f72c8e2f81b2d169f5fd19964811c193
2014-05-07 09:29:18 +02:00
97a5ba4a71 remove comments why a file gets included
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
b7ba33e4a0 fix non unique property handle
Change-Id: I110feee77ab65bc8f528e85cba7c74063937b086
2014-04-17 02:08:59 +02:00
329332ba52 chart2: sal_Bool->bool
Change-Id: I85751b4e636596ef88ef02bc958abdc6abf98427
2014-04-15 15:23:29 +02:00
a3354ecf4f Separate mouse event handlers for GL3D bar chart.
They are just skeletons for now.

Change-Id: I7e5e95ad8a2809125cbcf3affd17e663aafa99b0
2014-04-11 09:36:40 -04:00
dfb2ab0cee add initial code for creating 3D bar shapes
Change-Id: I55489fad8723f204003fe502eea5e02de4c8d6ef
2014-04-08 04:38:19 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
86090ef2fb Make the new OpenGL chart type a compile time option.
And it's disabled for now.

Change-Id: I9a513d757960b61e7b2d6009eabf97a75b6c453e
2014-03-25 22:50:50 -04:00
be1152e0cc List child type for GL3D bar chart type.
For now there is only one child type.

Change-Id: If39a3e75fdae62f0b20769c21e6a4e235ede941e
2014-03-25 22:50:49 -04:00
be89276e63 Add a new chart type "GL 3D Bar" (working name).
Change-Id: I0b0a65bf4f9365a8d522e3c439afe19797b2fdd5
2014-03-25 22:50:48 -04:00
349a5b72bf Initial skeleton class for the new chart type. Still very much empty.
Change-Id: I5e9eaeb9337d51f59f800f8e676b8bc83b80df70
2014-03-25 22:50:48 -04:00
236d6cd67e chart2: prefer passing OUString by reference
Change-Id: I685b1dc3d7c735bc70be29252f55c082546f3cb1
2014-03-17 13:30:50 +02:00
bc338f4afc improve the handling of property mapping sequences
Change-Id: I4ddd656a41ab975786ce6e5cd05597f6b773b334
2014-03-09 19:27:49 +01:00
adbf974f82 remove unused code chart::ChartModelHelper::setPageSize
Change-Id: I9c6d6f8d9389070a41af2a289e97b6eeb2fc750c
2014-03-05 09:17:44 +02:00
d61b787c84 remove unused code chart::ModifyListenerCallBack::startListening
Change-Id: I43de71815d13bf359926dc6c6d63eb5a933ca712
2014-03-05 09:17:43 +02:00
885fd98fa3 convert chart type page to .ui format
Change-Id: I2e95e0dec66b8985abad81b02722e1bf632a15e0
2014-03-03 13:27:10 +00:00
f2cdf8848c Remove visual noise from chart2
Change-Id: Ic8dc71c2815df265e1935e629e0220396a50aaac
Reviewed-on: https://gerrit.libreoffice.org/8239
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-02-27 00:44:41 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
66b16aec3d replace auto_ptr with boost::scoped_ptr
Change-Id: I52299aa147799214c83a87dbc99104d8ba9b6206
2014-02-22 05:52:26 +01:00
2b12a5b87b the return of callcatcher
Change-Id: I447ebcc61ff061bce15678c6fcfd3d0a4669908f
2014-02-10 11:21:03 +00:00
750b46025c give up with the nice solutions and enjoy the ugly hack
I was always hitting a corner case so it seems that this need some
drastic measures.

Change-Id: I3fdd278b9c3fed178513d653ef24ad8adf20cbd2
2014-01-29 08:09:30 +01:00
55656ee2e8 some improvements for the time based charting
The updating seems to work. It just does not update the references yet.

Change-Id: I0a971dbe2beb113c1c3e9ef103d77d5d8c7174a0
2014-01-29 08:09:30 +01:00
4f5391b19d no auto_ptr in this class
Change-Id: I9f915d10136b230d0f6354379ef0afc1da4dda28
2014-01-29 08:09:17 +01:00
0f13f675ed It performs better to use unordered_map than std::map here.
Change-Id: I5b89ac2dfbe348f0bf0b07880ccddc734b6d14ab
2014-01-02 12:39:17 -05:00
e6a87e17b2 Convert insert error bars dialog to widget UI
Change-Id: Ie2fbcb0bacb968a784698908c8cc62f73a80cf32
Reviewed-on: https://gerrit.libreoffice.org/7219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-28 08:44:59 +00:00
3596e88b65 Convert chart data label dialog to widget UI
Conflicts:
	chart2/AllLangResTarget_chartcontroller.mk

Change-Id: Id9054b3b0c6e7a10a72bc90b05cd7c6bbc5e82a2
Reviewed-on: https://gerrit.libreoffice.org/7205
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-12-27 21:19:56 +00:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
7059c70d81 RegressionCurveCalculator & co - com::sun::star -> css
Change-Id: I7cbf11009b5d7dbe2464288e696a1fcb1f3de3a0
2013-12-14 22:35:12 +01:00
cd840e6a7e Make RegressionCurveHelper more readable (com::sun::star -> css)
Change-Id: I9b9e63a81bf5002413d18267b1000230f9ca7cdd
2013-12-14 22:35:11 +01:00