Commit Graph

67 Commits

Author SHA1 Message Date
25df8adbc0 cli_ure: adapt destructors in cli_uno library to "C++/CLI"
commit 4b56d82c7d20ba5897d87aaf7fc94da5356b8eec converted the cli_uno
library from "Managed C++" to "C++/CLI", but forgot one detail:

The destructors on "ref" classes were mapped to Finalize() methods in
the old syntax, but the new one maps them to Dispose() methods, which
are only invoked on stack-allocated objects.  Presumably this omission
results in leaking of native C++ UNO objects.

Reading the C++/CLI documentation i get the impression that:
1) the destructor should explicitly call the finalizer
2) the CLR will not call the finalizer itself iff the destructor is
   invoked

http://msdn.microsoft.com/en-us/library/ms235315.aspx
http://msdn.microsoft.com/en-us/library/ke3a209d%28v=vs.110%29.aspx

Change-Id: I509d9b69a399c3d7d6597060ab9b7c78c5916e11
Reviewed-on: https://gerrit.libreoffice.org/11132
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-08-27 05:06:32 -05:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
b19db6b21d Typo: apend->append
Change-Id: I062c95ca8d478ba6c241723dda25c1dc4d7bb852
2014-06-29 13:15:51 +02:00
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
acc04202e8 use css prefix consistently
Change-Id: Ia2f827381ec768a7867918d61d7afb2f68457832
2014-05-12 19:52:28 +02:00
49dff05943 cli_ure: fix dbglevel=2 build on windows
Some blocks are completely unused.

According to http://msdn.microsoft.com/de-de/library/ms235298.aspx

rtl_uString * __pin * pp_sInterfaces = &_sInterfaces;

should be

pin_ptr<rtl_uString *> pp_sInterfaces = &_sInterfaces;

Change-Id: I039e94649d542fb5b51231b2e0df0a4dc1170c19
Reviewed-on: https://gerrit.libreoffice.org/9318
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-12 14:53:26 +00:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
b8239ac2f9 typo: noone -> no one 2014-04-14 12:32:54 +02:00
1712e6c614 Remove visual noise from cli_ure
Change-Id: I1ddada46767b2840c663a0a077e1b723f9645b56
Reviewed-on: https://gerrit.libreoffice.org/8240
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:15:25 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
f212aa9f84 fix existing comments
Change-Id: I06dca63053dae5d3dceb49bf67adb0c100b56e8b
2013-08-31 22:41:12 +02:00
78ced6235b fix indentation
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I55ff666c357c89ad355a1a5bc0d0347fcc188476
2013-08-31 22:41:11 +02:00
bf42b6f9f5 fdo#62475 - remove visual noise
This is a follow up commit to
 - 22d1beb78a475e4846af945afde1c4d6c263b5d6
 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75

Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-31 22:41:10 +02:00
1c7af455ab Re-work 8bit characters in source code, or remove them.
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3
Reviewed-on: https://gerrit.libreoffice.org/5550
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@suse.com>
Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-08-20 19:30:59 +00:00
eeaa2ecd1e remove unused component_canUnload functions
Change-Id: Id3f41e2a620c47bb848718d0fc994739be2d64fc
2013-04-19 16:52:03 +02:00
92c6a38175 Fixed 4 spelling errors in the comments.
Change-Id: Ic48f52d7ea4f6a4964f627e3051c96c46ffc2f76
Reviewed-on: https://gerrit.libreoffice.org/3164
Reviewed-by: Andras Timar <atimar@suse.com>
Tested-by: Andras Timar <atimar@suse.com>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-07 21:28:01 +00:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
616c6924f1 s/the the/the/
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22 09:58:19 +02:00
13ed66c9ce s/Whith/With/
Change-Id: I098290a33a3d455594bd200034b279eef02c792b
2013-02-22 09:39:47 +02:00
97eb8a6e0e Removed several useless macros: A2OU, A2S, C2U, C2S, OUSTR, OUSTRING
Change-Id: Ie859cb2dfdc7103c379fce56be88eef8fe390afd
Reviewed-on: https://gerrit.libreoffice.org/1924
Tested-by: Luboš Luňák <l.lunak@suse.cz>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-30 12:54:40 +00:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
a3ce60eb3c We only support MSVC 2008 (_MSC_VER 1500) or later
We can drop or simplify many conditionals.

Change-Id: I37e820e515cc09845c30b62c89ddb3b6ff370f97
2012-11-28 20:53:40 +02:00
d59379a70a cli_ure: warning C4965: implicit box of integer 0
Change-Id: I0ccc91ea686e599171845ff2cff5e536bbdb7b77
2012-10-24 21:58:26 +02:00
f61e81a6ef fix warnings in cli_ure
Change-Id: I4e081473612403e0bf277e8dbf5f1b9a15541dd7
2012-10-24 10:19:51 -04:00
1b66ced236 Managed C++ to C++/CLI conversion also for the debug code
Change-Id: Ibb4f5e386644a67905421d2f9c33336a119fca88
2012-10-08 14:29:39 +03:00
4b56d82c7d convert uno_bridge to new syntax
Change-Id: Iac5e9a860f7ef68104c4cfc19abe686b754190af
2012-10-07 10:42:14 +02:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
97eb770d28 switch cli_ure to gbuild
Change-Id: Icad2f8019130781f036b5d46105cf5a99709663f
2012-09-22 08:15:27 +02:00
ab79555058 export uno_initEnvironment and uno_ext_getMapping
Change-Id: Ic907b7dbf4cee22ac899e413bc5122e3a09e6b1a
2012-09-22 08:15:22 +02:00
1340890ccd simplify include guards
Change-Id: Id4210229b20a1d54b680ff1a2ccbcdd3684ecf5f
2012-07-14 05:44:15 +02:00
e18655e475 re-base on ALv2 code. 2012-06-27 19:30:33 +01:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
b6db3e3acc re-base on ALv2 code.
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-21 13:11:06 +01:00
d95d58af08 nuke unused namespace
Change-Id: Ic00cdfce4172af0a2f0aa1aa33ef5e386d407976
2012-06-01 01:04:50 +09:00
d6bc02f8c4 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator 2012-04-06 20:03:42 +02:00
b8f007d052 remove extraneous qualifiers that break some compilers 2012-02-17 15:22:46 +00:00
664b22c56b Fixed some cppcheck messages 2012-02-06 10:16:35 +01:00
0439af27e1 Code cleanup: ( () ) replaced by (()) 2012-01-26 17:41:07 +00:00
aee436760e function component_canUnload is exported 2011-12-27 15:44:42 +01:00
7904a8cc56 I don't see NO_BSYMBOLIC being used anywhere 2011-12-11 02:57:59 +02:00
0c9d2b9cb3 precompiled_cli_ure.hxx is empty, so just remove it 2011-11-02 07:52:19 -07:00
3f411f3631 Adapt to removal of dangerous operators 2011-10-05 10:08:59 +02:00
f3423eab78 Fix MSVC build against debugging runtime 2011-08-17 23:21:24 +03:00
a50103a702 Bin stuff for compiler versions we don't use 2011-08-17 23:08:50 +03:00
999dce7d69 WaE: return after throw 2011-03-16 10:54:21 +00:00
adc6fe00e3 Move OSL_ENSURE(0,...) to OSL_FAIL(...) 2011-03-12 14:19:48 +01:00
933e22880b Remove "using namespace ::rtl" 2011-03-02 21:53:12 +01:00