Commit Graph

95 Commits

Author SHA1 Message Date
8c9fdc4a96 java: remove modifiers implied by the context
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
3f210b0e75 java: remove unnecessary return statements
found by PMD

Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-20 10:35:54 +02:00
0764292c5d java: use 'Short.valueOf' instead of 'new Short'
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long'
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19 14:57:17 +02:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
6d2de44a54 fix-includes.pl: comphelper
Change-Id: I0b4cd8320881b2b1f7984c86e58915217bcd0d5f
2014-05-11 01:55:37 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
a67c2a12bc Remove visual noise from comphelper
Change-Id: I7e5512b43240beee05404cff9d49a87d0217ea89
Reviewed-on: https://gerrit.libreoffice.org/8242
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:42:45 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
2c6b6ba446 Disambiguate CPPUNIT_ASSERT_EQUAL arguments
Change-Id: Ib32d59522f33bcd2608401b4f3d3529d9dee5642
2013-10-28 14:31:34 +01:00
c99267b326 Fold SyntaxHighlighter::initialize into ctor
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused.

Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28 13:48:14 +01:00
f5e8be8bb1 Remove unused SimpleTokenizer_Impl::nLine/nCol
...which are never read; remove thereby unused parameters from functions.

Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-28 13:48:13 +01:00
0827aba84e Correctly fix "Terminating NUL" fix
1cbe2313edda8a04f0fe233b4a29ef4e2485f557 "Terminating NUL at end of its buffer
is not considered part of OUString" was a thinko that cut the last character off
the last reported HighlightPortion on a line.

Change-Id: Idbe74676e85749cd93854293c6f49c7581414562
2013-10-28 10:47:19 +01:00
2733bc38f0 Demonstrate that empty comments are handled just fine
...see preceding revert of a79cb836b951eb2492e43aadd2ee672b9b67b914 "COMPHELPER:
Allow empty comments in SyntaxHighlight."

Change-Id: Ib0a8c46c19dd7f0697b95a1c28398073a1183281
2013-10-28 10:47:19 +01:00
a699e7c70d Revert "COMPHELPER: Allow empty comments in SyntaxHighlight"
This reverts commit a79cb836b951eb2492e43aadd2ee672b9b67b914, which broke
--with-help builds again, as

  strLine.copy(i->nBegin, i->nEnd-i->nBegin)

in BasicCodeTagger::tagParagraph (helpcompiler/source/BasCodeTagger.cxx) depends
on the invariant that a HighlightPortion does not extend past the source string.

Also, I see no reason for that change, as empty comments are handled just fine
already as demonstrated by the following commit...

Change-Id: I384bae9c4cf6a38d0a0a2832fa15bde82126cace
2013-10-28 10:47:19 +01:00
a79cb836b9 COMPHELPER: Allow empty comments in SyntaxHighlight
Change-Id: I0f3d5673e28e34ed3921c930aca48f3d7574b064
Reviewed-on: https://gerrit.libreoffice.org/6450
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2013-10-27 16:07:16 +00:00
2a8e751eb5 Improve test
Change-Id: I54e939b7bca883f1c92c957c66ebf47259c92a46
2013-10-23 09:40:38 +02:00
51ac50b538 Fix and enable CppunitTest_comphelper_syntaxhighlight_test
Change-Id: I2b2aa5f5afdbf58ec3ac2447db370bcb7d1778c0
2013-10-23 09:32:32 +02:00
eb13f2d92c add inital test for syntaxhighlighter
Test is partly disabled as we still generate invalid tokens

Change-Id: I1a9b03b9bbe2ed7087c6ab7b6d0823ac1d058ba7
2013-10-23 04:28:16 +02:00
8bebd29976 Java cleanup, remove unnecessary @SuppressWarnings annotations
Change-Id: Ib5df091fc4a6233b526c44ae42dbdbacb0bef7c6
2013-05-06 11:45:58 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
be9d9fee66 RTL_CONSTASCII_(U)STRINGPARAM removed in comphelper
Change-Id: Ib068c06956bc9f04bb7c468375aacd2e6e9db77d
2013-01-31 10:21:07 +01:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
37a2fa5d5a fdo#51304: Remove the author of some java source files
This patch remove some '@author' for Java souce files, and removes some
commented code founded when removing the '@author'.

Change-Id: Ic4fcd028a9cdbd85c693d93bcd48e41f36386d22
2012-10-01 14:10:03 +02:00
0dae234811 Java5 update - use generics in code, and general cleanup
Change-Id: I6f2490c48a9d6dbb7de4917c07d5c1fb36c58777
2012-06-29 22:03:03 +02:00
2005a34318 re-base on ALv2 code. 2012-06-29 15:51:49 +01:00
328e2263fb targetted re-work of cppunit pieces. 2012-06-27 19:13:11 +01:00
b6db3e3acc re-base on ALv2 code.
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-21 13:11:06 +01:00
8e01e88145 add a route to compare a O[U]String to one code unit
Seems very awkward to create an entire temporary O[U]String just to compare it
to another when we want to know if that other contains just one char of a given
value

Change-Id: Iacd4e0d87dc5c5211fa06c61c55e1ed85b1e91f3
2012-06-18 15:13:51 +01:00
e2cd6a77ea drop String::Reverse
Change-Id: Ie06635dc1f242241d48f9d6de4f592898e605bf2
2012-06-06 14:38:42 +01:00
9ab0b38e95 Various string function clean up
Added:
* rtl::OString::matchL
* rtl::OString::endsWith
* rtl::OString::endsWithL
* rtl::OString::indexOfL
* rtl::OString::replaceFirst
* rtl::OString::replaceAll
* rtl::OString::getToken
* rtl::OUString::endsWith
* rtl::OUString::replaceFirst
* rtl::OUString::replaceFirstAsciiL
* rtl::OUString::replaceFirstAsciiLAsciiL
* rtl::OUString::replaceAll
* rtl::OUString::replaceAllAsciiL
* rtl::OUString::replaceAllAsciiLAsciiL
* rtl::OUString::getToken
plus underlying C functions where necessary

Deprecated:
* comphelper::string::remove
* comphelper::string::getToken

Removed:
* comphelper::string::searchAndReplaceAsciiL
* comphelper::string::searchAndReplaceAllAsciiWithAscii
* comphelper::string::searchAndReplaceAsciiI
* comphelper::string::replace
* comphelper::string::matchL
* comphelper::string::matchIgnoreAsciiCaseL
* comphelper::string::indexOfL

Also fixed some apparent misuses of RTL_CONSTASCII_USTRINGPARAM ->
RTL_CONSTASCII_STRINGPARAM.
2012-02-15 15:41:09 +01:00
740cf4a590 bah, we don't need these after all 2012-02-10 14:20:52 +00:00
9c19e79f19 extend unit test to islower 2012-02-10 11:09:08 +00:00
bacfd2dc4c add a comphelper::string::getTokenCount
suitable for conversion from [Byte]String::GetTokenCount
converted low-hanging variants to rtl::O[UString]::getToken loops
added unit test
2012-01-05 09:18:19 +00:00
b8ee1f9b5f remove include of pch header in comphelper 2011-11-27 13:00:14 -06:00
0dbc4fa3ef add string::strip, can replace EraseLeadingAndTrailingChars 2011-11-23 23:16:44 +00:00
b7ea361014 add stripStart, can replace EraseTrailingChars 2011-11-23 10:10:09 +00:00
20153742d2 add a stripStart, can replace EraseLeadingChars 2011-11-23 10:10:08 +00:00
4a06a42de4 want to match here, not check for equality 2011-11-22 12:50:14 +00:00
dca04e2361 add a StringUtils-alike remove (can replace EraseAllChars) 2011-11-17 23:04:10 +00:00
2401f2aa1c reported compile failure, possible sal_Int32 is long on 32bit vs int 2011-11-10 11:17:10 +00:00
8e482e60c5 an indexOfL would be useful 2011-11-10 09:28:39 +00:00
d996328cd5 sb140: #i113503# mixing system CppUnit and OOo STLport does not work, backed out a6913c9677c2
For LibO, that just means replacing sal/cppunit.h with sal/precppunit.hxx.
2011-09-12 22:47:50 +02:00
313332e76b various centralized isFOOAsciiStrings 2011-08-29 09:56:08 +01:00
14d2a60053 remove ByteString::IsAlphaNumericAscii and refactor a bit 2011-08-29 09:56:06 +01:00
eba1f976ce rename test 2011-08-15 09:21:49 +01:00
061ebc3446 add a getToken wrapper for extracting a single token painlessly 2011-08-15 09:21:49 +01:00
90fe8dadaa add a jdk 1.5-alike string replace to comphelper::string 2011-08-15 09:21:49 +01:00