Commit Graph

11 Commits

Author SHA1 Message Date
6d2de44a54 fix-includes.pl: comphelper
Change-Id: I0b4cd8320881b2b1f7984c86e58915217bcd0d5f
2014-05-11 01:55:37 +02:00
2c6b6ba446 Disambiguate CPPUNIT_ASSERT_EQUAL arguments
Change-Id: Ib32d59522f33bcd2608401b4f3d3529d9dee5642
2013-10-28 14:31:34 +01:00
c99267b326 Fold SyntaxHighlighter::initialize into ctor
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused.

Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28 13:48:14 +01:00
f5e8be8bb1 Remove unused SimpleTokenizer_Impl::nLine/nCol
...which are never read; remove thereby unused parameters from functions.

Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-28 13:48:13 +01:00
0827aba84e Correctly fix "Terminating NUL" fix
1cbe2313edda8a04f0fe233b4a29ef4e2485f557 "Terminating NUL at end of its buffer
is not considered part of OUString" was a thinko that cut the last character off
the last reported HighlightPortion on a line.

Change-Id: Idbe74676e85749cd93854293c6f49c7581414562
2013-10-28 10:47:19 +01:00
2733bc38f0 Demonstrate that empty comments are handled just fine
...see preceding revert of a79cb836b951eb2492e43aadd2ee672b9b67b914 "COMPHELPER:
Allow empty comments in SyntaxHighlight."

Change-Id: Ib0a8c46c19dd7f0697b95a1c28398073a1183281
2013-10-28 10:47:19 +01:00
a699e7c70d Revert "COMPHELPER: Allow empty comments in SyntaxHighlight"
This reverts commit a79cb836b951eb2492e43aadd2ee672b9b67b914, which broke
--with-help builds again, as

  strLine.copy(i->nBegin, i->nEnd-i->nBegin)

in BasicCodeTagger::tagParagraph (helpcompiler/source/BasCodeTagger.cxx) depends
on the invariant that a HighlightPortion does not extend past the source string.

Also, I see no reason for that change, as empty comments are handled just fine
already as demonstrated by the following commit...

Change-Id: I384bae9c4cf6a38d0a0a2832fa15bde82126cace
2013-10-28 10:47:19 +01:00
a79cb836b9 COMPHELPER: Allow empty comments in SyntaxHighlight
Change-Id: I0f3d5673e28e34ed3921c930aca48f3d7574b064
Reviewed-on: https://gerrit.libreoffice.org/6450
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
Tested-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2013-10-27 16:07:16 +00:00
2a8e751eb5 Improve test
Change-Id: I54e939b7bca883f1c92c957c66ebf47259c92a46
2013-10-23 09:40:38 +02:00
51ac50b538 Fix and enable CppunitTest_comphelper_syntaxhighlight_test
Change-Id: I2b2aa5f5afdbf58ec3ac2447db370bcb7d1778c0
2013-10-23 09:32:32 +02:00
eb13f2d92c add inital test for syntaxhighlighter
Test is partly disabled as we still generate invalid tokens

Change-Id: I1a9b03b9bbe2ed7087c6ab7b6d0823ac1d058ba7
2013-10-23 04:28:16 +02:00