2602a41f76
coverity#706466 Uncaught exception
...
and
coverity#706463 Uncaught exception
Change-Id: I77cb09054f00d86cd3e206e44ef4942ddf148a7f
2014-08-30 18:16:49 +01:00
78b2d82111
comphelper: starbeans -> css::beans
...
Change-Id: Iedfc4460194f179b20d734cb7671894213c77008
2014-08-21 09:03:20 +02:00
f133857cc6
comphelper: starutil -> css::util
...
Change-Id: If4c0d404b0f7027837dcc245b5b7d21b1f749347
2014-08-21 09:03:20 +02:00
32093237b3
comphelper: starlang -> css::lang
...
Change-Id: Ie8adb5b81df51fd973cbb786f27ea3ef1462679c
2014-08-21 09:03:19 +02:00
007099ea32
comphelper: staruno -> css::uno
...
Change-Id: I21991280c5b7e4c6d0c200f4489c89a9f4fbc385
2014-08-21 09:03:18 +02:00
eeeef4e83c
Include <algorithm> for std::min
...
Change-Id: If2bf31494f1354ff3856ad8b32f6799042e23b18
2014-07-29 18:21:00 +03:00
f8226e87b4
Pass a useful exception message.
...
Change-Id: Idde024a7b6896571d159c3983ef1985fa12d0c5a
2014-07-09 12:15:40 -04:00
f692c88e60
use SimpleReferenceObject in comphelper module
...
to replace hand-rolled version
Change-Id: Ie4e66d2f1f893c04be589877ef53f470ca74c9eb
2014-07-08 15:16:48 +02:00
0d78ad871e
DBG_ASSERT->assert when followed by dereference
...
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
2134c9653e
comphelper: sal_Bool -> bool
...
Change-Id: I7d7ae1f5ddff0cf7d11a407b190256f37a71d48a
2014-07-03 11:51:01 +02:00
37b1835972
Revert "comphelper: sal_Bool -> bool"
...
Oops, this reverts commit c95ff75df274e3d84458e928ee96870bc8b663b3.
2014-07-02 18:54:32 +02:00
c95ff75df2
comphelper: sal_Bool -> bool
...
Change-Id: Icde90101b6adfa766c8abbeb55c518725e6596e1
2014-07-02 18:49:31 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
9ea1bb2c1d
loplugin:staticcall
...
Change-Id: Iae319f84028bb2468ca663afe9a82eb3cf46ae37
2014-06-13 17:54:23 +02:00
41066fef1c
comphelper: remove SAL_THROW macro
...
Change-Id: I692f1213c4bf42a84fae119f513e609d8874bf0c
2014-06-05 08:17:46 +02:00
e7bc3cab01
remove boilerplate in UNO Exception constructor calls
...
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
b09b5f8f7c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
...
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
9c3e819f06
move boost rng wrapper from sc to comphelper
...
so we can re-use it in other modules
Change-Id: I6057b1e955f745019fd48f91a754279df0f2b948
Reviewed-on: https://gerrit.libreoffice.org/9348
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-17 12:40:39 +00:00
3c1e30b77d
Correct common misspellings, and remove some ASCII art along the way.
...
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
2014-05-17 12:38:38 +00:00
0b3d0fb2d9
fdo#78159: fix import of OOoXML embedded objects
...
MimeConfigurationHelper::GetDefaultFilterFromServiceName() checks that
there is both an import and an export filter, and for OOoXML the export
has been removed; tweak the check to require only import for OOoXML.
Currently it still works invoke the OOoXML filter, but it is clearly
better to store the embedded documents only in ODF, so tweak
OCommonEmbeddedObject::store* methods to do that.
(regression from aeeaccf59abbc485d7786486f1accc1cb4d4dbf7)
Change-Id: Ib71f23fd110cbd4b570517f2dde2c53e3aa6301d
2014-05-15 23:39:13 +02:00
036a660a86
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part11
...
Change-Id: Ibe0a1006aba2b6cbd87c0bd6ca3acbf9ba7b0fbe
2014-05-13 23:20:26 +02:00
6d2de44a54
fix-includes.pl: comphelper
...
Change-Id: I0b4cd8320881b2b1f7984c86e58915217bcd0d5f
2014-05-11 01:55:37 +02:00
2510690866
callcatcher: update unused code
...
Change-Id: I954a5dd88cb9ae9a2a36509507385e68b88f8cd5
2014-05-09 09:28:06 +01:00
4f9b21248f
simplify ternary conditions "xxx ? yyy : false"
...
Look for code like:
xxx ? yyy : false;
Which can be simplified to:
xxx && yyy
Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
ff154adfdc
fixincludeguards.sh: comphelper
2014-04-19 11:10:06 +02:00
728ec86062
Typo: s/cant/can't/
...
Change-Id: Id76b4ea569246c4b96da48dbc8d5a557367e0cca
2014-04-18 00:30:35 +03:00
6835d9f307
It's "its", not "it's"
...
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
b8757ee8c7
Clean up function declarations and some unused functions
...
Change-Id: I5817a5ad3966918cfb1920be568b7401dd6f948c
2014-04-07 13:48:53 +02:00
5babf1b903
remove unnecessary scope qualifier from sal_Bool uses
...
i.e. convert "::sal_Bool" to "sal_Bool"
Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
c289013572
typo: tempoary -> temporary
2014-03-29 19:16:24 +01:00
59f1e95844
typo: previos -> previous
2014-03-29 19:16:24 +01:00
dc8f33ba5d
typo: decription -> description
2014-03-29 19:16:23 +01:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
36784563ed
OAccessibleContextWrapperHelper does not implement XAccessibleContext
...
...but rather some (non-virtual) base functionality for use in derived classes
(that do implement XAccessibleContext)
Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1
2014-03-14 14:29:24 +01:00
9b7f17dd30
Fix races in AsyncEventNotifier::execute
...
* m_aDeadProcessors was useless; for one, removeEventsForProcessor could never
have run (and set m_aDeadProcessors) between execute's reading from aEvents
and checking m_aDeadProcessors (because of the use of aMutex in both
functions), and if that were addressed, there would always be a race that
execute would run a processor that has just been removed. Clients have to be
aware that a call to removeEventsForProcessor is just an optimization hint,
but does not guarantee that the given processor is not called from the execute
thread after removeEventsForProcessor returns.
* The sequence
aGuard.clear(); aPendingActions.reset(); aPanedingActions.wait();
could cause calls to aPendingActions.set() to get lost, both for signalling
new content in the queue and for signalling termination.
Change-Id: I43293e3d5090c2d46db8bc8ed6fb9c71e049d55c
2014-03-14 12:20:42 +01:00
61c44a9929
comphelper::OIHWrapNoFilterDialog does not implement XInitialization
...
Change-Id: Idce153607c3deb3f0a1809b9d18cbcc6f30cf04d
2014-03-13 12:50:12 +01:00
e3e1f9f30d
Leftover SAL_CALL
...
Change-Id: I895b2132ee752f191f30d6adc0af35cad005afe5
2014-03-11 14:54:30 +01:00
7211162081
Clean up uses of rtl_ustr_ascii_shortenedCompareIgnoreAsciiCase_WithLength
...
Change-Id: Ie37614dac882bfe05f8ce595ae6b20326dce872e
2014-03-01 19:28:14 +01:00
ec9e5a0f5d
coverity#1187647 try and help coverity out here
...
Change-Id: I94a0dad8113b8b6ac06ddf5456ff8c35d7c64fc1
2014-02-27 12:58:51 +00:00
697ec96e61
coverity#1187646 unused mpAbort
...
Change-Id: I1fc3f0253c2af4779ba59b5b85ea7fc400226177
2014-02-27 12:58:50 +00:00
a67c2a12bc
Remove visual noise from comphelper
...
Change-Id: I7e5512b43240beee05404cff9d49a87d0217ea89
Reviewed-on: https://gerrit.libreoffice.org/8242
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:42:45 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
6fbe00f9b6
coverity#983702 Uncaught exception
...
Change-Id: I3a0b4c8fe4208d0945860f6b4e1b31852aef8502
2014-02-25 16:12:23 +00:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
d12e472474
comphelper: sal_Bool -> bool sequel
...
Change-Id: I2b9bd19abf4510fccef0374a539069cb8222ccae
2014-02-19 14:31:09 +01:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
faced6b5f7
ucbhelper: sal_Bool -> bool
...
Change-Id: Iee327c3dd75bebb35d99de01eaa7103956e08974
2014-02-17 17:55:18 +01:00
3ec9bccaab
silence coverity#1027865 Out-of-bounds access
...
and coverity#1027864
Change-Id: Ic3d1b91ef77ab3510c7428b7135dd9f249d56b4b
2014-02-07 09:03:48 +00:00
9e77c2fb7c
Remove UNOIDL "array" and "union" vaporware remnants
...
...and deprecate what cannot be removed for compatibility.
Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
