Commit Graph

306 Commits

Author SHA1 Message Date
32093237b3 comphelper: starlang -> css::lang
Change-Id: Ie8adb5b81df51fd973cbb786f27ea3ef1462679c
2014-08-21 09:03:19 +02:00
7a54951fbb coverity#1231667 Unchecked return value
Change-Id: I40d8fc61b1e488955faa61c868877c7b6487c529
2014-08-17 16:39:22 +01:00
136fa5432d coverity#706282 Uncaught exception
Change-Id: Icca233fdc6d841d1bf51f918b83f3eef2cd5952e
2014-07-13 20:10:49 +01:00
b03675889d coverity#706281 Uncaught exception
Change-Id: I469b812c666801db5e3a6fac1d6152afd80cf39a
2014-07-13 20:10:49 +01:00
42bcbee2e6 clang: Result of operation is garbage or undefined
Change-Id: I49f58ae6a7c046af4c3de8d35219ffe2e4ba8f20
2014-06-26 16:29:14 +01:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
9ea1bb2c1d loplugin:staticcall
Change-Id: Iae319f84028bb2468ca663afe9a82eb3cf46ae37
2014-06-13 17:54:23 +02:00
63312dbbd3 coverity#706280 Uncaught exception
Change-Id: I41d841718da2eab8a6f424df694ba8ea4e450bac
2014-06-13 11:18:47 +01:00
c8b78a1ca2 coverity#706287 uncaught exception
Change-Id: Ie2ec61c75d036dbad68bd43d5a2eb9834dadd735
2014-06-13 11:16:32 +01:00
5e46374df0 coverity#706286 uncaught exception
Change-Id: Ic951a16c3d44b36ce82f05381c98e13e74b8bc35
2014-06-13 11:16:32 +01:00
41066fef1c comphelper: remove SAL_THROW macro
Change-Id: I692f1213c4bf42a84fae119f513e609d8874bf0c
2014-06-05 08:17:46 +02:00
f0ae48b684 remove unnecessary NULL parameter passed to UNO Exception
.. now that we have a default value for that parameter

Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-29 09:01:40 +02:00
0f2824b117 remove more unnecessary use of OUString constructor
Change-Id: Iae14cb3df65295b6894fd9e05411c5698e9c8aba
2014-05-27 08:20:12 +02:00
9c2b19c926 coverity#703930 Unchecked return value
Change-Id: Ifa4091eb08774309829ec9016b19e71cf9ea201a
2014-05-26 15:51:59 +01:00
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
c288b17cc5 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part12
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7
2014-05-14 23:18:57 +02:00
6d2de44a54 fix-includes.pl: comphelper
Change-Id: I0b4cd8320881b2b1f7984c86e58915217bcd0d5f
2014-05-11 01:55:37 +02:00
569ff6727e update_pch: add a bunch of pch files
I had to fix some source files because of macro redefinitions and such stuff.

Small modules like basic have a great win, too:

make basic.clean && time make basic:

                with    w/o
                 pch    pch
accessibility    23s  1m59s
basctl           30s  1m42s
basic            56s  1m35s
comphelper       23s    51s
editeng          48s  2m04s
forms            40s  1m40s
unotools         19s    38s
sd             3m37s  4m33s

Change-Id: Id24cdcddbe2ff64820b42266325c25af1355558f
Reviewed-on: https://gerrit.libreoffice.org/9293
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-09 19:50:42 +00:00
dc469b9d0b odd that apparently these only are checked in non-opt mode
Change-Id: Icbcd5f090e8fc63bf017ec83611ba9abf7335dae
2014-04-25 21:00:47 +01:00
dc21c527c5 coverity#706281 Uncaught exception
Change-Id: I6bc7ea330834054a20f89bdb0ac7cc9ccd9ca4aa
2014-04-25 20:19:12 +01:00
69c8acdcb4 coverity#706282 Uncaught exception
Change-Id: I495c558ed7692a0d2b669d9bc9cb62ed9ddc6665
2014-04-25 20:19:12 +01:00
ff154adfdc fixincludeguards.sh: comphelper 2014-04-19 11:10:06 +02:00
fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused
...since f059134fab0f91b7a15594ad06536a13fbfae034 "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
2014-04-15 07:46:43 +02:00
39b26e4466 typo: ommit -> omit 2014-04-14 12:32:13 +02:00
b8757ee8c7 Clean up function declarations and some unused functions
Change-Id: I5817a5ad3966918cfb1920be568b7401dd6f948c
2014-04-07 13:48:53 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
cc3a302fcb typo: unfortunally -> unfortunately 2014-03-29 19:16:20 +01:00
ee6895c61f Avoid possible resource leaks by boost::scoped_array
Change-Id: I3d26325995995f658cd6adcc80e0716cfcee7de0
2014-03-27 23:25:20 +09:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
98666e8625 No need for a virtual OPropertyContainer::getTypes
(and rename to getBaseTypes for clarity)

Change-Id: Icfe6202eea9b1f4ec2e46ade3fc8e001ca6b649f
2014-03-14 17:57:24 +01:00
22684273d5 forward*PropertyValue functions need not be SAL_CALL
...and _bSuccess parameter is unused

Change-Id: Iee5e1d5c2d4272f342b2867bfe76f8c87dcd69d4
2014-03-13 14:00:03 +01:00
ff19246a81 OPropertyStateHelper::getTypes isn't an override of XTypeProvider::getTypes
Change-Id: I633c711aabbd2ec7d1385d106b512f14672393f1
2014-03-11 13:03:20 +01:00
2726f2a785 comphelper: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I8da24ffd5eb1ac1fe6a6d2312ddc4ab13828bf07
2014-03-10 17:39:53 +01:00
a67c2a12bc Remove visual noise from comphelper
Change-Id: I7e5512b43240beee05404cff9d49a87d0217ea89
Reviewed-on: https://gerrit.libreoffice.org/8242
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:42:45 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
6fbe00f9b6 coverity#983702 Uncaught exception
Change-Id: I3a0b4c8fe4208d0945860f6b4e1b31852aef8502
2014-02-25 16:12:23 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
f45183d26f Unwind comphelper::OPropertyContainer_Base typedef
Change-Id: Ied87e18f8297fb8e85fdbcab38d719664e3ed066
2014-02-12 12:03:28 +01:00
ac6e8ac7e4 typo fixes in comments
Change-Id: Idd49478d59cd062118fbf8e99d1c8bc5250013fc
2014-02-06 23:22:30 +01:00
d98d2ad0cb Remove needless SAL_DLLPRIVATE annotations
Change-Id: Ib8d1eae0dce29756da626c73db75f59666bb0ea5
2014-02-03 16:05:10 +01:00
9bd0e895a4 coverity#1079000 Uncaught exception
Change-Id: I7ffee42abe03c34d68b6168328143666d72e7efc
2014-01-29 16:41:32 +00:00
1b574435a5 bool improvements
Change-Id: I17c451d33d6d5e4edf0304ff47d63ac878d7e5d9
2014-01-28 20:24:39 +01:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
ab9e014d6f Some clean-up
Change-Id: I8ea3018efb01069b9a0555d9ac4ddfa89a990ba8
2013-12-12 15:10:35 +01:00
3f3c755475 Remove newly unused comphelper/TypeGeneration.hxx
Change-Id: Ia63e07fa6f56f4797e2741f6800cb96559ff4928
2013-12-12 15:10:35 +01:00
45c0a6174d Simplify comphelper::PropertyInfo
...as its sole two uses (in sw) are already fine with initializing arrays of
it dynamically, there is no harm in changing it and thereby getting rid of the
last use of comphelper/TypeGeneration.hxx.

Change-Id: I11931dbbec48dac5a694a59cf6425206c806fbfb
2013-12-12 15:10:35 +01:00
83e191e25d Do not use C++-UNO internal static_type functions in client code
...use cppu::UnoType instead.

Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12 11:10:10 +01:00
a62c2a5fa5 Don't hold css::uno::Type instances by pointer
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry.  And as the
arrays of such need to be initialized dynamically anyway, also change their name
members to proper OUStrings while at it.  Plus some const clean-up.

Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-12 08:26:40 +01:00