Commit Graph

4593 Commits

Author SHA1 Message Date
57a4337e25 set names on a bunch more threads...
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25 13:21:59 +02:00
56ad57dee7 starsdbc -> css::sdbc
Change-Id: Id0411425b0a3400dffe47143f908ab283fd2247e
2014-08-21 09:03:24 +02:00
b3d9852309 Remove more useless includes of tools/debug.hxx
Change-Id: If289dcbff125ac0088f01b5c9752f9f3173585dc
Reviewed-on: https://gerrit.libreoffice.org/11020
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-20 09:10:01 -05:00
d4e64d0300 check len before memcpying into it
valgrind + bff on sf_3e0068c9b19bb548826bed0599f65745-CrdWMI-minimized.gif

Change-Id: I74cc21609f1c97a27e13615593f678cbbc8463e3
2014-08-18 12:59:48 +01:00
e49e41f760 check return of Execute row and propogate error code
Change-Id: I75b2c454122aa2d75d66dc46865135e01277bbcb
2014-08-09 13:35:48 +01:00
a9201a4dfe Conditional jump or move depends on uninitialised value(s)
at 0x2DC948DF: connectivity::dbase::ODbaseTable::fillColumns() (DTable.cxx:330)
...
   by 0x2C57E3B3: ScDocShell::DBaseImport(rtl::OUString const&, unsigned short, ScColWidthParam*, ScFlatBoolRowSegments&) (docsh8.cxx:345)

bff + valgrind: sf_52f907dbea3069ba59ef1e183a0f4160-430.pcx
fuzz a pcx long enough and it turns into a dbase file

Change-Id: Idf1622d6b55ae2cca381f263333d0ab0b6a469b2
2014-08-09 13:35:48 +01:00
6b5fb7ef6a coverity#706301 Uncaught exception
Change-Id: I6c81df21c7c8713e3d409fb9418e6d6bcca48d68
2014-07-26 21:25:20 +01:00
28b98516e5 coverity#1079093 Uncaught exception
Change-Id: I4b09963e2daf22dcd006fee0ce0bb130c7c18342
2014-07-26 21:25:15 +01:00
5687788744 Resolves fdo#81213: Wrong table-clause generated by reportbuilder
Oracle doesn't accept "AS" for making an alias from a table
See https://bugs.freedesktop.org/show_bug.cgi?id=81213#c2
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c4
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c5
for more information

(thank you Lionel)

Change-Id: I33c86d78b2590116d4af46ffd3e54c3c791268ea
2014-07-22 18:38:21 +02:00
8923103eee coverity#706376 Uncaught exception
Change-Id: Ic18823fd60826c144058df32c27ab25d58664e30
2014-07-21 13:59:34 +01:00
55dac4ff40 coverity#706364 Uncaught exception
Change-Id: I4a6f7a2aa76d2a998bb6392de35fa1d25c85b3ce
2014-07-13 20:10:49 +01:00
31a1eb4824 coverity#706372 Uncaught exception
Change-Id: If3b3395bbe44720540e9619bba6088c6cd29ed37
2014-07-10 13:39:15 +01:00
4228f08d60 use assert when followed by deref
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-03 12:49:38 +01:00
a215499bf3 clang scan-build: Argument with 'nonnull' attribute passed null
Change-Id: I7e8700936cf98a672a2513232cf4247f1783c41b
2014-07-03 12:49:37 +01:00
6a6d83ace3 coverity#706374 Uncaught exception
Change-Id: Ie17e29e6893c6f69f176d77fab9dcb6a90cb432b
2014-07-02 09:46:33 +01:00
7501ee9d9d coverity#706373 Uncaught exception
Change-Id: Iee4774dffd43be3fc3eacbcc81f150706625fcad
2014-07-02 09:46:32 +01:00
051a8f9577 coverity#706371 Uncaught exception
Change-Id: I2019711112b1acb336b3002faca312c658f28671
2014-07-02 09:46:32 +01:00
b26ccfa080 coverity#706368 Uncaught exception
Change-Id: Ia8988be31ed4dc4843bd6c2573ec14efa3af6397
2014-07-02 09:46:32 +01:00
c12e8e6435 coverity#706367 Uncaught exception
Change-Id: I5c17c94956a44dab13935dca41e812ebd196203a
2014-07-02 09:46:31 +01:00
067738943a coverity#706364 Uncaught exception
Change-Id: I75cd82d55d8bdf2f111cd0a91f056e1956ddad02
2014-07-02 09:46:31 +01:00
287ad2adeb coverity#706308 Uncaught exception
Change-Id: I852e701bd62929c1a7303b86286b8cbe66cdfc1f
2014-07-02 09:46:31 +01:00
6a20b62711 salplug:literaltoboolconversion
Change-Id: I94b3bea97b6b4710bd4bf4c0fe88a1518a151de5
2014-07-01 23:19:17 +02:00
9263b101c3 Activate the "suspicious cast to sal_Bool" parts of loplugin:salbool
Change-Id: I78a368ef2899b2462251b45a327fc7b1f31fe764
2014-07-01 17:49:10 +02:00
968f633b24 coverity#706382 Uncaught exception
and

coverity#706377
coverity#706378
coverity#706382

Change-Id: I17f672e31867b1be77c16a8a6e121a8f67df7c90
2014-07-01 16:43:05 +01:00
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
6d45e2a4fc coverity#1224302 Uncaught exception
Change-Id: I622a7c41c9083f2deec21dc8c37572f978874127
2014-07-01 10:56:14 +01:00
d979903273 odbc driver: let's not allocate the buffer twice for nothing
Change-Id: If5db845c856a9fb3adf8c4fcb883607e1cb9446e
2014-06-28 17:22:11 +02:00
715ecfe361 firebird driver: shutdown explicitely firebird on dispose of driver.
Change-Id: Ia44f7e01a3a01da57e4d9382f41511aa6f987b43
2014-06-28 16:56:24 +02:00
9015333ebd firebird: release driver on dispose rather than destroy.
Change-Id: I5ffeaf818c1eb4985bdd150830f089f03fe42ceb
2014-06-28 16:56:24 +02:00
ae6551b43d firebird driver, abandon ref to about to be disposed embedded storage.
Change-Id: I6bfce155151b79cd0a1707744e79298b45d8752b
2014-06-28 16:56:23 +02:00
6af3926609 WaE: null argument where non-null required (argument 2)
Change-Id: I3eb71120aed85a4ec2c697d149006bce063d983e
2014-06-28 07:22:23 +02:00
f7453024e1 fdo#80574 firebird memory management issues
Change-Id: I37438cd3f9c8e197e5a3aa3d9cbcc5bf3681d792
2014-06-27 23:37:51 +02:00
939ce4afbb Blind fix for OPreparedStatement::setParameter's useWChar case
...after 0181a13904daef160bee543e9806b23a835f79c8 "odbc properly support
platform with sizeof(SQLWCHAR) = 4" introduced usage of RTL_TEXTENCODING_UCS2/4
there, which do not make sense in combination with converting between OString
and OUString.

OTools::getStringValue will need a corresponding fix, too, in the other
direction (where the OUString(sal_uInt32 const * codePoints,
sal_Int32 codPointCount) ctor will be useful).

Change-Id: Ia94cd0deec46d269b6ee43362f4849837bb011c5
2014-06-27 23:07:00 +02:00
0181a13904 odbc properly support platform with sizeof(SQLWCHAR) = 4
Change-Id: I06d5a6c93817d2623fac3962b82c1319caf13276
2014-06-27 17:08:04 +02:00
e48a233960 loplugin:unreffun: also warn about redundant redeclarations
Change-Id: I9a812220b58cf6da00d854e65794f7c673ab239d
2014-06-27 15:27:39 +02:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
75ae6c9105 Typo: kjnow->know
Change-Id: Ib30aa4e8f430131f5f073169d694e53a3bcd6960
2014-06-18 22:56:12 +02:00
75df2983cb Typo: perharps->perhaps
Change-Id: Ibc1580d04d896a953edc15fb6cc9381914230e32
2014-06-18 22:55:24 +02:00
4c6a27aaad Use rtl::Reference to make code clearer & exception-safe
Change-Id: I8cfdf792541b351a19e16f95d4e6f7127e3d33b2
2014-06-18 22:46:53 +02:00
2504ffccd0 fdo#80084 file driver PreparedStatement: close previous ResultSet on reexec
This partially reverts commit d87c2c59c9c1d5f5825f355c9eb941fdf95b42f6
"sdbc file driver (Prepared)Statement: created ResultSet owned by *caller*"

From that commit, we keep the part about not reusing the same
ResultSet on reexecution (client code may have disposed it or closed
it), but we revert the part about not closing / disposing the previous
ResultSet on reexecution.

Change-Id: I4946207f9740484b2f5fbc3575a5708fe39f357c
2014-06-18 16:17:32 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
488f312000 Resolves: fdo#80025 Crash with Thunderbird/Icedove address book
There's no property USEBOOKMARKS for mork/moz

(regression from 0fadbdbbdbd55cf60f9a202f1cf7b1d60517078c)

Change-Id: If81f063fad2d702c9d8b0bb4147757655cb016cf
2014-06-15 07:02:11 +02:00
75838570c3 loplugin:staticcall
Change-Id: I7f22aa5576ca3c62fa363971f4fa5992b7711563
2014-06-13 17:54:24 +02:00
1beabeb55c coverity#706304 Uncaught exception
also

coverity#706301

Change-Id: Ie6eba530c9a2f822226fbd1b1a6aa49deaf99659
2014-06-13 13:38:26 +01:00
0acd0ed3a5 Related fdo#79714 OSX-crash opening query or table in embedded Firebird ODB
See https://bugs.freedesktop.org/attachment.cgi?id=100839 and other comments

Change-Id: I1187b171caf54997f5e8850ade4a3fb35ad9ec29
2014-06-11 19:24:03 +02:00
88cf5c115d coverity#1213468 Uncaught exception
Change-Id: I451b13be6b72925e4cfa0e66c5690eca22c54dad
2014-06-10 16:08:03 +01:00
c2034f3993 fixincludeguards: fix include guards
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-06 19:16:40 +00:00
11383f56fb connectivity: remove SAL_THROW macro
Change-Id: Id3bbb7a0d39a41b7106303f42d55ba4968235b63
2014-06-05 08:17:47 +02:00
a2db194ea0 connectivity: fix includes
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-06-04 21:18:39 +02:00
332a67afdc coverity#736759 Dereference before null check
Change-Id: Ia36e192d32c46a5c1129eca050b2863ec1213bb4
2014-06-04 12:34:14 +01:00