b3d9852309
Remove more useless includes of tools/debug.hxx
...
Change-Id: If289dcbff125ac0088f01b5c9752f9f3173585dc
Reviewed-on: https://gerrit.libreoffice.org/11020
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-20 09:10:01 -05:00
d4e64d0300
check len before memcpying into it
...
valgrind + bff on sf_3e0068c9b19bb548826bed0599f65745-CrdWMI-minimized.gif
Change-Id: I74cc21609f1c97a27e13615593f678cbbc8463e3
2014-08-18 12:59:48 +01:00
a9201a4dfe
Conditional jump or move depends on uninitialised value(s)
...
at 0x2DC948DF: connectivity::dbase::ODbaseTable::fillColumns() (DTable.cxx:330)
...
by 0x2C57E3B3: ScDocShell::DBaseImport(rtl::OUString const&, unsigned short, ScColWidthParam*, ScFlatBoolRowSegments&) (docsh8.cxx:345)
bff + valgrind: sf_52f907dbea3069ba59ef1e183a0f4160-430.pcx
fuzz a pcx long enough and it turns into a dbase file
Change-Id: Idf1622d6b55ae2cca381f263333d0ab0b6a469b2
2014-08-09 13:35:48 +01:00
6b5fb7ef6a
coverity#706301 Uncaught exception
...
Change-Id: I6c81df21c7c8713e3d409fb9418e6d6bcca48d68
2014-07-26 21:25:20 +01:00
8923103eee
coverity#706376 Uncaught exception
...
Change-Id: Ic18823fd60826c144058df32c27ab25d58664e30
2014-07-21 13:59:34 +01:00
a215499bf3
clang scan-build: Argument with 'nonnull' attribute passed null
...
Change-Id: I7e8700936cf98a672a2513232cf4247f1783c41b
2014-07-03 12:49:37 +01:00
75838570c3
loplugin:staticcall
...
Change-Id: I7f22aa5576ca3c62fa363971f4fa5992b7711563
2014-06-13 17:54:24 +02:00
1beabeb55c
coverity#706304 Uncaught exception
...
also
coverity#706301
Change-Id: Ie6eba530c9a2f822226fbd1b1a6aa49deaf99659
2014-06-13 13:38:26 +01:00
a2db194ea0
connectivity: fix includes
...
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-06-04 21:18:39 +02:00
f0ae48b684
remove unnecessary NULL parameter passed to UNO Exception
...
.. now that we have a default value for that parameter
Change-Id: I54d6b0a0a01ce2f2e5168ada0c427424de0477bc
2014-05-29 09:01:40 +02:00
55029129aa
coverity#982631 Missing break in switch
...
Change-Id: I1c21dfb48f4ecdcc3c599d69fe76bde006a85313
2014-05-26 10:18:27 +01:00
b09b5f8f7c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
...
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
c8695c6cce
Unify utl::TempFile ctors
...
Change-Id: I0a781a86804808cebf7756506d9299971c13e2ff
2014-05-14 13:38:23 +02:00
7339ab25ee
fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
...
this is a continuation of the above bug, removing SAL_INFO's
that only mark function entry.
Change-Id: Idb0f72481415594e3f8b7a11ad6e4b8835f6fca0
Reviewed-on: https://gerrit.libreoffice.org/9343
Tested-by: Thomas Arnhold <thomas@arnhold.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-13 18:04:58 +00:00
199d333f13
connectivity: sal_Bool->bool
...
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
2014-04-16 11:51:51 +02:00
75f5d9d214
typo: postion -> position
2014-04-14 12:32:40 +02:00
786b31696b
Typo: corect->correct
...
Change-Id: I31267af8aae35d647b8c4b0a0c5f926ad4779919
2014-04-03 21:15:54 +02:00
8728c34662
connectivity: sal_Bool->bool
...
Change-Id: Iafa52d3643b9313c20c75cf98f6b1ec231bf9d6d
2014-04-01 07:38:09 +02:00
5a1732eaab
Remove remaining DBG_CTOR etc. remnants from connectivity
...
Change-Id: I9d7ca8354cef6a1474914ce290c476460f982bdd
2014-03-28 15:26:01 +01:00
358be80f65
comphelper,connectivity: prefer passing OUString by reference
...
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
1bc8bc96c1
coverity#1190360 Unintended sign extension
...
Change-Id: I1fa3a668d47190af3197801a4d99e135d50e2088
2014-03-08 14:25:04 +00:00
ac9212feed
Remove visual noise from connectivity
...
Conflicts:
connectivity/source/inc/odbc/OConnection.hxx
Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 06:54:35 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
d9cd3dc9aa
connectivity: harmonize types relatated to Tell()/Seek()
...
Change-Id: I032f6d32b151203e62b23bffaf25dbc4aeb5ae8a
Reviewed-on: https://gerrit.libreoffice.org/8217
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2014-02-25 04:42:28 +00:00
b7259532d8
Remove unnecessary bool2any
...
Change-Id: Ie2caee1d5a7912011d76172539c2f8f37eaee5cf
2014-02-24 08:08:00 +01:00
ad73967e99
Remove unnecessary extractInterface
...
Change-Id: I4848bf84615274ad5732223a354fb7a6b845d9a8
2014-02-24 08:08:00 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
15535e32dd
convert SvStream::operator>> methods to ReadXXX methods
...
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-02-12 15:31:40 +00:00
4bb7e9a1b0
WaE: -Werror=missing-field-initializers
...
Change-Id: I7d1c9c460d41dec416275e1ce8e6328020118682
2014-02-02 00:50:35 +00:00
599b3c91dc
accidentally used a c++11 only construct
...
Change-Id: I3c89cdf3c3ea6214f4313afde70677f0752dc66b
2014-02-01 17:38:17 -06:00
5323a5a587
coverity#707692-93 : Uninitialized scalar field
...
Change-Id: I72f1e29ef4f5e8af1e3bd300bc2604396080912c
2014-02-01 15:29:56 -06:00
9e015c70cd
coverity#707691 : Uninitialized scalar field
...
Change-Id: I7bd74a8cb2b3cd5a57e960605816fc8373f8bae4
2014-02-01 15:29:56 -06:00
c6faf13222
coverity#707690 : Uninitialized scalar field
...
Change-Id: Ie8df6f61610083afd46bccc3a1363e62f54a40db
2014-02-01 15:29:55 -06:00
ead1525417
bool improvements
...
Change-Id: If35c939adede6a912dee14714a7ceeab84ac977e
2014-01-28 20:24:39 +01:00
61360536d7
coverity#440728 Explicit null dereferenced
...
Change-Id: I76b8d6eb59d2558a7ff8a1b1573f24e41a03b8b6
2014-01-23 20:35:32 +00:00
89f7da7ac1
coverity#1158204 Unintentional integer overflow
...
Change-Id: I8e10fb52803dbd81e5490940a9a7e529beebc803
2014-01-23 20:35:32 +00:00
d803483f6a
convert more SvStream::operator<< calls
...
.. to more explicit SvStream::Write* calls
This was done using another run of the clang rewriter, and then
a lot of hand tweaking to fix all the places where the rewriter
did not play nice with various macros.
Change-Id: I7bcab93851c8dfb59cde6bc76290c6484d88fb18
Reviewed-on: https://gerrit.libreoffice.org/7494
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-01-22 22:00:39 +00:00
c648d08720
convert SvStream::operator<< overloads to more explicit methods
...
This is in preparation for more conversion of SvStream::operator<< calls
to use more explicit method names.
This converts the subclasses that have their own convenience overloads
of operator<< to use normal methods.
Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-16 16:08:34 +01:00
09dc581359
drop unnecessary tools/string.hxx includes
...
Change-Id: I2439ed19b554381f80e882aacbac05167622df92
2014-01-13 13:54:51 +00:00
b69864f3f8
re-write SvStream operator<< to non-overloaded methods
...
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-01-10 13:26:24 +00:00
e2591cdeeb
drop STRING_MAXLEN uses from connectivity
...
Change-Id: I12a999c2c6bdd119c2e3e544bbbdabb0b0ce2ba2
2013-12-30 00:21:08 +00:00
151887a955
Fix other typos
...
Change-Id: I3f0a51c53efdd383d49d978a1e8531afe9dac896
2013-12-22 18:51:41 +01:00
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
4283bc1836
convert STRING_NOTFOUND -> NODE_NOTFOUND in connectivity
...
The code was interchangably using the two anyway.
Change-Id: I4f3fe8f1d699a9725bbcce0138a9d978a1eff28a
2013-11-11 13:41:43 +02:00
1bdb2b6f06
remove unnecessary use of OUString constructor in CONNECTIVITY module
...
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
2013-11-11 11:21:25 +02:00
aeb41c9b9b
remove redundant calls to OUString constructor
...
Change code like this:
aStr = OUString("xxxx");
into this:
aStr = "xxxx";
Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04 10:11:07 +02:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
2b91dc3ae6
fdo#54938: Adapt connectivity module to use cppu::supportsService
...
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Stephan Bergmann <sbergman@redhat.com >
2013-10-09 15:03:38 +00:00
8e30689680
drop worthless _VECTOR_/_MAP_ header guards
...
Change-Id: I54be19847b8fb609f0b08a528cc06dbae9f579d5
2013-09-25 19:24:24 +02:00
