Commit Graph

492 Commits

Author SHA1 Message Date
56ad57dee7 starsdbc -> css::sdbc
Change-Id: Id0411425b0a3400dffe47143f908ab283fd2247e
2014-08-21 09:03:24 +02:00
5687788744 Resolves fdo#81213: Wrong table-clause generated by reportbuilder
Oracle doesn't accept "AS" for making an alias from a table
See https://bugs.freedesktop.org/show_bug.cgi?id=81213#c2
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c4
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c5
for more information

(thank you Lionel)

Change-Id: I33c86d78b2590116d4af46ffd3e54c3c791268ea
2014-07-22 18:38:21 +02:00
8923103eee coverity#706376 Uncaught exception
Change-Id: Ic18823fd60826c144058df32c27ab25d58664e30
2014-07-21 13:59:34 +01:00
4228f08d60 use assert when followed by deref
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-03 12:49:38 +01:00
75838570c3 loplugin:staticcall
Change-Id: I7f22aa5576ca3c62fa363971f4fa5992b7711563
2014-06-13 17:54:24 +02:00
a2db194ea0 connectivity: fix includes
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-06-04 21:18:39 +02:00
6cc359f8d7 Replace "compareToAscii" by !=
See http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-td4110680.html

Change-Id: I1ed37671e6c248ada7a972dba00e0fe98b565e75
2014-05-30 22:17:41 +02:00
db681394e0 Update comment to reality... many properties now, not one.
Change-Id: Icc81d3067969d1d61182865d36ecabec4e7f85b7
Reviewed-on: https://gerrit.libreoffice.org/9551
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-05-29 10:52:16 -05:00
74393875bc To avoid some confusion for people like me :)
Thank you Lionel and Tor!
(see http://nabble.documentfoundation.org/Strange-part-in-connectivity-source-drivers-jdbc-tools-cxx-td4110680.html)

Change-Id: Ibbe68b8b3d12e4dfacf7f66bb3adbc2fd831d1a5
2014-05-29 12:45:20 +02:00
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
985f2b8b40 remove unnecessary use of OUString constructor
Change-Id: I7769625289d8bf47fe5905dfb91d3bce9e0f5c85
2014-05-22 07:54:55 +02:00
fcf4b4c3eb remove wrongly added IsBookmarkable property
Change-Id: I7bde1200dbe9da76e062f2783cc223a07084c6fd
2014-05-17 19:41:51 +02:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
7339ab25ee fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
this is a continuation of the above bug, removing SAL_INFO's
that only mark function entry.

Change-Id: Idb0f72481415594e3f8b7a11ad6e4b8835f6fca0
Reviewed-on: https://gerrit.libreoffice.org/9343
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-13 18:04:58 +00:00
0fadbdbbdb Kill DECL_PROP0 and the rest + clean propertyids.hxx
Change-Id: I872bc07ff9b1fe96a35e06ad3c5d8aaa75199bdd
2014-05-12 22:54:33 +02:00
1334d20046 Kill DECL_PROP1IMPL and related (jdbc part)
Change-Id: I9b9e985768f05b20457cfb8a0fc991f7b3da53e9
2014-05-12 22:54:32 +02:00
199d333f13 connectivity: sal_Bool->bool
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
2014-04-16 11:51:51 +02:00
358be80f65 comphelper,connectivity: prefer passing OUString by reference
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
ac9212feed Remove visual noise from connectivity
Conflicts:
	connectivity/source/inc/odbc/OConnection.hxx

Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:54:35 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
3b06e5e646 Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: I1ebfb33063d39f64dc59623df0f942501870c4e7
2014-02-22 21:51:27 +09:00
c92753e395 Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: Iafdebacd43ed24a30fb8e2d041fe975a1adbcfa0
2014-02-20 11:25:30 +09:00
6759faa1e6 sal_Bool -> bool fixup
Change-Id: Id1d838fe4316bbc0e1137d395bb15db3585aed84
2014-02-18 10:55:23 +01:00
d20ffc370b fix windows build
Change-Id: Ibbeda9f66ee9c81ac4202f999173adbf00ed8f83
2014-02-18 04:04:23 +01:00
cb64711136 Don't use OSL_LOG_PREFIX when throwing exceptions in non-debug builds.
Using OSL_LOG_PREFIX in the exceptions is not a good idea; it blows the size
of the string literals tremendously - full build path for every line that uses
that, including the line.

Let's not remove it for good, but hide it for non-debug builds
(OSL_DEBUG_LEVEL == 0) so that anybody who would like to use this during
debugging could still do (but I doubt it has any value for anybody).

Change-Id: Icc8db95ae0862671a206e681f92c60cdf51ffc32
2014-01-27 23:21:43 +01:00
01329972d8 fdo#37167 create statement before execute/wasNull/getBoolean
This populates "object" member variable.

The "createStatement" calls were removed in:

 commit b9392a36645d8632b97ad79240f483b3a1683b61
 Author: Ivo Hinkelmann <ihi@openoffice.org>
 Date:   Thu Apr 23 10:42:05 2009 +0000

    CWS-TOOLING: integrate CWS dbaperf1

This was most probably in error since the call is not removed from the
other modified member functions in this commit and/or failed to
aaccount for the scenario of no parameter (and thus no setXXX call
before execute).

Change-Id: Ic0e7b7b64ea496791f32c1416aa7d4416f909616
2014-01-06 17:11:00 +01:00
b1d65c9f15 Allow setting environment value directly in .component files
...for internal loader="com.sun.star.loader.SharedLibrary" components, instead
of exported component_getImplementationEnvironmen (or implicit
CPPU_CURRENT_LANGUAGE_BINDING_NAME).  Adapted a few .component files as proof-
of-concept, more to follow.

Change-Id: I82332e0a48e6fc1da245990bb72265fe6e58447e
2013-12-16 21:43:12 +01:00
a83b2af9ab Clean-up uno/lbnames.h
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-16 21:43:12 +01:00
c5b7a5fd19 fix equalsAscii conversion. Noticed in fdo#72391
In commit 363cc397172f2b0a94d9c4dc44fc8d95072795a3
"convert equalsAsciiL calls to startWith calls where possible"
I incorrectly converted equalsAsciiL calls to startsWith calls.
This commit fixes those places to use the == OUString operator.

Change-Id: If76993baf73e3d8fb3bbcf6e8314e59fdc1207b6
2013-12-09 12:53:18 +02:00
363cc39717 convert equalsAsciiL calls to startWith calls where possible
Simplify code like:
    aStr.equalsAsciiL( "%", 1 )
to
    aStr.startsWith( "%" )

Change-Id: Iee0e4e60b0ae6d567fa8f72db5d616fffbec3c00
2013-11-19 12:49:29 +02:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
1bdb2b6f06 remove unnecessary use of OUString constructor in CONNECTIVITY module
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
2013-11-11 11:21:25 +02:00
2b91dc3ae6 fdo#54938: Adapt connectivity module to use cppu::supportsService
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-09 15:03:38 +00:00
0718498999 Replace deprecated std::auto_ptr with boost::scoped_ptr
Change-Id: Ic55d1a8b14ec0355a6289007d954e89cd41c7486
2013-10-02 16:49:49 +02:00
54a737ab4d -Werror,-Wunused-const-variable
Change-Id: I2cf98c691fb11be340ff973a51477c56d5d97d50
2013-10-02 16:49:29 +02:00
4290420215 Make Java-based connectivity drivers work with jvmfwk "direct mode"
...so they work from CppunitTests (which make use of that "direct mode").

Change-Id: I92b72fb708ac1868644111b208f92ac58610ed11
2013-09-16 11:39:24 +02:00
83d62cad93 CID#1079186 ununinitialized pointer
Change-Id: Ie22e82904dc12f064c3b7d47bce294c5515590de
2013-09-05 12:52:11 +01:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
1b0a43142b new dbtools::DBTypeConversion::toTimeStringS for time in second precision
(no fractional second)

Change-Id: I8bf448783b24fceae9a750f40887d6296999b203
2013-06-27 09:29:33 +02:00
83dc5c0758 fdo#66216 JDBC no fractional second in time format
fractional second allowed in timestamp. But not in time. Don't ask why.

Change-Id: I5415889ab4cf4835b8b0db7363b7d9eb0a332393
2013-06-27 09:29:32 +02:00
dd3f8fbaff fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
- replaced RTL_CONTEXT_ with SAL_INFO
- replace OSL_* with SAL_*

Change-Id: If89af70767c3fdc4b1d0cb5e51033ca98583bc5d
Reviewed-on: https://gerrit.libreoffice.org/4286
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-17 15:55:21 +00:00
e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
e8ff469da5 Remove any remaining remnants of unused component_canUnload feature
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19 16:52:03 +02:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
2b7ee1db28 remove boilerplate comments
Change-Id: I44a476a9843816f70a7a4d84b8c35edeecd5daaf
2013-04-01 22:45:36 +02:00
aa753f01ba -Wunused-macros
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20 07:32:53 +02:00
39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00