Commit Graph

219 Commits

Author SHA1 Message Date
9263b101c3 Activate the "suspicious cast to sal_Bool" parts of loplugin:salbool
Change-Id: I78a368ef2899b2462251b45a327fc7b1f31fe764
2014-07-01 17:49:10 +02:00
968f633b24 coverity#706382 Uncaught exception
and

coverity#706377
coverity#706378
coverity#706382

Change-Id: I17f672e31867b1be77c16a8a6e121a8f67df7c90
2014-07-01 16:43:05 +01:00
75ae6c9105 Typo: kjnow->know
Change-Id: Ib30aa4e8f430131f5f073169d694e53a3bcd6960
2014-06-18 22:56:12 +02:00
75df2983cb Typo: perharps->perhaps
Change-Id: Ibc1580d04d896a953edc15fb6cc9381914230e32
2014-06-18 22:55:24 +02:00
75838570c3 loplugin:staticcall
Change-Id: I7f22aa5576ca3c62fa363971f4fa5992b7711563
2014-06-13 17:54:24 +02:00
a2db194ea0 connectivity: fix includes
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
2014-06-04 21:18:39 +02:00
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
0fadbdbbdb Kill DECL_PROP0 and the rest + clean propertyids.hxx
Change-Id: I872bc07ff9b1fe96a35e06ad3c5d8aaa75199bdd
2014-05-12 22:54:33 +02:00
5e7e4edb7a Kill DECL_PROP1IMPL and related (kab part)
Change-Id: Ia387a4255e641c51094347d8f0d0a5271f3af8e7
2014-05-12 22:54:31 +02:00
888057cb5c fixincludeguards.sh: connectivity 2014-04-19 11:10:08 +02:00
453ee351f3 fdo#43157 : clean up more OSL_POSTCOND
Change-Id: Iaca31b4e12c258b762b3d88fbad0fb08b4f1fc16
Reviewed-on: https://gerrit.libreoffice.org/8832
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-04-04 07:23:43 -05:00
1ea5e5c4a9 loplugin:literaltoboolconversion
Change-Id: I9f0e84b63ee6e338fc273c137eb1d1470b8185dc
2014-04-01 08:40:10 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
ac9212feed Remove visual noise from connectivity
Conflicts:
	connectivity/source/inc/odbc/OConnection.hxx

Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:54:35 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
1bdb2b6f06 remove unnecessary use of OUString constructor in CONNECTIVITY module
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
2013-11-11 11:21:25 +02:00
2b91dc3ae6 fdo#54938: Adapt connectivity module to use cppu::supportsService
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-09 15:03:38 +00:00
4216518982 Update implementations of ColumnLocate::findColumn to throw on invalid column.
Change-Id: I7a9354ecd35a70a005c6c50e38d27de9b33332bd
Reviewed-on: https://gerrit.libreoffice.org/5922
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-09-12 17:26:12 +00:00
1ece204b54 valueOf is deprecated
Change-Id: I8966ecd4e94c7b11af4d59b5b4461ce03a888891
2013-08-21 16:09:07 +02:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
e8ff469da5 Remove any remaining remnants of unused component_canUnload feature
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19 16:52:03 +02:00
81cf58f191 date/time IDL datatypes incompatible change: fixup
Change-Id: Ib750a009e49e19d63f8b6df85947a7b5c9b75bcf
2013-04-19 07:17:33 +02:00
f805afcf4c date/time IDL datatypes incompatible change: fixup
Change-Id: Icb5ffe659e0b6eebacf7788a7f66ce454a00b524
2013-04-18 23:00:32 +02:00
9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
52f8321c41 use #if instead of #ifdef for testing config_xxx.hxx macros
http://lists.freedesktop.org/archives/libreoffice/2013-March/047769.html

Change-Id: I81ed4500878ff3193e028410a1f0205e28d17fc3
2013-03-20 11:34:18 +01:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
4bf95c4c31 make use of startsWith()
Change-Id: Ie70097de550ddd1cddc6714f8f86f9723cb36679
Reviewed-on: https://gerrit.libreoffice.org/2599
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-03-08 13:16:49 +00:00
4f4e4e40f5 loplugin: improve indentation
Change-Id: Idb847766d93dc222d6c55889616da21eeac212ee
2013-02-25 17:59:40 +01:00
fa24204cd7 Update TDE (Trinity Desktop Environment) integration files
Change-Id: I48a5da0d01ad3532b9a77ff864f8f9e4d14e734c
Reviewed-on: https://gerrit.libreoffice.org/2374
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2013-02-24 23:46:04 +00:00
f6585c2718 added language tags comment
Change-Id: Ie5942c13c8f64063ca9d45e25ff7efbf5c3b3d16
2013-02-18 20:07:06 +01:00
53990ff947 fixes for UNO changes
Fix KAB driver

Change-Id: Iba44875122b813fb7ed2f09e3a8d9dbbef91d085
2012-12-21 11:18:25 +02:00
bb121c864c fdo#46808, Convert frame::Desktop to new style service.
I had to drop XEventBroadcaster from the merged interface
because it introduced method name conflicts (addEventListener).

Shouldn't be an issue since it was scheduled to be dropped anyhow,
and the service implementation still implements it, so existing clients
will be fine.

I dropped the interface XPropertySet from the combined IDL because nobody
seems to be using it, and it's primary purpose appears to be to set weird
flags.

I dropped the optional interfaces
   XStatusIndicatorFactory
   XDispatchInformationProvider
from the combined IDL because the service does not implement them, and
nobody seems to be using them. I suspect they were mistakenly copied
from XFrame.

I also did not convert the Title, UserDefinedAttributes and LayoutManager
properties to attributes, again because no-one is using them.

Change-Id: I678a00006ed2cca2d6c37c4e39465811442c33af
2012-12-21 10:57:09 +02:00
bd9eaa10d3 Some cppcheck cleaning in connectivity
Change-Id: I72cf68b193a4d6b16255f8b92e4c0262cd6cac78
2012-12-20 23:56:32 +01:00
1aad4689ba use config_xxx.h files instead of -DHAVE_XXX on the command line
As the latter does not quite scale, and also source files depending
on the setting/feature did not rebuild in case of a change.

There are intentionally more config_xxx.h files (so autoheader
from autotools is not used), so that a setting change does not force
automatically a rebuild of everything. Running configure does not
touch those config_xxx.h files that have not changed.

There's config/README with a howto.

Change-Id: I6d6e82050ff8faf5364ed246848b8401aca3e0e5
2012-12-07 19:48:16 +01:00
0666e43c45 fdo#46808, use service constructor for i18n::CharacterClassification
Change-Id: I0499ad7de27b1539e97f01ab8aa0ef2d6713ae76
2012-11-05 18:05:00 +01:00
e3b12f1762 connectivity: port kab driver to new OColumn, too
Change-Id: I19657ee92b5d0e1e51d11dd2aa69191fdb0f4f50
2012-11-02 11:54:27 +01:00
f42a930976 Use prefixes for these UNO components
Change-Id: I719f10818fd211bfe60e5351a5de53a716fdf20f
2012-10-01 21:54:57 +03:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
65006ffb0b -Werror,-Wunused-private-field (connectivity/source/drivers/kab)
...and some related clean up.

Change-Id: I26a8720fb7f60615f2e348e4728a3abddf6a33cd
2012-09-13 13:32:27 +02:00
091c1b6fc5 more old module-description xml files
Change-Id: I9ac503b073ee3f9b8e7958264ffcc26d9446c220
2012-08-22 23:27:34 +02:00
78b2d4d00d callcatcher: update list
Change-Id: Id297f32de5fba9d17fec89d2f8ea21c5d1a2a4bc
2012-08-22 12:08:22 +01:00
d88325f73e Revert "fix for fdo#48200.diff import regrex state for filter"
This reverts commit 094654fcebe35af07a9e12137becdf85277ef706.
2012-08-16 17:43:12 +01:00
094654fceb fix for fdo#48200.diff import regrex state for filter
Change-Id: I46b07341e96d78130e6301e40fa32df6ed2c7879
2012-08-16 17:40:05 +01:00
57154616f0 Remove UNO includes comments
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
2012-06-29 09:25:09 +02:00
6c1dd94d78 re-base on ALv2 code. 2012-06-26 11:33:03 +01:00
27b88d815d removed unused forward declarations of class
Change-Id: I814f8bdf4e4015f8e4eea34533db4ed8d6a7496e
2012-06-25 10:13:44 +09:00
ddaf53acd4 re-base on ALv2 code. 2012-06-12 22:24:55 +01:00