wangxin/loongoffice
1
0
Fork 0
forked from amazingfate/loongoffice
Code Pull Requests Activity
359,769 Commits 5 Branches 0 Tags
67cba3af55e94debe8eb6392bc8d0b2f00a7a199
Commit Graph

96 Commits

Author SHA1 Message Date
Caolán McNamara
8923103eee coverity#706376 Uncaught exception 
Change-Id: Ic18823fd60826c144058df32c27ab25d58664e30
 2014-07-21 13:59:34 +01:00
Noel Grandin
e2080e70fe new compilerplugin returnbyref 
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
 2014-06-24 11:34:21 +02:00
Noel Grandin
3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Julien Nabet
488f312000 Resolves: fdo#80025 Crash with Thunderbird/Icedove address book 
There's no property USEBOOKMARKS for mork/moz

(regression from 0fadbdbbdbd55cf60f9a202f1cf7b1d60517078c)

Change-Id: If81f063fad2d702c9d8b0bb4147757655cb016cf
 2014-06-15 07:02:11 +02:00
Thomas Arnhold
c2034f3993 fixincludeguards: fix include guards 
Change-Id: Ie6e8d4272b0b1d0d2ce93bcbc2e818a9eac1a56b
Reviewed-on: https://gerrit.libreoffice.org/9629
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-06 19:16:40 +00:00
Noel Grandin
11383f56fb connectivity: remove SAL_THROW macro 
Change-Id: Id3bbb7a0d39a41b7106303f42d55ba4968235b63
 2014-06-05 08:17:47 +02:00
Thomas Arnhold
a2db194ea0 connectivity: fix includes 
Change-Id: I5d5dc6871789865189c78fe9135e7f8bff829489
 2014-06-04 21:18:39 +02:00
Stephan Bergmann
317306710d Fix memory leak 
Change-Id: I64a74ea23d9a2410ebff0c42c54601fd0b0190f0
 2014-05-30 16:16:19 +02:00
Stephan Bergmann
773881d49e Fix memory leak 
Change-Id: I30ab0dcf47d236c8ebda3a2d1da0aaa4f0cd7477
 2014-05-30 16:16:02 +02:00
Stephan Bergmann
f33dc92572 Fix memory leak 
Change-Id: Ia9176826b89b947408230bf65db26a83f269c845
 2014-05-30 15:55:01 +02:00
Stephan Bergmann
c9f5e9b709 Fix memory leak 
Change-Id: I70522657f968ed4f84e9447dd999d8be746fc973
 2014-05-30 15:55:00 +02:00
Stephan Bergmann
63405c0500 Fix memory leak 
Change-Id: I0e5c3af0504f3090a5db7692c6bfb1d33b3aa81f
 2014-05-30 15:55:00 +02:00
Caolán McNamara
56abf72c45 coverity#983622 Uncaught exception 
Change-Id: I3b63a42444a116afe7d88e2f806b17a709651e34
 2014-05-24 16:11:01 +01:00
Julien Nabet
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Noel Grandin
72f6071351 connectivity: remove SAL_INFO's that only mark function entry 
Change-Id: If6863d18dac6ee0364c98d255e0cf55748ea4bf9
 2014-05-14 16:54:23 +02:00
Noel Grandin
7339ab25ee fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO 
this is a continuation of the above bug, removing SAL_INFO's
that only mark function entry.

Change-Id: Idb0f72481415594e3f8b7a11ad6e4b8835f6fca0
Reviewed-on: https://gerrit.libreoffice.org/9343
Tested-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-13 18:04:58 +00:00
Julien Nabet
0fadbdbbdb Kill DECL_PROP0 and the rest + clean propertyids.hxx 
Change-Id: I872bc07ff9b1fe96a35e06ad3c5d8aaa75199bdd
 2014-05-12 22:54:33 +02:00
Julien Nabet
a269406d40 Kill DECL_PROP1IMPL and related (mork part) 
Change-Id: Icb2f67fd8ebd88e3cd9db1daa0a0a97ad75a44a0
 2014-05-12 22:54:33 +02:00
Stephan Bergmann
aff54e8ef5 That lone acquire() was hopefully just a needless copy/paste 
...from ab9d657e0060473a25abd6f36bd30aad0574a4db "INTEGRATION: CWS dba22ui:
acquire in dtor, to prevent reentrance."  Yuck.

Change-Id: Iec5e1fa9d04199a4a1e83c67ed2014299317c5d8
 2014-04-25 14:14:50 +02:00
Thomas Arnhold
371046c6a3 add missing modelines to cxx and hxx files 
some of them have no copyright header

Change-Id: I9c2c0c859dabe231cb29af29290847e7b4aa46a3
 2014-04-24 11:58:15 +02:00
Thomas Arnhold
888057cb5c fixincludeguards.sh: connectivity 2014-04-19 11:10:08 +02:00
Noel Grandin
199d333f13 connectivity: sal_Bool->bool 
Change-Id: I96371121ce6697f153f4e973e65831ea2265eb56
 2014-04-16 11:51:51 +02:00
Tor Lillqvist
6835d9f307 It's "its", not "it's" 
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
 2014-04-10 20:22:50 +03:00
Stephan Bergmann
362d4f0cd4 Explicitly mark overriding destructors as "virtual" 
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
 2014-04-01 19:22:54 +02:00
Noel Grandin
8728c34662 connectivity: sal_Bool->bool 
Change-Id: Iafa52d3643b9313c20c75cf98f6b1ec231bf9d6d
 2014-04-01 07:38:09 +02:00
Noel Grandin
2c7bef7b8d connectivity: sal_Bool->bool 
Change-Id: Ic583deda8b0be3c89bcd644a1872ebd83276487a
 2014-04-01 07:38:08 +02:00
Caolán McNamara
2c345da372 coverity#736137 Dereference null return value 
Change-Id: Ie66e71e2aff49db5c0192fd0e787231081d24060
 2014-03-28 13:14:00 +00:00
Stephan Bergmann
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Noel Grandin
358be80f65 comphelper,connectivity: prefer passing OUString by reference 
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
 2014-03-14 07:47:01 +02:00
Alexander Wilms
ac9212feed Remove visual noise from connectivity 
Conflicts:
	connectivity/source/inc/odbc/OConnection.hxx

Change-Id: I5ca98359e18cf1b27bf53037dde211774d798626
Reviewed-on: https://gerrit.libreoffice.org/8245
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-27 06:54:35 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs 
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
 2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Takeshi Abe
d39178ff6c Drop unused #include 
Change-Id: Id1badf4ae68d322a6e05e900aa63bdb124387bab
 2014-02-17 11:26:31 +09:00
Stephan Bergmann
ead1525417 bool improvements 
Change-Id: If35c939adede6a912dee14714a7ceeab84ac977e
 2014-01-28 20:24:39 +01:00
Tor Lillqvist
be053c9a80 Spelling correction: s/retrive/retrieve/ 
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
 2013-12-20 23:26:58 +02:00
Caolán McNamara
bea15d037b CID#736937 Not restoring ostream format 
Change-Id: I07b1d90258647453e498b574bc38c78872041c2d
 2013-12-19 11:31:10 +00:00
Stephan Bergmann
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..." 
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
 2013-12-17 11:06:00 +01:00
Noel Grandin
08fe82e59c Remove unnecessary use of OUString constructor in + expressions 
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
 2013-12-17 11:49:03 +02:00
Stephan Bergmann
b0926378ac Clean up includes of comphelper/stl_types.hxx 
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
 2013-12-06 17:56:11 +01:00
Noel Grandin
610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Caolán McNamara
09a1a81dac remove archaic drop comments referring to STRING_NOTFOUND 
Change-Id: Ieb31ca4d3a4dbeae2bc66f9c94b243425805fdb0
 2013-11-13 13:50:38 +00:00
Noel Grandin
fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii 
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
 2013-11-11 12:58:13 +02:00
Noel Grandin
1bdb2b6f06 remove unnecessary use of OUString constructor in CONNECTIVITY module 
Change-Id: Ie32d03920d996db2793ead9940fc90668cde03dd
 2013-11-11 11:21:25 +02:00
Noel Grandin
5285beeaa4 remove redundant calls to OUString constructor in if expression 
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
 2013-11-04 10:11:08 +02:00
Noel Grandin
aeb41c9b9b remove redundant calls to OUString constructor 
Change code like this:
  aStr = OUString("xxxx");
into this:
  aStr = "xxxx";

Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
 2013-11-04 10:11:07 +02:00
Noel Grandin
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith 
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
 2013-10-31 08:34:21 +02:00
Marcos Paulo de Souza
2b91dc3ae6 fdo#54938: Adapt connectivity module to use cppu::supportsService 
Change-Id: I885b4c7a60ff51d44138c4f8a56a584c38a9804a
Reviewed-on: https://gerrit.libreoffice.org/6172
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
 2013-10-09 15:03:38 +00:00
Caolán McNamara
2a20c95e84 CID#738572 uninitialized members 
Change-Id: Ie3614d86e27aab67cfe68bea76de30b775173fb3
 2013-10-07 09:16:26 +01:00
David Ostrovsky
b4e25bc4c1 fdo#64741 Thunderbird mork driver: implement collected addresses 
Change-Id: I5a8516a6cf4bd71cea2be916d5a7fcfb16b4e749
Reviewed-on: https://gerrit.libreoffice.org/6020
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2013-10-04 14:43:20 +00:00
Andrzej J.R. Hunt
4216518982 Update implementations of ColumnLocate::findColumn to throw on invalid column. 
Change-Id: I7a9354ecd35a70a005c6c50e38d27de9b33332bd
Reviewed-on: https://gerrit.libreoffice.org/5922
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
 2013-09-12 17:26:12 +00:00