Commit Graph

285 Commits

Author SHA1 Message Date
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
8fce2ef6c3 QueryBox QBX_CONFIRM_RESTORE_DEFAULT -> MessageDialog + string
Change-Id: I93911342a316beaba0d33b35bda1bfa4355befe2
2014-08-21 14:07:54 +01:00
24e76b6506 QueryBox QBX_CONFIRM_DELETE_TOOLBAR -> MessageDialog + string
Change-Id: If03a966ab6519d1335903b7d76cb44c38113a4a3
2014-08-21 10:17:48 +01:00
bf6c743fb6 various unused QueryBoxes
Change-Id: I6ce6aa7cc4420bf8f82a578b7985e795c99e0898
2014-08-18 04:16:57 +02:00
06a485f02b InfoBox IBX_MNUCFG_ALREADY_INCLUDED to String
Change-Id: I343948a9a5e093f210cae1049caa92eeb614a2d7
2014-08-18 02:18:20 +02:00
c6f4f70b24 Convert RID_SVXDLG_ASSIGNCOMPONENT to .ui
Change-Id: Id38ee64e22684905c1a0809d3649e54e893580e1
Reviewed-on: https://gerrit.libreoffice.org/10710
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-04 10:41:22 +00:00
e221c954ea fix a memory leak
Change-Id: I105f0ac40251122348ed86eaab5d99a023f5c09b
Reviewed-on: https://gerrit.libreoffice.org/10588
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-07-28 10:16:06 +00:00
77b74fe9de Avoid possible memory leaks in case of exceptions
Change-Id: I4c9d1746d43642e1be2dd1e72a1b689d3fae1ae6
2014-07-27 02:18:29 +09:00
9586554cae Convert MD_ICONSELECTOR and MD_ICONCHANGE to .ui
I implemented multiple row ToolBox in MD_ICONSELECTOR.

Change-Id: I0f275b2332a15f3ba37952f6a104099e4f1f1678
Reviewed-on: https://gerrit.libreoffice.org/10112
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-10 12:40:03 +00:00
2c90156b76 loplugin:staticcall
Change-Id: I6bc306aa59b5610b987871ea8cf6e561233178c6
2014-06-13 17:54:24 +02:00
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
a92e973b6d Change SfxTabPage::Reset param from ref to pointer
...there was a call site that passed undefined "null pointer reference"
(apparently in a case where the passed argument was actually unused)

Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-11 10:39:03 +02:00
4dbeadb9c1 Change SfxTabPage::FillItemSet param from ref to pointer
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)

Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10 17:25:23 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
ea491d056d OSL_TRACE -> SAL_INFO
Change-Id: Ib9e1ed6119b5286871ac10136f7fcbefffe7aebe
2014-05-27 12:34:30 +02:00
c5d47c327a add default value for Context param in uno::Exception constructors
and all it's subtypes, which is almost never used, so this allows us to
simplify lots of call sites.

Change-Id: I0b05793ea2bdd1027679f63252d42ce4af89433b
2014-05-23 15:05:59 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
1a0cdabf1d remove some commented out lines from src files
Change-Id: If872737d2a7db5d9053a256f7e3d57007c24230e
2014-05-05 19:42:28 +02:00
dd9c9a69da Add the "quoteright" key to the list of available keyboard shortcuts.
Change-Id: I24800c28b1513b883c42d9ce1c787eaf07815b92
2014-05-02 15:43:46 -04:00
667772760a coverity#738577 Uninitialized pointer field
Change-Id: I2a1c99b368ae970a63545cea4d750711baa4ad55
2014-04-30 21:02:41 +01:00
225cc70f39 coverity#704598 Dereference after null check
Change-Id: I37bb96ae15c2e96ed4592f1a2a13d4f932be0d2b
2014-04-30 11:43:39 +01:00
417a537d97 some more hrc cleanup
Change-Id: Ia7db5d7b52aadd158584ffaa06e777d8b02f9820
2014-04-24 11:58:13 +02:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
aa39d21107 clean up hrc files
Change-Id: I76756fe539589d2ab086fd1f1aeec50a9f39af37
2014-04-22 13:03:18 +02:00
9d2977d0a3 remove some more bloat
Change-Id: I7b6c04d99c41360ff49be774afcb4447a829d31c
2014-04-21 09:39:35 +02:00
5b1b1e55ce cui: sal_Bool->bool
Change-Id: Ib7dd1f27d4909d30ee794936364a472a9755c609
2014-04-16 11:51:51 +02:00
2ada2b3375 typo: dependend -> dependent 2014-04-14 12:31:58 +02:00
8b16cc50f4 typo: te -> the 2014-04-14 12:31:57 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
380d4600d7 use TriState instead of sal_Bool as there's three possibilities
Change-Id: If24d4cec9ef4369f20419fe70de7392614a35316
2014-04-08 09:18:33 +01:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
7cdbf12f20 coverity#982292 Logically dead code
Change-Id: I7862ffc1ba51b1083e7cd1fe428fd9a0e134bc38
2014-03-29 18:12:09 +00:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
34002c4e5c sfx2: sal_Bool->bool
Change-Id: I1fd02cc148fd9a54d2092dad1e548f51a0813a14
2014-03-27 13:45:09 +02:00
436cd90095 svtools: sal_Bool->bool
Change-Id: Ifd3e643dbc6755839ad4af73ae141fd115ddb4f4
2014-03-25 14:32:56 +02:00
16752a8a77 sfx2: sal_Bool->bool
Change-Id: Ief810c49b821e2e60ee2c8b14187dd8d7d81c461
2014-03-19 09:21:24 +02:00
a6c3f7d234 callcatcher: update unused code
Change-Id: Ic8952696fc0e3d78b8183ee7f5c90e37590c7dec
2014-03-07 20:20:33 +00:00
1cded3f89a convert customize menu page to .ui
Change-Id: Ifb47cb1e902a64ece951fe9b4d28ba49bbb4b3ee
2014-03-07 16:26:44 +00:00
f8eb776519 convert events config page to .ui
Change-Id: Ida0a6d1242333497cde9f2ef7a8830602caa0ccb
2014-03-07 11:04:25 +00:00
af523f604d convert acceleration config page to .ui
Change-Id: I0868b635d3aca4d368f32a0035b3f57a0da35ac7
2014-03-07 10:22:17 +00:00
f4f2ba8dd1 callcatcher: update unused code
Change-Id: I6487e6ede0a50d88a4f8c3d3b07bdad2603aa4b4
2014-03-07 10:22:17 +00:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
94e0f1a0b3 remove unused code SfxAcceleratorConfigPage::Create
Change-Id: I0fa740b8eec80aff999627ba5a095248f69dab81
2014-03-05 09:17:51 +02:00
4f31b90271 Remove visual noise from cui
Change-Id: I6cec1f747ce57c3153af92e9e0c317d34d5a245d
Reviewed-on: https://gerrit.libreoffice.org/8250
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 06:07:48 -06:00
057a663043 coverity#704595 Dereference after null check
Change-Id: I2c8aa1163d3eb228259db0c51f5cf9dca0657daf
2014-02-23 14:22:41 +00:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
ae8a688555 cid#704597 dereference after null check
this code dates back to the first commit, if the null check was
valid the dereference should have triggered a bug by now.

Change-Id: If074f68bde6a63083921f687e700321488842364
2014-02-14 11:38:03 +02:00