30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
f4246fab77
fdo#56456 fdo#75578 fdo#63271 fdo#75805 Improve hyperlink dialog
...
Changes made:
* Rename "Back" to "Reset" like in other dialogs (eg. Writer - Format - Character).
* Apply-Button, which reflects the old behavior of the dialog, and doesn't
close it automatically.
* Added an OK-Button, which applies the changes made and automatically closes the
dialog.
With this both use cases should be handled:
* Inserting one single URI with simple close.
* Modifying multiple URIs without closing the dialog.
Hopefully all users are happy with this ;)
Change-Id: I1881dee083945cd165fbb8f8444395c1b04a0607
Reviewed-on: https://gerrit.libreoffice.org/10946
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-22 21:33:06 -05:00
ac57362b23
Typo: and->end
...
Change-Id: I8c3707dbf537261d7ed9a69807fc1bdeae851526
2014-08-21 07:33:38 +02:00
d21d5a7261
drop unnecessary shl.hxx includes
...
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
a107bdfdfc
ErrorBox->MessageDialog
...
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
dd97e42661
ErrorBoxes from fmsearch to String
...
Change-Id: I0c2d12a79e8af2125c3aad7f0a6cb873ce3b4d2c
2014-08-15 23:30:27 +02:00
2903650409
remove unused HYPERDLG_IMGBUTTON_HEIGHT
...
Change-Id: I24b9740f20ef975ab6ea747e7e35c721a99e91d0
2014-08-09 18:12:07 +02:00
59828ae2fc
coverity#1229891 Uninitialized scalar field
...
Change-Id: I5e7e0f95b0a93c6b0db5b8ec313822fadbbc4a07
2014-08-07 18:00:43 +01:00
c9be1193b0
fdo#75757: remove inheritance to std::vector
...
Change-Id: Ia2f03e08199f23fd1b226db2c7e0bfade07bf0f0
Reviewed-on: https://gerrit.libreoffice.org/10719
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-04 11:06:25 +00:00
c0d298ecec
Avoid possible memory leaks in case of exceptions
...
Change-Id: I9783669a26fd9c9e2c890f430b29427ccf6bea77
2014-07-30 14:31:07 +09:00
7dad065277
loplugin:unreffun
...
Change-Id: I5986efd3d5690cb63ea44afaba7705c6f747e7f8
2014-07-29 14:09:04 +02:00
e6caeefce4
Converted RID_SVX_MDLG_HANGULHANJA to Widget Layout.
...
Also, removed the unused hrc/src files.
Change-Id: Ice45dde1af7492e40e0847ead06bb26f4e58ed9c
Reviewed-on: https://gerrit.libreoffice.org/10595
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-07-29 11:59:06 +00:00
fe951dc06a
coverity#1228876 Uninitialized pointer field
...
Change-Id: I8de9efc5abfa01225aa6032bf68a32fed17aeb00
2014-07-26 21:25:15 +01:00
77b74fe9de
Avoid possible memory leaks in case of exceptions
...
Change-Id: I4c9d1746d43642e1be2dd1e72a1b689d3fae1ae6
2014-07-27 02:18:29 +09:00
20f6cf0377
Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'
...
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-26 14:25:33 +02:00
e153510659
Convert RID_SVX_MDLG_HANGULHANJA_EDIT to Widget Layout.
...
Change-Id: I63d61a9caeb356e6b5bd340c1f9a5415869a91a1
Reviewed-on: https://gerrit.libreoffice.org/10518
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-07-25 09:19:09 +00:00
2529a364d1
coverity#1226482 Dereference after null check
...
Change-Id: I2723812f960cde23c480651c9f8f5b26585fd51d
2014-07-18 15:36:14 +01:00
de8648c3c8
Convert RID_CUI_DIALOG_COLORPICKER to .ui
...
Conflicts:
extras/source/glade/libreoffice-catalog.xml.in
Change-Id: I161681859c924cc97afa9886b80005e70fa2a87c
Reviewed-on: https://gerrit.libreoffice.org/10210
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-07-11 14:39:28 +00:00
33be4c0f69
return early for empty bitmap
...
Change-Id: I768ffe9dc1226bbcca706e0c56c6103e043b2401
2014-07-11 15:38:22 +01:00
5a3d129a46
remove SvRefBase::ReleaseReference
...
because no-one is using the return value of ReleaseRef, but everyone is
calling ReleaseRef, so make ReleaseRef void-returning and remove
ReleaseReference
Change-Id: I0bedcb65a887ba7a4953132b4c1ccefbdd554a43
2014-07-10 12:03:16 +02:00
d92aa2f445
remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
...
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
56bbd70990
-Werror,-Wunused-function -Werror,-Wunused-private-field
...
... -Werror,-Wunused-variable loplugin:bodynotinblock
Change-Id: I64742401e22b4b83364411a7454c755daa78d00c
2014-06-24 13:21:05 +02:00
46de7b7dbe
tweak sizes
...
Change-Id: Ica7275696b3f7e59d0db5d27811905710dce32e1
2014-06-24 10:05:24 +01:00
1579fc7930
hide old page on showing new page
...
and showing/hiding pages during Paint seems crazy to me, doing it
during ShowPage makes sense.
Change-Id: Ifd0c3c50812157cfa793da86715d58818e944e6b
2014-06-24 10:05:24 +01:00
5b98dcd94f
loop through all pages to get optimal size
...
Change-Id: Ie565ec33c8eaacb490eebcacec7662fde511e98a
2014-06-24 10:05:23 +01:00
35ec23fa29
rename and rework SetCtrlPos to SetCtrlStyle
...
Change-Id: I5720f5f27ea5e7e9eefb6bfb53c30a52146c689e
2014-06-24 10:05:23 +01:00
ea3fc1dd4a
unnecessary check before delete
...
Change-Id: Ie5793f910dd58e8930c2c2b27df00bd073c26f35
2014-06-24 10:05:22 +01:00
88afb39fd1
drop Resize
...
Change-Id: Ie8546cf0eb54888627dc2dfa47257de63b382f9d
2014-06-24 10:05:22 +01:00
c8512315ba
drop SetPosSizePages
...
Change-Id: I9835a4660ac9a9633ad81fc228b0e53b01fc85bf
2014-06-24 10:05:22 +01:00
f89ea2f4de
strip SetPosSizeCtrls down to min required
...
Change-Id: I8c198f9d1b318b35e0dc6221291bb4a57805e3ae
2014-06-24 10:05:22 +01:00
80bf2654d7
meChoicePos is always PosLeft, simplify
...
Change-Id: I40085b0db89484f0d24ecaccf910f4399198294d
2014-06-24 10:05:21 +01:00
360796b491
RID_SVXDLG_NEWHYPERLINK conversion to .ui
...
Conflicts:
cui/UIConfig_cui.mk
Change-Id: I8f06518f2d84e333b553c247ca3d9a28d1280eea
2014-06-24 10:05:21 +01:00
c4bf1f3540
Convert RID_SVXFLOAT_HYPERLINK_MARKWND to .ui
...
Change-Id: I58d21506ec17d1c0e73dd042b94ec2ee2e3ddf11
Reviewed-on: https://gerrit.libreoffice.org/9803
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-06-18 14:45:10 +00:00
b1d8df61b4
bnc#882627: Allow to edit spacing to contents even with no borders visible.
...
SfxItemSet::MergeValue changes some items from SFX_ITEM_DEFAULT state to
SFX_ITEM_SET which I think is a bug but this patch avoids the problem too.
The issue was: visible changes in some tables, after changing e.g.
borders spacing, because the cells had wrong SfxItemSet after the process.
Change-Id: I676b211e1a4a1d7341c385d63503aa740718ed5d
2014-06-17 12:04:19 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
2c90156b76
loplugin:staticcall
...
Change-Id: I6bc306aa59b5610b987871ea8cf6e561233178c6
2014-06-13 17:54:24 +02:00
bb761be472
Change SfxTabPage ctor SfxItemSet param from ref to pointer
...
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions. There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.
Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
4dbeadb9c1
Change SfxTabPage::FillItemSet param from ref to pointer
...
...there were a number of call sites that passed undefined "null pointer
references" (apparently in cases where the passed argument was actually unused)
Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-10 17:25:23 +02:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
0e507ae031
various: remove SAL_THROW macro
...
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
07561068fe
rather than use pixel widths, use appfont units
...
Change-Id: If9551f63ac59ffedd0bd614e4f4fe05c9047e1dc
2014-06-03 10:49:15 +01:00
d1f2e4d798
MD_UPDATE_BASELINKS conversion to .ui
...
Change-Id: I98b47dc20b341375c9caae264c2213aeba6e066a
Reviewed-on: https://gerrit.libreoffice.org/9620
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-06-03 09:48:53 +00:00
bbb598aeff
coverity#703935 Unchecked return value
...
Change-Id: I9300af5f9c2c430d0e67bfb8e16478db6be65477
2014-05-28 13:49:44 +01:00
3b24dcc8a8
Remove unnecessary semicolons
...
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/ )
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-05-27 01:19:00 -05:00
b09b5f8f7c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
...
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
3db8d606d5
hrc and src files: squeeze multiple newlines
...
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
2bd7767d01
Resolves fdo#70681: fixincludeguards.pl: all that's left
...
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-05-15 12:50:46 +00:00
9e8629c733
-Werror,-Wunused-private-field
...
Change-Id: Ie01aeb4215998b38bcb171be9d2c1961798b1488
2014-05-08 17:53:20 +02:00
b0668acdd2
coverity#735403 Logically dead code
...
Change-Id: I73262dcd37e76bc299929d55e38fea25d2510609
2014-05-08 16:10:44 +01:00
bf30c8b16d
use new VCL IsValueChangedFromSaved method
...
follow to commit ff1a7a59434f5f793d4044aad615bcf78148e963
"RFC: add IsValueChangedFromSaved to VCL button and listbox"
Change-Id: If2e6d9e7c18590dc4abbc90362d7897ca2557dd6
2014-05-08 14:55:12 +02:00
