7a3f09216e
coverity#1231674 Uncaught exception
...
and
coverity#1231675 Uncaught exception
Change-Id: If0907f2048fc5e492d5b8b49388c3bfad542e5f7
2014-08-17 16:39:19 +01:00
1bae7f5a57
cppcheck: Throwing the original exception
...
Change-Id: I0d2678dd86e42f882e8ed9926917f1e82746997e
2014-08-16 13:43:40 +02:00
33e94f367a
fdo#82151 finish fixup
...
Fix the UnoApi test, and give ORowSetDataColumn::getFastPropertyValue the reasonable behaviour.
Change-Id: I68cc1221b6772e3036c78b8234b1d8b248d4d673
2014-08-11 16:28:42 +02:00
f122722402
warning C4101: 'e': unreferenced local variable
...
Change-Id: Ieaea27df421c939da895723485770830ac15c873
2014-08-08 18:00:43 +02:00
5be4407d07
fdo#82151 fixup
...
The dbaccess unoapi test calls
css::sdb::XSingleSelectQueryComposer::appendFilterByColumn
in a state where there is no current row, and thus no column value.
This does not make sense, but let's not break the build while I
figure out how to fix the unoapi test.
Change-Id: If813a1544ec9a5dac6f87197982d10576c91cd8c
2014-08-07 11:34:24 +02:00
47585cea02
Missing include
...
Change-Id: I1dc2b46109e62b3df1e887472e0bd927cb4bedb7
2014-08-07 09:55:54 +02:00
90b09303ef
Tunnel SQLException through getPropertyValue
...
Regression introduced with 03a2b4a80c5854bcb8520f2a43e485b98e3eba8f "fdo#82151
when constructing column object, replace m_aCurrentRow by a function," where
the other call to m_pGetValue in ORowSetDataColumn::fireValueChange appears OK,
as ORowSetBase::firePropertyChange already wraps the fireValueChange calls in a
try--catch.
Change-Id: I527cc35ae120cf083f7c69a9a23526839a2bbddb
2014-08-07 09:40:02 +02:00
03a2b4a80c
fdo#82151 when constructing column object, replace m_aCurrentRow by a function
...
The passed m_aCurrentRow becomes out-of-date as soon as the current row changes.
This also hides an implementation detail of ORowSet to ORowSet(Data)Column.
Change-Id: Ib9188743e5dd6dec240e9f5fd3fd9655c6761abc
Reviewed-on: https://gerrit.libreoffice.org/10792
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2014-08-06 13:49:32 +00:00
1e1b2c563d
Don't leak the previous cache
...
Change-Id: I61cb1c608a7de8efc63533085e86c6c17c05f545
Reviewed-on: https://gerrit.libreoffice.org/10793
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2014-08-06 13:48:45 +00:00
5687788744
Resolves fdo#81213: Wrong table-clause generated by reportbuilder
...
Oracle doesn't accept "AS" for making an alias from a table
See https://bugs.freedesktop.org/show_bug.cgi?id=81213#c2
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c4
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c5
for more information
(thank you Lionel)
Change-Id: I33c86d78b2590116d4af46ffd3e54c3c791268ea
2014-07-22 18:38:21 +02:00
8923103eee
coverity#706376 Uncaught exception
...
Change-Id: Ic18823fd60826c144058df32c27ab25d58664e30
2014-07-21 13:59:34 +01:00
fb10049037
coverity#706384 Uncaught exception
...
Change-Id: Ieadbc90be19ec14d78fdf352df7537c69c66616b
2014-07-18 15:36:17 +01:00
96afb3cf40
ODatabaseModelImpl doesn't need to be using rtl::IReference
...
Change-Id: Ia08d57b33af93ceb5c60c48602c403f893bbccc2
2014-07-14 11:07:47 +02:00
17ec028be4
coverity#706461 Uncaught exception
...
and
coverity#706460 Uncaught exception
coverity#706458 Uncaught exception
Change-Id: I580e4dbcb1c65404fe7e93098eb44b5d5d004e8b
2014-07-11 08:50:10 +01:00
ea8f32b61a
use SimpleReferenceObject in dbaccess module
...
to replace hand-rolled version
Change-Id: Ie7b98c284d157521482b0f98915146133f32748e
2014-07-10 11:04:11 +02:00
2acf20d41d
coverity#706384 Uncaught exception
...
Change-Id: I337e948609f66dc9f0002b67cc0ac581a634478a
2014-07-09 09:59:01 +01:00
ce55457a8f
coverity#708787 Unused pointr value
...
Change-Id: Ib1b0dd07be41d382fa24edbb37d30cbe9ea193fa
2014-07-05 22:41:09 +02:00
6c4e21a234
bnc#812796: Correctly handle static value array for OOXML charts.
...
We need to pass the role of the data sequence in order to avoid unreliable
guess work when importing static value array.
Also, not all Excel's scatter plots have real numeric X values; some have
textural X values in which case Excel switch to generating 1, 2, 3, ... as
X values. When importing to our chart implementation, using "categories" role
in such cases instead of "values-x" results in a more faithful chart rendering.
Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-07-02 20:56:31 -04:00
7950797f27
coverity#706468 Uncaught exception
...
and
coverity#706469 Uncaught exception
Change-Id: Ia67d777b09ac7f72a94a9019765266854775c53f
2014-07-01 16:43:06 +01:00
968f633b24
coverity#706382 Uncaught exception
...
and
coverity#706377
coverity#706378
coverity#706382
Change-Id: I17f672e31867b1be77c16a8a6e121a8f67df7c90
2014-07-01 16:43:05 +01:00
e50ef195bc
New loplugin:stringconcat
...
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
501ebd0f7c
Resolves fdo#43277 Send Legacy Report "E-Mail as ..."=>error message
...
Change-Id: Iaaadd4fd3015214c007a86d1a83f837aa0d2bdb6
2014-06-30 23:27:34 +02:00
533c6cb6ba
fixes for up-casting to Reference<XInterface>
...
Fix regressions introduced with
6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking
Reference constructor to reduce code noise"
Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-06-25 17:10:43 +02:00
ef242d3ac8
Typo rong->wrong
...
Change-Id: I9665d0bd8eccfb16a53eeb733954cdc59af8ccdd
2014-06-22 23:35:48 +02:00
32694db4bf
rtl::Reference fits just fine here
...
Change-Id: I14cdcab307f1d2edcebb9fd4aa3009daa32bc7d1
2014-06-18 11:26:34 +02:00
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
db7042cdba
janitorial: update function name in SAL_INFO output
...
Change-Id: Ie01599c8f3ae465998113dd8bfd2a33b27d0a39d
2014-06-16 21:58:05 +02:00
21f2efbe5f
dbaccess::ORowSet: separate impl_rebuild_throw
...
Used by two different callers that wanted different things.
Also, freeResources now always positions on BeforeFirst.
It is only called with _bComplete==false by execute()-related code.
Change-Id: I3e34f77ce37c239d8d3d6a8cd7514b125b049de6
2014-06-16 21:58:05 +02:00
767e15343f
clean up fdo#79427 fix: force BeforeFirst only at execute(), not updateRow()
...
Change-Id: Iaa881d055923702acbb96862d187af41a6ded730
2014-06-16 21:58:05 +02:00
564b8d8ed5
coverity#983629 Uncaught exception
...
Change-Id: Ie3f8a0a04c136a5ed68486aa5e31284556805510
2014-06-16 16:59:08 +01:00
44cd9a17ca
fdo#79427 after execute() a ResultSet is expected to be BeforeFirst
...
Change-Id: I38091d1ee2161d6e32da3a0bde60e3fc008aa83d
Reviewed-on: https://gerrit.libreoffice.org/9794
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2014-06-16 06:47:33 +00:00
529e7619c5
loplugin:staticcall
...
Change-Id: I78895f3524086e1d00d9e8eafd52e505f786320b
2014-06-13 17:54:25 +02:00
111cec826b
coverity#982455 Dereference after null check
...
Change-Id: If4ad2fe763bffdb64119f7f2a5797aae588fbbf8
2014-06-12 10:24:20 +01:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
ea41de0ba5
dbaccess: remove SAL_THROW macro
...
Change-Id: I01e43d6171dc2381ff8c151d5716e9ffede24822
2014-06-05 08:17:49 +02:00
48a697ef1c
coverity#706394 Uncaught exception
...
and hopefully a bunch more of those in dbaccess
Change-Id: I5aefcfe56a697f9e6b18dfe167fdd8a4f54ab6e0
2014-05-30 15:54:56 +01:00
b158fd2695
Prefer cppu::UnoType<T>::get() to ::getCppuType(&T)
...
See http://nabble.documentfoundation.org/Questions-about-getCppuType-td4106361i20.html
Change-Id: I05d0b026e1ef2088472a42ee20e0823df1588428
2014-05-28 23:09:11 +02:00
3b24dcc8a8
Remove unnecessary semicolons
...
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/ )
// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p
@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>
Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-05-27 01:19:00 -05:00
6deec9c910
Fix
...
Change-Id: Ib4d7c2da71a6fa083fc1ed56f058c8dfbc6e58fb
2014-05-22 23:48:37 +02:00
b09b5f8f7c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
...
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
f824604b5c
fix spelling
...
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-21 13:14:11 +02:00
dc24203e5f
fdo#78971 There's even a git hook to prevent commits containing SAL_DEBUG
...
Change-Id: I5a46e1eed129edf3648c68c36951d6fdf9bd370d
2014-05-20 17:01:38 +02:00
ec70ac6e94
WaE: -Wunused-variable
...
Change-Id: Iece721dea1c8cc7601352849ca4fc0398375d320
2014-05-19 20:04:23 +02:00
3db8d606d5
hrc and src files: squeeze multiple newlines
...
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done
Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
ca86511a6e
dbaccess: remove SAL_INFO's that only make function entry
...
Change-Id: Ibdf92698446d0a7aed7c474ec7d3ea720cd2c2a6
2014-05-14 10:00:03 +02:00
70e744b215
fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF
...
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2014-05-12 11:32:38 +02:00
3bd0b2ef2d
Fix previous commit (dbaccess part)
...
Change-Id: I0815cb6334ab47dbe9f5029fe553457de00c5ad5
2014-05-11 11:11:03 +02:00
bd59628620
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10
...
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-11 10:16:42 +02:00
35e9897aec
update_pch: add dba
...
3m32s -> 2m43s
Change-Id: I67f3d05fad90ca06754e8305387171f52b3d7095
2014-05-11 01:55:42 +02:00
fa51b55680
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part9
...
Change-Id: I82ed4a4868cb22566706ca0f4b1321e0d45016cf
2014-05-10 23:54:07 +02:00
