Commit Graph

370 Commits

Author SHA1 Message Date
7a3f09216e coverity#1231674 Uncaught exception
and

coverity#1231675 Uncaught exception

Change-Id: If0907f2048fc5e492d5b8b49388c3bfad542e5f7
2014-08-17 16:39:19 +01:00
6c4e21a234 bnc#812796: Correctly handle static value array for OOXML charts.
We need to pass the role of the data sequence in order to avoid unreliable
guess work when importing static value array.

Also, not all Excel's scatter plots have real numeric X values; some have
textural X values in which case Excel switch to generating 1, 2, 3, ... as
X values.  When importing to our chart implementation, using "categories" role
in such cases instead of "values-x" results in a more faithful chart rendering.

Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-07-02 20:56:31 -04:00
ea41de0ba5 dbaccess: remove SAL_THROW macro
Change-Id: I01e43d6171dc2381ff8c151d5716e9ffede24822
2014-06-05 08:17:49 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
fee4efcb54 dbaccess: sal_Bool->bool
Change-Id: Ieb52470f9638b74898954db3890aaf2cf202290a
2014-04-17 11:17:21 +02:00
e616c346d4 WaE: Unreferenced function definition [loplugin:unreffun]
Work around a slight confusion in the Clang plugin when used with Clang
3.2. Put these 'extern "C"' function definitions consistenly outside
namespaces, as they are declared in the header.

Change-Id: Iccee41dfe0776f382e677b109009a95fb806a12c
2014-04-16 09:54:12 +03:00
fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused
...since f059134fab0f91b7a15594ad06536a13fbfae034 "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
2014-04-15 07:46:43 +02:00
ae59446aab Clean up function declarations and some unused functions
Change-Id: Ie4f6197e42db298b4a3dcb6befdbd72dff6ea2b7
2014-04-13 22:40:55 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
a7458fba26 Work around MSC "'override' cannot be used with 'inline'" bug
Change-Id: I4aeccc3957048a40e705654bf6b9972cc03648b6
2014-03-27 19:12:24 +01:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
5d456dc5c6 dbaccess: prefer passing OUString by reference
Change-Id: I7cec02a40db48ce3d3003b3808d06ff0455a6eb4
2014-03-17 13:30:52 +02:00
358be80f65 comphelper,connectivity: prefer passing OUString by reference
Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a
2014-03-14 07:47:01 +02:00
cfedbdea58 Remove newly unused getUnoTunnelImplementationId functions
...after recent clean-up of getImplementationId implementations.

Change-Id: I2a11f6ddf03dc7852b7e8e50dc6284a7215a0113
2014-03-11 13:03:20 +01:00
3aaaab3db7 Remove unused OQueryComposer::getSomething
(OQueryComposer does not actually derive from XUnoTunnel.)

Change-Id: Ib0d358db2b6a87caae9bbc893dffb25e86109b85
2014-03-10 17:39:54 +01:00
74f0596ea0 Remove unused OSingleSelectQueryComposer::getSomething
(OSingleSelectQueryComposer does not actually derive from XUnoTunnel.)

Change-Id: I4eb26f5d217016e09d1e7e6a4b4bc10fcc5159e6
2014-03-10 17:39:53 +01:00
2a33953f6e Remove visual noise from dbaccess
Change-Id: I1130439e5883672b4ca462838d72197acd6bc1f2
Reviewed-on: https://gerrit.libreoffice.org/8251
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:44:14 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
e0e370a13d cid#707727 Uninitialized pointer field
resolved by removing the field, since it is unused

Change-Id: Ia543877ee645023bf6e1ee3c4f396cb082517f82
2014-02-21 11:59:06 +02:00
d39178ff6c Drop unused #include
Change-Id: Id1badf4ae68d322a6e05e900aa63bdb124387bab
2014-02-17 11:26:31 +09:00
b55259eeb5 typo fixes
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
b0926378ac Clean up includes of comphelper/stl_types.hxx
Change-Id: I00a8e794189d17ad91a90beb9ce6cb89b7bab2aa
2013-12-06 17:56:11 +01:00
0fa31bed9a Default OMultiTypeInferfaceContainerHelperVar equalImpl parameter
...and assorted OUStringHash clean up

Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
2013-12-06 12:03:59 +01:00
0bdfebdc95 Remove unused typedefs
Change-Id: I5af478155963343fa9fe5fa2a39d0209829b2409
2013-12-06 12:03:58 +01:00
07ab0d43b5 Get rid of DECLARE_STL_VECTOR
Change-Id: If4588034fc09e4663b5217669c71f26c0a3b8c8a
2013-12-06 08:04:23 +01:00
4a8175ebeb Get rid of DECLARE_STL_USTRINGACCESS_MAP
Change-Id: I00d02eaeff3eaa5f49550eb9c1d4e4e7e0b2203c
2013-12-06 08:04:22 +01:00
bfbe8c0b5b fixincludeguards.sh: dbaccess
Change-Id: Iadd4326d58a5df5761a0ed5ce7fd5fb01fb87d11
2013-11-05 09:28:52 +01:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
2ec606730b fdo#62475 removed pointless comments
Conflicts:
	dbaccess/source/filter/xml/xmlfilter.cxx
	dbaccess/source/ui/dlg/ConnectionPage.cxx
	dbaccess/source/ui/dlg/detailpages.cxx
	dbaccess/source/ui/dlg/odbcconfig.cxx
	dbaccess/source/ui/querydesign/querycontroller.cxx

Change-Id: I3a05649efa3a43dd8d8fb069fc1bce14ca0a6338
Reviewed-on: https://gerrit.libreoffice.org/5484
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Tested-by: Petr Mladek <pmladek@suse.cz>
2013-08-27 16:11:09 +00:00
c9db5e6f08 Do not use this ptr in ctor
...offload to init() instead and wrap ctor in create().  That removes the need
for refcount fiddling and additional OContainerListener class.  Which in turn
removes code using dynamic_cast on UNO interface classes, which my claim at
<http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130812/
086127.html> "ubsan: check type_info equality via strcmp" that "there should not
be uses of dynamic_cast involving [UNO] classes in the LibreOffice code base"
made me wonder about...

Change-Id: I5d72650f6bf081f971f7bd6bb65f4e58a342f791
2013-08-16 15:02:30 +02:00
40370f759c ORDER BY columns are prioritarily *SELECT* columns
as opposed to *table* columns,
and notwithstanding HSQLDB 1.8 (our embedded database) bugs.
Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs
(but quite common)

Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6
2013-07-11 17:53:30 +02:00
9a95669e50 fdo#43460 dbaccess: use isEmpty()
Change-Id: Ie27a81f4e59c48ef5aa03fb82ab38e920c0646a1
Reviewed-on: https://gerrit.libreoffice.org/4321
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-17 19:45:38 +00:00
cd2f2e772c make OSingleSelectQueryComposer use *system* parse context
and pass it to the parser and PredicateInput constructors.
This makes the whole story consistent; before system locale settings were already manually passed to parseNodeToPredicateStr, which led to some things being parsed as en_US and others as system locale.

Change-Id: Ib9571b10d79183571e8ab3f79660b41594dc2d1c
2013-05-19 14:05:18 +02:00
9a7603187e dbaccess: remove Package_inc
Change-Id: I8e6748eef04f25603851a33d049cb9585fa04cc6
2013-05-07 01:41:23 +02:00
c32b6be06b fdo#60724 correct spelling
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
2013-04-15 05:32:37 +02:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
a066525b42 fdo#46808, Convert a bunch of comphelper::ComponentContext stuff
.. to Reference<XComponentContext>
mostly in the dbaccess module, but it also affected some other
modules.

Change-Id: I09b3f6fe7a9b33498b11d98b5521b5aeeb8882be
2013-03-20 07:32:53 +02:00
bdc374eadf fdo#38838, String to OUString in dbaccess
Replaced String with OUString in module dbaccess/ui/app , and also removed RTL_CONSTASCII_USTRINGPARAM deprecated macro.

Conflicts:
	dbaccess/source/ui/app/AppControllerDnD.cxx
	dbaccess/source/ui/app/AppControllerGen.cxx
	dbaccess/source/ui/app/AppDetailPageHelper.cxx
	dbaccess/source/ui/browser/unodatbr.cxx

Change-Id: Ie385d44c328fb3f919d53a604d51640a334a1013
Reviewed-on: https://gerrit.libreoffice.org/2386
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-15 01:25:12 +00:00
a0296296fb fdo#60691 add modelines to *.src and *.hrc files
use solenv/bin/add-modulelines script for the task
and remove all UTF bom from *.src and *.hrc files

svx/source/dialog/hdft.src

Change-Id: I745d4f0fe9b05436a142a03f8512970f91c41bd4
2013-03-08 21:02:26 +00:00
db7a441342 Typo fix: informations -> information and a few other adjacent typos.
FDO:60724

Change-Id: I73ad9f1c37cbbcf28d996ed73c75cf09553e499b
Reviewed-on: https://gerrit.libreoffice.org/2479
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2013-03-02 02:45:55 +00:00
806d18ae7b optimisation: take ref to OUString instead of constructing temp object
Change-Id: I9dcb821cd71f89fa5b3d8274fd93facc1f43863f
2012-11-02 10:50:52 +01:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
4a69252e2c -Werror,-Wunused-private-field (Clang towards 3.2)
Change-Id: I55ad905bef36b54fadc245bfb22f687e47d20c3a
2012-08-31 09:04:17 +02:00
889de665ec Typo ressource -> resource
Change-Id: Id13e7acfbe34eca5e124c9032d36d6f158bfb831
2012-07-30 09:26:00 +02:00
eecb5ac9a4 removed useless forward declarations of class
Change-Id: I13cf52cc4e1cf8d5e2453d7ac4b68cc8c64cd011
2012-07-05 19:08:02 +09:00
64517292c9 hrc cleanup: Remove include guards
Also add some missing include guards.

Change-Id: I320a3c017ca65d34f2cd516849bcde3dec9b33f1
2012-07-02 22:42:09 +02:00
57154616f0 Remove UNO includes comments
Change-Id: I48e193322967fb75e93eaf81e9e2110d3056f92a
2012-06-29 09:25:09 +02:00
577cf8ff67 re-base on ALv2 code. 2012-06-14 17:41:07 +01:00