a33f9d080b
coverity#1229892 Uninitialized pointer field
...
Change-Id: Ida750e33efd8d18ee754d1bf8b123295581365c8
2014-08-07 18:00:43 +01:00
5be4407d07
fdo#82151 fixup
...
The dbaccess unoapi test calls
css::sdb::XSingleSelectQueryComposer::appendFilterByColumn
in a state where there is no current row, and thus no column value.
This does not make sense, but let's not break the build while I
figure out how to fix the unoapi test.
Change-Id: If813a1544ec9a5dac6f87197982d10576c91cd8c
2014-08-07 11:34:24 +02:00
47585cea02
Missing include
...
Change-Id: I1dc2b46109e62b3df1e887472e0bd927cb4bedb7
2014-08-07 09:55:54 +02:00
90b09303ef
Tunnel SQLException through getPropertyValue
...
Regression introduced with 03a2b4a80c5854bcb8520f2a43e485b98e3eba8f "fdo#82151
when constructing column object, replace m_aCurrentRow by a function," where
the other call to m_pGetValue in ORowSetDataColumn::fireValueChange appears OK,
as ORowSetBase::firePropertyChange already wraps the fireValueChange calls in a
try--catch.
Change-Id: I527cc35ae120cf083f7c69a9a23526839a2bbddb
2014-08-07 09:40:02 +02:00
b6b77711bb
Convert PAGE_ADO and PAGE_MYSQL_ODBC to .ui
...
Conflicts:
dbaccess/source/ui/dlg/dbadmin.src
Change-Id: Idaba7ea38b8ca6b7d0d9cc9599e9a76836573086
2014-08-07 09:35:18 +02:00
2159107594
Convert PAGE_LDAP to .ui
...
Conflicts:
dbaccess/source/ui/dlg/dbadmin.src
Change-Id: I2655cc1d58c87a254c7074682fd7814e4d00fe73
2014-08-07 09:29:05 +02:00
03a2b4a80c
fdo#82151 when constructing column object, replace m_aCurrentRow by a function
...
The passed m_aCurrentRow becomes out-of-date as soon as the current row changes.
This also hides an implementation detail of ORowSet to ORowSet(Data)Column.
Change-Id: Ib9188743e5dd6dec240e9f5fd3fd9655c6761abc
Reviewed-on: https://gerrit.libreoffice.org/10792
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2014-08-06 13:49:32 +00:00
1e1b2c563d
Don't leak the previous cache
...
Change-Id: I61cb1c608a7de8efc63533085e86c6c17c05f545
Reviewed-on: https://gerrit.libreoffice.org/10793
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu >
Tested-by: Lionel Elie Mamane <lionel@mamane.lu >
2014-08-06 13:48:45 +00:00
3067d228cd
TAB_WIZ_TYPE_SELECT and TAB_WIZ_NAME_MATCHING conversion to .ui
...
Conflicts:
dbaccess/UIConfig_dbaccess.mk
dbaccess/source/ui/misc/WizardPages.src
Change-Id: I1a628dd6220f3f180cc01353380fe4aa7e166cf4
Reviewed-on: https://gerrit.libreoffice.org/10776
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-06 13:15:04 +00:00
f71d65f39e
Convert PAGE_ODBC to .ui
...
Change-Id: I23dfbeb7a1a5ed0c8c51d925a1c0d11daca75f3f
Reviewed-on: https://gerrit.libreoffice.org/10787
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-06 12:58:55 +00:00
7b10285665
Convert PAGE_MYSQL_JDBC and PAGE_ORACLE_JDBC to .ui
...
Change-Id: I925dd0971aaf7f453c76ec37771ce001608dc57b
Reviewed-on: https://gerrit.libreoffice.org/10785
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-06 12:14:19 +00:00
1ff594ce98
Convert PAGE_DBASE to .ui
...
Change-Id: Ie2f1592b030465a2ca5e2f25408ae38e9a833831
Reviewed-on: https://gerrit.libreoffice.org/10777
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-06 12:05:31 +00:00
020e283970
Convert PAGE_CONNECTION to .ui
...
Change-Id: Id65d57b848280fee12384b4f470782a28233acd8
Reviewed-on: https://gerrit.libreoffice.org/10748
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-05 11:06:14 +00:00
b8423c4f83
remove unused resource ids
...
ui conversion fallout
Change-Id: I9c07728e6fccee46545171573fb95fbda8cf1fcb
2014-08-04 15:59:06 +02:00
b15c01e430
Convert DLG_PARAMETERS to .ui
...
Conflicts:
dbaccess/UIConfig_dbaccess.mk
Change-Id: Ib9e1c986e2f58b0095e69890664764d1cf8badb0
2014-08-04 14:00:04 +02:00
0059f083e5
PAGE_MYSQL_NATIVE and PAGE_DBWIZARD_MYSQL_NATIVE conversion to .ui
...
Change-Id: I5daec87637f1b3ad528c1f966a148adec7fae166
Reviewed-on: https://gerrit.libreoffice.org/10706
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-04 10:38:30 +00:00
780e192feb
init. pointer members
...
Change-Id: Iad5edda570466a35c138f7f7fe042b931c58ad75
2014-08-02 13:47:19 +02:00
3b71e0cb1c
TAB_PAGE_USERADMIN conversion to .ui
...
Change-Id: I65ae56bee3e66ec0b19e40fa23ac02a8ec1afbf8
Reviewed-on: https://gerrit.libreoffice.org/10681
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-02 11:47:11 +00:00
cf22f952af
Convert DLG_DATABASE_TYPE_CHANGE to .ui
...
Conflicts:
dbaccess/source/ui/inc/dbu_resource.hrc
Change-Id: I854d1c37d5a8b4944b786b9a4cace8b3f8b5e093
2014-08-02 13:19:09 +02:00
3743f9da9a
Convert PAGE_DBWIZARD_AUTHENTIFICATION and PAGE_DBWIZARD_LDAP to .ui
...
Conflicts:
dbaccess/source/ui/dlg/dbadminsetup.hrc
dbaccess/source/ui/dlg/dbadminsetup.src
dbaccess/source/ui/inc/dbu_resource.hrc
Change-Id: I71558269dd2edcc828af9633992f2d143ffefd6d
2014-08-01 16:56:21 +02:00
2984644d86
Convert 3 tabpages to .ui
...
I converted PAGE_DBWIZARD_MYSQL_JDBC, PAGE_DBWIZARD_ORACLE and
PAGE_DBWIZARD_JDBC to .ui.
Conflicts:
dbaccess/source/ui/dlg/dbadminsetup.hrc
dbaccess/source/ui/inc/dbu_resource.hrc
Change-Id: I920183c4abf303918ac0406b5810e1b8b377a04c
Reviewed-on: https://gerrit.libreoffice.org/10608
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-01 14:45:57 +00:00
ca1897ede3
Convert 5 tabpages to .ui
...
I convert PAGE_DBWIZARD_ADO, PAGE_DBWIZARD_DBASE,
PAGE_DBWIZARD_MSACCESS, PAGE_DBWIZARD_ODBC, PAGE_DBWIZARD_USERDEFINED
Conflicts:
dbaccess/source/ui/inc/dbu_resource.hrc
Change-Id: Id5efedb2016011a25c037b7d2bc15b20ddd73800
Reviewed-on: https://gerrit.libreoffice.org/10607
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-01 14:38:40 +00:00
803b9cb047
Convert DLG_DATABASE_WIZARD dialog to .ui
...
Change-Id: I18bc001be01b526d4005eacc324b7d2fb82830a0
Reviewed-on: https://gerrit.libreoffice.org/10602
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-08-01 08:21:15 +00:00
8ea2d6b073
PAGE_DBWIZARD_MYSQL_INTRO and PAGE_DBWIZARD_SPREADSHEET conversion to .ui
...
Change-Id: I5d14fc4bd051c37802c0689d55d8557e26312a5d
Reviewed-on: https://gerrit.libreoffice.org/10606
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-07-29 11:46:44 +00:00
03fe3215e3
PAGE_DBWIZARD_TEXT, PAGE_TEXT, DLG_TEXT_CONNECTION_SETTINGS conversion to .ui
...
Change-Id: Iea5105cc33b436e9c0728df799b1ceb63f20e46e
Reviewed-on: https://gerrit.libreoffice.org/10579
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-07-28 12:34:26 +00:00
025a10e6d6
Typo: useles->useless
...
Change-Id: I62c253e9ee23186efcaafda69566148bc484276d
2014-07-26 09:42:34 +02:00
8a690c88a9
Apply pimpl to XMLPropertySetMapper.
...
Let's hide its implementation for real this time.
Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
2014-07-25 11:50:02 -04:00
215703b494
Typo: PRECSION->PRECISION
...
Change-Id: I63f8ad597cea2562b567b7df13823b75a6e50dde
2014-07-24 10:17:42 +02:00
5687788744
Resolves fdo#81213: Wrong table-clause generated by reportbuilder
...
Oracle doesn't accept "AS" for making an alias from a table
See https://bugs.freedesktop.org/show_bug.cgi?id=81213#c2
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c4
https://bugs.freedesktop.org/show_bug.cgi?id=81213#c5
for more information
(thank you Lionel)
Change-Id: I33c86d78b2590116d4af46ffd3e54c3c791268ea
2014-07-22 18:38:21 +02:00
9c7a7d85aa
convert DLG_MACRO_MIGRATION to widget layout
...
Change-Id: Ie4cef54a943fc456b042425b53286492a0bed0be
2014-07-22 12:21:53 +01:00
d8e64d76a8
all macromigrate pages are .ui, remove ResId stuff now
...
Change-Id: Ib92eb813666a418ced584076094cdd6511118d6a
2014-07-22 12:21:53 +01:00
1f106a522e
convert migrate page to .ui
...
Change-Id: I9a7871bfd08fdd8dc649d7a728eb41bcc0b64b37
2014-07-22 09:54:39 +01:00
fa9ce74db5
convert summary page to .ui
...
Change-Id: I27fbeaafb53b4a0ae30c3408888419af93a37300
2014-07-22 09:54:39 +01:00
059ce597b5
SaveDBDocPage: [loplugin:saloverride]
...
Change-Id: I2491ec467df8874bb7eaa89e316b0e89f59c740a
2014-07-21 19:32:59 +02:00
55a639f6b3
convert backup page to .ui
...
Change-Id: Id9a90001153fdaad51a00b68f38b1298195c5646
2014-07-21 17:10:37 +01:00
aa7d58a1e6
convert TP_PREPARE to .ui
...
Change-Id: Iad0c94ffd08117f79cba5d5305f03c836ac6ada9
2014-07-21 16:28:41 +01:00
8923103eee
coverity#706376 Uncaught exception
...
Change-Id: Ic18823fd60826c144058df32c27ab25d58664e30
2014-07-21 13:59:34 +01:00
8329197678
coverity#704620 Explicit null dereferenced
...
and
coverity#704621 Explicit null dereferenced
Change-Id: I06e335da746b02b16f7e5bd947d6eeff0c81b815
2014-07-19 21:26:00 +01:00
fb10049037
coverity#706384 Uncaught exception
...
Change-Id: Ieadbc90be19ec14d78fdf352df7537c69c66616b
2014-07-18 15:36:17 +01:00
835c9e6d84
shouldn't need to call AdjustLayout now its converted to .ui
...
Change-Id: I539741e71785232987b26c7b414a416dda5e4bb6
2014-07-15 11:56:09 +01:00
96afb3cf40
ODatabaseModelImpl doesn't need to be using rtl::IReference
...
Change-Id: Ia08d57b33af93ceb5c60c48602c403f893bbccc2
2014-07-14 11:07:47 +02:00
17ec028be4
coverity#706461 Uncaught exception
...
and
coverity#706460 Uncaught exception
coverity#706458 Uncaught exception
Change-Id: I580e4dbcb1c65404fe7e93098eb44b5d5d004e8b
2014-07-11 08:50:10 +01:00
ea8f32b61a
use SimpleReferenceObject in dbaccess module
...
to replace hand-rolled version
Change-Id: Ie7b98c284d157521482b0f98915146133f32748e
2014-07-10 11:04:11 +02:00
2acf20d41d
coverity#706384 Uncaught exception
...
Change-Id: I337e948609f66dc9f0002b67cc0ac581a634478a
2014-07-09 09:59:01 +01:00
ce55457a8f
coverity#708787 Unused pointr value
...
Change-Id: Ib1b0dd07be41d382fa24edbb37d30cbe9ea193fa
2014-07-05 22:41:09 +02:00
27e86fe677
coverity#735691 Unchecked dynimic cast
...
Change-Id: I5b26469792cf7b2ac6b1b28e2419cadeea09a37d
2014-07-04 19:19:41 +02:00
8b499cea76
fix spelling in class name OSpecialHanldeXMLExportPropertyMapper
...
Change-Id: Ideaa021f76f1c384150caad5ec6a41bf65bae28e
2014-07-04 09:42:57 +02:00
4228f08d60
use assert when followed by deref
...
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-03 12:49:38 +01:00
6c4e21a234
bnc#812796: Correctly handle static value array for OOXML charts.
...
We need to pass the role of the data sequence in order to avoid unreliable
guess work when importing static value array.
Also, not all Excel's scatter plots have real numeric X values; some have
textural X values in which case Excel switch to generating 1, 2, 3, ... as
X values. When importing to our chart implementation, using "categories" role
in such cases instead of "values-x" results in a more faithful chart rendering.
Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78
2014-07-02 20:56:31 -04:00
4ff115b3e7
drop UniReference in favour of rtl::Reference
...
since they're doing the same thing.
Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-07-02 15:23:52 +02:00
