Commit Graph

641 Commits

Author SHA1 Message Date
70946992d4 Fix some *_component_getFactory function types
Change-Id: I912f9d1454c049419e9ead6f0ff8d7fa7d8cd6c5
2014-08-28 16:11:33 +02:00
57488f2a10 convert RID_WARNINGBOX_* to MessageDialog + string
Change-Id: Ic6031faa475e22ee23a6c8888987127b3caf92de
2014-08-25 16:45:29 +01:00
e932500e23 convert RID_QUERYBOX_INSTALL_FOR_ALL with custom buttons to .ui
Change-Id: If7ac491cb6f256af22b48f681590adb1484350d0
2014-08-25 16:45:26 +01:00
32ce5ae15a Avoid possible memory leaks in case of exceptions
Change-Id: Icc073be041ae0b0c690e869a0edaff3515d1d601
2014-08-25 10:27:10 +09:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
4b339818bb add a VclViewport
like GtkViewport so that the scrolled region will be clipped,
which also has the side-effect of stopping glade clobbering
the non view-port scrolled .ui files on editing

Change-Id: Ic64174b3a35b77f068e0085cdc7721aeb33f1d82
2014-08-20 14:00:58 +01:00
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
bf866b0ad6 WARNINGBOX -> WarningBox
Change-Id: Id39add923b94bcf43e64ffbf4940625efe4d35a0
2014-08-18 04:22:28 +02:00
df64b892f5 remove RID_DLG_DEPENDENCIES resources
unused since 8c0bd0deee50a5f54926afe87d849411757c2f18

Change-Id: If720d7022e291db870fd196cf2ea0a3bc44f3ad2
2014-08-09 18:12:04 +02:00
8c0bd0deee Convert RID_DLG_DEPENDENCIES to .ui
Change-Id: I45779ac7dd88608e0f46b468cc51641b386e8a1a
Reviewed-on: https://gerrit.libreoffice.org/10712
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-04 10:43:20 +00:00
8d373129e9 callcatcher: update unused code
and strip away some stuff in rsc that should now be dead

Change-Id: I6411e706c50dff299099680f1f942bf61c4e79f2
2014-06-15 20:30:39 +01:00
1db81a3e4b loplugin:staticcall
Change-Id: I98f62391ee27c806f89cd8b85a04d67d1bcc78b7
2014-06-13 17:54:25 +02:00
e88c019fba convert extensions update required dialog to .ui
Change-Id: Ia3ad4032f500e95db5db520292e6c8b07b0f5c0b
2014-06-13 09:50:53 +01:00
b3843321e9 desktop: fix includes
Change-Id: Ia51cd6fcdb84c049907b0aeda20774558198b575
2014-06-04 10:59:07 +02:00
3ddb928061 fdo#68849: Add header guards to all include files
Added header guards to files in directories desktop/*, and embedserv/*

Change-Id: Idaffcc0539b84962ed7c132cb20078512799d433
Reviewed-on: https://gerrit.libreoffice.org/9556
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-30 01:44:03 -05:00
9172ee7293 the stock multilineedit is sufficient IMO
Change-Id: I374c17fcda80c4f821271bf665a41beae100cccf
2014-05-27 12:07:13 +01:00
1908f27da8 desktop: further src file cleanup
Change-Id: I37f83084203fcc4e2f7d68f7c21774573b9281e8
2014-05-27 13:00:20 +02:00
5249cf49ed RID_DLG_UPDATEINSTALL conversion to .ui
Change-Id: I02ead5dc934d0f9ae9e958cbe6592250f1aaf1a4
Reviewed-on: https://gerrit.libreoffice.org/9464
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-27 05:44:23 -05:00
9af0abebfd remove unnecessary use of Reference constructor in throw
Convert code like this:
  throw IOException("xx",
     Reference< XInterface >(static_cast<OWeakObject*>(this)) );
to this:
  throw IOException("xx",
     static_cast<OWeakObject*>(this) );

Change-Id: Ife9f645f0f1810a8e80219126193015502c43dbb
2014-05-27 08:20:11 +02:00
ca4a381947 lets drop the custom DescriptionEdit widget
Change-Id: Id08b364b828ccacd5c54276daf605ec4ff3fdb0a
2014-05-21 13:47:05 +01:00
5690def7c8 RID_DLG_UPDATE conversion to .ui
Conflicts:
	desktop/source/deployment/gui/descedit.hxx

Change-Id: Icf9ee3081b468f99833d1e38182887ad1da6f675
Reviewed-on: https://gerrit.libreoffice.org/9417
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-21 07:46:34 -05:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
93f5d5a919 The opaque PostUserEvent IDs are actually pointers
...so declare them as such.  This avoids the recurring mistake of storing such
IDs as sal_uInt32, truncating in 64 bit environments, causing RemoveUserEvent to
potentially not remove the event, it thus firing "too late" and probably causing
a crash.

While at it, consolidate the trivially unnecessary overloads of both
Application::PostUserEvent and Window::PostUserEvent.  And in each of them, it
looks like deleting the mpLink member was missing from the failure branch.

Change-Id: Iab13afbb06e12ac15dec6a6b5b85a7e402a3c654
2014-05-07 11:49:46 +02:00
702f9c5176 huge hrc and src file cleanup
* mostly fallout from ui conversion
* some completely unused defines from src files
* lots of unused HID ids

Change-Id: I976561205798db3d06ee139de6223f638e58f47a
Reviewed-on: https://gerrit.libreoffice.org/9142
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-23 22:49:57 +00:00
133b4d9729 desktop: sal_Bool->bool
Change-Id: Id2606a2024d62de1882da18a1e438fb626655ff4
2014-04-22 09:53:12 +02:00
f7d6bb536a typo: gard -> guard 2014-04-14 12:32:31 +02:00
f5051821bc Clean up function declarations and some unused functions
Change-Id: Ie35d71a03d2f89cd72836db21fac8746a9e85b09
2014-04-13 23:26:48 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
2991d2d65b Remove visual noise from desktop
Change-Id: Ib8ca7794ce6f3e96ee3a9b2896b141635665552c
Reviewed-on: https://gerrit.libreoffice.org/8252
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 05:59:38 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
d548b250db Drop unnecessary #include
Change-Id: Ib9ab63cdf21f54b1611de37c5538a300a1b39ba6
2014-02-18 13:24:11 +09:00
064c628842 fdo#63154 Remove unused solar.h ref in vcl, basctl, desktop..
Change-Id: Ic0187495d8f7f64ddf9d3c202ec41201c9ac3a8c
Reviewed-on: https://gerrit.libreoffice.org/8001
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com>
2014-02-12 07:23:09 +00:00
d63170c4c0 coverity#704223 Logically dead code
Change-Id: I4d5380f7c60ff10d1e1c2560e1e1288eb79cd056
2014-02-11 20:21:48 +00:00
21e90f901d coverity#707748 : Uninitialized scalar field
Change-Id: I9155c4ab7409d1fa00abbc3c81ff03d0c0d3910b
2014-02-01 16:16:53 -06:00
e1dc859beb bool improvements
Change-Id: Ie4c9d7f01fef2604d80d8e465ce30daab7481eed
2014-01-28 20:26:29 +01:00
ef597d80dc Introduce com.sun.star.task.theJobExecutor singleton.
To replace com.sun.star.task.JobExecutor single-instance service,
incorrectly converted in 748aa84e9808ad31c6ff6b71459525c82de10e58

[including changes by Stephan Bergmann <sbergman@redhat.com>]

Change-Id: I4cea2c63a20b5b22f6e1f822fb35fcc4d0397687
Reviewed-on: https://gerrit.libreoffice.org/7609
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-01-24 14:24:34 +00:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
d8bbe0ede2 EndDialog takes long nResult, not bool
Change-Id: Ic6283b7a71a5d1c539ae99155f448e34e877080a
2014-01-14 21:28:05 +01:00
82625bb98e remove unnecessary sal_Unicode casts in OUStringBuffer::append calls
Convert code like:
    buf.append( static_cast<sal_Unicode>('!') );
to:
    buf.append( '!' );

Change-Id: Iacb03a61de65a895540940953b49620677b3d051
2014-01-07 09:43:37 +02:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
08fe82e59c Remove unnecessary use of OUString constructor in + expressions
Convert code like
  aFilename =  OUString::number(nFilePostfixCount) + OUString(".bmp");
to
  aFilename =  OUString::number(nFilePostfixCount) + ".bmp";

Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-12-17 11:49:03 +02:00
661f7bdefc m_bHasActive must be false after last visible entry is removed
...otherwise, ExtensionBox_Impl::RecalcAll would crash in CalcActiveHeight(-1).

Change-Id: If399825951c79b821ed44ebefa19d1032ab4f850
2013-12-16 13:53:30 +01:00
de6be3dcdf convert accept license dialog to .ui
Change-Id: Ib36f42d65ef73446320823775accc94016afb13a
2013-12-06 10:50:25 +00:00
e661d295c2 convert show extension licence dialog to .ui
Change-Id: I0e34a0ddaee1485184b55788d618288f4e3f69cb
2013-12-06 09:38:14 +00:00
f01580ce9c Windows: Require at least Windows XP SP2
* Windows XP SP2 is 0x0502, see
  http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
  this is done module wide now. So the overall behavior
  is as before. This seems to be the best compromise for
  now.
* We need at least SP2 because of the bluetooth stuff
  used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
  has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
  project specific precompiled header files.
* All local definitions of WINVER are removed, because
  the global WINVER setting makes them obsolete now.

To the relation of the three macros:

Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.

WINVER and NTDDI_VERSION can be set idenpendently each
for itself.

Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
2013-11-20 07:15:16 -06:00