Commit Graph

168 Commits

Author SHA1 Message Date
e50ef195bc New loplugin:stringconcat
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-07-01 15:45:52 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
0a99770037 desktop: remove SAL_THROW macro
Change-Id: I523d47b443bc7a3fc8129b3a15643560e3971782
2014-06-05 08:17:50 +02:00
b3843321e9 desktop: fix includes
Change-Id: Ia51cd6fcdb84c049907b0aeda20774558198b575
2014-06-04 10:59:07 +02:00
3ddb928061 fdo#68849: Add header guards to all include files
Added header guards to files in directories desktop/*, and embedserv/*

Change-Id: Idaffcc0539b84962ed7c132cb20078512799d433
Reviewed-on: https://gerrit.libreoffice.org/9556
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-30 01:44:03 -05:00
7985311358 desktop: sal_Bool->bool
Change-Id: I3462a9d4c23c9bc858c1a9d91caa58d87b204ee0
2014-05-08 11:48:14 +02:00
f5051821bc Clean up function declarations and some unused functions
Change-Id: Ie35d71a03d2f89cd72836db21fac8746a9e85b09
2014-04-13 23:26:48 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
2991d2d65b Remove visual noise from desktop
Change-Id: Ib8ca7794ce6f3e96ee3a9b2896b141635665552c
Reviewed-on: https://gerrit.libreoffice.org/8252
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 05:59:38 -06:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
15535e32dd convert SvStream::operator>> methods to ReadXXX methods
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".

Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12 15:31:40 +00:00
7c586c4132 coverity#704224 Logically dead code
Change-Id: Ic113260ff969f3bb670cb8ecaf5d6068dea5dbdd
2014-02-11 20:21:49 +00:00
e1dc859beb bool improvements
Change-Id: Ie4c9d7f01fef2604d80d8e465ce30daab7481eed
2014-01-28 20:26:29 +01:00
0e5c7d0b5b bool improvements
Change-Id: Iddc92e42a100a0fb36c77c21d4c176dded8f3391
2014-01-22 08:22:33 +01:00
9ed364774c Adapt all (non-extension, SharedLibrary) .components to environment="..."
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
3773201d59 -Werror,-Wunused-variable
Change-Id: I46138b946ff38df5366760dbc1999057fee35bd3
2013-11-19 12:29:52 +01:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
35836f3508 fixincludeguards.sh: desktop
Change-Id: Iaeba85d313af1840f925fd0536d11ac83545a118
2013-10-28 15:16:18 +01:00
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
7865b9762d convert DESKTOP module from String to OUString
Change-Id: I5dc43849ace8edbab9e6308db80a70797f090c69
2013-09-17 09:05:21 +02:00
6a08067902 OUString convertion for unotools
Change-Id: Ifae7f344e3827875e32afa3cda23c771f5735707
Reviewed-on: https://gerrit.libreoffice.org/4659
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-02 07:31:30 +00:00
710f41b7ae Clean String and sal_Bool in tools
Change-Id: I6a92196f33d7a5278c7dcc426112e9c56d582655
Reviewed-on: https://gerrit.libreoffice.org/4627
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-30 04:58:49 +00:00
a81f161b12 add desktop libs to libmerged
Change-Id: I0e5477f84de316598015330cea995e42f1249acb
2013-04-15 14:47:43 -04:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
a808497dbb drop prefix from ::css
as css is already ::com::sun::star

Change-Id: I86b43843e4b74f990b6e05dee37184a002072d12
2013-04-02 09:01:37 +02:00
2c108a29d1 Leftover unused local variable
Change-Id: I402cdcf2c9a78eb40c26c4cd016f603d85a38d39
2013-03-20 16:50:40 +01:00
190b925736 deb#703486: Keep migrating more user extensions after one failed
Change-Id: I9cc8acac54bd5a02652462c3967b4c81f7cf8ee3
2013-03-20 16:41:28 +01:00
15003612ae Clean up some supportsService implementations
Change-Id: Ib74400765a6e0ef203e751afa5433a01c8564fee
2013-02-16 12:32:24 +01:00
f53517a5b0 fdo#46808, convert xml::xpath::XPathAPI to new-style service
Change-Id: I54bb0eb08d687e7d54c42601c826c580a7a17ebb
2013-02-11 08:02:14 +02:00
99e157ce64 RTL_CONSTASCII_(U)STRINGPARAM removed in desktop/source/migration
removed OUSTR() as well

Change-Id: I420f2e9214db86e1edefae0ed14a6a1faf065cfc
2012-12-30 11:04:47 +01:00
a9916dabb4 Remove xml2cmp leftovers
Change-Id: I7c0ba8b653b8e0534ae17bd879b93b75c6554893
2012-12-12 10:27:41 +01:00
bd9c4510ff Take extra cache/uno_packages/*.tmp_/*properties files into account
...when migrating user extensions from an old user profile.

Change-Id: I4425eba1e840bfdb33782bb3ed0542ce48b2f75f
2012-12-04 18:11:58 +01:00
66a175834c c++ API: use css alias in generated headers, adds global css decl
This changes all generated API headers (.hpp and .hdl) to use a
namespace alias 'css' instead of the pointlessly long com::sun::star

Makes the change in cppumaker & associated tools, adds a global
namespace alias definition in sal/types.h, and removes a kiloton
of local, now pointless-to-harmful versions of that alias from all
over the code.

Change-Id: Ice5a644a6b971a981f01dc0589d48f5add31cc0f
2012-11-30 14:36:36 +01:00
7de4f83848 Adapt to OUString-oriented SearchForward
Change-Id: I0aec0bf6d2d3010292f5dee314074457c24ee408
2012-11-25 01:09:48 +01:00
daeed90f45 re-base on ALv2 code. Includes:
Patch contributed by: Jurgen Schmidt
    remove onlineregistration with dependencies
    http://svn.apache.org/viewvc?view=revision&revision=1240245
    imported patch package_eventlistener.patch
    http://svn.apache.org/viewvc?view=revision&revision=1172103

    Patch contributed by Pedro Giffuni
    Accept Google Chrome OS fonts as equivalent to MS fonts.
    http://svn.apache.org/viewvc?view=revision&revision=1233155
    http://svn.apache.org/viewvc?view=revision&revision=1233408

    Patch contributed by Andre Fischer
    Do not add targets for junit tests when junit is disabled.
    http://svn.apache.org/viewvc?view=revision&revision=1241508

    Patches contributed by Mathias Bauer (and others)
    gnumake4 work variously
    http://svn.apache.org/viewvc?view=revision&revision=1394707
    http://svn.apache.org/viewvc?view=revision&revision=1394326
    cws mba34issues01: #i114600#: remove forbidden characters
    from list of unencoded characters
    http://svn.apache.org/viewvc?view=revision&revision=1172370

    Patches contributed by Oliver Rainer-Wittman
    some clean up in JPEGReader due to memory constraints
    http://svn.apache.org/viewvc?view=revision&revision=1299729
    119114 - method <UpdateDialog::addSpecificError(..)> - create
    entry with correct type
    http://svn.apache.org/viewvc?view=revision&revision=1305265

    Patches contributed by Ariel Constenla-Haile
    i118707 - make toolbar control's popup window grab focus
    http://svn.apache.org/viewvc?view=revision&revision=1225846

    Patches contributed by Herbert Duerr
    #i118662# remove usage of BerkeleyDB in desktop module
    http://svn.apache.org/viewvc?view=revision&revision=1213171
    minor cleanups in dp_persmap.*
    http://svn.apache.org/viewvc?view=revision&revision=1215064
    flush early to prevent problem with extension manager not
    cleaning up its objects
    http://svn.apache.org/viewvc?view=revision&revision=1228147
    i118726 do not flush *pmap file while reading it
    http://svn.apache.org/viewvc?view=revision&revision=1230614
    #i119048# migrate BDB extension entries using a simple heuristic
    http://svn.apache.org/viewvc?view=revision&revision=1300972
    #i119048# handle edge cases when importing BDB hash files
    http://svn.apache.org/viewvc?view=revision&revision=1301428
    #i119113# fix of-by-one when importing BDB files
    http://svn.apache.org/viewvc?view=revision&revision=1305420

restore our encryption settings, icon themes, and dictionaries.
removed wrapper hacks, kill obsolete bundled extension blob /
pre-registration handling, remove duplicated quickstart code.
remove OS/2 conditionals.
2012-11-19 17:44:55 +00:00
5837402fb1 fdo#46808, use service constructor for ucb::SimpleFileAccess
I upgraded the service to return XSimpleFileAccess3, since it
already implemented that interface, and it's backwards
compatible.

Change-Id: I40001a46048bd21a23b6a2f58a95376f06fc634b
2012-11-15 08:28:44 +01:00
aa06349cff drop unused #include
Change-Id: I11b59681a101c3e89db8d7a15d196e8bf11114ed
2012-10-06 15:06:38 +02:00
9b07288138 fdo#46808, Adapt xml::dom::DocumentBuilder UNO service to new style
Change-Id: I577fbc7f990be9ec1f7b7eea53218b7daaccb2a1
2012-09-03 15:55:04 +02:00
d57d3c3454 removed unnecessary forward declarations of class
Change-Id: Id08393f66797ef1c4378c8f3549d0900d4f1c7ec
2012-06-26 22:48:49 +09:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
b6db3e3acc re-base on ALv2 code.
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-21 13:11:06 +01:00
d08578912f fdo#46808, Adapt UNO services to new style, Part 7, updating ::create
Update calls to factories to use new SimpleFileAccess::create method

Change-Id: Ie5b0696fe2228a9033b19969245a53c21a61aa14
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, added some tweaks.
2012-06-06 10:01:22 +02:00
a6b68f4682 removed unused static rtl::OUString
Change-Id: I5a097beaaeb30214ed6071bba1297e551291922b
2012-05-14 23:43:54 +09:00
e4fb171d3a Replaced a few equal calls with == 2012-04-08 19:24:00 +02:00
743f22045c Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\)) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 15:07:41 +02:00
8a01ee6243 Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)\(else if\|if\) *( *\([^!()|&]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\) ) *) *)$/\1\2 ( \3 == \4 )/' \{\} \;
2012-04-06 14:30:05 +02:00
0439af27e1 Code cleanup: ( () ) replaced by (()) 2012-01-26 17:41:07 +00:00
725f7d0171 autocorrection migration never actually used 2011-12-21 09:30:20 +00:00