Commit Graph

361 Commits

Author SHA1 Message Date
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
47fa001b94 -Werror,-Wundefined-bool-conversion
Change-Id: I3efdef9a6581fcb1d5e8da7a86445d2f2401e9f9
2014-08-11 16:11:09 +02:00
9d140ccdb3 drop use of SFX_ITEM_PRESENTATION_NONE
since none of the call sites specify it

Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
2014-07-29 12:26:17 +02:00
7e018afaf7 simplify return argument of SfxPoolItem::GetPresentation
since all two of the actual call-sites only care about whether
it is a valid presentation or not, not what kind of presentation it is.

Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-29 11:04:01 +02:00
cd3d26b7ed vcl consitent use of long for corrdinate
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.

Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20 22:10:59 +02:00
59a2e1b9fa Cleanup: removed comments and debugging output
Change-Id: I41f13d33da641153784725344f5bd526ca69542b
2014-06-30 22:54:44 +02:00
4693d7cc99 Added class SvxBackgroundColorItem
Change-Id: If10795bbbd9fc911896b57bbab5410bc1e62f71f
(cherry picked from commit ad6a2607f09d2f770e683a21ad7243a077d65a7a)
2014-06-30 22:54:39 +02:00
be085bf523 Moved Text Filling Color in OutDev. Text Filling occurs in ImplDrawText
Change-Id: I9c75066a8dea32721757d0511a2af58c68408438
(cherry picked from commit b09cf493611f2521e66159287b88acc3c05d6d33)
2014-06-30 22:54:37 +02:00
039599e9d5 Put text filling in SvxFont
Change-Id: I290fff0cb66fc07122b976d977dff24ac491e108
(cherry picked from commit ea56441757a34082b9ffc5f28936413fcb55e31a)
2014-06-30 22:54:37 +02:00
d097bc8e15 HasBkg method to Font.HasBkg iff HasSingleUnderline.SetBkgColor in OutputDev
Change-Id: I10e6e1b916df0c78d26596a37944e8b57b2897e7
(cherry picked from commit 181266201b5e6aaad1dcd9cbc2dd4db44ecf3dc5)
2014-06-30 22:54:37 +02:00
e123213f46 coverity#735422 Logically dead code
Change-Id: I5639746f25024b0808e9c4e620bb0fa9f1a2c0b6
2014-06-10 10:48:42 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
b24739c98f coverity#705153 Missing break in switch, surely this is not intentional
since the initial commit of c04e60275f273dacf8796e957e1ebadc08b497a1

Change-Id: I9d3c3c2870c145b2fdb5c4f6c6ed17a14d1162c2
2014-06-05 09:51:06 +01:00
bd7d32bf1c coverity#705152 Missing break in switch
Change-Id: I9b56f5fe890d0d60e451cd35b69dcfb68e7b86b4
2014-05-26 10:18:23 +01:00
48eab8e0db coverity#705151 Missing break in switch
Change-Id: I7bfddf3bb7be3ade65c8b33c6d41901522498d56
2014-05-26 10:18:23 +01:00
56eadf4789 coverity#705150 Missing break in switch
Change-Id: I09249504ace6b38ae3dac677678995bbb5080a28
2014-05-26 10:18:22 +01:00
f056fd9852 coverity#707758 Uninitialized scalar field
Change-Id: I39954506deafc42e854d556170417af67f5461b2
2014-05-23 14:16:07 +01:00
77f79f29f0 coverity#984086 Uninitialized scalar field
Change-Id: Iba162efd0b582541199f343b64ac3b8c59dcc3d8
2014-05-23 14:16:05 +01:00
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
f730fafc03 coverity#984086 Uninitialized scalar field
Change-Id: Iab787537a4212e58710a1db1b30f953784824dfa
2014-05-11 11:52:30 +01:00
325e586dd0 coverity#707758 Uninitialized scalar field
Change-Id: I2f123b0be283b1cb7d890f0e2318dabb5a5930ec
2014-05-11 11:52:30 +01:00
623fa779b6 coverity#1019408 Uninitialized scalar field
Change-Id: I63bc844627ca9eaf43f9b4b01ab987ef4f188afa
2014-05-11 11:52:30 +01:00
5ec7a589be Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
2014-05-10 06:19:42 +02:00
9d2977d0a3 remove some more bloat
Change-Id: I7b6c04d99c41360ff49be774afcb4447a829d31c
2014-04-21 09:39:35 +02:00
5684e67aa8 no temporary instance of SvtLanguageTable necessary here
Change-Id: I35395e169e795386740fb2b5ee34fc3117b8c844
2014-04-17 23:15:04 +02:00
64b040866d coverity#735422 Logically dead code
Change-Id: I8e1694c311e1e29dc5ea59b292c6afe90fb762fa
2014-04-16 20:21:03 +01:00
3edb4611b2 editeng: sal_Bool->bool
Change-Id: I71ea2f0e48a6252832180872945b96a120f21907
2014-04-15 09:02:32 +02:00
84272d115d Introduce twip/mm100 conversion functions instead of duplicated macros
Change-Id: Ib689e35b417e0e9016cd6a239c986e0603a99d62
Reviewed-on: https://gerrit.libreoffice.org/8837
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-04-11 10:19:05 +00:00
b4fd20fc6b Clean up function declarations and some unused functions
Change-Id: Id9e29dcaab64b0244b5c53abb48ac27253a11917
2014-04-09 14:42:51 +02:00
a20b62dac8 svl/eitem.hxx: sal_Bool->bool
Change-Id: I45dfd2429a490af3cc80f51340e0c05a91425668
2014-04-04 13:44:18 +02:00
ddac6b1f30 use SAL_N_ELEMENTS
Change-Id: I533ce52828ae08a6ab111bcbeaaa6b44c62a6ab9
2014-03-31 16:33:23 +01:00
0b7c856978 Presentation string for recently-added border types
LibreOffice will show a textual description of a style in some contexts
eg in the Organizer tab of the dialog for modifying a style.

This change updates the description of border line types to support
recently-added types: FINE_DASHED, DOUBLE_THIN, DASH_DOT, DASH_DOT_DOT

Also this fixes an out-of-bounds array access in
SvxBorderLine::GetValueString

Change-Id: Ia354a05ab1455eb8bcc079c6e51419a0cc6429d6
Reviewed-on: https://gerrit.libreoffice.org/8781
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-31 15:30:50 +00:00
fe3dff3020 .doc support for recently-added border line types
Some new border line types have been added recently to LibreOffice
(FINE_DASHED, DASH_DOT, DASH_DOT_DOT)

This change updates .doc import/export to support these.
(Import of FINE_DASHED was already working, but not export).

Change-Id: Id3bcb1d4e6e9ceb97b492f0c578fd5b885ab16ff
Reviewed-on: https://gerrit.libreoffice.org/8780
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-31 15:29:25 +00:00
6e61ecd096 Merge back branch alg_writerframes to trunk
(cherry picked from commit b635b4fa4e42053d30ab639643d2236a20243f62)

Conflicts:
	comphelper/inc/comphelper/TypeGeneration.hxx
	comphelper/source/property/TypeGeneration.cxx
	cui/source/factory/dlgfact.hxx
	cui/source/inc/cuitabarea.hxx
	cui/source/tabpages/tabarea.cxx
	cui/source/tabpages/tabarea.hrc
	cui/source/tabpages/tabarea.src
	cui/source/tabpages/tparea.cxx
	drawinglayer/source/primitive2d/polypolygonprimitive2d.cxx
	drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx
	drawinglayer/source/texture/texture.cxx
	editeng/inc/editeng/unotext.hxx
	editeng/source/items/frmitems.cxx
	include/drawinglayer/texture/texture.hxx
	include/editeng/brushitem.hxx
	include/svx/sdr/primitive2d/sdrdecompositiontools.hxx
	include/svx/svxids.hrc
	include/xmloff/xmltypes.hxx
	reportdesign/source/ui/misc/UITools.cxx
	sc/source/ui/drawfunc/drawsh.cxx
	sfx2/source/dialog/tabdlg.cxx
	svl/source/undo/undo.cxx
	svx/inc/svx/unoshprp.hxx
	sw/Library_sw.mk
	sw/inc/doc.hxx
	sw/inc/format.hxx
	sw/inc/frmfmt.hxx
	sw/inc/swatrset.hxx
	sw/inc/unomap.hxx
	sw/inc/unoprnms.hxx
	sw/source/core/access/accpara.cxx
	sw/source/core/attr/format.cxx
	sw/source/core/attr/swatrset.cxx
	sw/source/core/doc/docdraw.cxx
	sw/source/core/doc/docfly.cxx
	sw/source/core/doc/notxtfrm.cxx
	sw/source/core/inc/frame.hxx
	sw/source/core/inc/frmtool.hxx
	sw/source/core/layout/atrfrm.cxx
	sw/source/core/layout/paintfrm.cxx
	sw/source/core/text/inftxt.cxx
	sw/source/core/text/porfld.cxx
	sw/source/core/text/txtfly.cxx
	sw/source/core/txtnode/fntcache.cxx
	sw/source/core/uibase/app/docst.cxx
	sw/source/core/uibase/app/docstyle.cxx
	sw/source/core/uibase/shells/drawdlg.cxx
	sw/source/core/uibase/shells/frmsh.cxx
	sw/source/core/unocore/unoframe.cxx
	sw/source/core/unocore/unomap.cxx
	sw/source/core/unocore/unoprnms.cxx
	sw/source/core/unocore/unostyle.cxx
	sw/source/ui/fmtui/tmpdlg.cxx
	sw/source/ui/fmtui/tmpdlg.src
	sw/source/ui/frmdlg/frmdlg.cxx
	sw/source/ui/frmdlg/frmpage.src
	sw/source/ui/inc/frmsh.hxx
	xmloff/source/text/txtprhdl.cxx
	xmloff/source/text/txtprmap.cxx

Change-Id: Id3ffaa83bb5594d287f1ac8f2c1c9cf55c70946d
2014-03-28 14:31:08 +01:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
402fffa1b4 Add dash-dot and dash-dot-dot line styles.
We need these for Excel interop.

Change-Id: I91450c1d205f28636edfb4392aa6ae5091b1d7b7
2014-03-19 00:28:16 -04:00
87efec9cc2 Make this non-inline.
Change-Id: I2002f7278b63b7678a5274e4213ab9dfb50e525e
2014-03-17 22:48:53 -04:00
84f4de3b65 fdo#68779: RTF import: set borders without explicit width
Word reportedly uses 0.75pt as a default if \brdrw is missing.

Change-Id: I263c56f756c65ff6bb30870aa70806564d5826a6
2014-03-14 19:15:57 +01:00
ca789f8ea4 coverity#1190356 Dereference null return value
Change-Id: I9a857423cd190b2da9f535e8897a9c9baba40b73
2014-03-06 16:35:50 +00:00
fd6a568ada remove unused code SvxNumRule::Create(SvStream&)
Change-Id: I82205010e613a07df24f22071eec74f53578671d
2014-03-05 09:17:47 +02:00
e964e2c56b remove unused code SvxNumberFormat::Create(SvStream&)
Change-Id: If8cfea11552bf008ab4381ecec50aadf58a98a45
2014-03-05 09:17:47 +02:00
2c62596cf2 fdo#75260: Correctly draw double lines for both Writer and Calc.
Fix all sorts of incorrect double line handling in drawinglayer in order to
draw thick-thin double line types correctly.  Also change handling of border
lines in writer tables. There are still some outstanding issues but it's
much better than how it was before.

Also realized that Word and Excel handle simple thin double lines differently;
Word varies widths of all of the lines and the gap whereas Excel only has one
fixed size for its double line.  For this reason I decided to add a separate
double line type (DOUBLE_THIN) to handle Excel's double line.

Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4
2014-03-04 22:02:37 -05:00
074a2af8bc editeng: sal_Bool->bool
Change-Id: I26b1fe14023737b85bcf23628e4881c8be79f071
2014-03-03 08:59:37 +02:00
241f1a1ab4 editeng: sal_Bool->bool
Change-Id: I0aa375d35c796cfa1929f9c0e735eaaa05561ee4
2014-03-03 08:59:36 +02:00
710178094d Remove visual noise from editeng
Change-Id: Id7582119a5628cb7f54347678580ce7e47f6d703
Reviewed-on: https://gerrit.libreoffice.org/8255
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 07:26:53 -06:00
015b80e852 editeng: sal_Bool->bool
Change-Id: I9e27453f0b77a23ae3d811f0a50a85d3fdf80978
2014-02-27 12:30:30 +02:00
c521f07208 editeng: sal_Bool->bool
Change-Id: I7da10ad3ba8017d64c723b53795348edf0e7dd6d
2014-02-27 12:30:30 +02:00
27842247e5 editeng: sal_Bool->bool
Change-Id: Iede0a8ea3e28d1a77069e61c5a9b9d5bccc69adb
2014-02-27 12:30:28 +02:00
2a4a74a499 editeng: sal_Bool->bool
Change-Id: I3827611dc887985484aec7fa5506e15298ac916e
2014-02-27 12:30:28 +02:00