Commit Graph

163 Commits

Author SHA1 Message Date
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
794d5ac4ac vcl: use enum for complex text layout constants
Since these constants are bitfield flags, we define some methods to make
working with them reasonably type safe.

Move the definitions to outdevstate.hxx, since we need the values there,
and that appears to be the "root most" header file.

Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing
as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write
weird code thinking that it's a real flag.

Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343
Reviewed-on: https://gerrit.libreoffice.org/10676
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-20 09:01:26 -05:00
68c3cd53a2 editeng: initialize mnRefCount in all ctors, fix sw.check crashes...
(regression from aa3babb42fa88840706f5b487ca0e88552cd8f83)

Change-Id: I5de9f4d79fa81c95c6f5dc9890485d91ea8fb97f
2014-08-15 14:37:35 +02:00
aa3babb42f Use boost::intrusive_ptr in lieu of manual ref-counting.
Change-Id: I0a29a1e490f5aa52a9057be71164573e403affe9
2014-08-14 11:17:26 -04:00
af246f9455 Apply a simple pimpl idiom and rename the old Impl to make it non-Impl.
The old Impl instance is ref-counted, which I'd like to convert to using
boost::intrusive_ptr.  But to make it happen, we need to really hide this
from public header...

Change-Id: I1f1e9e500f2112eea04e3e6d661a7dfa74655c62
2014-08-14 11:17:26 -04:00
cd3d26b7ed vcl consitent use of long for corrdinate
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.

Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20 22:10:59 +02:00
fdb1d62a09 Related: rhbz#1117853 nStartPara of EE_PARA_NOT_FOUND
we know that nStartPara is EE_PARA_NOT_FOUND so rOutliner.GetAbsPos must have
returned that, but we don't know the circumstances that lead to that yet.

Change-Id: I53a488317d154b4a3c050248b8737da0a611ca43
2014-07-17 13:52:13 +01:00
430484932e Typo: beeing->being
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
05f90a9afe Paragraph argument never used in InvalidateBullet
Change-Id: I07ba855e473fb137551e70de9cfa858c5e079324
2014-06-13 17:06:06 +01:00
794f09f195 simplify ternary conditions "xxx ? true : yyy"
Look for code like:
   xxx ? true : yyy;
Which can be simplified to:
   xxx || yyy

Change-Id: Ib7ca86580bfd0cf04674328a3c0cf3747de4758d
2014-05-06 07:45:25 +02:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
3edb4611b2 editeng: sal_Bool->bool
Change-Id: I71ea2f0e48a6252832180872945b96a120f21907
2014-04-15 09:02:32 +02:00
fa1f7d27c1 typo: attribut -> attribute 2014-04-14 12:32:59 +02:00
362d4f0cd4 Explicitly mark overriding destructors as "virtual"
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."

Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
95c45ef7b8 Avoid possible resource leaks by boost::scoped_array
Change-Id: Iffc9d1ca971610bad9b3dd2bd9a6cd00f02ff39b
2014-03-30 03:40:26 +09:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
c58fe8c85f codemaker,editeng: prefer passing OUString by reference
Change-Id: If3e2dd3905cc33f1e7fc9fbfbb9f2bb49a756a34
2014-03-17 09:00:07 +02:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
710178094d Remove visual noise from editeng
Change-Id: Id7582119a5628cb7f54347678580ce7e47f6d703
Reviewed-on: https://gerrit.libreoffice.org/8255
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 07:26:53 -06:00
af2f568cc7 editeng: sal_Bool->bool
Change-Id: Icaab3bcf646611ebb31415c54e0ce350817d8fc8
2014-02-27 12:30:27 +02:00
57779aa019 editeng: sal_Bool->bool
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-27 12:30:26 +02:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
b7180bd14f editeng: sal_Bool->bool
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
2014-02-21 12:19:24 +02:00
7e06ccad8f editeng: sal_Bool->bool
Change-Id: I36cb765d87ddef1fba3447a3ea90e5285cbcd678
2014-02-21 12:19:23 +02:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
5d4e4f3048 A little simpler.
Change-Id: I684317003a7afee4154fe39098ced7ba27bdff2f
2014-02-10 01:31:58 -05:00
49341001e7 fdo#46707: Don't bother with synonyms for text with mixed script types.
Change-Id: I7922905523406d05f864b10e1ecfd27f3fb5f9d6
2014-02-10 01:28:23 -05:00
d232561a74 Remove a now unneeded cast (xub_StrLen and tools/string.hxx removal).
Change-Id: Ic45b3c572483aa0292c227274565a1750dd51f17
Reviewed-on: https://gerrit.libreoffice.org/7854
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-05 20:54:34 +00:00
3cbfcee36d xub_StrLen and tools/string.hxx final straw
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases

Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-03 07:44:28 +00:00
f46a685b27 Resolves: #i123228# ParagraphData symbols shouldn't be required...
for outlobj.hxx users

Avoid the ParagraphDataVector default constructor in the editeng/outlobj.hxx
header. ParagraphData symbols are not DLLPUBLIC so they are not available
outside of editeng. When inlining is disabled (e.g. for debugging) this may
break the build as observed when building svx in debug mode on Solaris.

(cherry picked from commit 2738b2ea2df22759f32b687d08fd6868b425760e)

Change-Id: I0a8250fe3d61819217c913949dfa20a902b3e397
2014-01-29 09:11:57 +00:00
6bdd60462f bool improvements
Change-Id: If99daef91a41036a5b8dac1e53ab68e928b0b710
2014-01-28 20:24:39 +01:00
747ba6295d bool improvements
Change-Id: I2a0980a603822ffdf74a38ba0b41ba27a6830861
2014-01-22 11:39:21 +01:00
5e10e6937a EDITENG : Remove usage of DBG_CTOR and DBG_DTOR.
Valgrind is capable of detecting such bugs. No need for extra macros.

Change-Id: Ifc04e2ec9d27c706868569a3bcb8fbfae0e84c69
Reviewed-on: https://gerrit.libreoffice.org/7524
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21 16:07:00 +00:00
f89712a131 WaE: unreachable code
Change-Id: Iee5fa84eb2335efa7d7f7cb28b8efdecf9366592
2013-11-26 19:53:38 +02:00
c23ab5eaed Integrate branch of IAccessible2
WaE: Reorder initializations to prevent compiler warnings.

(cherry picked from commit c05431aa92fa2c7c7258418a6ecd651b5c26d982)

WaE: unname unused variable to prevent compiler warnings.

(cherry picked from commit 2259256a390c4b6f83cfb5dbe4a65df5032aee47)

Conflicts:
	editeng/source/accessibility/AccessibleEditableTextPara.cxx

ad61537527a74670af266feb9e4d26d2d654daf7
66044902b8d94fc15d4c30270e6cc419fb7d3565

Change-Id: I3ec9798f2c7d854824722c0cf44b62128b4f4cb4
2013-11-26 15:27:17 +00:00
9c57cb0a6c fixincludeguards.sh: editeng
Change-Id: I022e690c1f50f7f5ae872889e21aaedb5c60085d
2013-10-28 15:16:20 +01:00
7a06928bcf convert code to use OUString::endsWith
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23 08:29:15 +02:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
590359618a -Werror,-Wunused-const-variable
Change-Id: I0daea62642ea19e500287681070ebfd071d08da6
2013-10-02 16:49:33 +02:00
6536270e14 remove unused members from OutlinerView
Change-Id: Iac32c42afef80e01af70479e5b2f9de4e1dfab26
2013-09-22 20:01:15 +04:00
be5b8202f8 convert various bits in editeng from String to OUString
Change-Id: If8b0da1e6b6e3f1f0a0f4946c7741fd5aec66aa6
2013-09-11 09:45:39 +02:00
b929c66384 convert include/editeng/editeng.hxx from String to OUString
Change-Id: I92f69364667abec1b7a31080ce48fc55c4042165
2013-09-11 09:45:34 +02:00
c049ec8589 convert include/editeng/outliner.hxx from String to OUString
Change-Id: I53a9f334845e163625ed245859bdeb030ae61baa
2013-09-11 09:45:32 +02:00
166510ed48 Resolves: rhbz#996162 apparent NULL bullet font
Change-Id: I2f50ef1dabe2f152f2e18025edc88734158dbea2
2013-08-22 15:29:43 +01:00
96f24b9cc0 XubString->OUString
Change-Id: I9ccb06134dfadd9bf1ecb8e5edcd24c02980b754
2013-08-14 16:10:09 +01:00
403a75a275 XubString->OUString
Change-Id: I178f9eb702afb6143c583d5fd54003a427d895fa
2013-08-14 09:13:07 +01:00
d08a76cf72 String->OUString
Change-Id: I49e0e589c4bad3706882c9e30fe4f6bf8bdd7f1d
2013-08-11 21:53:59 +04:00
358d1a9948 use static LanguageTag::convertTo...() for standalone conversions
If no LanguageTag instance is at hand use the static methods to convert
between BCP 47 string, Locale and MS-LangID instead of creating
temporary instances.

Change-Id: I9597f768078eb81c840e84a5db5617f26bb7dc09
2013-07-13 11:55:16 +02:00
0ff751efaa Resolves: #i122096# apply default bullet numbering rule on toggle on...
if the current numbering rule is not a bullet numbering rule.

- improve application default bullet numbering rule by add corresponding
  spacing to the first list level
- refactoring of code introduced for paragraph property panel to handle toggle
  and set of bullets and numbering

(cherry picked from commit 8c142809c7e16853d5634487cc9ed4e53caa3f91)

Conflicts:
	editeng/inc/editeng/outliner.hxx
	editeng/source/outliner/outlin2.cxx
	editeng/source/outliner/outliner.cxx
	editeng/source/outliner/outlvw.cxx
	sd/source/ui/func/fuolbull.cxx

Change-Id: If2807b2b81f8ade1e5b3282aa636cc2c0d8ea76a
2013-05-30 14:28:48 +01:00
4f298ece2f Do not enable outliner when it was not before only for temporary undo disable
(cherry picked from commit 68e5157012bc54ad4ce9bcd644cc163d5662ff67)

Change-Id: I2cbdc2a228884dff8000206ced4a5d8930dd6339
2013-05-28 15:55:25 +01:00