88a874fcb3
convert SfxItemState constants to a proper enum
...
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants
Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23 13:26:19 +02:00
6a873638fa
Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
...
- Remove includes from files where they are not needed.
- Update pch files
Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-07-17 08:47:58 +00:00
dac4ca5f68
new loplugin: externalandnotdefined
...
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.
Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
4228f08d60
use assert when followed by deref
...
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-03 12:49:38 +01:00
430484932e
Typo: beeing->being
...
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-29 13:15:51 +02:00
e2080e70fe
new compilerplugin returnbyref
...
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
class A {
struct X x;
public X* getX() { return &x; }
}
which can be:
public X& getX() { return x; }
Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
e45366826c
loplugin:staticcall
...
Change-Id: If6fca7f7761877b5642eddb800de46efb59aa6dc
2014-06-13 17:54:26 +02:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
5ceded62aa
editeng: remove SAL_THROW macro
...
Change-Id: I8e36112a10cdef6250dba4b4cf75e5eba443e0b9
2014-06-05 08:17:47 +02:00
ff998ca882
coverity#705374 Mixing enum types
...
Change-Id: Ie18131e7207d8f93a775c21abfc77d768352a5d3
2014-06-04 12:34:15 +01:00
abe5aaa726
coverity#706505 Uncaught exception
...
Change-Id: Ia00361fb1d86223a7ed65f0be295b291183e3ad6
2014-05-28 13:49:51 +01:00
ddaaeec1b1
coverity#706506 Uncaught exception
...
Change-Id: I60f0a08029ef4599403c9853a55fff25cdf3f0bc
2014-05-28 13:49:51 +01:00
9b791f9c31
remove unnecessary use of OUString constructor when throwing
...
Change-Id: I4a3f3f911dcfbf88696053215a2fb7a94678244c
2014-05-27 08:20:11 +02:00
b09b5f8f7c
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
...
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
b2096deaff
various loplugin:passsequencebyref
...
Change-Id: Id1045a7f66b4fa10b6491587ba07246a31ceba72
2014-05-14 16:54:27 +02:00
036a660a86
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part11
...
Change-Id: Ibe0a1006aba2b6cbd87c0bd6ca3acbf9ba7b0fbe
2014-05-13 23:20:26 +02:00
ffa2229a8e
remove dead code
...
Change-Id: Ic4fb478921714429af138ca212bd7f67f408d434
2014-05-13 12:00:27 +02:00
5ec7a589be
Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8
...
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
2014-05-10 06:19:42 +02:00
3edb4611b2
editeng: sal_Bool->bool
...
Change-Id: I71ea2f0e48a6252832180872945b96a120f21907
2014-04-15 09:02:32 +02:00
f767d4580e
callcatcher: update unused code
...
OAuth2Handler is from libcmis
Change-Id: Ia1986d6df7ab45580c66b4e536c5882af41f357f
2014-04-10 09:50:54 +01:00
b4fd20fc6b
Clean up function declarations and some unused functions
...
Change-Id: Id9e29dcaab64b0244b5c53abb48ac27253a11917
2014-04-09 14:42:51 +02:00
3d330f20ef
Resolves: coverity#705447 Self assignment
...
in every other !bAbsorb branch we set the StartPara to the EndPara
Change-Id: I4fc877e9d63f823679acf9c4b1550d5e877819be
2014-04-04 13:57:46 +01:00
214751e3cc
cleanup up the EditEngine::GetAttribs call
...
It was using a bool parameter, but passing various constants
through it.
Make the constants into an enum, and use the enum in the GetAttribs
call.
Change-Id: I3010397dfe83b24db3946b9dea2fb37f4393abdd
2014-04-04 13:44:16 +02:00
0523304875
svl: sal_Bool->bool
...
Change-Id: I6938314a08d061d2b07d9129742d74a989bd1385
2014-04-03 09:17:52 +02:00
95c45ef7b8
Avoid possible resource leaks by boost::scoped_array
...
Change-Id: Iffc9d1ca971610bad9b3dd2bd9a6cd00f02ff39b
2014-03-30 03:40:26 +09:00
1db5a63365
typo: selektion -> selection
2014-03-29 19:16:31 +01:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
447e910c19
editeng: simplify deprecated XTypeProvider.getImplementationId
...
Change-Id: I4135695eccb486e5df180f98a247755ba85a9454
2014-03-10 17:39:54 +01:00
ded5965ce8
editeng: sal_Bool->bool
...
Change-Id: I51b4ae54c2c440d38879439f74d4fea39d243004
2014-03-03 08:59:38 +02:00
82ce4dd607
editeng: sal_Bool->bool
...
Change-Id: Icfda5e8e774b9b5a6c3d99b636e4ce772b93139d
2014-03-03 08:59:38 +02:00
ec960fd3de
editeng: sal_Bool->bool
...
Change-Id: I767aa3d25f6d18e8a6e23b4d3f8d038d581ac292
2014-03-03 08:59:38 +02:00
0f60ab5ebf
editeng: sal_Bool->bool
...
Change-Id: I4fc276e320294d57eb667b6db8e5eff078bc28b3
2014-03-03 08:59:37 +02:00
0786a72308
editeng: sal_Bool->bool
...
this had to be done in conjunction with changing
include/svx/unoshtxt.hxx
because there are two virtual methods "bool IsValid" in two different
base classes and some subclasses are overriding both base-class
methods at once.
Change-Id: Ib43fc5000b443057caaa513b4efeaa6fd16e4260
2014-03-03 08:59:36 +02:00
710178094d
Remove visual noise from editeng
...
Change-Id: Id7582119a5628cb7f54347678580ce7e47f6d703
Reviewed-on: https://gerrit.libreoffice.org/8255
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 07:26:53 -06:00
b46f93a3c5
editeng: sal_Bool->bool
...
Change-Id: Ic59e48341f69b8c6e6fe77b05eeebac56a2c53e7
2014-02-27 12:30:30 +02:00
ef16d954c2
editeng: sal_Bool->bool
...
Change-Id: Ic3d9fe45d3242d3da147067d3c388e9d7305ee61
2014-02-27 12:30:25 +02:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
db0222881b
editeng: sal_Bool->bool
...
Change-Id: Ie2c8bf805461d61de2dfa2658160fd612959932c
2014-02-21 12:19:25 +02:00
d9fd1d5310
remove unused return value from method
...
Change-Id: If8ad6d01e92bb6df429acca03df0b40a4e2b7f1d
2014-02-21 12:19:20 +02:00
12f1faf7bf
svl: sal_Bool -> bool
...
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
811e6f6745
coverity#738003 Uncaught exception
...
Change-Id: Iddb64e592ae47dd5f22430778b8018fc8c9880c5
2014-02-13 21:04:53 +00:00
1c71cef7f8
coverity#707769 Uninitialized pointer field
...
Change-Id: I449173ea1c4418cc2cc978862fe465e33e7b4338
2014-02-13 14:56:25 +00:00
a79f1097ee
sal_Bool->bool
...
Change-Id: Ie477a46fae2b8c4deb55435f3769ba74037dd259
2014-02-12 09:01:08 +02:00
3cbfcee36d
xub_StrLen and tools/string.hxx final straw
...
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases
Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2014-02-03 07:44:28 +00:00
93ef9a43a5
fdo#54938 Convert bridges, editeng and others to cppu::supportsService
...
Change-Id: I7ff5189473c3e0831c2f1e95264d1a04f3b716a9
Reviewed-on: https://gerrit.libreoffice.org/7761
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Marcos Souza <marcos.souza.org@gmail.com >
Tested-by: Marcos Souza <marcos.souza.org@gmail.com >
2014-02-02 17:38:09 +00:00
6bdd60462f
bool improvements
...
Change-Id: If99daef91a41036a5b8dac1e53ab68e928b0b710
2014-01-28 20:24:39 +01:00
887bc4dd3e
cp#1000025: Import casemaps from pptx.
...
Note: This only imports it and it may not be
even possible to export (even to othe formats).
Change-Id: I8e104f1bc3a95c42ac932b6ab58365dc113fb2e0
2014-01-27 16:23:44 +05:30
747ba6295d
bool improvements
...
Change-Id: I2a0980a603822ffdf74a38ba0b41ba27a6830861
2014-01-22 11:39:21 +01:00
3257e9a47a
bool improvements
...
Change-Id: Ia212b8f80da70de7796f0d8ba817c8d3da693080
2014-01-22 08:22:32 +01:00
