961d061ba1
set names on some UNIX-only threads
...
Change-Id: I4c247916256618312e7d98673d9db4d26e26fa39
2014-08-25 13:21:58 +02:00
1bb161ece5
these strings should be translatable
...
so bring back scn.res and add them in there
Change-Id: I378d64f524c64295d26223f54fe17950b475cd80
2014-08-18 11:13:55 +01:00
a107bdfdfc
ErrorBox->MessageDialog
...
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
1f7a67083d
coverity#703955 Unchecked return value
...
Change-Id: If10c9643474620855e21caaa1fdcbbc4b7fd07ac
2014-07-01 12:44:04 +02:00
629bb797b9
coverity#1223093 Uninitialized scalar field
...
Change-Id: I5519b552507ab81e51f81996835467d353277a18
2014-06-17 10:57:56 +01:00
8b8311a867
loplugin:unreffun
...
Change-Id: Ia4eda7adc7685809b69a248f664b6a38dc3ea0e6
2014-06-12 15:05:37 +02:00
5c53bb8a99
scn resource file is empty now post ui-ification
...
Change-Id: Id8a6d6c4faf3101b13d84de180f8db7cab2cb16f
2014-06-12 13:54:15 +01:00
84e1368bd8
more the png into the .ui so it isn't garbage collected
...
Change-Id: If0d3829bfc14c602a0167967cbe215782c75f549
2014-06-12 13:54:15 +01:00
0cab72b819
extract gamma grid drawing to standalone widget
...
so the dialog stops scribbling on itself, and instead
uses a real widget for that
This has to be one of our weirdest dialogs, why expend so much effort to create
this dialog for the most obscure of issues.
Change-Id: Ia25e6c67fb278528c6c68a1d6db74de59915fd34
2014-06-12 13:54:14 +01:00
99b1b4d475
don't use raw english string
...
Change-Id: I5f34889520afb2149ba480f56d59f14d75ee50c0
2014-06-12 13:54:14 +01:00
3137acbe78
Convert GRID_DIALOG to .ui
...
Change-Id: I4476559cc2e6a90b65d5bdc8169b256929f07f7e
Reviewed-on: https://gerrit.libreoffice.org/9734
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-06-12 12:53:44 +00:00
81f7aa81bc
Resurrect SaneResId in the place where it is still used
...
Change-Id: I20f751f6b9fdf683566544aed4ca2ad877abc253
2014-06-11 18:05:24 +02:00
58d6e4fdc5
loplugin:unreffun
...
Change-Id: Iffc5a864954e106e1b20a86c8caddf4257ff139e
2014-06-11 17:50:13 +02:00
14560264be
Reset preview boundaries on a new scanner
...
Change-Id: Id2830727216fa25ca5935406a74f4237276d56db
2014-06-11 15:07:44 +01:00
ab713ba1ff
Changing scanners has no effect
...
I guess no-one ever tested with multiple scanners but it just happens that my
laptops webcam is presented as a (non-functional) scanner alongside the real
one
Change-Id: Ie36651cfc867027ef19e272dbabe46de6c4261ee
2014-06-11 14:52:11 +01:00
d6eeb8a489
extract Scan Preview code into a preview widget
...
instead of scribbling over the parent dialog directly. Doing is this way allows
the .ui-ification to work right.
Change-Id: Ia0c33eae4cd5a4c94896436fe5a5afad8d60a577
2014-06-11 14:27:54 +01:00
f188c982d5
Convert RID_SANE_DIALOG to .ui
...
Change-Id: I1f08493cdc18f4c0691a8436368432fe4e94dec3
Reviewed-on: https://gerrit.libreoffice.org/9696
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-06-11 13:27:30 +00:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
ebc0a15515
remove more unnecesary OUString constructor use
...
when throwing exceptions
Change-Id: I6edfb6b6745499f802b0e3c0e096a36fb7c32aac
2014-05-29 09:01:40 +02:00
025387b6e7
coverity#983672 Uncaught exception
...
Change-Id: I1b2ff484906ba3dc85fa4926dbbf45c91a57c6be
2014-05-24 16:11:00 +01:00
424a9f1fe6
coverity#738627 Uninitialized scalar field
...
Change-Id: I32d0f04a3346aa2ec8df6dbd8709c74f45c66c06
2014-05-11 11:52:30 +01:00
aa3548fba6
prewin.h includes windows.h
...
Change-Id: I221e9f704f75472234a6ce2b09930aeff6279c7a
2014-05-09 22:32:54 +02:00
7ae4102f17
extensions: sal_Bool->bool
...
Change-Id: I1730f99c08690138e9aa7aba54304fd7bc51491d
2014-05-02 08:49:22 +02:00
a86b6727d3
coverity#738627 Uninitialized scalar field
...
Change-Id: Id52cf54dea1b51ab3884618f90a01324b7451f76
2014-04-23 09:40:04 +01:00
97a5ba4a71
remove comments why a file gets included
...
also remove some commented out code
Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
f400bdce03
fixincludeguards.sh: extensions
...
Change-Id: If652bce4cf7621795b084bcbc0aa4c46dd903878
2014-04-19 11:10:10 +02:00
8f7c677dbb
Avoid possible resource leaks by boost::scoped_array
...
Change-Id: Ibf92b3098c50388d8b6d27f4476e613a1f8918b5
2014-04-02 16:09:11 +09:00
362d4f0cd4
Explicitly mark overriding destructors as "virtual"
...
It appears that the C++ standard allows overriding destructors to be marked
"override," but at least some MSVC versions complain about it, so at least make
sure such destructors are explicitly marked "virtual."
Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-04-01 19:22:54 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
0f48aba07a
coverity#704634 Dereference after null check
...
Change-Id: Id6e4e71a9d261734d01de72f81e2df0f7fbad475
2014-03-02 20:08:15 +00:00
e6ba4db7f0
unnecessary check before delete
...
Change-Id: I62b42aa20395ff2f6b3dd2b7ab6460be2ce943b8
2014-03-02 20:08:15 +00:00
15246c959a
Remove visual noise from extensions
...
Change-Id: I0397d0d0e5343b7ed192a790664b068ac6955bd3
Reviewed-on: https://gerrit.libreoffice.org/8259
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2014-02-27 07:34:29 -06:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
0ce0c369aa
Remove unneccessary comments
...
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-23 03:38:49 +00:00
15535e32dd
convert SvStream::operator>> methods to ReadXXX methods
...
First, I updated the clang rewriter to do the conversion.
Then I lightly hand-tweaked the output for the few places where
the rewriter messed up, mostly when dealing with calls on "this".
Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9
Reviewed-on: https://gerrit.libreoffice.org/7879
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2014-02-12 15:31:40 +00:00
896899b843
cppcheck: redundant assignment
...
Change-Id: I62fbbe97c24deb45d8a79463e463a6783201ba98
2014-02-01 22:13:48 +01:00
a29cdd540c
bool improvements
...
Change-Id: If3402725c9cbff5df45043bd2ecd22dd6241c052
2014-01-28 20:26:28 +01:00
16a2e90335
remove SvStream::operator<< methods
...
.. and convert the last few places still using those methods.
Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd
Reviewed-on: https://gerrit.libreoffice.org/7495
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-01-22 22:00:47 +00:00
b69864f3f8
re-write SvStream operator<< to non-overloaded methods
...
This is the actual re-write.
Use a clang rewriter to rewrite SvStream::operator<< to methods
like WriteuInt32.
Note that the rewriter is not perfect, and I hand-tweaked the output.
In particular, I had to adjust places doing things like
(*this) << 1;
Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a
Reviewed-on: https://gerrit.libreoffice.org/7342
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Michael Stahl <mstahl@redhat.com >
2014-01-10 13:26:24 +00:00
9ed364774c
Adapt all (non-extension, SharedLibrary) .components to environment="..."
...
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17 11:06:00 +01:00
30ac3942b4
remove RTL_CONSTASCII_STRINGPARAM in OString::matchL calls
...
Convert code like:
if (aValue.matchL(RTL_CONSTASCII_STRINGPARAM("BOOL=")))
to:
if (aValue.startsWith("BOOL="))
Change-Id: I385d10fd486d6a3e5f81f4a28088d913fc2f0d26
2013-11-20 13:56:08 +02:00
d894fee80e
remove RTL_CONSTASCII_STRINGPARAM in OStringBuffer constructor
...
Convert code like:
OStringBuffer aKeyName(RTL_CONSTASCII_STRINGPARAM("NDX"));
to:
OStringBuffer aKeyName("NDX");
which compiles down to the same code
Change-Id: If9c96a290bc18cc8285fb733f27be58c6958b63c
2013-11-20 13:56:07 +02:00
610b2b94b3
remove unnecessary use of OUString constructor when assigning
...
change code like
aStr = OUString("xxxx");
to
aStr = "xxxx";
Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
22435a0777
remove unnecessary use of OUString constructor in EXTENSIONS module
...
Change-Id: Idf73eb831f52d4d74e6fbb6ea27f59ebbfd13a8c
2013-11-11 11:21:23 +02:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
e0280873b8
extensions: try to fix WNT String
...
Change-Id: I17ec25a836eda7bb023c440db1f40186b6156067
2013-10-22 14:55:17 +02:00
c0e827297b
stray String in extensions
...
Change-Id: Iea98e52fd026d93f68ab9916ccb583b156d5c9a7
2013-10-22 13:55:46 +01:00
dd28837249
vcl: mark more Image constructors as "explicit"
...
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22 14:42:17 +02:00
b37e2dd071
Resolves: fdo#38838 remove UniString
...
hammer silver nails into coffin and bury in concrete
Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-22 12:50:48 +01:00
45e366eadb
drop unnecessary tools/string includes
...
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
