Commit Graph

5720 Commits

Author SHA1 Message Date
dfb24d09a8 Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I10d58f79bf8e803953ce960d8f63c7139a23d609
2014-08-29 13:27:10 +02:00
1298c1d135 We don't check the extension for html
...since 86c6f18c2766aad43d6e3bfcf3530e40440ebca7,
so move the related code and comment to the plain
text scope.

Change-Id: I501ebaba915ddaa3f5d1d8d2977d3ba70fb6071b
2014-08-29 00:54:35 +03:00
98ef8894dd convert RID_PDF_WARNPDFAPASSWORD to MessageDialog + string
Change-Id: I40da6ede705bf8e56adee7a45c56cb60cf42d166
2014-08-25 16:45:29 +01:00
48500bdd05 fdo#82290: avoid pipe deadlock by executing write(2) in a new thread
Change-Id: I65737399d9ac7ffa1eb623f3ff5fffbce6929801

Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-25 11:31:55 +02:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
982029bd44 Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Id8796438fd63065a9aefdd4e142b6638a65bbb5f
2014-08-22 14:12:48 +02:00
e6fdd7ad0a The bLastBoxInChain fields are unused
Change-Id: I741733a053c8b0123be8efbcb9fde39f53f6d83c
2014-08-22 14:48:25 +03:00
db12d9042c bHasUDefProp is unused
Change-Id: I8eae6f1ed791ba92c3b4679d1b9f8041f16678d1
2014-08-22 14:48:25 +03:00
60eeeb9d2f Avoid undefined MSO_LineStyle values outside the enum's value range
Change-Id: Ie9eee91374818cbfbb10a7d91e0fb2114ce140b4
2014-08-21 14:51:11 +02:00
1f65b55398 Avoid undefined left shift of negative values
Change-Id: I428b2401f59930e115f4b0d205f6c1db779b16f9
2014-08-21 14:34:24 +02:00
f8bf090bbb These "newly added" record types are publicly documented nowadays
Use symbolic names from the MS-PPT RecordType documentation,
http://msdn.microsoft.com/en-us/library/dd945336(v=office.12).aspx

Change-Id: I1deecfc69dd3360ef982f144d5ff5348a2953280
2014-08-21 12:33:19 +03:00
8fd3b09456 staruno -> css::uno
Change-Id: I29a8aa8168f604f1e71323b5a19c3f67c67e2c1a
2014-08-21 09:03:17 +02:00
892f4c2ad8 stario -> css::io
Change-Id: I4e82694399e72ce17172ac3d3c3cd9f9bcd30ba5
2014-08-21 09:03:17 +02:00
9d17726dcd staruno -> css::uno
Change-Id: Ic82bbe5797d4f3c16096598cd566b917ee335a10
2014-08-21 09:03:16 +02:00
1ab0e8717b guard against division by 0
valgrind + bff

Change-Id: I5fa40f7a9759c98bb70ee6eb854dd9b376401f89
2014-08-19 15:22:13 +01:00
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
759f5d24b0 Consistency around XColorItem in svx/sdshcitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I7ecf827a0713efaecb4b0eb49f9f8c06f8c59091
2014-08-18 18:18:08 +02:00
69dd9c669a Consistency around SdrPercentItem in svx/sdshtitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I4e98c362f811c19f03766d0c78f10c795d3ac79d
2014-08-18 17:38:08 +02:00
8fa219fbb5 Downcast to wrong SfxPoolItem sub-type
Change-Id: I9f4dc2f470f94d6f7cc2959e368fda419d9482c4
2014-08-18 16:29:25 +02:00
08edafa656 Consistency around SdrOnOffItem in svx/sdtcfitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18 14:56:55 +02:00
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
a51c423743 Consistency around SdrMetricItem in svx/sdsxyitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I3734cb14b6ed8f556af85b234968682a55ac8a4c
2014-08-18 10:55:36 +02:00
ad07270f80 warning C4189: local variable is initialized but not referenced
Change-Id: Idc096dd366284503b397a51e708647d026b64eb0
2014-08-13 10:10:40 +02:00
95f0811c09 Revert "Resolves: #i125187# more precision where the BLIP graphic is located"
This reverts commit 3ea17073114cae99d7c323f051a4a2ba074f043c.

That change from AOO single-handedly broke all image import from xls
binary files.

Change-Id: I384ae8f286ccc9d39e64de9da5ef6458af0a0972
2014-08-12 14:16:56 -04:00
5fe1a59cb7 Scope reduction in GetBLIP() & remove non-ASCII character (degree symbol).
Change-Id: I306a22b087aceed5dbb6cb2e8b67e2501589ee61
2014-08-12 14:16:56 -04:00
a1fab361cb valgrind + bff: Integer divide by zero
Change-Id: I4c47d17a421f1c6d2d6cc29c7b92ec930bdf901f
2014-08-09 17:31:34 +01:00
03e0bd6b3b [API CHANGE] Removed two cppuhelper deprecated headers.
The headers cppuheader/compbase.hxx and implbase.hxx. They have been deprecated
since 2001. Moved the definitions of the deprecated functions to
cppuhelper/source/compat.cxx.

Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, adding fixes and clean-up
in cppuhelper/source/compat.cxx and odk/Package_odk_headers.mk

Change-Id: I48b3cbf551b59d72614737a883a96aab55fc2090
2014-08-08 11:25:55 +02:00
b7325b907e fdo#45418 xslt: Make sure we're reading from the beginning
Change-Id: Id5beb6af8c32ab45d7e31120d38966f8fe4d5418
2014-08-06 12:36:18 +03:00
43856800f0 Consistency around SdrOnOffItem in svx/sdasitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Icdeff7f37901f99158bb00de5e912c181bf3e688
2014-08-06 10:20:53 +02:00
af28a77724 Better names for several filters
Thanks to David Tardon

Change-Id: I646f43fde5b7481ba77a2b12b7111b2093476f78
2014-08-05 22:29:11 +03:00
8d023edc18 Consistency around SdrOnOffItem in svx/sdshitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Id712c222034ef807ea2d7bc459e78882e948aca6
2014-08-05 08:59:37 +02:00
151fbebf8c Consistency around SdrOnOffItem in svx/sdtagitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04 19:22:55 +02:00
768d32cf5b Consistency around SdrMetricItem in svx/sdtditm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-04 11:29:51 +02:00
fe817d6672 Fix showing calc/draw types in some file pickers
Having the same UIName for several filters, causes some
file pickers (gtk & generic) to drop the whole group.

Change-Id: I6d18a751cb77a6a83e8e2a46338e41b7c72180ff
2014-08-03 16:09:24 +03:00
e5ac048af1 Fix calc_MS_Works_Document extensions
Change-Id: Icbf087464997561b09c7b43c2269eea2c8c603bb
2014-08-03 15:52:41 +03:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
68969cc61a Consistency around SdrMetricItem
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem
while others where of trivial derived classes SdrTextMinFrameHeightItem etc.,
that appear to only existed for better-named constructors.

Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-31 15:57:12 +02:00
23c5a5362b remove some unused headers from svgfilter.hxx
Change-Id: Ide1319b0b3504f8084d2dfb999b5ece35b95be8f
2014-07-24 00:34:49 +02:00
245df9b4b3 fdo#78663 : The File gets corrupted when saved in LO
Problem Description:
The docx file contains a word art inside a drawing tool.
After RT, nesting of <txbxContent> tag is happening which
is causing the corruption.

Solution: Created a service in util.cxx for checking
few shapetypes for which textbox with content is not
allowed. This check also helps to find that if we are
already inside a DML then we should purely read VML
Information.An existing UT testWordArtWithinDraingtool
was failing. The UT is related to same issue
(word art inside drawing tool) hence changed it
accordingly. Following is the commit id of the
UT-Change-Id: I00e94712e912ad1977fcb65a945fefb927795d77

Change-Id: I7e456c9f6a69af80da443e29eb02a64ba7d59468
Reviewed-on: https://gerrit.libreoffice.org/10229
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Luboš Luňák <l.lunak@collabora.com>
2014-07-21 15:03:25 +00:00
cd3d26b7ed vcl consitent use of long for corrdinate
most of length in vcl are calculated in 'long'
but array of X position tend to be in sal_Int32.
As a prep work to be able to support 'double'
as the base type of Device Coordinate, harmonize
the use of 'long' for non-float coordinate.

Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-20 22:10:59 +02:00
1e6ff8f7f8 XFillStyle -> css::drawing::FillStyle
Change-Id: I6b2fabd72fd34f4ac1b3a18f386c90794bc39ce4
2014-07-19 00:30:37 +02:00
724c242f1d coverity#704477 Division or modulo by float zero
Change-Id: If229ad014851f46ccad5f8aec24cbf0bd2781b5e
2014-07-18 15:36:18 +01:00
dac4ca5f68 new loplugin: externalandnotdefined
Find "missing headers," where a function is declared directly in the
.cxx (as extern) and not defined, and should arguably instead be declared
in an include file.

Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2
2014-07-11 14:12:25 +02:00
d01e35e120 Clean up usage of 'this' and constness.
Change-Id: I35085bebdec47598a5f927924b429b02b44c0e65
2014-07-11 09:32:08 +02:00
4ce9e4a68f Head cleanup - use forward declarations.
Change-Id: Icc4fa0acad77d61200eb77cc70e21866590b658e
2014-07-10 14:13:57 -04:00
86c6f18c27 avoid problems detecting HTML files with .xls ext.
Change-Id: I9955223aac20f3f640fde51bb7231666c269ca70
2014-07-08 17:03:42 +02:00
579d9ae1c5 Include <algorithm> for std::min()
Change-Id: Ieb01023b93923777cf53a2fc8d7198d88422e8a4
2014-07-08 12:06:48 +03:00
845e8427fc Include <algorithm> for std::min() and max()
Change-Id: I88a590344292b4adf562ca83f5072d543b5924ad
2014-07-08 11:38:54 +03:00
a3338f8969 fdo#78989 set preferred filters for ODF types
We do not want to randomly pick FlatODF as the filter for

    libreoffice --convert-to od?

Change-Id: Id04e10120786ef6a2c2b0eaf2b20a256d8daa7dc
2014-07-07 17:04:00 +02:00
e110726bab don't terminate via unhandled exception on loading rhbz1013280-2.ppt
Change-Id: Ie2bff125f6839d99280d441b823eb6e0a712844d
2014-07-07 15:44:00 +01:00