New warning from Clang 6. So get rid of the initWithOUString
initializer completely, it is called only from stringWithOUString
anyway.
Change-Id: I510101bfe1e6ac52f8f5a1d8a061082b3875419f
fpicker/source/aqua/SalAquaFilePicker.mm:220:14: warning: 'NSOKButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseOK instead [-Wdeprecated-declarations]
fpicker/source/aqua/SalAquaFilePicker.mm:225:14: warning: 'NSCancelButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseCancel instead [-Wdeprecated-declarations]
fpicker/source/aqua/SalAquaFolderPicker.mm:114:10: warning: 'NSOKButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseOK instead [-Wdeprecated-declarations]
fpicker/source/aqua/SalAquaFolderPicker.mm:119:10: warning: 'NSCancelButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseCancel instead [-Wdeprecated-declarations]
Change-Id: Ib497903e4df868867cc56e2eade7bb2572f0902a
Reviewed-on: https://gerrit.libreoffice.org/10115
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
The m_pFilterControl is always added to the m_aActiveControls list
(see createFilterControl()), so it has been released by the loop over
the list. So make sure to call setTarget before the loop.
For some reason this doesn't normally cause sending a message to a
deallocated instance, though. (I only noticed it when experimenting
with if-zeroing out the creation of the user pane.) I guess this might
mean that we actually have a leak here, if the controls in the list
don't actually get deallocated by the release messages in the loop?
Change-Id: If691f8d35bab606ce8a61f677d8e495e72a23148
Store security scope bookmarks for files selected in the file picker
in the user data. (I looked into storing it in the LO "registry" in
the Histories/PickList thingies, but that was horribly complex.)
When opening a file, if we have stored a security scope bookmark for
it, use that while opening the file.
Change-Id: I347ae2dd815299441c17467d9b66a226061d0ed2
NSLog demands a non-const NSString but doesn't change the string.
(cherry picked from commit 6f279aad1a472ebf4afd08334e10a24342924315)
Conflicts:
fpicker/source/aqua/CFStringUtilities.hxx
Change-Id: I25c82dc81feda9b771f064631857a1e7f9c4d2bb
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
...replacing hard-coded GCC version checks. Those checks that guard
#pragma GCC diagnostic ignored "-Wnon-virtual-dtor"
appear relevant only for GCC itself, not Clang (which used to fail the old
guards because it typically announces itself with a rather low
__GNUC__/__GNUC_MINOR__ version), see 6e67c03dc0225fc66343546b14e902b9d238b1a3
"Enable -Wnon-virtual-dtor for GCC 4.6"
Change-Id: I6bfa4d5caa6192e7a203ce829682bf6bb8d61a1b
...broken by 4b51374a7021d52f7f1be1861e2ee6a011b30ecd "fdo#46808,
Adapt ui::dialogs::FilePicker UNO service to new style."
Also remove unused field while we're there.
Change-Id: If7e2057b9383edf4ee2fa581df984dea0e04e430
