a9fc9f4a9f
Drop unused E_NOEXCEPTIONS
...
Change-Id: I558684352cc99002752d4c5d118a0c46572bd6f0
2014-07-02 14:56:52 +02:00
b6df953c8f
Drop unnecessary ITransactionManager base class
...
Change-Id: Iebed1d63ff76fdc9b82ce6ce8860592606500e38
2014-07-02 14:56:52 +02:00
493bd11fcb
Removed redundant private methods comments
2014-05-14 14:17:01 +01:00
e6ac6cbccf
automaticly -> automatically.
...
Change-Id: Iae55083160eee86ac8301f272634dd3ae65fd847
2014-04-27 01:28:55 +02:00
dc6175ff1f
Remove LockHelper::getGlobalMutex().
...
Do what the TODO suggests - change it to SolarMutex in most cases.
In some cases it is only there to guard a local static, introduce a local
mutex for those.
Change-Id: Idc3155818f737b958b36ee9125e2e9e8cb1b91a1
2014-04-15 13:10:56 +02:00
a6287e21f1
framework: sal_Bool->bool
...
Change-Id: Ia6e87e2b382bd4005637e14088bde9e809996a25
2014-04-07 13:53:49 +02:00
e32e7946aa
Bin empty @seealso, @param, @return etc metacomments
...
Change-Id: I9582afceb5daf5993bfca1445370d8a60030c3c5
2014-04-06 20:02:08 +03:00
f4e8d2ad0e
Bin empty @seealso, @param, @return and @onerror metacomments
...
Change-Id: I30a761a21a98419816c4b67258664becd79e2db1
2014-04-06 19:37:48 +03:00
ee3945bd98
Kill superfluous spacing before semicolons
...
Change-Id: I53689e78221f3fe074e47d6b47f1a2c3fef96222
2014-04-06 19:37:48 +03:00
951ed199f1
Kill superfluous vertical whitespace
...
Change-Id: Ia1bb2b40c74efb17e655dd6f00d7ba48c16c65ae
2014-04-06 19:37:48 +03:00
190085dd4d
Work around MSC "'override' cannot be used with 'inline'" bug
...
Change-Id: I35170712b8f0c83ab35cb5ef7115a6dc434a7a4f
2014-03-26 17:46:10 +01:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
c8239a1dd4
Remove newly unused framework::LockHelper class
...
...and make LockHelper::getGlobalLock() FWI_DLLPUBLIC again (so there's a single
such lock, not one per library).
Change-Id: I0aed77333dc93cdf1c7dd7b96620fb7a8eb3dd64
2014-03-20 17:30:03 +01:00
250a4e8875
Remove newly unused framework::Guard
...
Change-Id: I49650bfd036c5df22f81c3e8cf30bc0795154a30
2014-03-20 17:30:02 +01:00
4ddb43bcf1
Turn odd framework::LockHelper::getGlobalLock() into an osl::Mutex
...
...and extract it to framework::GlobalLock::get().
The old lock was actually effectively two different locks,
LockHelper::getGloblaLock() and
LockHelper::getGlobalLock().getShareableOslMutex(), and both were used in
different places. These places all use the same single osl::Mutex instance now,
but hopefully that does not lead to problems (which it shouldn't, given the
documentation of LockHelper::getShareableOslMutex: "Sometimes we need a osl-
mutex for sharing with our uno helper ... What can we do? We must use a
different mutex member :-( I HOPE IT WORKS!").
Of course, the "TODO: This presumable should return the SolarMutex" still
applies.
Change-Id: I7caea3241d1b70a00272fe1f2214c071ef22cf2c
2014-03-20 17:30:02 +01:00
03fc5edba3
Remove newly unused framework::ThreadHelpBase
...
Change-Id: I75e7cfc8aa1f4e4e50a2e21c5f7596363594e179
2014-03-20 15:15:11 +01:00
07b32bc2bf
Consolidate framework::{Resetable,}Guard
...
Change-Id: I97290c2504992f4a92e6aeb71e02a2542dd35faa
2014-03-17 18:00:10 +01:00
a98d7543ad
No need for framework::LockHelper to derive from framework::IMutex
...
Change-Id: I677abeb9e313b983f750331ec925c24ade04e95b
2014-03-17 17:41:23 +01:00
4eb0625d01
Use LockHelper directly
...
Change-Id: I4d83ab49187590728326f4f60bb205d1d0b3dfe7
2014-03-17 17:37:40 +01:00
ab3acb7ef7
Consolidate framework::{Read,Write}Guard
...
...now that it is obvious that they both do the same
Change-Id: I6878acca4750ef4204fe32a695b6d9e1c5140115
2014-03-17 16:52:34 +01:00
803a8a04e9
Remove unused framework::WriteGuard::getMode
...
...and consequently unused framework::ELockMode
Change-Id: Icba47a9007e7250871be4bf5ee151504cad43f75
2014-03-17 16:52:34 +01:00
1997de8690
Remove single, unnecessary use of framework::WriteGuard::downgrade
...
...and its implementation, and the now-unused E_READLOCK cases.
Change-Id: I2df514f9351a1b63da3063c8db9892e11e9bf83b
2014-03-17 16:52:33 +01:00
571a34e350
Remove superfluous framework::LockHelper::{acquire,release{Read,Write}Access
...
Change-Id: I2f8b8c07b943f8aea47523db99a019c7c4541248
2014-03-17 16:52:33 +01:00
7cb41ae451
Remove no-op framework::LockHelper::downgradeWriteAccess
...
Change-Id: I26c8dbfb2ad3b159d3b32dea450e063f1552d714
2014-03-17 16:52:33 +01:00
23b13bce74
No need for framework::IRWLock interface
...
...of which framework::LockHelper is the only implementation
Change-Id: I235bb699ff26b1579803f617990fc4f71fe18b22
2014-03-17 16:52:33 +01:00
5f93d80b4a
Drop framework::INonCopyable duplication of boost::noncopyable
...
Change-Id: Ie4135353c7917fddf3efd15d0f3022b3aada8025
2014-03-17 16:52:33 +01:00
88c4f15deb
Remove unused framework::FairRWLock
...
Change-Id: I91adf908aaa399186ff69d3a07eb945aed0c90f5
2014-03-17 16:52:32 +01:00
fcbefea017
Remove visual noise from framework
...
Conflicts:
framework/inc/dispatch/oxt_handler.hxx
framework/inc/services/layoutmanager.hxx
framework/inc/tabwin/tabwindow.hxx
framework/source/dispatch/menudispatcher.cxx
framework/source/helper/dockingareadefaultacceptor.cxx
framework/source/helper/ocomponentaccess.cxx
framework/source/helper/ocomponentenumeration.cxx
framework/source/helper/oframes.cxx
framework/source/layoutmanager/toolbarlayoutmanager.hxx
framework/source/recording/dispatchrecorder.cxx
framework/source/services/desktop.cxx
framework/source/services/frame.cxx
framework/source/services/urltransformer.cxx
Change-Id: Ibb04e3f6f0796e7f2be16dcce38542f8b90708d4
Reviewed-on: https://gerrit.libreoffice.org/8265
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-02-26 14:41:41 -06:00
65191cda81
bool improvements
...
Change-Id: I757e19313576d2c3d13af1cb720f182f0de91613
2014-01-27 10:47:32 +01:00
b55259eeb5
typo fixes
...
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-20 15:55:00 +01:00
15b5412fad
fixincludeguards.sh: framework
...
Change-Id: Ia6f3cb21977095df45a176db2bf68f508c70191c
2013-11-05 09:28:53 +01:00
7f436c1fd3
typo fixes in comments
...
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
1817936b28
Bin unused remains of framework's own "debug framework"
...
Change-Id: I71937debf674ff11173d7d8fa5aa43dc12234ce6
2013-09-09 00:29:23 +03:00
ee47dfa474
LockHelper::getGlobalLock is never called with an argument
...
Change-Id: I90b431345d791c887f9047258a6f439bcf222784
2013-05-14 14:41:55 +02:00
4af8a94a96
Remove unused LOCKTYPE_FRAMEWORK env var override
...
...which means that only the E_SOLARMUTEX part of LockHelper is ever used.
Change-Id: Ibff0bda324af67c85cbd2975d308c612c66e5052
2013-05-14 14:41:55 +02:00
61ac80a6f6
ENABLE_MUTEXDEBUG is never defined
...
Change-Id: I533cc7041177cceff14d1e44e4cd1d25d5e94c11
2013-05-14 14:41:55 +02:00
11fd73acce
SolarMutex does not belong into the URE interface
...
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx. It looks
like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an
abstract interface to be used to implement a SolarMutex" put it here in the
first place.
I do not consider this an incompatible change really, as no external URE client
code should have used SolarMutex anyway.
(Also included some clean up, like removing unused
{Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places
it is used.)
Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14 14:41:54 +02:00
1264480bc3
fdo#60724 correct spelling
...
Change-Id: I3d978cb657647b4a4e9709258c6a6a4ac1d339a9
2013-04-15 05:39:31 +02:00
435f5e30c9
fdo#60724 correct spelling
...
Change-Id: I7318a9f4f3410edf4dbe67bf08f31682fcb4edc7
2013-04-15 05:10:29 +02:00
f5ca04caca
Related to fdo#60724: correct spelling
...
Using the autocorrect list of LibreOffice
extras/source/autotext/lang/en-US/acor/DocumentList.xml
Change-Id: I8b93969bc0742c2e95b8b7db3c4c37691e8d3657
Script: http://pastebin.ca/2327716
2013-03-03 17:14:16 +01:00
1443a9f7ab
[Uu]sefull -> [Uu]seful
...
Change-Id: I5dad83789ff9b6815561208679a5e19821041e1f
2013-02-22 11:12:33 +01:00
17ff7b41d1
re-base on ALv2 code. Includes:
...
Patches contributed by: Armin Le Grand.
#118558# Correcting OLE attributes of LO3.4 at load time by loading as OOo3.3, details see task.
http://svn.apache.org/viewvc?view=revision&revision=1195906
#118485# - Styles for OLEs are not saved.
http://svn.apache.org/viewvc?view=revision&revision=1182166
#118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles
http://svn.apache.org/viewvc?view=revision&revision=1293316
#119337# Solves the wrong get/setPropertyValue calls in
SvxShapeText (and thus in SvxOle2Shape)
http://svn.apache.org/viewvc?view=revision&revision=1344156
Patches contributed by Mathias Bauer (and others)
gnumake4 work variously
http://svn.apache.org/viewvc?view=revision&revision=1394707
http://svn.apache.org/viewvc?view=revision&revision=1394326
cws mba34issues01: #i117717#: remove wrong assertion
http://svn.apache.org/viewvc?view=revision&revision=1172349
Patch contributed by Herbert Duerr
goodbye Registration and License dialogs, don't let the door hit you
http://svn.apache.org/viewvc?view=revision&revision=1172613
help gcc 4.6.0 on 32bit ubuntu 11.10"
http://svn.apache.org/viewvc?view=revision&revision=1245357
Do not add targets for junit tests when junit is disabled.
Patch contributed by Andre Fischer
http://svn.apache.org/viewvc?view=revision&revision=1241508
Revert "sb140: #i117082# avoid unncessary static class data members
commit 21d97438e2944861e26e4984195f959a0cce1e41.
remove obsolete FreeBSD visibility special case.
retain consolidated BSD bridge code, remove OS/2 pieces.
2012-11-15 16:06:08 +00:00
2beba8f93e
reduce ascii noise and useless comments
...
Change-Id: I317058e3b25cebb7c1d89361636261c5f16a84d4
2012-08-08 13:53:54 +02:00
49ad17e2b1
remove include comments and boxes
...
Change-Id: I9ccf664e8f75a68b1b87c2b29ae617a90d0741a7
2012-08-08 13:53:53 +02:00
ecf943247f
re-base on ALv2 code.
...
Change-Id: I8018d9b5fa01d1720c0392dc5fdc4a0656f25a35
2012-06-22 09:51:05 +01:00
b9042fad7c
re-base on ALv2 code.
...
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
68f2753710
.h files don't need executable bits
2012-03-23 21:58:13 +01:00
6e67c03dc0
Enable -Wnon-virtual-dtor for GCC 4.6
...
...which has the necessary features to support it.
Change a lot of classes to either contain a protected non-virtual dtor
(which is backwards compatible, so even works for cppumaker-generated
UNO headers) or a public virtual one.
cppuhelper/propertysetmixin.hxx still needs to disable the warning, as
the relevant class has a non-virtual dtor but friends, which would still
cause GCC to warn.
Includes a patch for libcmis, intended to be upstreamed.
2012-03-14 13:32:02 +01:00
ad2eb6c4ba
Less succes, more success
2011-12-08 09:06:09 +01:00
e60d365c86
drop bogus executable flag from [ch]xx/bas/asm files
2011-03-29 21:40:28 +01:00
