Commit Graph

3724 Commits

Author SHA1 Message Date
8dfd4a3a34 Refactor of Menu classes from VCL module and Framework module.
Change-Id: I47aa65d3851692d38ee0741031d72fb02e9da785
2012-11-14 13:52:38 +01:00
6f79b2e35b Revert "if/else placement"
This reverts commit fd1e39cad891282e4343be4d5e80125d7954b347.
I don't see how this cosmetic change can actually affect anything,
but tinderbox #27 seems to claim one of the unittests fails because
of this one single commits, so let's see.
2012-11-06 14:46:04 +01:00
fd1e39cad8 if/else placement
Change-Id: I1f1cd86b66123f9c14423de685263f295629e4b2
2012-11-03 13:24:06 +01:00
0ac9a10d31 fdo#46808, Deprecate configuration::ConfigurationProvider old-style service
...in favor of existing new-style configuration::theDefaultProvider singleton.

Theoretically, ConfigurationProvider instances can be created with specific
Locale and EnableAsync arguments, but this is hardly used in practice, and thus
effectively all uses of the ConfigurationProvider service use the
theDefaultProvider instance, anyway.

theDefaultProvider is restricted to the XMultiServiceFactory interface, while
ConfigurationProvider also makes available XComponent.  However, dispose must
not be called manually on theDefaultProvider singleton anyway, and calls to
add-/removeEventListener are so few (and in dubious code that should better be
cleaned up) that requiring an explicit queryInterface does not really hurt
there.

This commit originated as a patch by Noel Grandin to "Adapt
configuration::ConfigurationProvider UNO service to new style [by creating] a
merged XConfigurationProvider interface for this service to implement."  It was
then modified by Stephan Bergmann by deprecating ConfigurationProvider instead
of adding XConfigurationProvider and by replacing calls to
ConfigurationProvider::create with calls to theDefaultProvider::get.

Change-Id: I9c16700afe0faff1ef6f20338a66bd7a9af990bd
2012-10-31 15:31:36 +01:00
96b60cf69b Improve previous commit slightly
Change-Id: I01e007a9e1dee12a8081e8b165fa7e090d594612
2012-10-29 17:32:56 +01:00
39c556da31 fdo#46808, Create new-style frame::AutoRecovery service
The service already existed, it just did not have an IDL file.
2012-10-29 17:32:55 +01:00
7f4e5c8c6f Improve previous commit slightly
Change-Id: I198f25f556efd4ec3f6582cf8bfb40675c6e3570
2012-10-29 17:32:55 +01:00
9b63e4e6e4 fdo#46808, use service constructor for frame::DispatchRecorderSupplier 2012-10-29 17:32:54 +01:00
ec4a5ba7f2 Improve previous commit slightly
Change-Id: I25595ea67eb521e118f4b00337ef2a55dc52256a
2012-10-29 17:32:54 +01:00
3f8f2f4a52 inline #define that is only used in one place 2012-10-29 17:32:53 +01:00
5b5f2b3edc Improve previous commit slightly
Change-Id: If39ae761165bc4debd3c7d994be0446149f2c4ac
2012-10-29 17:32:52 +01:00
fecbe0ec96 inline #define that is only used in one place 2012-10-29 17:32:52 +01:00
73fc75bf80 ditch SYNCHRONIZED_START/END
Change-Id: I1c0c015f371346efc5712ead7abe9e7f2ec0f9d0
2012-10-25 09:09:26 +01:00
13bedc55b1 fdo#46808, use service constructor for frame::GlobalEventBroadcaster
Add document::XEventBroadcaster interface to XGlobalEventBroadcaster,
because a client uses it, and the service always implements it.

This is safe to do because we haven't released an LO version with
XGlobalEventBroadcaster in it yet.
2012-10-24 17:59:30 +02:00
22d3fb11c6 Related fdo#46808: Improve previous commit slightly
Change-Id: Ie81ae8a75847fdbc70e69349d0646f0bb558b7d0
2012-10-24 17:59:30 +02:00
b8abd03688 fdo#46808, use service constructor for frame::DispatchHelper 2012-10-24 17:59:30 +02:00
900dc2b70d Related fdo#46808: Improve previous commit slightly
Change-Id: If633be759ab2aa4f42548f02a58fedb858783551
2012-10-24 17:59:30 +02:00
3bf3b01dfc inline a #define that it only used in one cxx file 2012-10-24 17:59:30 +02:00
d26f3acf28 fdo#46808, use service constructor for system::SystemShellExecute 2012-10-24 17:59:29 +02:00
33a0f8ce65 fdo#46808, Adapt awt::Toolkit UNO service to new style
Create a merged XToolkit2 interface for this service to implement.
Which is backwards-compatible, but does not require creating a new service.

Also mark sub-interfaces as non-optional.

Change-Id: I278d0288e92be277033013302267cf93f7d70480
2012-10-24 16:49:49 +02:00
e8aa70b5d4 fdo#46808, convert comphelper::ConfigurationHelper to XComponentContext
Convert the helper methods to take an XComponentContext parameter,
instead of XMultiServiceFactory.

Change-Id: I9f0098af37b91f107d8799f14caa04756eac82b1
2012-10-24 11:29:53 +02:00
5e9a7f1919 Related fdo#46808: Improve previous commit slightly
Change-Id: Ib4f44f745f7e3e2e1403d905cc16bee4c487b0b4
2012-10-23 17:44:17 +02:00
432c0f4917 fdo#46808, use service constructor for frame::ModuleManager
Change-Id: Iae2bd22a22213274d4a7697345b879f6573a30f0
2012-10-23 17:44:16 +02:00
b493b5a284 fdo#46808, use service constructor for xml::sax::Writer
Change-Id: I2b216a0e3a9694568642e9de2f4f43ecd682555f
2012-10-23 17:44:16 +02:00
5aa2cd1d3f fdo#46808, use service constructor for uri::UriReferenceFactory
Change-Id: I4e72bf5880fa28cb96d93ede7730a63220af7fa6
2012-10-23 11:45:47 +02:00
c348df5635 loplugin: various warnings
Change-Id: I605bffb518d804ee69edda5e7641e13e4c14ef01
2012-10-22 20:20:39 +01:00
3b76773b0e loplugin: misleading else if indent 2012-10-21 18:12:08 +01:00
a7efb9b8dd loplugin: fix some indents and unused OUStrings
Change-Id: I1d7256eea7a79453d3cdb85d1edcf824d58d775e
2012-10-14 16:37:00 +01:00
5f12d6d42d loplugin: what is it with the weird-ass else placement in framework
Change-Id: I81809a80242457147dba716daa92b83726f732ba
2012-10-13 11:47:19 +01:00
46a418af78 loplugin: bad else if placement
Change-Id: I56e88a675adf37fdf52637ecbff6778a5215a16a
2012-10-12 16:41:38 +01:00
f7a24eff2d mark lcl_ functions static or rename them if they are not local at all
http://lists.freedesktop.org/archives/libreoffice/2012-October/039639.html

Change-Id: I231f0b367bf0b513c6c1ce4c4cfdb7c3dc8660d5
2012-10-12 13:34:47 +02:00
2dd0712a12 loplugin: unused Strings
Change-Id: Ie9c888a48716e4bfd24ae78eef5f6e4a54dd1810
2012-10-12 09:22:23 +01:00
586895f8fa loplugin: more unused OUString and misleading indentation
Change-Id: Ic21ca9e14520f4f16c2d665a07a79ee1a46ab91d
2012-10-11 21:16:27 +01:00
6f1bdda2d2 loplugin: more unused OUStrings and so forth
Change-Id: I4f3a51e1fd3ddca9442022a7134306fbf32e13ae
2012-10-11 15:01:47 +01:00
7d044841e8 loplugin: misleading indent
Change-Id: Ia3c27c2b2e869af09557ad50e51a65894943947a
2012-10-11 11:15:41 +01:00
19d37e5c4b loplugin: unused O[U]Strings
Change-Id: I020149a3073d8479887d108465cf5d3b727588d7
2012-10-10 09:29:00 +01:00
8113588c35 cppcheck: unreadVariable.
aLangMap is a std::map that is written but never used, so drop it.

Change-Id: I8f5184c58fbe812beab8580349535920645e062e
Reviewed-on: https://gerrit.libreoffice.org/781
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-10-06 22:14:21 +00:00
a20f9a410f fdo#46808, Adapt xml::sax::XParser UNO service to new style
The xml.sax.Parser service already existed, it just did not have
a new-style service to create it.

Change-Id: I6f145a7504ff9e149c802f723991954a2801cbc9
2012-10-04 16:29:53 +02:00
36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
c2ca6fabd1 Use comphelper::getComponentContext
...and some further clean up.

Change-Id: Id294c0f38fe0041646fc86cacbd2e19734c746a9
2012-09-29 18:18:28 +02:00
2f002e3a49 having two SetPosSizePixel is a blasted nuisance
Lets rename the multiargument SetPosSizePixel to
setPosSizePixel drop the various using Window::SetPosSizePixel
and work towards de-virtualizing SetPosSizePixel/SetPosPixel and
SetSizePixel and doing the work in a virtual setPosSizePixel

Change-Id: I7057654168001b67becee1791e97f9e9dc01f7b8
2012-09-28 08:48:39 +01:00
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
1b034ebe04 fdo#41440, fdo#50296: start center: force black text color
Change-Id: I13834d3c0385e1a75d2d66d1622a966c66b9aab2
2012-09-22 14:32:05 +04:00
b40f95f915 fdo#34392: request button size after vcl has updated its settings
Change-Id: I1810562a2c0c09404271be5b910f5811fce3e465
2012-09-22 14:32:05 +04:00
03a9f139bd ComponentContext::getUnoContext -> getComponentContext simplification
...and some further clean-up.

Change-Id: If5dce53e382b56390c502d0d0d93fc06cbfe33ea
2012-09-19 13:16:38 +02:00
9ac86f484b Improvement on previous commit, UCB clean up
* As UCB is only ever initialized with "Local"/"Office", remove this
  configuration vector completely.  The "create" ctor creates an instance
  internally initialized with those "Local"/"Office" keys.  Special (test) code
  can still instantiate an uninitialized one via plain createInstance.  And for
  backwards compatilibity process startup still ensures to create an initialized
  instance early, in case there is still code out there (in extensions) that
  later calls plain createInstance and expects to get the already-initialized
  (single) instance.

* XInitialization is an "implementation detail" of the UniversalContentBroker
  service, do not expose in XUniversalContentBroker.

* ucbhelper/configurationkeys.hxx is no longer needed and is removed.

* ucbhelper/contentbroker.hxx is an empty wrapper and is removed; however, that
  requires ucbhelper::Content constructors to take explicit XComponentContext
  arguments now.

* The only remaining code in ucbhelper/source/client/contentbroker.cxx is
  Android-only InitUCBHelper.  Is that relevant still?

Change-Id: I3f7bddd0456bffbcd13590c66d9011915c760f28
2012-09-14 18:24:49 +02:00
3357115adf Unused #includes
Change-Id: If5c8ee05ef84c03a9cec6ef428256e17b33f073e
2012-09-12 17:51:27 +02:00
8a0d4ff715 Disable the experimental orcus-based csv filter for now.
Change-Id: Iba8b36aaa19bbf2a9cb632fb6fe586b27ae27a7a
2012-09-07 09:10:40 -04:00
a663931200 First cut on integrating liborcus into libreoffice tree....
It introduces the 'FilterProvider' property in the media descriptor
to optionally bypass the normal loading process and let the external
filter provider to handle the loading.

For now I'm overwriting the csv import filter just to see how this
could work just as an experiment.

Orcus still needs a lot of work, and it crashes very often at the
moment.

Change-Id: I11b34572c71073144804a7d0dd5176c8067d8deb
2012-09-07 09:10:34 -04:00
6a1c29d7ef offapi: move css.ui.UICommandDescription to css.frame.UICommandDescription:
The service implementation used "com.sun.star.frame.UICommandDescription"
since forever, so the IDL file was essentially wrong documentation.
But since 7a464263cc5c2ca2b7128734ff4860e02d662818 converted the service
to new-style, it cannot be instantated any more and e.g. clicking on
Tools->Customize crashes.
(Adapting the implementation instead would be an incompatible change.)

Change-Id: I564bddaf3836827f5b72360a2bde19d6158b7ba5
2012-09-06 11:13:42 +02:00