Commit Graph

668 Commits

Author SHA1 Message Date
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
2c5b3e7764 Resolves: #i122368# convert inc paths into short form on windows...
to avoid problem with ucpp

(cherry picked from commit 6e370ddd6b532e7bf12df3aa52f93913f4ea8348)

Conflicts:
	idlc/source/options.cxx

Change-Id: Ia8c7dc3a9a7df68a483dd106cd47c8624952aeae
2014-06-10 16:26:08 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
6f6f8aff63 fix-includes.pl: idlc
Change-Id: I62da508151614277d59e831c7506c3ec715348f4
2014-05-19 20:04:27 +02:00
0c49320772 Revert "CID#705985 ensure umask for mkstemp"
This reverts commit 5f5a981dd6df406b7bbddd88fa0b701b5a8d2246.  Coverity warning
about mkstemp without umask appears to be bogus (cf.
<https://communities.coverity.com/message/6516> "Why are uses of mkstemp
'without securely setting umask first' being flagged?) and calling umask is not
MT-safe, see fdo#60338 "FILESAVE: Saved files have incorrect permissions on
linux."
2014-05-13 10:51:04 +02:00
19c4d8d2fb Many spelling fixes: directories h* - p*.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done  before.

(cherry picked from commit 11a1ff6144521aeabb0c6db25c89a2ac31bedee0)

Conflicts:
	external/libxmlsec/xmlsec1-customkeymanage.patch
	hwpfilter/source/hwpeq.cxx
	icc/README
	icu/createmak.pl
	idl/source/objects/object.cxx
	idlc/inc/idlc/errorhandler.hxx
	include/jvmfwk/framework.h
	include/oox/helper/propertyset.hxx
	instsetoo_native/inc_ure/windows/msi_templates/_Validat.idt
	javainstaller2/src/JavaSetup/org/openoffice/setup/Controller/PrologueCtrl.java
	javainstaller2/src/JavaSetup/org/openoffice/setup/Installer/LinuxInstaller.java
	javainstaller2/src/JavaSetup/org/openoffice/setup/Installer/SolarisInstaller.java
	javainstaller2/src/JavaSetup/org/openoffice/setup/InstallerHelper/LinuxHelper.java
	javainstaller2/src/JavaSetup/org/openoffice/setup/SetupData/ProductDescription.java
	javainstaller2/src/JavaSetup/org/openoffice/setup/Util/Controller.java
	javainstaller2/src/JavaSetup/org/openoffice/setup/Util/ExecuteProcess.java
	javaunohelper/com/sun/star/comp/helper/SharedLibraryLoader.java
	javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java
	jurt/com/sun/star/comp/servicemanager/ServiceManager.java
	jvmfwk/plugins/sunmajor/pluginlib/sunversion.cxx
	jvmfwk/source/elements.cxx
	jvmfwk/source/elements.hxx
	l10ntools/inc/wtranode.hxx
	l10ntools/inc/wtratree.hxx
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/Convert.java
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/ConverterException.java
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/FileMaker.java
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/GSIWriter.java
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/GSIandSDFMerger.java
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFReader.java
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/SDFWriter.java
	l10ntools/java/l10nconv/java/com/sun/star/tooling/converter/XLIFFWriter.java
	l10ntools/scripts/localize.pl
	l10ntools/scripts/localize_old.pl
	l10ntools/source/cfgmerge.cxx
	l10ntools/source/export.cxx
	l10ntools/source/filter/merge/FCFGMerge.java
	l10ntools/source/filter/merge/Merger.java
	l10ntools/source/filter/utils/Cache.java
	l10ntools/source/filter/utils/ConfigHelper.java
	l10ntools/source/filter/utils/FileHelper.java
	l10ntools/source/filter/utils/XMLHelper.java
	l10ntools/source/merge.cxx
	l10ntools/source/tagtest.cxx
	l10ntools/source/xmlparse.cxx
	l10ntools/source/xrmmerge.cxx
	libtextcat/libtextcat-2.2.patch
	libxml2/libxml2-long-path.patch
	linguistic/inc/linguistic/misc.hxx
	linguistic/source/lngsvcmgr.cxx
	migrationanalysis/src/driver_docs/allstrings.ulf
	migrationanalysis/src/driver_docs/sources/AnalysisDriver.bas
	migrationanalysis/src/driver_docs/sources/CommonMigrationAnalyser.bas
	migrationanalysis/src/driver_docs/sources/word/MigrationAnalyser.cls
	migrationanalysis/src/msokill/msokill.cpp
	migrationanalysis/src/wizard/Wizard.frm
	odk/examples/DevelopersGuide/Accessibility/EventHandler.java
	odk/examples/DevelopersGuide/Accessibility/EventListenerProxy.java
	odk/examples/DevelopersGuide/Accessibility/GraphicalDisplay.java
	odk/examples/DevelopersGuide/Forms/DataAwareness.java
	odk/examples/DevelopersGuide/Forms/KeyGenerator.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/DocumentView.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/FunctionHelper.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/Interceptor.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/NativeView.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java
	odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/ViewContainer.java
	odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/AsciiReplaceFilter.java
	odk/examples/DevelopersGuide/OfficeDev/FilterDevelopment/AsciiFilter/FilterOptions.java
	odk/examples/cpp/complextoolbarcontrols/Makefile
	odk/setsdkenv_windows.template
	offapi/com/sun/star/accessibility/AccessibleEventId.idl
	offapi/com/sun/star/accessibility/AccessibleEventObject.idl
	offapi/com/sun/star/accessibility/AccessibleRelationType.idl
	offapi/com/sun/star/accessibility/XAccessible.idl
	offapi/com/sun/star/accessibility/XAccessibleRelationSet.idl
	offapi/com/sun/star/accessibility/XAccessibleStateSet.idl
	offapi/com/sun/star/animations/Event.idl
	offapi/com/sun/star/animations/XAnimationNode.idl
	offapi/com/sun/star/awt/AccessibleListBoxList.idl
	offapi/com/sun/star/awt/XLayoutFlow.idl
	offapi/com/sun/star/awt/XMessageBoxFactory.idl
	offapi/com/sun/star/awt/XPopupMenu.idl
	offapi/com/sun/star/awt/grid/XGridColumn.idl
	offapi/com/sun/star/chart/ChartAxis.idl
	offapi/com/sun/star/chart2/data/TabularDataProviderArguments.idl
	offapi/com/sun/star/chart2/data/XDatabaseDataProvider.idl
	offapi/com/sun/star/configuration/AdministrationProvider.idl
	offapi/com/sun/star/configuration/ConfigurationRegistry.idl
	offapi/com/sun/star/configuration/backend/XBackendChangesNotifier.idl
	offapi/com/sun/star/datatransfer/XDataFormatTranslator.idl
	offapi/com/sun/star/datatransfer/clipboard/RenderingCapabilities.idl
	offapi/com/sun/star/deployment/InvalidRemovedParameterException.idl
	offapi/com/sun/star/document/DocumentInfo.idl
	offapi/com/sun/star/document/EmptyUndoStackException.idl
	offapi/com/sun/star/document/EventObject.idl
	offapi/com/sun/star/document/ExtendedTypeDetection.idl
	offapi/com/sun/star/document/ExtendedTypeDetectionFactory.idl
	offapi/com/sun/star/document/FilterFactory.idl
	offapi/com/sun/star/document/MediaDescriptor.idl
	offapi/com/sun/star/document/NoSuchFilterRequest.idl
	offapi/com/sun/star/document/OfficeDocument.idl
	offapi/com/sun/star/document/TypeDetection.idl
	offapi/com/sun/star/document/UndoContextNotClosedException.idl
	offapi/com/sun/star/document/XExtendedFilterDetection.idl
	offapi/com/sun/star/document/XFilter.idl
	offapi/com/sun/star/document/XInteractionFilterSelect.idl
	offapi/com/sun/star/document/XTypeDetection.idl
	offapi/com/sun/star/drawing/Hatch.idl
	offapi/com/sun/star/drawing/XDrawPages.idl
	offapi/com/sun/star/drawing/XShapeBinder.idl
	offapi/com/sun/star/drawing/framework/XConfigurationControllerRequestQueue.idl
	offapi/com/sun/star/drawing/framework/XRelocatableResource.idl
	offapi/com/sun/star/embed/ElementModes.idl
	offapi/com/sun/star/embed/EntryInitModes.idl
	offapi/com/sun/star/embed/Storage.idl
	offapi/com/sun/star/embed/StorageFactory.idl
	offapi/com/sun/star/embed/StorageStream.idl
	offapi/com/sun/star/embed/XCommonEmbedPersist.idl
	offapi/com/sun/star/embed/XEmbedObjectClipboardCreator.idl
	offapi/com/sun/star/embed/XEmbeddedClient.idl
	offapi/com/sun/star/embed/XInplaceClient.idl
	offapi/com/sun/star/embed/XInplaceObject.idl
	offapi/com/sun/star/embed/XInsertObjectDialog.idl
	offapi/com/sun/star/embed/XPersistanceHolder.idl
	offapi/com/sun/star/embed/XStorage.idl
	offapi/com/sun/star/embed/XTransactionBroadcaster.idl
	offapi/com/sun/star/embed/XTransactionListener.idl
	offapi/com/sun/star/form/FormComponents.idl
	offapi/com/sun/star/form/XSubmitListener.idl
	offapi/com/sun/star/form/binding/BindableDataAwareControlModel.idl
	offapi/com/sun/star/form/binding/BindableDatabaseListBox.idl
	offapi/com/sun/star/form/component/DatabaseComboBox.idl
	offapi/com/sun/star/form/component/DatabaseFormattedField.idl
	offapi/com/sun/star/form/component/DatabasePatternField.idl
	offapi/com/sun/star/form/component/DatabaseTextField.idl
	offapi/com/sun/star/form/component/GridControl.idl
	offapi/com/sun/star/frame/Components.idl
	offapi/com/sun/star/frame/ContentHandler.idl
	offapi/com/sun/star/frame/ContentHandlerFactory.idl
	offapi/com/sun/star/frame/Desktop.idl
	offapi/com/sun/star/frame/DispatchDescriptor.idl
	offapi/com/sun/star/frame/DispatchProvider.idl
	offapi/com/sun/star/frame/DispatchRecorder.idl
	offapi/com/sun/star/frame/Frame.idl
	offapi/com/sun/star/frame/FrameActionEvent.idl
	offapi/com/sun/star/frame/FrameLoaderFactory.idl
	offapi/com/sun/star/frame/ProtocolHandler.idl
	offapi/com/sun/star/frame/XControlNotificationListener.idl
	offapi/com/sun/star/frame/XDesktop.idl
	offapi/com/sun/star/frame/XDispatchRecorderSupplier.idl
	offapi/com/sun/star/frame/XDocumentTemplates.idl
	offapi/com/sun/star/frame/XFrame.idl
	offapi/com/sun/star/frame/XFrameLoader.idl
	offapi/com/sun/star/frame/XInterceptorInfo.idl
	offapi/com/sun/star/frame/XRecordableDispatch.idl
	offapi/com/sun/star/frame/XStatusbarController.idl
	offapi/com/sun/star/frame/XStorable2.idl
	offapi/com/sun/star/frame/XSynchronousDispatch.idl
	offapi/com/sun/star/frame/XTerminateListener2.idl
	offapi/com/sun/star/graphic/GraphicObject.idl
	offapi/com/sun/star/graphic/XGraphicObject.idl
	offapi/com/sun/star/inspection/XNumericControl.idl
	offapi/com/sun/star/inspection/XObjectInspectorModel.idl
	offapi/com/sun/star/inspection/XPropertyHandler.idl
	offapi/com/sun/star/installation/XProtocolHandlerCheck.idl
	offapi/com/sun/star/installation/protocols.idl
	offapi/com/sun/star/linguistic2/SpellFailure.idl
	offapi/com/sun/star/linguistic2/XLinguServiceManager.idl
	offapi/com/sun/star/mail/XMailServer.idl
	offapi/com/sun/star/mozilla/XPluginInstance.idl
	offapi/com/sun/star/mozilla/XPluginInstanceSyncPeer.idl
	offapi/com/sun/star/packages/zip/ZipIOException.idl
	offapi/com/sun/star/presentation/OutlineView.idl
	offapi/com/sun/star/presentation/XPresentation2.idl
	offapi/com/sun/star/presentation/XSlideShow.idl
	offapi/com/sun/star/presentation/XSlideShowController.idl
	offapi/com/sun/star/report/XFunction.idl
	offapi/com/sun/star/report/XFunctionsSupplier.idl
	offapi/com/sun/star/report/XReportComponent.idl
	offapi/com/sun/star/report/XReportDefinition.idl
	offapi/com/sun/star/report/meta/XFunctionManager.idl
	offapi/com/sun/star/resource/XStringResourcePersistence.idl
	offapi/com/sun/star/resource/XStringResourceWithLocation.idl
	offapi/com/sun/star/resource/XStringResourceWithStorage.idl
	offapi/com/sun/star/sdb/DataSettings.idl
	offapi/com/sun/star/sdb/ErrorCondition.idl
	offapi/com/sun/star/sdb/SQLContext.idl
	offapi/com/sun/star/sdb/Table.idl
	offapi/com/sun/star/sdb/XRowSetApproveListener.idl
	offapi/com/sun/star/sdb/application/XDatabaseDocumentUI.idl
	offapi/com/sun/star/sdb/tools/XConnectionTools.idl
	offapi/com/sun/star/sdbc/DataType.idl
	offapi/com/sun/star/sdbc/XDatabaseMetaData.idl
	offapi/com/sun/star/sdbcx/Descriptor.idl
	offapi/com/sun/star/security/DocumentSignatureInformation.idl
	offapi/com/sun/star/sheet/AccessibleSpreadsheetDocumentView.idl
	offapi/com/sun/star/sheet/AccessibleSpreadsheetPageView.idl
	offapi/com/sun/star/sheet/DatabaseRange.idl
	offapi/com/sun/star/smarttags/XSmartTagAction.idl
	offapi/com/sun/star/table/AccessibleTableView.idl
	offapi/com/sun/star/table/CellProperties.idl
	offapi/com/sun/star/table/CellRangeListSource.idl
	offapi/com/sun/star/table/CellValueBinding.idl
	offapi/com/sun/star/table/XMergeableCellRange.idl
	offapi/com/sun/star/task/DocumentPasswordRequest.idl
	offapi/com/sun/star/task/JobExecutor.idl
	offapi/com/sun/star/task/MasterPasswordRequest.idl
	offapi/com/sun/star/task/PasswordRequest.idl
	offapi/com/sun/star/task/XJob.idl
	offapi/com/sun/star/text/AccessiblePageView.idl
	offapi/com/sun/star/text/AccessibleTextDocumentView.idl
	offapi/com/sun/star/text/LineNumberingProperties.idl
	offapi/com/sun/star/text/NumberingRules.idl
	offapi/com/sun/star/text/XRelativeTextContentRemove.idl
	offapi/com/sun/star/text/textfield/Database.idl
	offapi/com/sun/star/text/textfield/SetExpression.idl
	offapi/com/sun/star/text/textfield/docinfo/Description.idl
	offapi/com/sun/star/text/textfield/docinfo/Info0.idl
	offapi/com/sun/star/text/textfield/docinfo/Info1.idl
	offapi/com/sun/star/text/textfield/docinfo/Info2.idl
	offapi/com/sun/star/text/textfield/docinfo/Info3.idl
	offapi/com/sun/star/text/textfield/docinfo/Keywords.idl
	offapi/com/sun/star/text/textfield/docinfo/Revision.idl
	offapi/com/sun/star/text/textfield/docinfo/Subject.idl
	offapi/com/sun/star/text/textfield/docinfo/Title.idl
	offapi/com/sun/star/ucb/CommandFailedException.idl
	offapi/com/sun/star/ucb/Content.idl
	offapi/com/sun/star/ucb/ContentAction.idl
	offapi/com/sun/star/ucb/FetchError.idl
	offapi/com/sun/star/ucb/FetchResult.idl
	offapi/com/sun/star/ucb/HierarchyDataSource.idl
	offapi/com/sun/star/ucb/InteractiveFileIOException.idl
	offapi/com/sun/star/ucb/SearchRecursion.idl
	offapi/com/sun/star/ucb/UniversalContentBroker.idl
	offapi/com/sun/star/ucb/XAnyCompare.idl
	offapi/com/sun/star/ucb/XCachedContentResultSetFactory.idl
	offapi/com/sun/star/ucb/XCachedDynamicResultSetFactory.idl
	offapi/com/sun/star/ucb/XContentIdentifierMapping.idl
	offapi/com/sun/star/ui/UIElementType.idl
	offapi/com/sun/star/ui/dialogs/FilePicker.idl
	offapi/com/sun/star/ui/dialogs/FolderPicker.idl
	offapi/com/sun/star/util/PathSubstitution.idl
	offapi/com/sun/star/util/XChangesNotifier.idl
	offapi/com/sun/star/util/XCloseBroadcaster.idl
	offapi/com/sun/star/util/XCloseListener.idl
	offapi/com/sun/star/util/XCloseable.idl
	offapi/com/sun/star/util/XStringSubstitution.idl
	offapi/com/sun/star/util/XTextSearch.idl
	offapi/com/sun/star/util/XURLTransformer.idl
	offapi/com/sun/star/xforms/XModel.idl
	offapi/com/sun/star/xml/sax/XFastAttributeList.idl
	offapi/com/sun/star/xml/sax/XFastParser.idl
	officecfg/registry/data/org/openoffice/Office/Labels.xcu
	officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
	officecfg/registry/schema/org/openoffice/Office/Common.xcs
	officecfg/registry/schema/org/openoffice/Office/Embedding.xcs
	officecfg/registry/schema/org/openoffice/Office/ExtensionDependencies.xcs
	officecfg/registry/schema/org/openoffice/Office/ExtensionManager.xcs
	officecfg/registry/schema/org/openoffice/Office/Histories.xcs
	officecfg/registry/schema/org/openoffice/Office/OptionsDialog.xcs
	officecfg/registry/schema/org/openoffice/Office/Paths.xcs
	officecfg/registry/schema/org/openoffice/Office/PresenterScreen.xcs
	officecfg/registry/schema/org/openoffice/Office/TabBrowse.xcs
	officecfg/registry/schema/org/openoffice/Office/UI.xcs
	officecfg/registry/schema/org/openoffice/Office/UI/Sidebar.xcs
	officecfg/registry/schema/org/openoffice/Office/UI/WindowState.xcs
	officecfg/registry/schema/org/openoffice/Office/WebWizard.xcs
	officecfg/registry/schema/org/openoffice/Office/Writer.xcs
	officecfg/registry/schema/org/openoffice/Setup.xcs
	officecfg/registry/schema/org/openoffice/TypeDetection/Types.xcs
	oox/source/xls/sheetdatabuffer.cxx
	package/source/xstor/xstorage.cxx
	padmin/source/padialog.src
	postprocess/signing/signing.pl
	pyuno/source/module/pyuno_module.cxx

Change-Id: I60c7b6d661ff803b5e9214ac7fefb32772ef19a7
2014-04-30 17:11:30 +01:00
c12bc7f894 fixincludeguards.sh: idl and idlc
Change-Id: I665e901eb6f65308b8f130da1c6da95bc3255490
2014-04-19 11:10:12 +02:00
70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
9afdc72df6 callcatcher: update unused code
Change-Id: I48990c044e4583e835f3e995527ba423e8c459fb
2014-03-24 12:12:22 +00:00
a52c42ae05 loplugin:literaltoboolconversion
Change-Id: I513aeeabbb4d6fc48b6a95e034c311a454dd5ca7
2014-03-12 16:24:42 +01:00
ec689e4561 coverity#707935 Uninitialized scalar field
Change-Id: I7c957419b72cc97dbec819c51acb521bcd716624
2014-03-08 20:28:02 +00:00
361774e910 idlc: sal_Bool -> bool
Change-Id: Ibeed903d73eb8b3fce7b8c6021c9107437a8c813
2014-02-17 17:55:17 +01:00
a4285867cd Typo: atribute(s) -> attribute(s)
Change-Id: I5434402e372c4567b2c3f96f5c175618ba3e5cfb
2014-02-06 21:32:04 +01:00
89420ff310 Fix spelling errror
Change-Id: Ie5fc19fa223942e31899408324beb2e15c1d7bef
2014-02-06 19:16:56 +02:00
8e71d9400b Remove UNOIDL "array" and "union" vaporware from idlc
Change-Id: Iccd5a78b54620796cfde672388b70ad97d17b7a5
2014-01-30 17:53:45 +01:00
5061fa5345 bool improvements
Change-Id: I0ec9d6ed41eddbc0177c26755b621f404cfd4703
2014-01-28 20:26:26 +01:00
5806a777b0 coverity#440064 Logically dead code
Change-Id: I52c9e37ca4d3238b9018264b6542a9dcebca13f6
2014-01-28 11:29:17 +00:00
57f288fdcc coverity#440240 Dereference after null check
Change-Id: I1ca5e4d31ab203a0ddd5e98928f5046f5fffb485
2014-01-25 03:10:52 -06:00
c69b6417af fdo#72598 Remove SunStudio cruft from code base
Change-Id: Ia6799c852eb95d496fbc8dcfdabde62dffc263a6
Reviewed-on: https://gerrit.libreoffice.org/7066
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2013-12-13 09:07:07 +00:00
a39d07e134 Unwind occurrences of deprecated sal_sChar, sal_uChar
Change-Id: I76be464200d486efef9c8a7e957c310c9adae3b8
2013-11-27 12:52:32 +01:00
e14e4f5351 Duplicate base checking code already covers check for opt base != XInterface
Change-Id: Icd47d87f93641a0b24a96a4be8d3d120f0405f2d
2013-11-26 11:03:41 +01:00
1366e61fcb Fix fn declaration parameter names to match fn definition
Change-Id: I733cd478caabc6337af9705a57ebbaeedfb92bb0
2013-11-25 17:26:18 +01:00
454f3f72c5 Fix unoidl sourceprovider interface base and member checks
...and enable tests shared with idlc

Change-Id: I422b16c9b2636835d276cc2085cb640073894c97
2013-11-25 17:26:17 +01:00
bd21de41e3 Fix unoidl sourceprovider polystruct argument checks
Change-Id: Ib7ee3188b87b9b4216214b65347e34970e1b92a5
2013-11-22 18:58:20 +01:00
87dc222876 Fix unoidl sourceprovider "published" checks
Change-Id: I93b9fcc2b20ed7a7c160a9ef3294b6e578678f53
2013-11-22 18:58:19 +01:00
2abcff2513 constant.tests idlc/unoidl diffs:
* byte only accepts singed literal values < 128 now

Change-Id: If557b5212e349fe115948f72b5558fee338db659
2013-11-22 18:58:19 +01:00
61c092497e attributes.tests idlc/unoidl diffs:
* global exception names no longer clash with local names
* repeating the same exception in a raises spec is caught now

Change-Id: I388aae4de59bddc1c69bf4c263297d0b92b47106
2013-11-22 18:58:19 +01:00
c5bb39d64d Add exectest.pl OLD-/NEW-FAILURE for deliberate idlc/unoidl diffs
Change-Id: I653522d8ebaac3329f368c102d14041c6b49d41d
2013-11-22 18:58:18 +01:00
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-04 08:06:10 +02:00
e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
7eb42bddb3 windows: warning 4706 is disabled globally in com_MSC_defs.mk
So there is no need to do this locally, too.

Change-Id: Ibc623235cae07a86dfd0dbc1d7672ca4273facec
2013-10-28 01:08:27 +01:00
7a06928bcf convert code to use OUString::endsWith
Convert places that call
   aStr[aStr.getLength()-1] == 'x'
to use the shorter form
   aStr.endsWith("x")

Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23 08:29:15 +02:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
3656a57e88 add mode lines to new files (and idls) since last run
Change-Id: Id1e74f18c90e69d1a781c8f02e30dc3c005ed4fd
2013-09-22 12:21:34 +01:00
7794ae344c bad search/replace
Change-Id: Ic14565414637a6d08aee94ad183dd852eb7875f0
2013-09-20 15:44:07 +02:00
aeee571501 Use tempfile instead of stdin in exectest.pl
...so it can easily be reused to test unoidl-write, too.

Change-Id: I4992850b44faaa152bcf1d281f2787824d6ad036
2013-09-20 15:38:02 +02:00
5f5a981dd6 CID#705985 ensure umask for mkstemp
Change-Id: I861b85ac38a2881ff4b993047c1a15335308ba62
2013-09-12 13:09:04 +01:00
af05fe65ab CID#440614 use after free
a bit of guesswork here I admit

Change-Id: I774da6f585e4b81a25660b7823d6bb150630f44f
2013-09-12 13:09:03 +01:00
71ac97f709 Minor clean up
Remove an odd {1} repeat count, and remove the "."{DIGIT}+ pattern that is
already covered by the following {DIGIT}*"."{DIGIT}+ pattern.

Change-Id: If99dfe10a5e37225355472bf4deceb34c0a92eb9
2013-09-04 14:37:54 +02:00
2f4eeea173 Do not leave $$ uninitialized in case of error
Change-Id: Id28fb53a98ff164cd14f8f9dcb4ebee7a71bfd1e
2013-08-28 16:45:56 +02:00
284a03b4d2 parser.y: untabify, remove trailing whitespace, mode lines
Change-Id: Ief0109289c6dc70b51193fa5f4432efe2b48c3fb
2013-08-28 16:36:36 +02:00
4ef1f4ae49 downcast of address which does not point to an object of type 'AstInterface'
(note: object is of type 'AstTypeDef'); Clang -fsanitize=undefined

Change-Id: I1b11a7678f18557c8040af2118c1c0101913f086
2013-08-22 07:13:58 +02:00
d239ee4fa4 downcast of address which does not point to an object of type 'AstType'
(note: object is of type 'AstDeclaration'); Clang -fsanitize=undefined

Change-Id: I08eef7d3e8b298abd16b0c6d72cfb72b75190cd5
2013-08-22 07:13:58 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
caab53cf21 fdo#43460 connectivity,extensions,filter,idl,idlc: use isEmpty()
Change-Id: I78ba286be5aa4d731f734e5eb16adb77c686aad9
Reviewed-on: https://gerrit.libreoffice.org/4325
Reviewed-by: Noel Power <noel.power@suse.com>
Tested-by: Noel Power <noel.power@suse.com>
2013-06-18 17:31:20 +00:00
4b373ef7f5 fdo#60724 change spelling error REMOVEABLE -> REMOVABLE II
Change-Id: I0057b9174af6a83f3fde0e27c3a91a4aeca95873
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-05-29 10:43:24 +02:00
2ae6f9d1d2 RHEL-5 baseline ver of flex doesn't have nounistd
lets try this hack, if it fails revert and I'll just
manually update the baseline with a newer flex than
flex-2.5.4a-41.fc6

Change-Id: If644489e80fc4e4cdba97808af0fe4d544d08646
2013-05-23 13:57:20 +01:00