Commit Graph

28 Commits

Author SHA1 Message Date
7bbaa39102 Catch invalid null pointer operations early
Change-Id: I324d5a6e84e0d2121d8e4612e074b44ed5127b11
2014-07-03 08:24:09 +02:00
7242fe6e33 SAL_WARN_UNUSED_RESULT for static Reference::query function
...which the recent loplugin:staticcall changes showed was occasionally used
apparently under the assumption that it was non-static and changed the object
it was called on.

Change-Id: I989a2a4ed3886d7f370855c9e8c1867e646c059b
2014-06-16 10:22:31 +02:00
0e507ae031 various: remove SAL_THROW macro
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
37d764bce9 Enforce "There is no css::uno::Sequence<bool>"
While some uses of Sequence<bool> might silently work, it would be too dangerous
to accidentally pass them around to other places that correctly expect
Sequence<sal_Bool> instead, so best to rule them out completely.

Change-Id: Ia60c839218c079cc42b4310d1315d95b6f2c68fd
2014-05-09 13:14:46 +02:00
44d9e4960e Sequence::operator[]: let's cast the other side to unsigned too
Change-Id: I30845477e5dfbf5c90702bb0b6acb7955fcbe684
2014-04-24 13:11:29 +02:00
c1158fbc1c Sequence::operator[]: silence -Werror=strict-overflow warnings
GCC 4.8.2 warns when index is a subtraction expression; the real
problems in that case will be found by the "index >= 0" check.

Change-Id: I4c3f0bdb7996e433b1693eb7dcbafb9610b5dbcf
2014-04-24 13:01:26 +02:00
8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
2224ef3972 Any: consistently use explicit specialization instead of overloading
Should be transparent to client code.

Change-Id: I5632fba87242ff9cb9a6b3481a179fa3e92c618b
2014-02-18 19:00:51 +01:00
34a44156b3 cppu: sal_Bool -> bool
Change-Id: I1288f1f6f38d1475b4eb5272509e479bd9f2552d
2014-02-17 17:55:18 +01:00
a2c464868a [API CHANGE] Remove UNOIDL "array" and "union" vaporware remnants from cppu
This leaves only aborting stubs (for SONAME stability) for

  typelib_static_array_type_init
  typelib_typedescription_newArray
  typelib_typedescription_newUnion

and completely removes corresponding

  typelib_ArrayTypeDescription
  typelib_UnionTypeDescription

structs and C++ inline

  getCppuArrayType*

functions.  None of this should ever have been called by client code anyway, so
while technically an API change it should not matter for practical purposes.

Change-Id: I23769d104d545533bf578762b79994e269d78c22
2014-01-31 10:18:17 +01:00
9e77c2fb7c Remove UNOIDL "array" and "union" vaporware remnants
...and deprecate what cannot be removed for compatibility.

Change-Id: I1ea335af775b867b468b8285113631167729a92a
2014-01-31 10:15:47 +01:00
83d51e244d Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Change-Id: Ife614637082036dd17412f247be79233326c4f0b
2014-01-22 11:39:22 +01:00
46cf9aed39 SAL_WARN_UNUSED css::uno::Type
Change-Id: I3b165e2a4414fd3d6c3cede5eb39beffa9fe7576
2014-01-08 11:48:04 +01:00
c6e2fcb286 Consistently mark these as deleted on all platforms
Change-Id: I87b226fe8ade512fa5559be9cb66cff75543e383
2013-12-18 10:17:14 +01:00
66397a4fd2 fdo#72598 Remove SunStudio cruft from code base
Change-Id: I5150eec33228e18e274a8ae4effd3f185851b7f4
Reviewed-on: https://gerrit.libreoffice.org/7103
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2013-12-16 20:52:39 +00:00
6da3bd044f const fix
Change-Id: I9abd4fa85d3d5718dffc0f03e3cc662a17a78ac8
2013-11-26 13:44:08 +01:00
ab5d1fbfb4 SAL_WARN_UNUSED com::sun::uno::Any
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14 21:02:40 +01:00
ec7e3cc0d7 fdo#65108 inter-module includes <> include/css/uno
Change-Id: Ic710b335632489f77c2c0abc76e7550e6a7c0885
2013-11-09 18:48:55 -06:00
bcb51cff22 fdo#63020: Replace ::comphelper::stl_begin()...
And use some templates inside include/com/sun/star/uno/Sequence.hxx

Change-Id: I48875fa1517751fc4cb0cf2b6c08b88975a29b47
Reviewed-on: https://gerrit.libreoffice.org/6599
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-11-07 10:43:34 -06:00
0bd7f12d41 fixincludeguards.sh: include/c*
Change-Id: Icba422d99836518a1b662b15144bc9334bed1473
2013-10-23 23:22:30 +02:00
dbbd252cee find unused Sequences
Change-Id: Ic1227899d13627e6f52312be830cf9d91068994e
2013-10-02 16:03:55 +01:00
c38592527a EXCEPTIONS_OFF is never defined
...since gb_LinkTarget_NOEXCEPTIONFLAGS became unused with
e81b1f23c49e35c1cde1faa44281812e97be60f5 "remove
gb_LinkTarget_add_noexception_object."

Change-Id: I4a7275b5b26a9d4b6ded66efb52e6866e6e09cc3
2013-08-14 13:29:39 +02:00
86435f9e28 Some improvements for operator<<(std::ostream&, const uno::Any&)
Change-Id: I2b3eb7a8e3d47b646eb8d4a8ca396a7c9de9545f
2013-08-14 13:29:39 +02:00
8284ca9c4b Implement operator<<(std::ostream&, const uno::Any&)
In other words, SAL_DEBUG(any) works now. Structured any types
(e.g. struct, array) not implemented yet.

Change-Id: I6460e72bbeff86da17711cab5d2018508468290c
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-08-14 13:29:39 +02:00
8c3657658a Tweak comments
(Preventing documentation of macros via @cond ... @endcond is apparently at
least broken in Doxygen 1.8.3 and working in Doxygen 1.8.4.)

Change-Id: I2ee582119dba2c3d27db5298786d3076921af46d
2013-05-29 15:03:01 +02:00
904b3d1fce Up-cast conversion constructor for css::uno::Reference
Based on a previous patch by Noel Grandin,
<https://gerrit.libreoffice.org/#/c/3613/>, and borrowing from
boost::is_base_and_derived (see comment in include/com/sun/star/uno/Reference.h)
to avoid including Boost headers in URE headers.

Change-Id: Iade5af144dd73ef03bd7d96000134c7a66a5e591
Reviewed-on: https://gerrit.libreoffice.org/3699
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-05-07 07:14:41 +00:00
6c7659b584 move URE headers to include/
Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d
Reviewed-on: https://gerrit.libreoffice.org/3499
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:17:10 +00:00