Commit Graph

180 Commits

Author SHA1 Message Date
40c45e0fac remove unused bIsOwner field in SfxHint
Change-Id: I676039b07519fbed3b92c6ada0fa8217ee2cbe27
2014-08-27 08:34:38 +02:00
7e2b9fa213 Remove some useless tools/debug.hxx includes
Also remove the tools/solar.h included from tools/debug.hxx. The include of solar.h
header was necessary in some cases because of a macro or a typedef that was needed.

Change-Id: Ia6e15d5c2571c58c9e9138b0d0a7f08ae88053c9
Reviewed-on: https://gerrit.libreoffice.org/11075
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-08-22 16:33:18 -05:00
e426e448ce Consistency around SfxStringItem in svx/inc/sxonitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I694c42a53cb9041b51ef876416f0f61963b89f86
2014-08-22 15:40:43 +02:00
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
9d140ccdb3 drop use of SFX_ITEM_PRESENTATION_NONE
since none of the call sites specify it

Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
2014-07-29 12:26:17 +02:00
7e018afaf7 simplify return argument of SfxPoolItem::GetPresentation
since all two of the actual call-sites only care about whether
it is a valid presentation or not, not what kind of presentation it is.

Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-29 11:04:01 +02:00
81b594afa7 svl: remove some odd and obsolete debugging code related to MI_HATS_REPARIERT
This was apparently disabled before the MI_HATS_REPARIERT check was
removed in f03a3edf2523c208948059861e0df48567834d0d, and then yesterday
something in the header inclusions changed to enable the DBG macros that
still used the removed stuff, but _only_ on Windows... now clean this up.

Change-Id: I4222db252f4a886b3497ca0c22dbec26eaa6c994
2014-07-24 13:45:55 +02:00
2a19718575 move SFX_ITEMS_DIRECT etc. definitions inside the module
These are internal constants, they don't need to be visible to the rest
of LO

Change-Id: I313def85b8c404948ec9ecb3996fed03b32ff9bf
2014-07-24 08:13:04 +02:00
9782ba7f1b fdo#76754 Add return first to IndexedStyleSheets to speed up ods writing
Change-Id: I6fc9fe8ce78ad9cc1a7c2fe3e13ed38ce468ce6c
Reviewed-on: https://gerrit.libreoffice.org/10347
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23 11:33:14 +00:00
88a874fcb3 convert SfxItemState constants to a proper enum
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants

Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23 13:26:19 +02:00
11e66edd0e remove dead SfxArgumentError typedef
Change-Id: I62127b23475dedf081fc981c20e916d5868ab086
2014-07-23 13:26:19 +02:00
e72ddca6a0 move string IO methods out of global header
and into a module-local header.
It's not like the methods have any actual relationship with the
SfxPoolItem class.

Change-Id: I1378364a1554642333b0c5c79d869d719b53fa0c
2014-07-23 13:26:18 +02:00
8497efb425 convert SfxPoolItem kind constants to an enum
Change-Id: I57de8c0cebfd60fdf70c23c72ecf1e47c69d7ecd
2014-07-23 13:26:18 +02:00
b78d881520 remove unused values from SfxFieldUnit enum
Change-Id: I3cb720b62216f5534d0ff3b524c596158ffe824c
2014-07-23 13:26:18 +02:00
262bde9b3e simplify SfxItemPool::GetPresentation
drop the ePresentation parameter, since all 4 of the callsites use
SFX_ITEM_PRESENTATION_COMPLETE as the parameter value,
and just inline the value into the method.

Change-Id: I42c8eae82837c9f9d4edc886d7c760f57b129125
2014-07-23 13:26:17 +02:00
f2940a4bff rename SfxItemDesruptor -> SfxItemDisruptor
Change-Id: I7cc9fa3ab6aebc541df4708e29b530f8021b14ba
2014-07-23 13:26:17 +02:00
dc0af9ef8e mark m_nRefCount in SfxPoolItem as mutable
so that we don't have to const-cast when modifying it

Change-Id: If584e4ddd440638169af00493f0194b34832177f
2014-07-23 13:26:17 +02:00
0361eb7c20 remove unused return type from SfxItemPool::AddRef
Change-Id: Ideb690df8a74efe55bff832e16e66a6b77b1530a
2014-07-23 13:26:17 +02:00
b0a13b78e7 remove unused SfxPoolItem::Delete_Impl method
Change-Id: Idb20e9acd97a27801ff95dc53d3e179326c122d4
2014-07-23 13:26:16 +02:00
331132b4cb comments and code formatting in SfxPoolItem
Change-Id: Ibf7b2f5e93748198eccbbbf54fad5f8053270003
2014-07-23 13:26:16 +02:00
7be041309c remove SFX_ITEM_PRESENTATION_NAMEONLY
since it is unused

Change-Id: Ib739240a362eeff6a72b2300804583b575edfb24
2014-07-23 13:26:16 +02:00
8f8ee6fd2c fdo#76754 Add Positions by StyleSheetFamily to IndexedStyleSheets
Change-Id: I4eade2d00d145d8f65ccd70a1c6bbd0a134a1ad5
Reviewed-on: https://gerrit.libreoffice.org/10346
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23 11:07:54 +00:00
798379313d fdo#76754 Speed up registration of new listeners to SfxBroadcaster
Also change behavior for the GetListenerCount() method which now
returns the count of listeners.

The previous behavior is available in method GetSizeOfVector().

Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89
Reviewed-on: https://gerrit.libreoffice.org/10344
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-22 06:26:06 +00:00
312926823d Add unittests for SfxBroadcaster
Change-Id: I9ecd8fec395eafbdc2675dda9fa25ac32761123c
Reviewed-on: https://gerrit.libreoffice.org/10343
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-07-22 06:25:22 +00:00
6a873638fa Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xx
- Remove includes from files where they are not needed.
- Update pch files

Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5
Reviewed-on: https://gerrit.libreoffice.org/10342
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-17 08:47:58 +00:00
7dd5f93088 translate comments in itempool.hxx
Change-Id: Ifd9c0dd2ceec08f50f3a8c4356fb288e65040dc5
Reviewed-on: https://gerrit.libreoffice.org/10345
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-16 07:30:30 +00:00
5c6ee09126 fdo#81309: Adjust references during sort.
Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f
2014-07-13 18:07:14 -04:00
80a1a2599e Generally better to have DLLPUBLIC class with some DLLPRIVATE members
...than the other way around an implicitly DLLPRIVATE class with some DLLPUBLIC
members, so that any symbols implicitly added by the compiler have the right
visibility (e.g., RTTI as needed by -fsanitize=function).

Change-Id: I4898dee0ccc6fdc4e7e1f3fb19db94661563444f
2014-07-02 16:10:39 +02:00
b7558d19bb Translated German comments in filerec.hxx and doxygen-ify.
Moved general file format description to be included in
class SfxMiniRecordReader documentation.
Changed '@example' to @par Example @code ... @endcode,
since Doxygen interprets @example as "all this file is an example",
which is not what was meant.

Change-Id: I01a91e7f1166b37dcb4e20368b4f70a908b4576b
Reviewed-on: https://gerrit.libreoffice.org/9957
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-30 09:13:10 +00:00
f15e440d14 Move SheetPrinter to svl and rename it to GridPrinter.
I need to use this outside of sc.

Change-Id: I153863d6c5c31e5ab5f25da2dba81bd4d4b6d3fe
2014-06-26 13:35:33 -04:00
8c717ff5d7 Revert needless inlining of methods for publicly exposed class.
Keep the method implementations unexposed please.

Change-Id: Ic9b1f8654e6ebef428d4182782c1aa4962934c6a
2014-06-26 11:26:16 -04:00
19863db337 indentation fixes
Change-Id: Ia391ccc9889a135730f0fead11eb0b6c2f748ec4
2014-06-19 09:57:33 +02:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
7198d97a2d Bin crack, _NOTIFY_HXX is not defined anywhere anyway
Change-Id: I596ec18deca1a7bd85bc49f637fc1765e43d1278
2014-06-12 00:01:54 +03:00
f9f60b95c1 Bin crack, _SFXITEMS_HXX is not defined anywhere anyway
Change-Id: I9143e7fffef6e99d25a0fd87712ed26d2d42116e
2014-06-11 22:43:28 +03:00
efd6106f09 de-virtualize these stringify methods, nothing overrides them
Change-Id: Id523ae3f50147fd778a1576c2851d01e1ea8c3ae
2014-06-09 16:24:40 +01:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
a10a621b48 simplify SfxListener::EndListening and StartListening
No-one is using the return values, so we can simplify the methods

Change-Id: Icc2dbfb797bcd82afcbf42ed3bdc20b0426ccba1
Reviewed-on: https://gerrit.libreoffice.org/9542
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-06-06 15:39:42 +00:00
05e2fd162e Related: fdo#79142 make SetName default to Reindexing
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5
2014-05-28 13:25:12 +01:00
352158b811 Remove unused headers
Change-Id: I67cb5bf14114f9892d2680b7688092cafd9644f1
2014-05-24 22:09:09 +02:00
f4166f967b sal_uInt16 to size_t
Change-Id: I46d85e82376a3135408ab77ad31b76a5edbe9ce7
2014-05-24 22:09:08 +02:00
3db8d606d5 hrc and src files: squeeze multiple newlines
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done

Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19 20:04:22 +02:00
3c1e30b77d Correct common misspellings, and remove some ASCII art along the way.
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17 12:38:38 +00:00
b862a216f7 ODF filters: fallback glTF model to bitmap for older versions
Change-Id: I33161401a29f511e61429355dd2905d4643fe8ff
2014-05-16 16:24:10 +02:00
2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
248145f99e Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-14 08:10:22 +00:00
ffa2229a8e remove dead code
Change-Id: Ic4fb478921714429af138ca212bd7f67f408d434
2014-05-13 12:00:27 +02:00
2c9d68ff56 move INetContentTypes::scan() to INetMIME::scanContentType()
to avoid circular dependencies between svl and tools when using
INetContentType::scan functionality for future handling of data urls in
urlobj.cxx

Change-Id: Iad13286769e8906aebf8208e4f532151ff2f3d13
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-09 16:01:30 +02:00
9e436082af dflt -> default
Change-Id: I89f1f5771eb7d96da233a8c7386b906b2a3a9c3e
2014-05-06 07:19:09 +02:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00