Commit Graph

3904 Commits

Author SHA1 Message Date
4eb84ab8d6 typo
Change-Id: I74c2943c5967bb19a3d7b669313894134348adba
2014-08-04 15:59:04 +02:00
4189b71599 suppress legacy locales, fdo#44112 related
With MsLangId::isLegacy() locales can be suppressed in language lists
and are not offered unless actually used at the current position of the
document. Language attribution now handles adding a language/locale to
the list on the fly.

For example, Serbian (Latin or Cyrillic) for "Serbia and Montenegro" are
legacy locales, the confederation doesn't exist anymore. A further
candidate would be pap-AN as the Netherlands Antilles ceased to exist,
see fdo#44112.

Suppressing "Serbian Cyrillic (Serbia and Montenegro)" also has the nice
benefit of narrowing the language list box width a little ...

Change-Id: Id05cce328622465016901524b759369c18bc4dbd
2014-08-04 14:24:17 +02:00
768d32cf5b Consistency around SdrMetricItem in svx/sdtditm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib0234883d441be668700df5ccd0e855973dc5426
2014-08-04 11:29:51 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
2568a0bb72 hidpi, startcenter: Don't set fixed font heigt in the startcenter.
Change-Id: I68efbd08d21b514ab1659cd6bddfc2c4788c4a74
2014-08-01 15:25:02 +02:00
3d65212809 fix memory leak around function descriptions
Found by Lsan.

Change-Id: Ia443ed6eb2a20854998a615f3c2bd9fdac156a8c
2014-07-31 22:14:25 +02:00
41fbe85870 Mark osl_areCommandArgsSet as internal only.
Change-Id: Iac97290738088bd1ce7469ffee773994e7653efc
2014-07-31 16:02:09 +02:00
7cfd6db1ff Add @since to osl_areCommandArgsSet.
Change-Id: Ib2d033f975a9b5bf7b667fd80e495d8f043faff0
2014-07-31 16:02:08 +02:00
68969cc61a Consistency around SdrMetricItem
...where some instances of SDRATTR_TEXT_MINFRAMEHEIGHT etc. where SdrMetricItem
while others where of trivial derived classes SdrTextMinFrameHeightItem etc.,
that appear to only existed for better-named constructors.

Change-Id: If0af79fbb803275ed09fc7b950868c5de7d61615
2014-07-31 15:57:12 +02:00
6a2ea81ca1 Remove unused ctors
Change-Id: I01506e923f3197f97f771983edd72dfddb2af1b8
2014-07-31 14:26:43 +02:00
7e0e581c16 cleanup usage of MapUnit enum
some places were using the wrong enum constant, and some places were
unnnecessarily converting to sal_Int16

Change-Id: I754993533c840cd33106820d99af2dc951f26a80
2014-07-31 11:38:48 +02:00
65803ad94c fix some dodgy FieldUnit conversions
the FieldUnit enum was being converted in some dodgy ways and
in some places the MapUnit enum values were being used.

Change-Id: Ic9aacb84058d1c14c3a4a79ef6676082df9a7270
2014-07-31 11:38:47 +02:00
85118169a5 ASPECT_ALL is unused
Also add comment about the three sets of names for the same constants that
must match.

Change-Id: Id626b6f1cdaa4c2a8c391ae4f020186997ccb4d9
2014-07-30 19:18:40 +03:00
56bd29136c Wrap "" in OUString: error: conversion from const char* to non-scalar...
Full error:
     error: conversion from const char* to non-scalar type rtl::OUString requested

This seems to be happening only where ITiledRenderable.hxx ends up being
included in an Objective C file.
2014-07-30 13:30:07 +02:00
7f8eb6d501 LOKDocView: add set_part_mode.
Change-Id: I0e14a535124e93979ef05431255911245a11aa29
2014-07-30 12:44:03 +02:00
dd032c3f3b ITiledRenderable: provide default implementations for some methods.
Writer doesn't understand the concept of parts at the moment, it
makes most sense to keep these dummy implementations central.

Change-Id: Iafbd89864b753ba2bed28a05b0f59df85f364feb
2014-07-30 12:44:03 +02:00
366d8fb4db LOKDocView: add part name retrieval.
Change-Id: Iac31de0410d7f6187e5884152c329375047a23f4
2014-07-30 12:44:02 +02:00
977ba354b2 Remove horrifically outdated comment.
Change-Id: I1362489c9aecf536b31bf6ab57ad8c149f37a876
2014-07-30 12:44:01 +02:00
6872ecdbc7 LOK: add setPartMode.
This API seems to be simplest in the long run where we'll want to be
able to select between rendering slides/notes/both/embedded objects,
and maybe even adding the option of switching between continuous
and single page mode in writer (although I have no idea how hard
getting a single page mode out of writer would be).

Change-Id: I5bdfdb61854c37281c6992c8f3ed1c50c8aa0919
2014-07-30 12:44:01 +02:00
6548361109 LOK: Add getPartName.
By default (i.e. for writer) we can just return an empty string,
and we only actually need to implement ITiledRenderable's
getPartName for components that actually support it (i.e. calc/impress).

Change-Id: I8b381e5d7a8000638b02f763b4bea8ef0226f8e0
2014-07-30 12:44:01 +02:00
5fe0711dbe Fix comment typo.
Change-Id: I8ebe3ad2a6efcf1797a2dc941994c7fc1e36f4bf
2014-07-30 12:44:00 +02:00
666f8651b1 simplify "no delete" logic in SvRefBase
by converting the bit munging to use bitfields.
Remove unused return values.
Add asserts to check that AddRef() is not called after the object
is deleted.
Fix the code in SfxObjectShell to not call AddRef() after
SfxObjectShell is deleted.

Change-Id: I3a3565a0bc45fc9d1d086222265ab8b8175818a7
2014-07-29 17:56:51 +02:00
c694837aea convert linked list to std::vector in SbxDimArray
Change-Id: I2640cfe1f9606d992f622b99ff3c607555771e23
Reviewed-on: https://gerrit.libreoffice.org/10298
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 15:38:56 +00:00
5021f29841 Remove some unused code
Change-Id: Ib1fb5108a858c35a5bbe8ba865e15660639725e3
Reviewed-on: https://gerrit.libreoffice.org/10593
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 14:20:36 +00:00
551f76f410 Drop unnecessary SfxApplication::CreateResManager wrapper
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-29 14:27:43 +02:00
9d140ccdb3 drop use of SFX_ITEM_PRESENTATION_NONE
since none of the call sites specify it

Change-Id: I9c15f0e042e21f6f78560c1962a533112d588c90
2014-07-29 12:26:17 +02:00
7e018afaf7 simplify return argument of SfxPoolItem::GetPresentation
since all two of the actual call-sites only care about whether
it is a valid presentation or not, not what kind of presentation it is.

Change-Id: I75717c88878d37b2897741b0c833ff283b3fee59
2014-07-29 11:04:01 +02:00
9e7bdb422d Kill the libreofficekit static library / shim.c.
It looks like the cleanest method of getting lok_init into
a LibreOfficeKitInit.h header (in a c89 compatible way) is to
have it as a static function.

(inline is only available in C99 or later -- this is actually
 available on Linux which is the only place that we can actually
 use lok_init anyways currently, however given we have to keep
 c89 for the C code (for MSVC) compatibility, selectively enabling
 c99 would likely be more messy.)

Change-Id: I0493e7a68ed5397479220bb6ba8c3db870b6dd32
2014-07-29 07:11:20 +02:00
537cda4457 fdo#75757: remove inheritance to std::vector
... by boost::ptr_vector.
Originally TextCharAttribList::Clear() was never called with false,
so this drops the argument.

Change-Id: I0306cd787dd38de0960af38afe9c08a910195b26
Reviewed-on: https://gerrit.libreoffice.org/10549
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-07-27 08:12:18 +00:00
ce4e7a830d fdo#81038 Fixed FormulaTokenIterator to use std::vector instead of linked list
Change-Id: I09f9adfa52b64732cc6200a0dbeb6263435c7c07
Reviewed-on: https://gerrit.libreoffice.org/10565
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2014-07-27 04:03:07 +00:00
6c2c974dd3 bnc#885825: Handle ODF import and export of data label border properties.
Change-Id: Ic8c7bc873768008537cd52a3fd4b11031b403139
2014-07-26 16:26:09 -04:00
48f31a9242 bnc#885825: OOXML import and export of data label borders. 2014-07-26 16:26:08 -04:00
52a36fb30a pImplize XMLPropertyHandlerFactory.
Change-Id: Iff524c9065e9374b39db998e3860704555130995
2014-07-25 15:54:19 -04:00
690f7ff883 Store the handler as a const pointer.
Handlers are conceptually stateless; we can keep them as const objects.

Change-Id: I3d35ab0695037632e82f67f901c9795adf9bdd8d
2014-07-25 15:54:12 -04:00
dbf84a3574 The 'mutable' keyword exists for this kind of use.
Change-Id: Ic52192f53039b7f1b4529a93c13de74c5f54e7f8
2014-07-25 15:54:02 -04:00
63a94bd053 Get the math right.
Change-Id: I6c0073d27d18676b85809bd5f294e90e23ec9770
2014-07-25 14:13:02 -04:00
0915d82bec Document what's in the type of the map entry.
And organize xmltypes.hxx a bit to make it easier to follow.  Also
rename MID_FLAG_PROPERTY_MAY_EXCEPT to MID_FLAG_PROPERTY_MAY_THROW.

Change-Id: If18f07159a613555cf031bea5e07c04c7c45abec
2014-07-25 14:04:56 -04:00
8a690c88a9 Apply pimpl to XMLPropertySetMapper.
Let's hide its implementation for real this time.

Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
2014-07-25 11:50:02 -04:00
2295697df9 convert the weak reference macro in tools into a template
which required making SfxFrame subclass SvCompatWeakBase,
but that makes the relationships clearer anyhow.

Change-Id: I209d05359d50111eacac72c971bb46ccf569ba49
Reviewed-on: https://gerrit.libreoffice.org/10285
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-25 08:13:39 +00:00
81b594afa7 svl: remove some odd and obsolete debugging code related to MI_HATS_REPARIERT
This was apparently disabled before the MI_HATS_REPARIERT check was
removed in f03a3edf2523c208948059861e0df48567834d0d, and then yesterday
something in the header inclusions changed to enable the DBG macros that
still used the removed stuff, but _only_ on Windows... now clean this up.

Change-Id: I4222db252f4a886b3497ca0c22dbec26eaa6c994
2014-07-24 13:45:55 +02:00
e904562af5 Related: fdo#81641 create new styles with an initial name
instead of creating with a blank name and changing it later

this way undo of a style creation is initialized with its name and so create a
style followed by deleting a style and undoing all those steps doesn't crash

Change-Id: Ida7a34410d5d7b05edcb86950aabb3c672b82c8f
2014-07-24 12:46:57 +01:00
2a19718575 move SFX_ITEMS_DIRECT etc. definitions inside the module
These are internal constants, they don't need to be visible to the rest
of LO

Change-Id: I313def85b8c404948ec9ecb3996fed03b32ff9bf
2014-07-24 08:13:04 +02:00
d5fb4b7319 Typos
Change-Id: I0c17f40b3e593ae3771fa751a817f84bf2f2323d
2014-07-23 22:23:52 +02:00
9782ba7f1b fdo#76754 Add return first to IndexedStyleSheets to speed up ods writing
Change-Id: I6fc9fe8ce78ad9cc1a7c2fe3e13ed38ce468ce6c
Reviewed-on: https://gerrit.libreoffice.org/10347
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23 11:33:14 +00:00
88a874fcb3 convert SfxItemState constants to a proper enum
and while we're at it
- use the enum type all over the place instead of passing around
sal_uInt16
- don't use bitwise logic on enum values
- use enum values instead of numeric constants

Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-23 13:26:19 +02:00
11e66edd0e remove dead SfxArgumentError typedef
Change-Id: I62127b23475dedf081fc981c20e916d5868ab086
2014-07-23 13:26:19 +02:00
e72ddca6a0 move string IO methods out of global header
and into a module-local header.
It's not like the methods have any actual relationship with the
SfxPoolItem class.

Change-Id: I1378364a1554642333b0c5c79d869d719b53fa0c
2014-07-23 13:26:18 +02:00
8497efb425 convert SfxPoolItem kind constants to an enum
Change-Id: I57de8c0cebfd60fdf70c23c72ecf1e47c69d7ecd
2014-07-23 13:26:18 +02:00
b78d881520 remove unused values from SfxFieldUnit enum
Change-Id: I3cb720b62216f5534d0ff3b524c596158ffe824c
2014-07-23 13:26:18 +02:00
262bde9b3e simplify SfxItemPool::GetPresentation
drop the ePresentation parameter, since all 4 of the callsites use
SFX_ITEM_PRESENTATION_COMPLETE as the parameter value,
and just inline the value into the method.

Change-Id: I42c8eae82837c9f9d4edc886d7c760f57b129125
2014-07-23 13:26:17 +02:00