Commit Graph

99 Commits

Author SHA1 Message Date
8e115c6008 fdo#68849: Add header guards to all include files
added header guards for directories basebmp/, chart2/, cppuhelper/,
include/test/, io/test/, sax/test, shell/, writerfilter/, and xmlhelp/

Change-Id: I0e29a9b75c26d71f58aa98986b52f6d3b46015a6
Reviewed-on: https://gerrit.libreoffice.org/9615
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-06-02 08:46:30 +00:00
ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
f73af1733e second test should be DataOutputStream
...as <https://gerrit.libreoffice.org/#/c/9007/> "cppcheck: multiCondition,
second test should be DataOutputStream" found out for an effective duplicate of
this code that got removed with the previous commit "Remove dead test code."

Change-Id: Ib7b088f065def2d5e954837d22178521f85c49fe
2014-04-22 09:11:29 +02:00
043e378521 Remove visual noise from io
Change-Id: I46f8c4f793596b0e6feb2db7b9302b9b6eb9644b
Reviewed-on: https://gerrit.libreoffice.org/8273
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:25:43 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
2013-11-11 12:58:12 +02:00
e52779d2f8 remove unnecessary use of OUString constructor
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-11 11:21:26 +02:00
5285beeaa4 remove redundant calls to OUString constructor in if expression
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04 10:11:08 +02:00
a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
f762dad2e7 fdo#46374 replace stardiv in comments where applicable
Change-Id: Icd07fba84735325408741ad10864c63ea32a6481
2013-10-04 15:06:23 +02:00
ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
5bb4a2ba1d further OUString cleanup
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
2013-03-19 14:18:10 +01:00
8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
00c9394baf re-base on ALv2 code. 2012-07-04 12:14:59 +01:00
b9042fad7c re-base on ALv2 code.
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
b6db3e3acc re-base on ALv2 code.
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-21 13:11:06 +01:00
acb7bd175a targeted string re-work
Change-Id: I145731d9f28faf0065f5960f2c5a32f27d8c8620
2012-06-02 16:48:34 -05:00
9601b63509 targeted string re-work
Change-Id: Ibe5c739c3066f3e706a44b64d4ad775abde9662c
2012-06-01 09:41:49 -05:00
135c63c8f9 fdo#48253 Expand SAL_STATIC_CAST and SAL_CONST_CAST
Change-Id: I50f0887ceb4517d7ef234f970ca2ba679d533382
2012-05-04 15:52:57 +02:00
23af031b09 Fix typos in comments 2012-02-18 09:35:43 +00:00
b8f007d052 remove extraneous qualifiers that break some compilers 2012-02-17 15:22:46 +00:00
0f44079ce2 catch exception by constant reference 2011-12-15 13:52:23 +09:00
7904a8cc56 I don't see NO_BSYMBOLIC being used anywhere 2011-12-11 02:57:59 +02:00
902b94875c remove include of pch header from io 2011-11-27 13:13:17 -06:00
15f10fc946 Remove component_getImplementationEnvironment 2011-07-12 16:30:06 +02:00
d5124274ae __cdecl -> SAL_CALL 2011-06-05 21:34:04 +02:00
08d3fdffae Easyhack: Add visibility markup to all component_get* functions 2011-04-21 16:06:40 +02:00
35e1b53c7e Remove OS/2 support. 2011-04-18 16:59:48 +02:00
5a7f6793ac Move OSL_ENSURE(sal_False,...) to OSL_FAIL(...) 2011-03-19 14:12:37 +01:00
adc6fe00e3 Move OSL_ENSURE(0,...) to OSL_FAIL(...) 2011-03-12 14:19:48 +01:00
ab1751a151 RTL_CONSTASCII_USTRINGPARAM in ure 2 2010-12-10 18:54:29 +01:00
3a18c3d97a RTL_CONSTASCII_USTRINGPARAM in ure 1 2010-12-10 18:31:39 +01:00
1b11499074 Remove redundant comments 2010-12-05 20:28:21 +00:00
d441fa1f8c remvove vos/macros.h usage 2010-10-25 19:55:39 -05:00
a715e1b3d0 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-14 17:04:31 +02:00
5284d1d961 CWS-TOOLING: integrate CWS changefileheader2 2010-02-17 10:32:35 +01:00
7c80db2eb3 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
fbf485ce60 cmcfixes71: #i108597# fix uninit warnings 2010-01-23 12:35:22 +00:00
3739e0b640 merge commit 2009-09-25 21:47:16 +02:00
fcd1e07f25 CWS-TOOLING: integrate CWS l10nframework01 2009-09-16 11:45:54 +00:00
ffd6952e9a #i103452#: replace PRODUCT by !DBG_UTIL; replace assert by OSL_ASSERT where possible 2009-07-10 14:03:42 +02:00
daa9882f81 INTEGRATION: CWS changefileheader (1.2.54); FILE MERGED
2008/03/31 12:33:32 rt 1.2.54.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:51:12 +00:00
0bdc072e04 INTEGRATION: CWS changefileheader (1.4.28); FILE MERGED
2008/03/31 12:33:32 rt 1.4.28.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:50:54 +00:00
2fbfa42828 INTEGRATION: CWS changefileheader (1.8.28); FILE MERGED
2008/04/01 15:20:42 thb 1.8.28.2: #i85898# Stripping all external header guards
2008/03/31 12:33:32 rt 1.8.28.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:50:36 +00:00
41c054e8dd INTEGRATION: CWS changefileheader (1.7.8); FILE MERGED
2008/03/31 12:33:32 rt 1.7.8.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:50:16 +00:00
e73f3a2f7b INTEGRATION: CWS changefileheader (1.6.28); FILE MERGED
2008/03/31 12:33:32 rt 1.6.28.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:49:53 +00:00
23e202c758 INTEGRATION: CWS changefileheader (1.5.14); FILE MERGED
2008/03/31 12:33:31 rt 1.5.14.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:49:33 +00:00
bba63955ff INTEGRATION: CWS changefileheader (1.11.8); FILE MERGED
2008/03/31 12:33:31 rt 1.11.8.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:49:13 +00:00