Commit Graph

2755 Commits

Author SHA1 Message Date
fba7b58a9d fix typo Sufface->Surface
Change-Id: I90847d0edbc2c13e405562647b150012bc5df7e2
Reviewed-on: https://gerrit.libreoffice.org/11249
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-09-01 15:39:42 -05:00
45dfbdca6a Fix build with boost-1.56.0.
Change-Id: I61686bf61ff1e0561c385492c563e4495456ca47
Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
2014-08-29 10:10:15 +01:00
14fa2698f2 bnc#822347: if number type is not set, skip numbering
If numbering is detected then (level is > 0) and the number type
is not set, the defult bullet symbol is written. This is not
correct as the default should be SVX_NUM_NUMBER_NONE which should
skip numbering or set it to none. With this change the numbering
is skipped (as in MSO).

Change-Id: I8d08a6325509c7bd6f96f64c8d29e5f3045458ca
2014-08-28 13:50:48 +02:00
3f1f2d7100 drawingml: remove AUTONUM macro, unneded checks
Change-Id: Ie0ad7ed9df9d0d1b19fa09b3a4b93a5cbd6b41c6
2014-08-28 13:50:47 +02:00
c75bddd73b reduce nesting in WriteParagraphNumbering
Change-Id: I49a3c3449d8354ce5e2a6e42414fbefdfc489388
2014-08-28 13:50:47 +02:00
1edf2c0f1b drawingml: Use SVX_NUM_NUMBER_NONE as default numbering type
Change-Id: I159fcf41fdb6c49687004e959d4032aef28678a5
2014-08-28 13:50:47 +02:00
64c4a651c8 sanitize "using" and "using namespace" declarations
Change-Id: I0b0cccc2d9cfe721c1ed421e614c4350a6b3dc7c
2014-08-28 13:50:46 +02:00
ef2668bad9 PPTX import: fix missing document metadata
Without this, the creation / modification date is lost on import.

Change-Id: I0b74ac91aee7b8b3e0bc763247086a3a39816bc1
2014-08-28 11:01:59 +02:00
6797610bcf use ptr_vector to prevent memory leak
Found by Lsan.

Change-Id: I727098ea3861bacf89209615e4b46e986a72c1ce
2014-08-25 13:06:02 +02:00
5d05367268 import the sourceLinked attribute
Change-Id: I74cdf7a09b2e6e3b3cd8f07b5d3495dcc66848c5
2014-08-25 13:05:47 +02:00
2a7119021e bnc#880448: Improved handling of placeholder shapes
If subTitle placeholder is not found, try body instead of title.
And use body text styles instead of title, for subTitle.

Also improve PPTShape::findPlaceholder to find placeholder
with just nSecondSubType type without the same index.

Change-Id: I470e7268088eb989fb934007dfcf704f67d8cb1d
2014-08-22 11:35:58 +02:00
1558b50e4f remove whitespace
Change-Id: I5634bf40e8ccc4ce076409907c13f9c6f52d11a3
2014-08-20 08:17:40 +02:00
23b49f2390 writerfilter: fail on mistyped namespace URL's
And also fix one typo detected by this new check.

Change-Id: Iaa7a4bb0b6dc3f81e5dd0b352584029cfed4ffbb
2014-08-19 08:17:34 +02:00
e99535df4d remove executable bits
Change-Id: Iec785ae538de81325812b1e6fe33115789b39770
2014-08-17 05:50:13 +02:00
403fdaba8a oox: sort namespaces in generated header
Otherwise it's next to impossible to reasonably diff the generated code
after a change.

Change-Id: I13f98532535bfe3f4915677cb3346300f25e0cfa
2014-08-15 22:18:33 +02:00
c980d4970b warning C4245 signed/unsigned mismatch
Change-Id: If28543252ee2265e9edd7d7963c1751bd21e754d
2014-08-13 23:01:01 +02:00
7cc627ff79 update_pch
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-13 10:10:33 +02:00
f91b81c24e Add reference to 'DomainMapper' to some DOCX import classes
The reason for adding 'DomainMapper' is to be able to check
during import in these classes whether or not the import is
in a 'styles.xml' file or not.

Also added blank handling for new XML nodes.

Reviewed on:
	https://gerrit.libreoffice.org/10870

Change-Id: Ib2acde736d96f30eda40ee327991dc6ae0ed7f25
2014-08-12 08:34:47 +02:00
35fa84f598 Forgot to add break here.
Change-Id: Ic7322f111ca6732243741296d7b5f577af28bf14
2014-08-08 09:34:44 -04:00
b385733098 Disable export of label placement properties for radar charts.
Change-Id: Ib9e5801bc13ccf146ddd5aa79b7cd7d2a640e203
2014-08-07 19:32:40 -04:00
7b8073906a Ensure we export correct labal placement value for percent/stacked charts.
Normal charts allow a variety of label placement options, but percent/stacked
charts only allow three variants, and exporting a wrong value would trigger
MS Office to think the file is corrupt.

Change-Id: I8bdc1dc072b29e8df2c506b6b16c61279df12045
2014-08-07 19:01:43 -04:00
cc6ae36728 bnc#821916: Better algorithm to find placeholder shape.
Placeholder type seems to be more relevant than index.

Change-Id: I9d6c6cad8e0a51b2385801f65d7d1c697ad7998e
2014-08-07 21:05:07 +02:00
f4677f58a2 Area chart also doesn't support label position property.
Change-Id: I612ca7426b2b3de07d4afe1d78cd809f1f6b37bb
2014-08-07 14:44:51 -04:00
fb1473692e Default data label placement may vary depending on chart types. Get it right.
If we export a wrong placement value, MS Office will flag the file corrupt and
the loading will fail.

Change-Id: I7ca1239cd390494c1181ecdb3310c5f88bb18f9b
2014-08-07 14:22:11 -04:00
ed39df130c Doughnut charts don't support label placement option. Don't export it.
Change-Id: I6d0e2c099869120bdf594813468a3c5ba4bb46fd
2014-08-07 14:21:59 -04:00
b0eff57aae cppcheck: Same iterator used with different containers
Change-Id: Idc7f16dc4c81857d7a3f508ed830904d90a762b0
2014-08-07 20:15:02 +02:00
ca730eed1e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I9d58782c3d3bd09dc0d1d7121c057541f1186b43
2014-08-07 18:35:09 +02:00
ff929ad45c remove unnecessary references to test-install (just use instdir)
Change-Id: I99f19a3e2ed166c2ea4397f8767975973dd5d983
2014-08-07 11:49:15 +02:00
0acc3300f1 If dev-install is obsolete, why have it at all?
Replace mentions of it in a few (dcumentation) places with test-install.

Change-Id: I6fc8e58fa5813b05de16feec35215c83e0e45834
2014-08-07 09:04:45 +03:00
bb13f1a063 Avoid exporting label placement property when the chart is 3D.
MS Office has trouble loading the file if you do.  There is an exception,
however.  A pie chart allows label placement option even when 3D.  There
may be other chart types that allow variable label placement when 3D.

Change-Id: I6a9247041ca6ee3ae1b9c245f5919fcb35951f24
2014-08-05 13:26:29 -04:00
d1c1248bee oox: tokenize all attributes from CT_Cnf
Change-Id: Ifceb9c1319208c897a6f018fa0b5f8863b58c3e1
2014-08-05 17:32:28 +02:00
19ef6b3e39 oox: sort tokens.txt
The benefit is that then it's possible to just add new tokens at the end
of the file, have your editor put them to their sorted place and have no
additional noise in the commit diff.

Change-Id: I221b8b10ae588180dd61207a6c9279fe8af7531f
2014-08-05 17:32:27 +02:00
151fbebf8c Consistency around SdrOnOffItem in svx/sdtagitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: I6d8b3709d6d55bd6958d38f262141c43779dfdcc
2014-08-04 19:22:55 +02:00
013744a5b4 Let's not forget the keyword.
Change-Id: I86c114e903eaee1404875a794ed4f1c76f61169e
2014-08-04 12:41:12 -04:00
4a8f243171 bnc#886540: Default chart background for pptx docs should be transparent.
Charts in docx and xlsx OTOH use solid white as the default fill style.

Change-Id: Ic4351fe65cabc12d60214b67c7026a317841f2c7
2014-08-04 12:25:56 -04:00
e9876fbe96 oox: tokenize noHBand and noVBand
Change-Id: I43ea6cb2665e17239da61adffd0583b9201bef59
2014-08-04 16:41:07 +02:00
ded5b1ecde fdo#78301 : Size of word-arts change during import.
- Do not resize the fallback geometry for Word-Arts(VML), since the
  overlay geometry is constructed using the properties of the
  fallback geometry.
- The resize autoshape to fit text attr of FontWork/Word-Art should
  always be false for the fallback geometry(the SdrObject).

Change-Id: If8badb382c525875a07a0a9e6268cec036739001
Reviewed-on: https://gerrit.libreoffice.org/10486
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-08-04 07:34:11 +00:00
194c17a7c7 fdo#80895 : Shape in Header&Footer is getting lost after RT
If there is a shape in Header or footer in a docx created in MSO-2010 that shape was
getting lost after RT(actually shape was there but it's properties were getting missed).
Root cause was : When LO processes Header it has msRelationFragmentPath= header.xml in
ShapeContextHandler::startFastElement() and searches for theme as there is No theme specific
to header or footer, aThemeFragmentPath becomes empty in that case.
This is because MS office shares same theme for both documentBody as well as Header or footer.

To fix Get Target for Type = "officeDocument" from _rels/.rels file this target is
 "word/document.xml" for docx & to "ppt/presentation.xml" for pptx and use this Target for fetching correct theme.xml.
Tested group shapes in header/footer,previously was not getting rendred and not preserved
 after RT.After this patch it's now working correctly.
Tested chart in header/footer previously chart colour was not coming properly
both during rendering as well as after RT.after this patch it's working correctly.

Reviewed on:
	https://gerrit.libreoffice.org/10451

Change-Id: Id47008550da90c0d697b434b676765230e3258a7
2014-08-01 10:42:54 +02:00
c8cc89ff80 Fix some number format issues, bnc#862510
Set "LinkNumberFormatToSource" to false, so that format code is not
ignored.
Also, do not inherit format code common for all labels, if there is
specific format code for a data label.

Change-Id: I505311d5df641d61e616e354734bd332609fa122
2014-07-29 22:58:15 +02:00
5f47e31942 bnc#862510: PPTX import: Properly show data labels in percent format.
Usually, "General" is "0.00" number format, but in this case, when we
want to show percent value, MSO writes that instead of "0%".

Change-Id: I748719765f58e66f9f3fb43c2b527c6823ef6fa1
2014-07-29 22:58:15 +02:00
ae7ca8b957 fdo#46037: remove unused comphelper/configurationhelper.hxx
Change-Id: I66f9d2912202ba1393d0c65189f8a945bca4fcaa
Reviewed-on: https://gerrit.libreoffice.org/10603
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-29 15:40:41 +00:00
2197777816 indentation fixes
Change-Id: I0a0f04d0f0e008e8947a5a7e3ed6083c1589e61b
2014-07-27 17:30:48 +02:00
48f31a9242 bnc#885825: OOXML import and export of data label borders. 2014-07-26 16:26:08 -04:00
b6bfd2c795 WaE: extern prototype in main file without definition
Change-Id: I7121bf7bcc043065d4f10f7c67aaecd7059d6f89
2014-07-25 20:39:53 +03:00
77ea585350 Remove compiler warning.
nTransparancy will be left uninitialized if unstuffing the value from
the Any value fails.

Change-Id: I06a5853066edeb39b811bf12fd09afbc11792add
2014-07-24 17:34:40 -04:00
d068f13596 bnc#887227: Do not set TextAutoGrowHeight for vertical text.
It's horribly broken and it would resize text box
horizontally which is not supposed to happen.

Change-Id: I201ec8dbcddca56d21bf46ea8ee838d01923c442
2014-07-24 20:31:19 +02:00
d60cec0e60 bnc#862510: PPTX import: bullets have color as following text by default.
aTextCharacterStyle contains font theme color set in Shape::createAndInsert.

Change-Id: I55e66aeaa7176fbd3f64dcdf075d411f460947d4
2014-07-24 19:37:18 +02:00
8952061d81 Most certainly meant to be plural.
Change-Id: I3772091c77307892b13d75cc6a5a191ec07c7bf5
2014-07-21 13:52:55 -04:00
77d6ac27e1 WaE: passing class rtl::OUString by value, rather pass by reference
Change-Id: Ib332d04fa27501ec35267b5e389c2979c9c55be2
2014-07-21 19:20:27 +03:00
245df9b4b3 fdo#78663 : The File gets corrupted when saved in LO
Problem Description:
The docx file contains a word art inside a drawing tool.
After RT, nesting of <txbxContent> tag is happening which
is causing the corruption.

Solution: Created a service in util.cxx for checking
few shapetypes for which textbox with content is not
allowed. This check also helps to find that if we are
already inside a DML then we should purely read VML
Information.An existing UT testWordArtWithinDraingtool
was failing. The UT is related to same issue
(word art inside drawing tool) hence changed it
accordingly. Following is the commit id of the
UT-Change-Id: I00e94712e912ad1977fcb65a945fefb927795d77

Change-Id: I7e456c9f6a69af80da443e29eb02a64ba7d59468
Reviewed-on: https://gerrit.libreoffice.org/10229
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Luboš Luňák <l.lunak@collabora.com>
2014-07-21 15:03:25 +00:00