Commit Graph

168 Commits

Author SHA1 Message Date
7bfee546dc coverity#735310 Unchecked return value
Change-Id: I1a35da4b23b9ff8efa8f500eaf18e4c259cc0177
2014-07-17 13:57:05 +01:00
ca362d6348 remove whitespaces
Change-Id: Ie14ba3dcb97f20479a04538748ef2c1c9e6c5dac
2014-06-25 05:41:11 +02:00
3b24dcc8a8 Remove unnecessary semicolons
A simplified version of the semantic match that finds this problem is
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r1@
statement S;
position p,p1;
@@
S@p1;@p

@script:python r2@
p << r1.p;
p1 << r1.p1;
@@
if p[0].line != p1[0].line_end:
    cocci.include_match(False)
@@
position r1.p;
@@
-;@p
// </smpl>

Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e
Reviewed-on: https://gerrit.libreoffice.org/9493
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-27 01:19:00 -05:00
e32da77836 oox: sal_Bool->bool
Change-Id: Icddec34e91305cfc3f9d852472bb86eab4d8cb26
2014-04-23 11:11:51 +02:00
e13022a825 Clean up function declarations and some unused functions
Change-Id: I2f5b3144e8d4ce3e497a030aa102985c3bc81645
2014-04-14 14:15:12 +02:00
63dc7b1ce8 SCROLLABLEFRAME never defined 2014-04-14 12:31:47 +02:00
07a43d8db4 SvxMSConvertOCXControlsRemoved never defined 2014-04-14 12:31:46 +02:00
5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
567ef6d578 Second batch of adding SAL_OVERRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: Ie656f9d653fc716f72ac175925272696d509038f
2014-03-27 18:12:18 +01:00
dd139fa3e4 coverity#735446 Logically dead code
Change-Id: I6615145e2529193cbe72f4e5d326832a5b8864d0
2014-03-25 12:33:21 +00:00
f566585f08 remove the inheritance to std::map in PropertyMap
Change-Id: Iaaf5b7ab47ffa151cd7c8ea376763d02c883f377
2014-03-04 18:43:38 +01:00
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
40961d7bcd Remove visual noise from oox
Change-Id: Ie25838f20f00dc32d9d22959308c118cef688e94
Reviewed-on: https://gerrit.libreoffice.org/8288
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 09:37:22 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
ad930bddba bool improvements
Change-Id: I171212bbfc2f54a16b5669ab4401a3168e7f0552
2014-01-28 20:26:25 +01:00
54a6b3d7b2 bool improvements
Change-Id: I89c35503d22797c5d5117e298f04e953de03044a
2014-01-14 21:28:08 +01:00
e8ba3d5160 mnMultiSelect takes AX_SELECTION_* values
Change-Id: I1918f91ec070761a8fe9d04058820af1c7880678
2014-01-14 21:28:07 +01:00
99a1f38156 remove unnecessary sal_Unicode casts in OOX module
Change-Id: I2b9f26cb500a9e56f5860bd1b483ed284b84f50d
2013-11-14 08:17:31 +02:00
3f16ec73e0 wrong comparison
regression since ed338bc212725f422f0def21aafc82f05e350646

Change-Id: Ia5dfe7a551abe244c313d3bdb2b90196fc0c6ba2
2013-10-20 19:00:37 +01:00
45e366eadb drop unnecessary tools/string includes
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-20 19:00:36 +01:00
06fe9af13a -Werror,-Wunused-const-variable
Change-Id: I41ec28c39c395b8eb2eaf72f91440f3ae2c3aa99
2013-10-02 16:49:38 +02:00
ba4e24da44 -Werror,-Wunused-const-variable
Change-Id: I7422272a7103bacd36c5d7234b6eb76477f5a2b9
2013-10-02 16:49:38 +02:00
2a4d6c63d1 -Werror,-Wunused-const-variable
Change-Id: Id941d9a9f5fc020e2e5bd11b419461f60b9b4626
2013-10-02 16:49:38 +02:00
02a27cbb72 -Werror,-Wunused-const-variable
Change-Id: I6c028561f0aa2eb4b1a14ed5646f1c10541512d1
2013-10-02 16:49:38 +02:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
949f97ba48 Resolves: #i121162# ImageScaleMode constants should be in UPPERCASE
(cherry picked from commit 734b532fb77d2d5be7eb7becb6720dbd7b3d8978)

Conflicts:
	offapi/com/sun/star/awt/ImageScaleMode.idl
	oox/source/ole/axcontrol.cxx
	reportdesign/source/filter/xml/xmlHelper.cxx
	wizards/com/sun/star/wizards/reportbuilder/layout/ReportBuilderLayouter.java

Change-Id: Ib5fa7b82edddb809129a4e5619a20ca7a7b2e38a
2013-06-27 16:58:09 +01:00
30414067f8 forgotten tweak for spinbutton
see origin f1ecd5ff46a217ee9f4323a08f03e59a53ef551e, f9d08dd5c9af8f8128371540e
& follow up 0a686a9bb54b5c1b3a45810e2601a098c0272c33

Change-Id: I1a10de6984f7ed78efdf6f32bfca14b433b24405
2013-06-26 18:54:15 +01:00
0a686a9bb5 tweak ppt ole import for libreoffice codebase
a) make sure backcolor is skipped when libreoffice backcolor
is default. Libreoffice default is 0 ( but if we write that out mso
reads it as black )
b) don't take the label default backcolor in exchange for the
libreoffice default. Libreoffice default backcolor for label is white,
mso's default is rather different ( and never seems to be used )
c) re-enable compObj export ( seemed this was disabled unintentionally
except for buttons )

Change-Id: Ie68267809cee2e92bd06e88e698f17a10eeeb6ad
2013-06-26 16:45:29 +01:00
5ba4939254 fix ppc build
char is a type distinct from both unsigned char and signed char.

Change-Id: Ia9de35ef42101ce818880b810c44547f1c1a417a
2013-06-18 16:12:27 +02:00
fecd316a96 typo correction AX_SELCTION_xxx -> AX_SELECTION_xxx
petty correct of AX_SELCTION_xxx -> AX_SELECTION_xxx but it
was irritating me

Change-Id: Iae7a0151a63502aa89f04ae54fe7348548ffd32c
2013-06-12 18:53:19 +01:00
d70f6df911 Fix Excel still complains about exported MorphData controls
seems that writing property values that same as file defaults can cause
problems ( this behaviour doesn't seem to be consistent but... ) Fix
up some instances of properties that I've seen make Excel complain

Change-Id: Iacf6789906f07dc35aa5dbe3e7b62f4d2090e20a
2013-06-12 18:52:19 +01:00
7943522291 squash some excel fileformat warnings ( and protected mode opening )
some attributes should not be exported for some controls, their
very presence triggers the dreaded nag dialog ( promising doom
& death if you open the file )

Change-Id: I974ac94f75ee95ab54ca19bd5cd31952a66b20e5
2013-06-11 17:44:02 +01:00
8668453566 fix build error, reinstate WriteOCXExcelKludgeStream to export ole control
new ole export used WriteOCXExcelKludgeStream but that function dissapeared when
msocximex was stripped of ocx control import ( now we use the new filters in oox )
When that stuff was moved WriteOCXExcelKludgeStream was #ifdef'ed out

Change-Id: I370983efa5e8c4ba2b210dfb7535ea211d13a8c1
2013-06-11 14:10:01 +01:00
25bb9d13b2 fix for fdo#53042 fix ole object macro bindings ( for xlsm )
A number of fixes needed here
a) make sure convert properties of control model is done before inserting
control model into formcontainer, need to do that to ensure that
GenerateVBAEvents is set ( so the fake VBA event generation can be
triggered )
b) remove the IsAlieanExcel check in servuno.cxx ( it's too strict and
additionally seems there is confusion over the media type to check )
c) split the vba import so that we can ensure the VBA mode is set (if
we have modules to import ) before sheets are imported and defer further
processing ( actual assigning of the modules and associated objects )
until later

Change-Id: I8fdbe788b400d7e41d4cc4b51b15f692bd7b0ecc
2013-06-04 15:29:45 +01:00
c2703b63fa remove non-sensical /*static*/ comments
They are presumably meant to say the functions are class-static,
but at the function definition it's pretty confusing (looks like file-static).

Change-Id: I28c69244c9eb7aa3f20f07d8784f3704dc6a57bf
2013-05-14 19:48:32 +02:00
880da6c7b7 fix userform data aware control import
Change-Id: I86f5cc0c60bba48eaaf40a3471cc0fb22e5e4b9c
2013-05-09 14:11:21 +01:00
72e5d0c8fb Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-30 13:34:06 +01:00
b850ab574c fix Frame import for oox filter
Change-Id: Ie165b509ea7668a3064e16b537bf2e51345324ba
2013-04-18 12:33:07 +01:00
a43cc9ec8d implement MultiPage, Page & TabStrip import for oox
Change-Id: I1912c9550c12a971fcc7fdbc8bd623f18ccc40b8
2013-04-17 17:10:31 +01:00
4c0c23af21 Simplify equalsIgnoreAsciiCaseAscii[L] calls
Change-Id: If5201bd772aed245e8f7f8b900d76ffe4ca57b49
2013-03-19 11:32:20 +01:00
9be25f14bd avoid Wundef for various FIXME, FEATURE_NOT_DONE_YET and what not
Change-Id: I8e409ba63d32dca9a1c7f09d143165d1d702d642
2013-03-18 17:15:56 +01:00
63bcb139b9 Replaced O[U]String::valueOf( static_cast<> ) with O[U]String::number()
Change-Id: I2f11f2f15a652a9edc3c7e5b67c854debeed20de
Reviewed-on: https://gerrit.libreoffice.org/1784
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-01-21 15:04:17 +00:00
b08ded38b0 oox: kill no longer needed CREATE_OUSTRING 2013-01-04 16:11:57 +01:00
ed338bc212 OUString cleanup in oox
Change-Id: Id3c121acddd515621325c93735bb3dd88592749e
Signed-off-by: José Guilherme Vanz <guilherme.sft@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/1485
Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com>
Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
2012-12-26 08:00:52 +00:00
78fc1e1b95 PCH for Library_oox 2012-12-13 21:49:59 +01:00
e40e6b26eb Remove some other newly tagged unused methods
Change-Id: I6413fa7b9a7ca5e5f88c634ac4a7092162a9a9c9
2012-11-23 22:52:05 +01:00
41c77ac5e8 targetted cleanup of misc. vba pieces. 2012-11-16 18:21:38 +00:00
5f78685ebf oox: make things easier to debug by tracing exceptions
Change-Id: I05df8435874eb65f3acedaaea50b4910e9fc9111
2012-11-09 17:37:01 +01:00
e8aa70b5d4 fdo#46808, convert comphelper::ConfigurationHelper to XComponentContext
Convert the helper methods to take an XComponentContext parameter,
instead of XMultiServiceFactory.

Change-Id: I9f0098af37b91f107d8799f14caa04756eac82b1
2012-10-24 11:29:53 +02:00
7518af82eb oox: fix loplugin warnings
Change-Id: I73375f46d31ef7446b7c059aa2a23024e677021c
2012-10-13 22:35:23 +02:00