9bac4d413e
typo: more then -> more than
...
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
184a00b962
loplugin: inlinesimplememberfunctions
...
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
7e4c6e1ff1
remove unnecessary linefeeds from the end of exception messages
...
Change-Id: Id1d7971639b2496dbe0274423ff4150d9295e8d6
2014-05-29 09:01:39 +02:00
e7bc3cab01
remove boilerplate in UNO Exception constructor calls
...
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.
Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
3c1e30b77d
Correct common misspellings, and remove some ASCII art along the way.
...
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c
Reviewed-on: https://gerrit.libreoffice.org/9356
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
2014-05-17 12:38:38 +00:00
8c004aa108
cid#982783 Unintentional integer overflow
...
Change-Id: Ida52d1fbe3d84c9c0070c91ae24cae58dc4aa13f
2014-05-14 09:49:08 +02:00
5df6dcf747
package: sal_Bool->bool
...
Change-Id: I05dd5070d0618ef7539b26c7edcaf01b0a84732c
2014-04-22 09:53:14 +02:00
d75f773f62
fixincludeguards.sh: package
...
Change-Id: Ia66d825baad3315c34bd579dc804f607bc6be30b
2014-04-19 11:10:11 +02:00
6f7ca49591
package: sal_Bool->bool
...
Change-Id: I66999e5d9f827650f4c1bccb14178f8fa8a57cbf
2014-04-03 09:17:50 +02:00
70cc2b191b
First batch of adding SAL_OVERRRIDE to overriding function declarations
...
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.
Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
52cc0c8f05
coverity#982784 Unintentional integer overflow
...
Change-Id: Ib50e0987adf419ecdd569fc5dd5c8b2b1e246e2f
2014-03-21 08:54:44 +00:00
16b6b45e8c
coverity#707964 Uninitialized scalar field
...
Change-Id: I051e5ae4200563426d810e9a4d94ab02fb8ccf51
2014-03-21 08:54:44 +00:00
86a32589e9
Find places where OUString and OString are passed by value.
...
It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.
So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.
Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-18 08:32:26 +02:00
5e21a413c7
cppuhelper: retrofit std::exception into overriding exception specs
...
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
05f742d28b
comphelper: sal_Bool -> bool
...
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
0f50845dbd
bool improvements
...
Change-Id: I5dfdb3a11737a2cb805ff44652c9ca502e5fc81b
2014-01-28 20:26:25 +01:00
cb64711136
Don't use OSL_LOG_PREFIX when throwing exceptions in non-debug builds.
...
Using OSL_LOG_PREFIX in the exceptions is not a good idea; it blows the size
of the string literals tremendously - full build path for every line that uses
that, including the line.
Let's not remove it for good, but hide it for non-debug builds
(OSL_DEBUG_LEVEL == 0) so that anybody who would like to use this during
debugging could still do (but I doubt it has any value for anybody).
Change-Id: Icc8db95ae0862671a206e681f92c60cdf51ffc32
2014-01-27 23:21:43 +01:00
8233226fe4
No need for implbase1.hxx to include XComponentContext.hpp
...
...which it did unlike all the other implbaseN.hxx. Required lots of downstream clean-up,
of course.
Change-Id: Ib720e7a0a43410dcd7e6338b84a3973dfbb20866
2013-12-17 17:32:58 +01:00
a7724966ab
Bin comments that claim to say why some header is included
...
They are practically always useless, often misleading or obsolete.
Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
7bdbe709ea
WaE: unused variable
...
Change-Id: Iad493e5022a36895a30438340826ef4df50b2837
2013-10-02 19:37:30 +03:00
608dec14f1
fdo#62475 removed pointless comments
...
Change-Id: Ic3743e48ef9055933ff040c180561ef41b3a2990
Reviewed-on: https://gerrit.libreoffice.org/5174
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org >
Tested-by: Fridrich Strba <fridrich@documentfoundation.org >
2013-07-31 16:26:12 +00:00
4d220882b4
hair splitting on years in dates in ZIP structure
...
Change-Id: I9d7a6436e3df75eff592d19dcaca0f655ebf2160
2013-07-05 12:22:04 +02:00
ba0a57702c
remove OUString wrap for string literals
...
For some functions and all kinds of Exceptions.
CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException
createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService
bash command:
for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
| cut -d ':' -f1 | sort -u
| xargs sed -i
-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
-e "s/\($i.*\)\"+ /\1\" + /g";
done
Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org >
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2013-06-29 21:52:54 +00:00
1b049bd2da
Accept even more corrupted zip documents as long as we can read them
...
Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
2013-05-30 12:35:39 +02:00
482d1ae3d0
Revert "Accept even more corrupted zip documents as long as we can read them"
...
This reverts commit ef2ad0063a530aee186568579378a368180547a4.
2013-05-30 12:35:39 +02:00
ef2ad0063a
Accept even more corrupted zip documents as long as we can read them
...
Change-Id: I8d039664d6c33d978b9addc3f35cbeae86d6c710
2013-05-30 12:30:08 +02:00
3c38b7727a
zlib: remove ExternalPackage_zlib
...
Change-Id: I5bce88b2044279a6563fd68c35f9c1ac824c8850
2013-05-08 23:34:26 +02:00
1946794ae0
mass removal of rtl:: prefixes for O(U)String*
...
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
aa753f01ba
-Wunused-macros
...
Change-Id: Ifaa1637122d6f9cae1e29b77ac36ca5d1f220aed
2013-03-27 09:36:53 +01:00
78eda507c8
coverity#704243 Logically dead code
...
Change-Id: Ie1140a90a6c9723582fa5e18ca0cf1dc1f918742
Reviewed-on: https://gerrit.libreoffice.org/2942
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Reviewed-by: Thorsten Behrens <tbehrens@suse.com >
Tested-by: Thorsten Behrens <tbehrens@suse.com >
2013-03-23 21:27:50 +00:00
27d02a348b
Improve debug messages
...
Some of those SAL_WARNs might actually better be SAL_INFOs; please change if
they hit too often.
Change-Id: I2a3b9bd485586b7878194f84bc734b54ce69bc06
2013-03-15 18:51:07 +01:00
1dedb15b17
fdo#46808, Adapt xml::crypto::SEInitializer UNO service to new style
...
Also create an NSSInitializer service IDL and split it's interfaces
out from SEInitializer.
It looks like this was the intention all along, but someone
took a shortcut.
Change-Id: I53ac1cb5d38b78b6718fe22c9666eae1f194a3b7
2012-11-05 16:43:14 +01:00
36a2db3722
Replace usage of rtl_*Memory with equivalent from string.h
...
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com >
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com >
2012-10-01 18:48:05 +00:00
5db7ac2392
fdo#49819, fdo#54609: Do not consider timestamp differences as corruption
...
MSO 2010 can produce a files with different timestamps in the
central directory entry and local file header
Change-Id: Ic6fc0b2fad96eb30babdd7e6ef4a0175936da4c5
2012-09-24 09:27:15 +02:00
9b0198b244
package: convert internal ZIP handling data-types to 64bit
...
Prepare for a ZIP64 implementation.
Audit all "Size" property fetches through Anys.
Audit all uses of nSize, nCompressedSize, nOffset through the code.
Add FIXME64: comments to all points requiring future work.
2012-09-21 15:37:17 +01:00
363c1edea6
package: kill RTL_CONSTASCII_USTRINGPARAM in zipapi
...
Change-Id: Ic53f613cfaa5bd4affd0c27b5ed4ed20536ee055
2012-08-31 18:03:22 +02:00
e2f3312ea2
throw earlier on broken zip streams
...
Change-Id: I0de705b4c6a9176e98baed21b2cd960d4d091563
2012-08-28 13:26:11 +01:00
fcd990f208
Some clean up after previous commit
...
Change-Id: Ie419c769c5d661d51c1b43b9808791dcf9e1725c
2012-08-23 09:58:25 +02:00
3e7990faa4
fdo#46808, Shiny UNO, Use factory to create XSimpleFileAccess instances
...
Change-Id: I86e2a8873e5646abd340015f500bf9e872e8e6c5
Signed-off-by: Stephan Bergmann <sbergman@redhat.com >
2012-08-23 09:58:25 +02:00
4be123fed2
Use memcpy & memcmp insteadof rtl_copyMemory & rtl_compareMemory in package
...
Change-Id: Ia24406ff31949e00725db74bbe5b016894a22f50
2012-07-29 15:01:55 +02:00
0ffc81ffdb
re-base on ALv2 code.
2012-06-22 18:32:47 +01:00
b9042fad7c
re-base on ALv2 code.
...
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
2012-06-21 15:00:05 +01:00
eb0497307b
nuke dead code
...
Change-Id: Id9920ea7b82ea178e904f78bbd41ffc434813e0b
2012-06-07 23:03:11 +09:00
78f614e5ff
check key size
...
Change-Id: Ia909b0abb3ef84a9f0a14d42379f693ae9e70812
2012-05-28 15:35:25 +01:00
3934efe28c
sigh, need a 64bit zlib too on windows, reverting
2012-04-13 14:06:55 +01:00
452af5f452
gbuildize internal zlib
...
and stick headers into the solver in the same hierarchy as is "standard"
so we don't have to patch so much, similiarly rename to libz
2012-04-13 13:15:25 +01:00
ccdb4d5c2c
remove dodgy header-guards
2012-02-17 16:36:04 +00:00
39481744b1
drop Z_PREFIX from internal zlib, makes building clucene much easier
2012-02-16 11:13:13 +00:00
dcfc99705f
use sal crc32 and skip cast frenzy
2012-02-15 16:08:46 +00:00
372a0d505c
these were surely meant to be Z_PREFIX not ZLIB_PREFIX
...
seeing as Z_PREFIX is what we set in our internal zlib
and one of these was ZLIB_PREFIXB anyway
2012-02-15 16:03:46 +00:00
