c0415d5f1e
java: remove unnecessary constructor declarations
...
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor
Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
8c9fdc4a96
java: remove modifiers implied by the context
...
found by PMD
Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
3f210b0e75
java: remove unnecessary return statements
...
found by PMD
Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-20 10:35:54 +02:00
a753a458e5
java: avoid if..else when returning boolean values
...
Change-Id: Iab52762a9abfe8735223372b09638ce9d8d44318
2014-08-20 10:35:53 +02:00
60f152caee
java: avoid unnecessary comparisons in boolean expressions
...
i.e. stuff like "x == true"
Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20 10:35:53 +02:00
2922a967a1
java: Avoid naming non-fields with the prefix m_
...
found by PMD
Change-Id: I5955cfc9c4d777496a2e8e4b2c422a51764a8bc1
2014-08-20 10:35:53 +02:00
4b4bff3402
java: no need to instantiate String objects directly
...
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
c552aac9f8
java: use 'Byte.valueOf' instead of 'new Byte'
...
Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90
2014-08-19 14:57:18 +02:00
0764292c5d
java: use 'Short.valueOf' instead of 'new Short'
...
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
8a2c6c29af
java: use 'Long.valueOf' instead of 'new Long'
...
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19 14:57:17 +02:00
ff0ad0493e
java: use 'Integer.valueOf' instead of 'new Integer'
...
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc
java: use Boolean.valueOf instead of instantiating Boolean objects
...
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc
java: classes in java.lang package do not need to be fully qualified
...
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
3a8d351988
java: remove unused methods
...
Change-Id: Ibb905e6f3e7d92a0e558f1f6562e5b472cd2717b
2014-08-19 14:57:13 +02:00
d2a3b21ade
coverity#1132709 Uncaught exception
...
Change-Id: If828f82e36d12ceca7e6392de5757a131c99462c
2014-08-17 16:39:20 +01:00
7a3f09216e
coverity#1231674 Uncaught exception
...
and
coverity#1231675 Uncaught exception
Change-Id: If0907f2048fc5e492d5b8b49388c3bfad542e5f7
2014-08-17 16:39:19 +01:00
0d916bb240
java: remove unused imports
...
Change-Id: Ic60b30141fd1dc61acfb97b811aec680a2ab9c22
2014-08-14 10:59:49 +02:00
63ac956e33
simplify timing code
...
Change-Id: I1ecbfc5183261e400349309924dbf059a32cb95f
2014-08-14 10:59:48 +02:00
537ff23149
improve copmments
...
Change-Id: Ib55ec2f787177829a85a121afb1d3dff2ee7ab1f
2014-08-14 10:59:48 +02:00
ac5954d7c5
java: remove commented out code
...
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
89c0a2b2f6
remove usage of DOCPTH and CNCSTR
...
from the java test code, this was legacy, just finishing the job
Change-Id: I2475efcde561cf10b29ea956972cddc06ec5635e
2014-08-14 10:59:47 +02:00
25e4635d35
clean upo runner.lib.TestParameters
...
- remove unused fields
- make all external code go through the get(XXX)
methods instead of also using the default values
- remove default values
declarations and inline them, since they are now unnecessary.
Change-Id: Idc875fbd133de90044647f3e3b1feb225d81a643
2014-08-14 10:59:47 +02:00
1714027ebe
clean up formatting
...
Change-Id: Ib81b58a6fbcd14a4902bd0650117c07f08088ad6
2014-08-14 10:59:47 +02:00
5ce80c9728
remove dead java constants
...
found by UCDetector
Change-Id: I1f8f5ba4f3ab1a1ef134dd0988f913dab7501351
2014-08-13 13:34:43 +02:00
4a4127d2c4
make some java methods private
...
found by UCDetector
Change-Id: Ic2edbc85194731116aac34064238d11ef1926a98
2014-08-13 13:34:43 +02:00
5ca7fa8db2
make some java fields private
...
found by UCDetector
Change-Id: Ib4cf18be134c3177cb123191e963bb43b7e6de93
2014-08-13 13:34:42 +02:00
34bcf9b498
java: remove dead methods
...
found by UCDetector
Change-Id: I219caa8e680dba5a395541a778df6144841c4dde
2014-08-13 10:24:10 +02:00
8583da1e93
java: remove unused fields
...
found by UCDetector
Change-Id: I4a7c56a9918054c23469de5680658e7b501f0165
2014-08-13 08:49:24 +02:00
68cd011c90
java: reduce scope, make some methods private
...
found by UCDetector
Change-Id: Ib1425edde146193a65c242dc159b7e3fbf0e4a2e
2014-08-13 08:49:23 +02:00
70f56bc22f
java: reduce scope, make member classes private
...
found by UCDetector
Change-Id: Ief32d078090102b14b60b35fc36542f8d4fb252b
2014-08-13 08:49:23 +02:00
da677dfd59
java: reduce scope, make fields private
...
found by UCDetector
Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-13 08:49:22 +02:00
14d1a11ec4
java: reduce scope, make constructors private
...
found by UCDetector
Change-Id: If05277fd2fe77ceabb4c7c87aeb8569e3406102d
2014-08-13 08:49:22 +02:00
e701b3f732
java: reduce scope, make constants private
...
found by UCDetector
Change-Id: Ide9975e361ed17ac8cdcbe67ba74c563a9392d57
2014-08-12 12:16:37 +02:00
9851925959
java: return value of trim() ignored
...
Change-Id: If4cd3eb3e6db0c095796b0ff018162e855afa38c
2014-08-12 09:41:31 +02:00
5656fe58a0
java: fix broken javadoc tags
...
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12 09:41:31 +02:00
1c496506bc
java: remove useless javadoc tags
...
that are not conveying any useful information
Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
0477e6c39b
java: add @Override annotation to overriding methods
...
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
33e94f367a
fdo#82151 finish fixup
...
Fix the UnoApi test, and give ORowSetDataColumn::getFastPropertyValue the reasonable behaviour.
Change-Id: I68cc1221b6772e3036c78b8234b1d8b248d4d673
2014-08-11 16:28:42 +02:00
d5a31b2215
java: remove unused parameters
...
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11 12:33:02 +02:00
41709cc268
java: remove unused parameters
...
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
2014-08-11 12:33:02 +02:00
616b3ad504
java: remove exceptions from throws clauses that are not
...
.. actually thrown
Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00
b6a83e99c8
java: remove redundant null checks
...
Change-Id: Ia42e5ed715fbd3f5b84029a9844da55f307c6260
2014-08-08 09:48:19 +02:00
8f020a45fa
java: redundant assignment, variable can only be null
...
Change-Id: I91209c5c185cf097a1609244419d73d4757d7d18
2014-08-08 09:48:19 +02:00
e5bc8b60ec
java: variable cannot be null
...
remove null check where null-analyis reveals the variable cannot be null
Change-Id: Ied0a24665514bbf68c2ed5f15af9e5c2232a8033
2014-08-08 09:48:19 +02:00
a274d19d11
java: remove redundant super-interfaces
...
Change-Id: Iaf671ef87057362c804999a5154d8e8277bbc4b8
2014-08-08 09:48:18 +02:00
336f3b9153
java: code some code to use non-deprecated constructors
...
Change-Id: I4194a3dfd361d1955cf5bb4fab915150eecfa21a
2014-08-08 09:48:17 +02:00
8d6cf7a147
java: remove dead methods
...
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-08 09:48:16 +02:00
0c5f51ebbc
java: remove commented out code
...
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
d26540bb05
java: remove unused fields
...
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-05 11:31:50 +02:00
36a74fe54a
java: remove unused import
...
Change-Id: Ic703b12c864093764f8d213534af1b2496930e79
2014-08-05 11:31:49 +02:00
