Commit Graph

3830 Commits

Author SHA1 Message Date
c0415d5f1e java: remove unnecessary constructor declarations
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
8c9fdc4a96 java: remove modifiers implied by the context
found by PMD

Change-Id: I04cbf986ddbcffff987784f381b8a9f52f1b3f31
2014-08-20 11:45:28 +02:00
3f210b0e75 java: remove unnecessary return statements
found by PMD

Change-Id: I3d150421948d17eaed34fac2b1a212da34288d1a
2014-08-20 10:35:54 +02:00
60f152caee java: avoid unnecessary comparisons in boolean expressions
i.e. stuff like "x == true"

Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20 10:35:53 +02:00
4b4bff3402 java: no need to instantiate String objects directly
Change-Id: I7610774c94bf673ed3b574ffce04c4ee6ca93c03
2014-08-19 14:57:18 +02:00
c552aac9f8 java: use 'Byte.valueOf' instead of 'new Byte'
Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90
2014-08-19 14:57:18 +02:00
0764292c5d java: use 'Short.valueOf' instead of 'new Short'
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long'
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19 14:57:17 +02:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
d2a3b21ade coverity#1132709 Uncaught exception
Change-Id: If828f82e36d12ceca7e6392de5757a131c99462c
2014-08-17 16:39:20 +01:00
7a3f09216e coverity#1231674 Uncaught exception
and

coverity#1231675 Uncaught exception

Change-Id: If0907f2048fc5e492d5b8b49388c3bfad542e5f7
2014-08-17 16:39:19 +01:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
89c0a2b2f6 remove usage of DOCPTH and CNCSTR
from the java test code, this was legacy, just finishing the job

Change-Id: I2475efcde561cf10b29ea956972cddc06ec5635e
2014-08-14 10:59:47 +02:00
5656fe58a0 java: fix broken javadoc tags
Change-Id: I43d25ba49b758739ee8dc891b0db3e527004ec8b
2014-08-12 09:41:31 +02:00
1c496506bc java: remove useless javadoc tags
that are not conveying any useful information

Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-12 09:41:31 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
33e94f367a fdo#82151 finish fixup
Fix the UnoApi test, and give ORowSetDataColumn::getFastPropertyValue the reasonable behaviour.

Change-Id: I68cc1221b6772e3036c78b8234b1d8b248d4d673
2014-08-11 16:28:42 +02:00
d5a31b2215 java: remove unused parameters
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11 12:33:02 +02:00
41709cc268 java: remove unused parameters
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
2014-08-11 12:33:02 +02:00
616b3ad504 java: remove exceptions from throws clauses that are not
.. actually thrown

Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00
b6a83e99c8 java: remove redundant null checks
Change-Id: Ia42e5ed715fbd3f5b84029a9844da55f307c6260
2014-08-08 09:48:19 +02:00
8f020a45fa java: redundant assignment, variable can only be null
Change-Id: I91209c5c185cf097a1609244419d73d4757d7d18
2014-08-08 09:48:19 +02:00
e5bc8b60ec java: variable cannot be null
remove null check where null-analyis reveals the variable cannot be null

Change-Id: Ied0a24665514bbf68c2ed5f15af9e5c2232a8033
2014-08-08 09:48:19 +02:00
8d6cf7a147 java: remove dead methods
Change-Id: I9f2e705fd603a7c8832c0f0772bee9f395380a0d
2014-08-08 09:48:16 +02:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
d26540bb05 java: remove unused fields
Change-Id: I6c93864f501f646a8940eac221a88c87b3f75525
2014-08-05 11:31:50 +02:00
dfd4b94a52 java: remove some unused import statements
Change-Id: Id6342be66221c81b05aee9af519c800e51a286b3
2014-08-04 13:38:31 +02:00
9658b27b69 java: remove some unused variables
Change-Id: Ia9405d3e34e710059ff68bf850de91c36f4e1e1b
2014-08-04 13:38:30 +02:00
f493555623 java: remove some casting in lib.TestParameters#getMSF
where the return value is always cast to XMultiServiceFactory,
so just do the cast in the method and avoid noise at the call sites.

Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
2014-08-04 13:38:30 +02:00
f6aea4202c java: removed unused imports
Change-Id: I3e3d15719cd1bc4fe4f0dec2c21a3414bde6a808
2014-08-04 13:38:29 +02:00
0a7b80a02e fix spelling compilant -> compliant
Change-Id: I5a469226a576906f0dd860c008d2e3fab1659ff7
2014-08-04 13:38:29 +02:00
405f9d4eea fix spelling sinse -> since
Change-Id: Ia2e52c2decd350bf2e5e513a66bb952104e7a6a8
2014-08-04 13:38:29 +02:00
dc2cd08af1 simplify some java static initializers
Change-Id: Ic767b655297bfb5fcfb5cd7878d7131a9cb6b2f1
2014-08-04 11:52:16 +02:00
9bac4d413e typo: more then -> more than
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-08-01 23:40:12 +09:00
e18c3848d1 Improve test failure output
Change-Id: Icfb4af890548a2a11d638c59bb0fb54aaa01a2ed
2014-06-16 10:18:09 +02:00
f2023b24ff Many spelling fixes: directory qadevOOo.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done  before.

(cherry picked from commit c3f20ae9a447f50517fe545a53de91d412c3337c)

Conflicts:
	qadevOOo/runner/base/java_complex.java
	qadevOOo/runner/basicrunner/BasicHandler.java
	qadevOOo/runner/basicrunner/basichelper/Connector.java
	qadevOOo/runner/helper/LoggingThread.java
	qadevOOo/runner/helper/StreamSimulator.java
	qadevOOo/runner/helper/URLHelper.java
	qadevOOo/runner/stats/SQLExecution.java
	qadevOOo/runner/util/SOfficeFactory.java
	qadevOOo/runner/util/utils.java
	qadevOOo/tests/basic/ifc/awt/XWindow/awt_XWindow.xba
	qadevOOo/tests/basic/ifc/beans/XPropertyState/beans_XPropertyState.xba
	qadevOOo/tests/basic/ifc/container/XIndexReplace/container_XIndexReplace.xba
	qadevOOo/tests/basic/ifc/io/XMarkableStream/io_XMarkableStream.xba
	qadevOOo/tests/basic/ifc/lang/XInitialization/lang_XInitialization.xba
	qadevOOo/tests/basic/ifc/sdbc/XCloseable/sdbc_XCloseable.xba
	qadevOOo/tests/basic/ifc/sdbcx/XRowLocate/sdbcx_XRowLocate.xba
	qadevOOo/tests/basic/ifc/text/XRelativeTextContentInsert/text_XRelativeTextContentInsert.xba
	qadevOOo/tests/basic/ifc/text/XTextColumns/text_XTextColumns.xba
	qadevOOo/tests/basic/mod/dynamicloader.uno/Dynamic/dynamicloader_uno_Dynamic.xba
	qadevOOo/tests/basic/mod/dynamicloader/Dynamic/dynamicloader_Dynamic.xba
	qadevOOo/tests/basic/mod/sc/ScDDELinkObj/sc_ScDDELinkObj.xba
	qadevOOo/tests/basic/mod/sc/ScDDELinksObj/sc_ScDDELinksObj.xba
	qadevOOo/tests/basic/mod/sc/ScIndexEnumeration_DDELinksEnumeration/sc_ScIndexEnumeration_DDELinksEnumeration.xba
	qadevOOo/tests/java/ifc/container/_XNameReplace.java
	qadevOOo/tests/java/ifc/document/_XStandaloneDocumentInfo.java
	qadevOOo/tests/java/ifc/frame/_XFrame.java
	qadevOOo/tests/java/ifc/i18n/_XCalendar.java
	qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
	qadevOOo/tests/java/ifc/sdbc/_XRowSet.java
	qadevOOo/tests/java/ifc/sheet/_XSheetCellCursor.java
	qadevOOo/tests/java/ifc/util/_XTextSearch.java
	qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java
	qadevOOo/tests/java/mod/_bridgefac.uno/package.html
	qadevOOo/tests/java/mod/_connector.uno/package.html
	qadevOOo/tests/java/mod/_corereflection.uno/package.html
	qadevOOo/tests/java/mod/_forms/GenericModelTest.java
	qadevOOo/tests/java/mod/_implreg.uno/package.html
	qadevOOo/tests/java/mod/_introspection.uno/package.html
	qadevOOo/tests/java/mod/_invocadapt.uno/package.html
	qadevOOo/tests/java/mod/_invocation.uno/package.html
	qadevOOo/tests/java/mod/_nestedreg.uno/package.html
	qadevOOo/tests/java/mod/_sc/XMLMetaImporter.java
	qadevOOo/tests/java/mod/_servicemgr.uno/package.html
	qadevOOo/tests/java/mod/_shlibloader.uno/package.html
	qadevOOo/tests/java/mod/_simplereg.uno/package.html
	qadevOOo/tests/java/mod/_streams.uno/package.html
	qadevOOo/tests/java/mod/_sw/SwXTextView.java
	qadevOOo/tests/java/mod/_sw/XMLMetaImporter.java
	qadevOOo/tests/java/mod/_typeconverter.uno/package.html
	qadevOOo/tests/java/mod/_typemgr.uno/package.html
	qadevOOo/tests/java/mod/_uuresolver.uno/package.html
	qadevOOo/tests/java/mod/_xmloff/Draw/XMLMetaImporter.java
	qadevOOo/tests/java/mod/_xmloff/Impress/XMLMetaImporter.java

Change-Id: I1ca48fdbb7aa71685b6145218d482dd9fa41be26
2014-04-30 20:43:31 +01:00
982babed5c Fix typo: cought => caught
Change-Id: I4fcede18c4b36a2b35f7fafae997f14acef84394
2014-04-27 14:00:42 +02:00
9a7fc5ee26 Typo: s/shure/sure
Change-Id: I1c55d3ee8be06deb6d48a6ad5cd30d170c8b9dbb
2014-04-18 00:30:35 +03:00
29368617fa typo: curosr -> cursor 2014-04-14 12:33:04 +02:00
aa0493be8c typo: puposes -> purposes 2014-04-14 12:32:29 +02:00
2d4afd15f0 typo: excption -> exception 2014-04-14 12:32:27 +02:00
cc1352243e typo: accesible -> accessible 2014-04-14 12:32:01 +02:00
6835d9f307 It's "its", not "it's"
Change-Id: Ieaa787afd7cc622b4750a2ee8f17f6dad934ba63
2014-04-10 20:22:50 +03:00
9d7ee8a70f qadevOOo: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I1efcc27818c8ec92db32151afc8f17bbf7fc1f40
2014-03-10 17:39:57 +01:00
faabee6755 Remove visual noise from qadevOOo
Change-Id: I3d65145422039d629d2375c9fef030cd6ee41124
Reviewed-on: https://gerrit.libreoffice.org/8291
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:59:24 -06:00
8e000814ef Typo: folowing -> following + elemtens -> elements
Change-Id: Ice7ae2e82085ba5f0061ba1a960f693744e45e63
2014-02-25 22:11:12 +01:00
55d3127f6c Typo: "omited"/"ommitted"/"ommited" -> "omitted"
Change-Id: Icc690b0ae1fc8f7165082774720d265798815faa
2014-02-12 20:08:03 +01:00
4ed804d928 Typo: realtion -> relation
Change-Id: I2ec2d716eaff6c6dc03bf657e77daa8e4d57cb53
2014-02-06 21:25:21 +01:00