Commit Graph

2446 Commits

Author SHA1 Message Date
c0415d5f1e java: remove unnecessary constructor declarations
in the absence of any other constructors, the compiler will automatically
generate a public no-arg constructor

Change-Id: I70eca507cd8e16e33580b3398d41d70690bc2909
2014-08-20 12:12:15 +02:00
60f152caee java: avoid unnecessary comparisons in boolean expressions
i.e. stuff like "x == true"

Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-20 10:35:53 +02:00
c552aac9f8 java: use 'Byte.valueOf' instead of 'new Byte'
Change-Id: Ia99765a6226317ee41ffb02a1b0dd7e6fd944a90
2014-08-19 14:57:18 +02:00
0764292c5d java: use 'Short.valueOf' instead of 'new Short'
Change-Id: Icef19ef61ee0af2dd3bda527263934006271f219
2014-08-19 14:57:18 +02:00
8a2c6c29af java: use 'Long.valueOf' instead of 'new Long'
Change-Id: If4fff3dd37326fbcdd01b743355a16591d71fa69
2014-08-19 14:57:17 +02:00
ff0ad0493e java: use 'Integer.valueOf' instead of 'new Integer'
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-08-19 14:57:17 +02:00
be1bb7b1cc java: use Boolean.valueOf instead of instantiating Boolean objects
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-19 14:57:16 +02:00
56ef5533fc java: classes in java.lang package do not need to be fully qualified
Change-Id: I7b18f62336c3a8ca4c538b30ce04c99f202a4756
2014-08-19 14:57:16 +02:00
ac5954d7c5 java: remove commented out code
Change-Id: I05c907a38b562231e968c17f14e09ef80e0a6ed1
2014-08-14 10:59:48 +02:00
89c0a2b2f6 remove usage of DOCPTH and CNCSTR
from the java test code, this was legacy, just finishing the job

Change-Id: I2475efcde561cf10b29ea956972cddc06ec5635e
2014-08-14 10:59:47 +02:00
0477e6c39b java: add @Override annotation to overriding methods
Change-Id: I086964c6f6ce52c60c52b6dbc445d3c21d22c80a
2014-08-12 09:41:28 +02:00
33e94f367a fdo#82151 finish fixup
Fix the UnoApi test, and give ORowSetDataColumn::getFastPropertyValue the reasonable behaviour.

Change-Id: I68cc1221b6772e3036c78b8234b1d8b248d4d673
2014-08-11 16:28:42 +02:00
d5a31b2215 java: remove unused parameters
Change-Id: Ifc44c51ddbd21fabaad686bc3d38e2dab54d97aa
2014-08-11 12:33:02 +02:00
41709cc268 java: remove unused parameters
Change-Id: I47c618117e079bb2ef90d92c449c8166ea957fa5
2014-08-11 12:33:02 +02:00
616b3ad504 java: remove exceptions from throws clauses that are not
.. actually thrown

Change-Id: Ia326ac7f82e11b948ed0f34e20908a96e7adcd10
2014-08-08 09:48:20 +02:00
8f020a45fa java: redundant assignment, variable can only be null
Change-Id: I91209c5c185cf097a1609244419d73d4757d7d18
2014-08-08 09:48:19 +02:00
e5bc8b60ec java: variable cannot be null
remove null check where null-analyis reveals the variable cannot be null

Change-Id: Ied0a24665514bbf68c2ed5f15af9e5c2232a8033
2014-08-08 09:48:19 +02:00
0c5f51ebbc java: remove commented out code
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-08-05 11:31:50 +02:00
dfd4b94a52 java: remove some unused import statements
Change-Id: Id6342be66221c81b05aee9af519c800e51a286b3
2014-08-04 13:38:31 +02:00
9658b27b69 java: remove some unused variables
Change-Id: Ia9405d3e34e710059ff68bf850de91c36f4e1e1b
2014-08-04 13:38:30 +02:00
f493555623 java: remove some casting in lib.TestParameters#getMSF
where the return value is always cast to XMultiServiceFactory,
so just do the cast in the method and avoid noise at the call sites.

Change-Id: I3a2e06ac6edb3c6021eda6442032db57aaa22e13
2014-08-04 13:38:30 +02:00
f6aea4202c java: removed unused imports
Change-Id: I3e3d15719cd1bc4fe4f0dec2c21a3414bde6a808
2014-08-04 13:38:29 +02:00
0a7b80a02e fix spelling compilant -> compliant
Change-Id: I5a469226a576906f0dd860c008d2e3fab1659ff7
2014-08-04 13:38:29 +02:00
f2023b24ff Many spelling fixes: directory qadevOOo.
Attempt to clean up most but certainly not all the spelling
mistakes that found home in OpenOffice through decades. We
could probably blame the international nature of the code but
it is somewhat shameful that this wasn't done  before.

(cherry picked from commit c3f20ae9a447f50517fe545a53de91d412c3337c)

Conflicts:
	qadevOOo/runner/base/java_complex.java
	qadevOOo/runner/basicrunner/BasicHandler.java
	qadevOOo/runner/basicrunner/basichelper/Connector.java
	qadevOOo/runner/helper/LoggingThread.java
	qadevOOo/runner/helper/StreamSimulator.java
	qadevOOo/runner/helper/URLHelper.java
	qadevOOo/runner/stats/SQLExecution.java
	qadevOOo/runner/util/SOfficeFactory.java
	qadevOOo/runner/util/utils.java
	qadevOOo/tests/basic/ifc/awt/XWindow/awt_XWindow.xba
	qadevOOo/tests/basic/ifc/beans/XPropertyState/beans_XPropertyState.xba
	qadevOOo/tests/basic/ifc/container/XIndexReplace/container_XIndexReplace.xba
	qadevOOo/tests/basic/ifc/io/XMarkableStream/io_XMarkableStream.xba
	qadevOOo/tests/basic/ifc/lang/XInitialization/lang_XInitialization.xba
	qadevOOo/tests/basic/ifc/sdbc/XCloseable/sdbc_XCloseable.xba
	qadevOOo/tests/basic/ifc/sdbcx/XRowLocate/sdbcx_XRowLocate.xba
	qadevOOo/tests/basic/ifc/text/XRelativeTextContentInsert/text_XRelativeTextContentInsert.xba
	qadevOOo/tests/basic/ifc/text/XTextColumns/text_XTextColumns.xba
	qadevOOo/tests/basic/mod/dynamicloader.uno/Dynamic/dynamicloader_uno_Dynamic.xba
	qadevOOo/tests/basic/mod/dynamicloader/Dynamic/dynamicloader_Dynamic.xba
	qadevOOo/tests/basic/mod/sc/ScDDELinkObj/sc_ScDDELinkObj.xba
	qadevOOo/tests/basic/mod/sc/ScDDELinksObj/sc_ScDDELinksObj.xba
	qadevOOo/tests/basic/mod/sc/ScIndexEnumeration_DDELinksEnumeration/sc_ScIndexEnumeration_DDELinksEnumeration.xba
	qadevOOo/tests/java/ifc/container/_XNameReplace.java
	qadevOOo/tests/java/ifc/document/_XStandaloneDocumentInfo.java
	qadevOOo/tests/java/ifc/frame/_XFrame.java
	qadevOOo/tests/java/ifc/i18n/_XCalendar.java
	qadevOOo/tests/java/ifc/sdb/_XSingleSelectQueryComposer.java
	qadevOOo/tests/java/ifc/sdbc/_XRowSet.java
	qadevOOo/tests/java/ifc/sheet/_XSheetCellCursor.java
	qadevOOo/tests/java/ifc/util/_XTextSearch.java
	qadevOOo/tests/java/ifc/xml/sax/_XDocumentHandler.java
	qadevOOo/tests/java/mod/_bridgefac.uno/package.html
	qadevOOo/tests/java/mod/_connector.uno/package.html
	qadevOOo/tests/java/mod/_corereflection.uno/package.html
	qadevOOo/tests/java/mod/_forms/GenericModelTest.java
	qadevOOo/tests/java/mod/_implreg.uno/package.html
	qadevOOo/tests/java/mod/_introspection.uno/package.html
	qadevOOo/tests/java/mod/_invocadapt.uno/package.html
	qadevOOo/tests/java/mod/_invocation.uno/package.html
	qadevOOo/tests/java/mod/_nestedreg.uno/package.html
	qadevOOo/tests/java/mod/_sc/XMLMetaImporter.java
	qadevOOo/tests/java/mod/_servicemgr.uno/package.html
	qadevOOo/tests/java/mod/_shlibloader.uno/package.html
	qadevOOo/tests/java/mod/_simplereg.uno/package.html
	qadevOOo/tests/java/mod/_streams.uno/package.html
	qadevOOo/tests/java/mod/_sw/SwXTextView.java
	qadevOOo/tests/java/mod/_sw/XMLMetaImporter.java
	qadevOOo/tests/java/mod/_typeconverter.uno/package.html
	qadevOOo/tests/java/mod/_typemgr.uno/package.html
	qadevOOo/tests/java/mod/_uuresolver.uno/package.html
	qadevOOo/tests/java/mod/_xmloff/Draw/XMLMetaImporter.java
	qadevOOo/tests/java/mod/_xmloff/Impress/XMLMetaImporter.java

Change-Id: I1ca48fdbb7aa71685b6145218d482dd9fa41be26
2014-04-30 20:43:31 +01:00
cc1352243e typo: accesible -> accessible 2014-04-14 12:32:01 +02:00
9d7ee8a70f qadevOOo: simplify deprecated XTypeProvider.getImplementationId
Change-Id: I1efcc27818c8ec92db32151afc8f17bbf7fc1f40
2014-03-10 17:39:57 +01:00
faabee6755 Remove visual noise from qadevOOo
Change-Id: I3d65145422039d629d2375c9fef030cd6ee41124
Reviewed-on: https://gerrit.libreoffice.org/8291
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:59:24 -06:00
8e000814ef Typo: folowing -> following + elemtens -> elements
Change-Id: Ice7ae2e82085ba5f0061ba1a960f693744e45e63
2014-02-25 22:11:12 +01:00
4ed804d928 Typo: realtion -> relation
Change-Id: I2ec2d716eaff6c6dc03bf657e77daa8e4d57cb53
2014-02-06 21:25:21 +01:00
8f50196ef1 *_AppDispatchProvider_get_implementation cannot bypass XInitialization
...as SfxAppDispatchProvider implements new-style service
css.frame.AppDispatchProvider that doesn't declare any non-default ctors (which
looks broken, though) and old-style service css.frame.DispatchProvicer.

(And fix the test code to pass in meaningful XInitialization arguments.)

Change-Id: Ifcc32d17f6b96ade2acc40ccdb60f7bad2d503a4
2014-02-04 11:51:49 +01:00
ef602ba8ce Remove unused XInitialization.args data
...now that ModuleUIConfigurationManager no longer implements XInitialization
since 72b5343bd16deec540d8cd148cd7aebd74e92c16 "fwk: Use constructor feature for
ModuleUIConfigurationManager."

Change-Id: I479c6c93e9982d80318e53b794bac99e949a5e46
2014-01-20 17:40:52 +01:00
be053c9a80 Spelling correction: s/retrive/retrieve/
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
718de51eb9 Some Java String clean-up
Change-Id: I6728720a13f4b66edc6c5cd0b7a9bcb036e86ff2
2013-11-24 20:58:56 +01:00
a25d360b3e Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I5244e8f8af9560ae986ed3a836bdf9571574420f
2013-11-04 18:24:25 +01:00
baa68e4e89 Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I64389b817d91a2bed8dfe1b8d92bafec42eba21a
2013-11-01 09:41:30 +01:00
ee337e7ed6 Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I4b0ca00c04c2b1c8ffbfe4aaf926305ee9b51f30
2013-10-22 12:24:31 +02:00
dcee4cfcdc Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed, the
same way it had been made more robust for ScAccessiblePageHeader.java in
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments" plus b5dd2b4218f966e177d880bcc29fa5fba3bfe1c1 "Also cope with
intermittend DisposedExceptions."

Change-Id: I4d429a96b7b595776aaf3fa20e3e03b00ca886bc
2013-10-08 10:55:32 +02:00
f52d78bf7c Unused variable (AccessibilityTools is all static members)
Change-Id: I5f3be57dea77cec1cfa3f48833758b0c2328350e
2013-10-08 10:55:32 +02:00
b5dd2b4218 Also cope with intermittend DisposedExceptions
...while waiting for the .uno:PrintPreview request to be processed, see
5b5c52a3a4d048bba8c18dfb06ffca25c670d099 "Try make this more robust in slow
environments."  (However, to avoid an endless loop in case DisposedExceptions
are caused by a crash of soffice.bin, cap the loop at 10 sec.)

Change-Id: I13518eea46deb68731604ef08461bad5bb5f7cdf
2013-10-07 10:22:16 +02:00
32e0f451d6 junit: add 'r' to creating, and better exception descriptions. 2013-09-30 15:28:58 +01:00
7f436c1fd3 typo fixes in comments
Change-Id: Iaadec33715f8e0e0c6595c5e684606905274fdab
2013-09-26 11:47:45 +02:00
5b5c52a3a4 Try make this more robust in slow environments
...where the previous .uno:PrintPreview request has not yet been processed and
xRoot/oObj would still be null.  Hopefully, it does not introduce infinite
loops, though.

Change-Id: Ie79e0b0a3185528ab4036ed7a33de81117c02c83
2013-08-28 13:23:58 +02:00
77dc93ddea What's it with all those *static* XSpreadsheetDocument instances?
...appears to be completely unnecessary, and maybe this helps fix some obscure
DispsedException failures in JunitTest_sc_unoapi (not ones resulting from a
crashed soffice.bin, but "genuine" ones happening when chasing
util.AccessibilityTools.getAccessibleObjectForRole).

Change-Id: I127940e9a2a9784d01255307b60614d53c86436f
2013-08-22 14:55:29 +02:00
bcce27d283 No (apparent?) need for xSheetDoc to be static
Change-Id: Iea653925d383537f5f7f5ef9dd7559e7cb8730cf
2013-08-21 14:19:10 +02:00
8dbfb3bfb1 More little fixes for JunitTest_forms_unoapi
...needed since 8ee69b0ba13f74d1515fac71df92947eb6328ab1 "fdo#67235 adapt form
control code to time nanosecond API change, step 3."

Change-Id: If0fc8109d6da56c8e8df181ae0b35a4d9b34e767
2013-08-05 11:57:23 +02:00
89fbed7e29 Revert "Java cleanup, AccessibilityTools.."
This reverts commit d702dd4396161f8e2e7396f5c24554088b752fcb, which reproducibly
broke JunitTest_sc_unoapi:

java.lang.NullPointerException
 at util.AccessibilityTools.getAccessibleObjectForRole_(AccessibilityTools.java:177)
 at util.AccessibilityTools.getAccessibleObjectForRole(AccessibilityTools.java:95)
 at mod._sc.AccessibleEditableTextPara_PreviewCell.createTestEnvironment(AccessibleEditableTextPara_PreviewCell.java:149)
 at lib.TestCase.getTestEnvironment(TestCase.java:121)
 at base.java_fat.getTestEnvironment(java_fat.java:319)
 at base.java_fat.executeTest(java_fat.java:167)
 at org.openoffice.Runner.run(Runner.java:234)
 at org.openoffice.test.UnoApiTest.test(UnoApiTest.java:38)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:601)
 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
 at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
 at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30)
 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
 at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
 at org.junit.runners.Suite.runChild(Suite.java:128)
 at org.junit.runners.Suite.runChild(Suite.java:24)
 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
 at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
 at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
 at org.junit.runner.JUnitCore.run(JUnitCore.java:136)
 at org.junit.runner.JUnitCore.run(JUnitCore.java:117)
 at org.junit.runner.JUnitCore.runMain(JUnitCore.java:98)
 at org.junit.runner.JUnitCore.runMainAndExit(JUnitCore.java:53)
 at org.junit.runner.JUnitCore.main(JUnitCore.java:45)

Change-Id: I3601fe24db21bd63f7dc6cdf0a1eb69f447d962a
2013-05-21 16:56:30 +02:00
d702dd4396 Java cleanup, AccessibilityTools..
was using a global variable. Yuck.
Fix it to use a local variable. Not perfect, but better.

Change-Id: I27bbbb2ddc89402da53be7f19d2cd963b03b1a83
2013-05-20 09:21:20 +02:00
2ce25faffd fix typos (wich instead of which) 2013-05-06 20:07:23 +02:00
6f17a2f66f Java cleanup, access static methods using correct syntax
Change-Id: I8443aef43d82de33ac7cb47d40cc5b544f7c9c87
2013-04-26 08:36:04 +02:00
64e85a4cc8 Java cleanup, remove unused imports
Change-Id: I697017f196a7f7e5684011ae23941e54051c45dd
2013-04-26 08:29:38 +02:00