54ceedfb4d
coverity#1233491 Dereference null return value
...
Change-Id: Ia02749585cb9694bddb21e4f040cf6e025046be1
2014-09-02 12:14:45 +01:00
d8463f95ea
catch by const
...
Change-Id: I4d51552a28ecd169a03e6c3dad992c9b2217dc74
2014-09-02 12:14:44 +01:00
7ea14056cb
fdo#75757: remove inheritance to std::vector
...
from FontPortionModelList.
Change-Id: Ice34808107a7b381e39d5f7d164590b48a630ee0
Reviewed-on: https://gerrit.libreoffice.org/11229
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2014-09-02 06:10:14 -05:00
1a91abb451
Avoid invalid premature downcasts
...
Change-Id: Ifc6d84a63719b141ddc9bd89349d4a605d2b3e00
2014-09-01 17:09:30 +02:00
024f334c48
Revert "fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode"
...
This reverts commit 15cea073e7ed4970e60967fe036fc492e2052203. I
overlooked the fact during review that this introduces an svx <-> sfx2
circular dependency.
2014-09-01 10:42:12 +02:00
15cea073e7
fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode
...
Change-Id: I9700d0d729a8f2d1255fcd03a07e05799e21f8d0
Reviewed-on: https://gerrit.libreoffice.org/11152
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr >
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr >
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
2014-09-01 03:20:52 -05:00
9fcf955c33
Left-align labels in Detailed Calculation Settings dialog
...
Change-Id: I7e60d45f81dc3adb5567df47b359b627234b5bba
Reviewed-on: https://gerrit.libreoffice.org/11209
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-31 07:18:04 -05:00
a2c6ce60b9
fdo#80538 Add (hidden) edit icons to the toolbar again
...
per https://bugs.freedesktop.org/show_bug.cgi?id=80538#c23
Change-Id: I1e9b06bd84ddbfbf70b4de904679bb99c2b72da0
Reviewed-on: https://gerrit.libreoffice.org/11203
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-31 07:11:06 -05:00
09426fdd94
Improve layout of random number generator dialog
...
New widgets arrangement in Calc - Edit - Fill - Random Numbers dialog.
I placed the distribution parameters closer to the distribution combo box.
Custom Seed and Decimal Places are now global options for the generators.
Help page for the new layout will follow.
Change-Id: I0d3f4c09b2c172271b675078abca6013c35a1da2
Reviewed-on: https://gerrit.libreoffice.org/11206
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-31 07:07:42 -05:00
4e017b4fc3
fdo#80269 (part): Help button for Calc Form dialog
...
Add help button in Calc - Data - Form... dialog
Change-Id: I7263fdc8709add1ce9cca69ece20feb14ab71589
Reviewed-on: https://gerrit.libreoffice.org/11204
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-31 06:46:56 -05:00
e96d259313
interpr: ZinsesZins is Compound Interest
...
There are many more, like ScZinsZ, ScLaufz, ScGetZw,...
And some I can't identify, because my financial vocabulary is limited:
nZr Zinsrate
nZzr Zinseszinsrate
nBw ?
nZw Zinswert
nRmz ?
and many many more ;)
Change-Id: I11c26a8d4519bbd1e8242d27d3815db2bc3fdecd
2014-08-30 11:12:40 +02:00
dcda429221
interpr: fPeriodn -> fPeriods
...
Change-Id: I21b76d2d121b27c5b4aeb676948786ab91bff0b7
2014-08-30 11:12:24 +02:00
e886f9ad66
fdo#39674: translated German to English
...
Conflicts:
sc/source/core/tool/interpr2.cxx
Change-Id: Ib063cafa895abd7d792ca068d727ea161946679c
Reviewed-on: https://gerrit.libreoffice.org/11184
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-30 03:55:44 -05:00
5605a36a31
fdo#39674: Improved translation
...
Conflicts:
sc/source/core/tool/interpr2.cxx
Change-Id: Ib80472a1670b61fdea61bdee4d52b19e28b85d63
Reviewed-on: https://gerrit.libreoffice.org/11192
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-30 03:47:11 -05:00
552b5e1f23
WaE: private field 'mnId' is not used
...
Change-Id: Id3e9c2c380b8c2388eda9e650dae635bfbae7711
2014-08-30 10:04:19 +03:00
fcc6e8ae56
Remove the old xlsx pivot table export code.
...
Change-Id: I6725cbc331b51f66025a8294612c6a5918c07adf
2014-08-29 18:36:40 -04:00
151d7a6223
Write test for importing and exporting of pivot table with 2 data fields.
...
This is for xlsx format.
Change-Id: I8ef2ae41cc88eeeab610e1a89726c62acb9e2fcb
2014-08-29 18:24:32 -04:00
f37c6e0d11
Correctly export subtotal functions of data fields.
...
Take note that data field may be duplicated.
Change-Id: I8f787075869f38d0101da2787bac315c71d8a6e8
2014-08-29 18:24:32 -04:00
3b856f0287
Use the source dimension name when searching for a dimension.
...
Otherwise we might miss the right dimension object. This fixes the bug where
the subtotal function of the second data field was not set correctly when
importing from xlsx.
Change-Id: Id6ecb07b86cf6803a3f6f7604267ce2f5f9a4067
2014-08-29 18:24:32 -04:00
bfaf4401b4
Export data layout field to xlsx correctly.
...
Excel uses a field index of -2 to indicate a data layout field.
Change-Id: I6b18c0bcff439eb4425ef0b0d0b841633dc81dd7
2014-08-29 18:24:31 -04:00
8d57c90b02
WaE: unused function 'isGL3DDiagram'
...
Change-Id: I0af5bf5e7d36036b3f0c98d01c8549c2b8e1aa1f
2014-08-30 00:07:37 +03:00
e9cb48ff65
Write export unit test for pivot table import / export with xlsx.
...
Change-Id: Idc4e9e9aafd3fe0a01758fe988ffacd76cb15784
2014-08-29 14:48:02 -04:00
8d509d69b4
This OpenGL window is useless
...
Change-Id: Ied9914c9a317dc3945c29b984d2a68957275fc52
2014-08-29 17:40:29 +02:00
43d23a24fd
opengl charts: Move the init from sc to chart2, to have the right parent.
...
Conflicts:
chart2/source/view/charttypes/GL3DBarChart.cxx
Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-08-29 17:40:25 +02:00
5990beed9a
Dead code
...
...left over from 95780ec73990f96dc16fc677c895d00fa1360008 "refactor concept for
c++ based subsequenttests"
Change-Id: I8a661f00c122d75e3b71ca51692ba17b6bdb3c56
2014-08-29 16:37:43 +02:00
a13923afa5
Typo in CppunitTest name
...
Change-Id: Ibb683b50b68b8f982fa6e70e48608f2e574b0def
2014-08-29 16:20:25 +02:00
c6270de939
fdo#80538 Show an infobar when document is in read-only mode
...
and remove the Edit icon from the toolbar
Change-Id: I27d9506bd0fb76b3f1ad056a9866f7744674a3e2
Reviewed-on: https://gerrit.libreoffice.org/11182
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr >
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr >
2014-08-29 03:42:38 -05:00
214fd01ba4
Fix signature of dummy non-ORCUS implementation
...
Change-Id: I8ff7d0d8d4f5bfd4426bd3878f77eda714d0f01d
2014-08-29 08:37:03 +02:00
f5aeaa3845
bnc#822173: Initial work on exporting pivot cache and pivot table to xlsx.
...
Still not perfect, but it somewhat does work.
Change-Id: Ic248e20f7ab18a37f56b2034f57551dded956bab
2014-08-28 21:37:08 -04:00
902e3898d3
Make some methods non-inline, and add method descriptions.
...
Change-Id: Ib8d5fa666827a7f97035ad37d05e305bb920c300
2014-08-28 21:37:00 -04:00
8074841146
fdo#39468 Translate German comments in sc/source/ui/miscdlgs
...
Change-Id: I3b15d653206e7c55422a08951466916947052a24
Reviewed-on: https://gerrit.libreoffice.org/11155
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-08-28 01:40:30 -05:00
b77bf9759a
assert on first use
...
Change-Id: I63a513406dbd90746bcad9da88945f49d2b51cc5
2014-08-27 14:05:11 +02:00
53617c8651
callcatcher: update unused code
...
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
aebcabd54c
out-of-bounds string access, this comparison never matched
...
aName == aLinkTabName.copy(nIndex, nLinkTabNameLength)
is not a replacement for
String(aName).Equals(String(aLinkTabName), nIndex, nLinkTabNameLength)
instead use
aName.match( aLinkTabName, nIndex)
because here nLinkTabNameLength actually is aLinkTabName.getLength()
Change-Id: I884f56541f819db5672e9d096a26a3673e82d83b
2014-08-27 00:34:43 +02:00
bbe49667aa
We don't need this branching here anymore.
...
Change-Id: I5253e919b85d66fb826eb76a8369f928611644ed
2014-08-26 09:41:26 -04:00
0b8c73c52f
This one needs to be local time too.
...
Change-Id: I4e0b19689f350018039b5f5a12605ed768be1f04
2014-08-26 09:23:57 -04:00
15bb3995ac
Let's not get the UTC date to see if it fixes test failure in PST.
...
Change-Id: I16276b50d07a221a4003f49cba75f16ca90015c2
2014-08-26 09:16:23 -04:00
4d32244437
Avoid possible memory leaks in case of exceptions
...
Change-Id: Ib4a87cab2729e18b2c830cbd7e7a34d62b5f0f45
2014-08-26 19:47:14 +09:00
a8526c4ab7
unit test for sort with volatile formula cells, fdo#83067
...
Change-Id: Ic832af76daac9114ea09740b725a4a45bd50bc1b
2014-08-26 01:09:45 +02:00
0792aef901
fdo#83067 also volatile cells need to listen to all references
...
As we now broadcast also cell moves it is not sufficient anymore to add
volatile cells only to the BCA_LISTEN_ALWAYS broadcaster, add them as
listener to all referenced cells and ranges as usual.
Change-Id: I7901b73db7e0c82c4bac302ae746810cbc16ea44
2014-08-25 22:00:24 +02:00
1d1d1c62ca
fdo#36772 Move the scrollbar and sheet tabs in a separate row.
...
Change-Id: I57d891d9f6e89dafb4840a577ba55baa734fdcc2
2014-08-25 21:34:48 +02:00
c64945bcb9
sc HTML export: indent conditional block
...
Change-Id: Ia96d201ce10fcb58b213b709506a54760c053643
2014-08-25 18:00:38 +02:00
1ee98159f7
HTML export: avoid invalid output for embedded spreadsheets
...
When the sc document is embedded inside an sw one, then the sc HTML
export should just write what's inside the <body>. Add a filter option
for that in sc and use it from sw.
Change-Id: I3a9605bd62f0628b78cd782c11661f12bc2c3ae4
2014-08-25 17:46:16 +02:00
c6477b9dd1
nitpick no need for an extra indentation level
...
Change-Id: Id7ab390cc28e83ac0ca6b9fff1c172ca46e88a68
2014-08-25 16:20:50 +02:00
c25ac84688
Resolves fdo#81084 fdo#81696 fdo#80874 fdo#81010 : sort causes crash
...
Change-Id: I8fb9ec26bc549c264bfbf30177d720b20677b319
Reviewed-on: https://gerrit.libreoffice.org/11102
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com >
2014-08-25 06:58:00 -05:00
c5d47afc15
Translate German comments, fix some ws
...
Change-Id: Ida67ce193ad032e2a1855e4380626f805514c2f2
Reviewed-on: https://gerrit.libreoffice.org/11103
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2014-08-25 01:16:04 -05:00
21c8b5815a
added Lithuanian "LTL" to EUROCONVERT(), CONVERT()
...
Change-Id: Iefde129177df827c4b6508ff190f20e1e1973221
Reviewed-on: https://gerrit.libreoffice.org/11088
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-24 06:30:11 -05:00
b4558b5081
fdo#73151 Make better use of the sidebar
...
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)
Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
(since they have an icon in the sidebar and the sidebar is shown by default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window
This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151
Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-24 06:26:17 -05:00
7c2697eb1c
Translate German comments, fix some ws
...
Change-Id: I3bc8d82c5689b8a2da1374e42dd70191e2fe8ef3
Reviewed-on: https://gerrit.libreoffice.org/11099
Reviewed-by: Thomas Arnhold <thomas@arnhold.org >
Tested-by: Thomas Arnhold <thomas@arnhold.org >
2014-08-23 20:16:58 -05:00
30ae83c268
fdo#82577: Handle KeyCode
...
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.
Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
