Commit Graph

13543 Commits

Author SHA1 Message Date
d8463f95ea catch by const
Change-Id: I4d51552a28ecd169a03e6c3dad992c9b2217dc74
2014-09-02 12:14:44 +01:00
024f334c48 Revert "fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode"
This reverts commit 15cea073e7ed4970e60967fe036fc492e2052203. I
overlooked the fact during review that this introduces an svx <-> sfx2
circular dependency.
2014-09-01 10:42:12 +02:00
15cea073e7 fdo#44081 don't remove 'edit' pop-up menu entry from form in design mode
Change-Id: I9700d0d729a8f2d1255fcd03a07e05799e21f8d0
Reviewed-on: https://gerrit.libreoffice.org/11152
Reviewed-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Tested-by: Bosdonnat Cedric <cedric.bosdonnat@free.fr>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-09-01 03:20:52 -05:00
3b856f0287 Use the source dimension name when searching for a dimension.
Otherwise we might miss the right dimension object.  This fixes the bug where
the subtotal function of the second data field was not set correctly when
importing from xlsx.

Change-Id: Id6ecb07b86cf6803a3f6f7604267ce2f5f9a4067
2014-08-29 18:24:32 -04:00
8d57c90b02 WaE: unused function 'isGL3DDiagram'
Change-Id: I0af5bf5e7d36036b3f0c98d01c8549c2b8e1aa1f
2014-08-30 00:07:37 +03:00
8d509d69b4 This OpenGL window is useless
Change-Id: Ied9914c9a317dc3945c29b984d2a68957275fc52
2014-08-29 17:40:29 +02:00
43d23a24fd opengl charts: Move the init from sc to chart2, to have the right parent.
Conflicts:
	chart2/source/view/charttypes/GL3DBarChart.cxx

Change-Id: I1e23329345e00e7d8e1f269c832e84d015824c0a
2014-08-29 17:40:25 +02:00
8074841146 fdo#39468 Translate German comments in sc/source/ui/miscdlgs
Change-Id: I3b15d653206e7c55422a08951466916947052a24
Reviewed-on: https://gerrit.libreoffice.org/11155
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-08-28 01:40:30 -05:00
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
aebcabd54c out-of-bounds string access, this comparison never matched
aName == aLinkTabName.copy(nIndex, nLinkTabNameLength)
is not a replacement for
String(aName).Equals(String(aLinkTabName), nIndex, nLinkTabNameLength)
instead use
aName.match( aLinkTabName, nIndex)
because here nLinkTabNameLength actually is aLinkTabName.getLength()

Change-Id: I884f56541f819db5672e9d096a26a3673e82d83b
2014-08-27 00:34:43 +02:00
4d32244437 Avoid possible memory leaks in case of exceptions
Change-Id: Ib4a87cab2729e18b2c830cbd7e7a34d62b5f0f45
2014-08-26 19:47:14 +09:00
1d1d1c62ca fdo#36772 Move the scrollbar and sheet tabs in a separate row.
Change-Id: I57d891d9f6e89dafb4840a577ba55baa734fdcc2
2014-08-25 21:34:48 +02:00
c6477b9dd1 nitpick no need for an extra indentation level
Change-Id: Id7ab390cc28e83ac0ca6b9fff1c172ca46e88a68
2014-08-25 16:20:50 +02:00
b4558b5081 fdo#73151 Make better use of the sidebar
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window

This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151

Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24 06:26:17 -05:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
708fc1c187 fdo#82577, fdo#82579: Handle Cursor
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.

Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
d40700d58e treat datetime as handled
Change-Id: Idc94174662eee5a75a6b467e47cbf9027e3ba224
2014-08-22 23:45:22 +02:00
0f4a999e02 current date/time hotkey inserts also if cell is in input or edit mode
Change-Id: Ib3caed607a5ca1b5ce82de0472223c7bdc8f7f54
2014-08-22 23:45:21 +02:00
e45001fad0 InsertCurrentTime: don't fiddle with the cell while editing
Change-Id: Ia12b10a44b7d90344a009753ddae801b7d58dddf
2014-08-22 23:45:21 +02:00
7afacb97a7 Use anonymous namespace for these. (mostly EnumWrapper)
Change-Id: Ice90e519bbd32a12de59d696a6dfedaaf45bd45e
2014-08-22 23:04:14 +02:00
10b6bda51c init formula options once, fdo#82183
Change-Id: I1db4816f4693e35024c6dc6c70585d7b72e68c32
2014-08-22 04:31:32 +02:00
9344af955b nitpick on comment form
Change-Id: I023f79187aaf6eb943a50516dace2aa229c5a87b
2014-08-22 02:59:57 +02:00
c0aba5007b fdo#82183 do not reset globals while loading a document
Destroying the function list while an instance of the Formula Wizard is
still open is a bad idea. Workaround not doing this when loading a
document due to a DDE function or external reference being entered in
the wizard.

Change-Id: I6fa00fb4f442bf7c9410679e446ff460289e4b16
2014-08-22 01:12:18 +02:00
c08fea639c add missing parameter flag
in dbgutil build gave:
warn:legacy.osl:27022:1:tools/source/rc/resmgr.cxx:701:
file:///build/libo/dev/instdir/program/../program/resource/scen-US.res
Class: 272, Id: 436. Classpointer not at the end!
Resource Stack
Class: 272, Id: 25044

and the following value of the suppress flag was taken in place of the
parameter flag, which was identical and didn't harm in this case, but ...

Change-Id: I951381ef2a5c2d7d7d44892ad5c34ea77ace51ce
2014-08-21 14:10:45 +02:00
da401ac07b Work around unhelpful MSVC error C2216: override cannot be used with inline
Change-Id: I2944b9911b2458bf1c0f1645fd983b635be67bd2
2014-08-20 18:24:52 +02:00
9a42c59394 Bad hack to enforce weakly emitted RTTI for ScValidationDlg
...(by inlining all its virtual functions), as otherwise -fsanitize=undefined
makes sc require ScValidationDlg RTTI (to verify the cast to ScValidationDlg in
the ScValidityRefChildWin ctor in sc/source/ui/view/reffact.cxx) but which would
only be emitted in scui (against which sc cannot link).

Change-Id: Id9e2bf0719ba3bba35e5ae1f0e58190d9fdb6dd4
2014-08-20 17:02:59 +02:00
794d5ac4ac vcl: use enum for complex text layout constants
Since these constants are bitfield flags, we define some methods to make
working with them reasonably type safe.

Move the definitions to outdevstate.hxx, since we need the values there,
and that appears to be the "root most" header file.

Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing
as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write
weird code thinking that it's a real flag.

Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343
Reviewed-on: https://gerrit.libreoffice.org/10676
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-20 09:01:26 -05:00
893d5f9973 Clean up line splicing and indentation
Change-Id: I2b9725052aeaeebef84ec9aedba639f6dda537ff
2014-08-20 15:44:59 +02:00
fdb7429bf5 update input bar with new value
If setting the number format isn't called we need to explicitly update
the input bar.

Change-Id: I60c4808ce86eb659d3faf92d368c5118ee9673b2
2014-08-20 13:43:33 +02:00
32e8c47df8 refine current date/time hotkey handling
Nearing the "do what I mean" principle..

* key date on time cell  =>  current date + time of cell  =>  date+time formatted cell
  * unless time cell was empty or 00:00 time  =>  current date  =>  date formatted cell
* key date on date+time cell  =>  current date + 00:00 time  =>  date+time formatted cell
  * unless date was current date  =>  current date  =>  date formatted cell
* key date on other cell  =>  current date  =>  date formatted cell
* key time on date cell  =>  date of cell + current time  =>  date+time formatted cell
  * unless date cell was empty  =>  current time  =>  time formatted cell
* key time on date+time cell  =>  current time  =>  time formatted cell
  * unless cell was empty  =>  current date+time  =>  date+time formatted cell
* key time on other cell  =>  current time  =>  time formatted cell

Change-Id: I5025e0d0ea9ac83d1b9e0b130262df6db4693a56
2014-08-20 13:43:31 +02:00
a1a480f91e Wa: C4701: potentially uninitialized local variable 'fVal' used
Change-Id: I579205c4cdc3149ef0c1b01daef32155a13d666b
2014-08-20 09:01:41 +03:00
5a05115ee2 more flexible handling of current date/time hotkeys
Let Ctrl+; current date and Shift+Ctrl+; (Ctrl+:) current time behave more
flexible, depending on the formatting (and as such the type) of the existing
cell content.

key date on time  cell => current date + time of cell => date+time formatted cell
key date on other cell => current date => date formatted cell
key time on date  cell => date of cell + current time => date+time formatted cell
key time on other cell => current time => time formatted cell

Change-Id: I2ccbfbab3c50c36a72c4db4696520e32f94caefa
2014-08-19 21:54:46 +02:00
11f145d90f a date is a date, without time
And use DateTime instead of manually concatenating Date and Time.

Change-Id: I6f9fb988beea2a9a17c976d3b98860c4f9ed063b
2014-08-19 21:54:44 +02:00
08edafa656 Consistency around SdrOnOffItem in svx/sdtcfitm.hxx
...similar to what has been done for svx/sdtmfitm.hxx in
6a2ea81ca1622d2c2ad55bea8ddc28167fcc2794 "Remove unused ctors" and
68969cc61adecac481ae9656978ef952f435b310 "Consistency around SdrMetricItem."

Change-Id: Ib461b5d3702e00a9d7cef3229c44e3328c776e1d
2014-08-18 14:56:55 +02:00
d21d5a7261 drop unnecessary shl.hxx includes
Change-Id: Ieb984987c4a4f888a563377e0500444b12f43506
2014-08-18 12:59:49 +01:00
a107bdfdfc ErrorBox->MessageDialog
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-18 10:57:21 +01:00
209cdaa109 coverity#737702 Uncaught exception
Change-Id: Idfc005c1c34c609b7dcaae266cdaf6a15a403e5a
2014-08-17 16:39:19 +01:00
4f1dabfd44 warning C4800: 'int' : forcing value to bool 'true' or 'false'
Change-Id: Ic438fe098f80e96dd4679dda6e5de93a1ba9dc6a
2014-08-17 05:15:20 +02:00
47e2fd0dc8 Consistently use size_t and SAL_MAX_SIZE
Change-Id: Ibab89984ec94556ec368653b6db50c6c2e380dec
2014-08-16 21:52:32 +02:00
384cb5ff7b Consistently use size_t and SAL_MAX_SIZE
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.

Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-16 21:52:28 +02:00
6af3bc396e fdo#79116 make paste special easier to use
This patch adds three short cut buttons to the calc paste special
dialog: paste values only (numbers, strings, dates), paste values and
formats, and paste transposed.

Change-Id: Ie70fbaa28976b2311b1d9cf53b094a5083fb42d4
Reviewed-on: https://gerrit.libreoffice.org/10928
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2014-08-14 19:50:27 -05:00
5cb5c24cc6 RID_SCDLG_DAPISERVICE conversion to .ui
Change-Id: I4194af3033f6591c7a8ca219aebf2ef816edcd63
Reviewed-on: https://gerrit.libreoffice.org/10915
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-13 12:04:15 -05:00
a8525fe5cf fdo#82418 prefer UTF-8 over UTF-16
Change-Id: Id2c990d24dc942a6d061146ea88cf53ee29a1c3d
2014-08-13 17:00:16 +02:00
6da4341228 warning C4242: 'initializing' : conversion from 'size_t' to 'sal_uInt16'
Change-Id: Ie5e64701a011768d861607a2e4267d75b995413e
2014-08-13 10:10:38 +02:00
176e99a965 -Werror,-Wundefined-bool-conversion
Change-Id: I6ff5f855becc44d195ea8043e3c7c1a4873617c4
2014-08-12 12:19:42 +02:00
519026e7aa remove unused RID_SVXDLG_CALCFUNC
Change-Id: I9414c7cc0bd08e819016ed4d263682d8db7c0958
2014-08-09 18:12:13 +02:00
17cf06b69b datafdlg.hxx: remove unused defines
Change-Id: I9b0e5b3803d7b291bd55cf91772dfa3e77646508
2014-08-09 18:12:11 +02:00
444600442b coverity#706946 Uncaught exception
Change-Id: I836e353ae3a8274842465719b3d8ae82ad433375
2014-08-07 18:00:54 +01:00
f97eb186bf coverity#735805 Explicit null dereferenced
Change-Id: I6641930b42f233096f4a0067ab320383ff07a72a
2014-08-07 18:00:50 +01:00
945d6444ad coverity#1158491 Uninitialized pointer field
Change-Id: I618427793885f6dce918e432e5d532f30bed71ad
2014-08-07 18:00:47 +01:00