Commit Graph

924 Commits

Author SHA1 Message Date
53617c8651 callcatcher: update unused code
Change-Id: Idaed255e4f004ad555ccbd6ba9dc29bf522d3c5f
2014-08-27 10:18:31 +01:00
b4558b5081 fdo#73151 Make better use of the sidebar
The general idea is to encourage use of the sidebar instead of floating windows (for Navigator, Styles&Formatting and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the sidebar)
* Remove all Gallery, Navigator and Styles&Formatting links from the default toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens in the sidebar instead of the floating window

This has all been discussed extensively here: https://bugs.freedesktop.org/show_bug.cgi?id=73151

Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-24 06:26:17 -05:00
30ae83c268 fdo#82577: Handle KeyCode
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11
KeyCode typedef.

Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-23 22:33:30 +03:00
708fc1c187 fdo#82577, fdo#82579: Handle Cursor
Put the vcl Cursor in the vcl namespace. Avoids collision with the Xlib Cursor
typedef and some ancient Carbon (?) Cursor typedef on OS X.

Change-Id: I7af770c522b5774c87f58cc079ced9fc1bcc88b0
2014-08-23 19:20:03 +03:00
c0aba5007b fdo#82183 do not reset globals while loading a document
Destroying the function list while an instance of the Formula Wizard is
still open is a bad idea. Workaround not doing this when loading a
document due to a DDE function or external reference being entered in
the wizard.

Change-Id: I6fa00fb4f442bf7c9410679e446ff460289e4b16
2014-08-22 01:12:18 +02:00
384cb5ff7b Consistently use size_t and SAL_MAX_SIZE
Instead of a mix of sal_uIntPtr, sal_uLong, int, and so on.
Also change CONTAINER_ENTRY_NOTFOUND=ULONG_MAX to SAL_MAX_SIZE as
return value in case of failure and in the related tests.

Change-Id: Ie778a849253b4be84fbcdab9557b7c4240233927
2014-08-16 21:52:28 +02:00
9fc83ae4e4 fdo#82241 fix autocompletion for calc functions with
dot or underscore in function name

Change-Id: Id460cad619098265b4ae000894df64a996ef0514
Reviewed-on: https://gerrit.libreoffice.org/10801
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-08-07 15:46:18 +00:00
5e2b4da10c handle autocomplete with dot in formula name, fdo#80058
The problem is that a dot is a word separator so the break iterator
provided by ICU will think that the dot separates two words whereas it
is part of the name here.

Change-Id: I73cee4304f83888b1645fec7b1851b9f42ef879f
2014-08-05 01:29:32 +02:00
2ee3b6deff use a anonymous namespace and sane function names
Change-Id: I8fdd5fb4f21e6c90e352089858ce98a62ac213de
2014-08-05 01:29:32 +02:00
551f76f410 Drop unnecessary SfxApplication::CreateResManager wrapper
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-29 14:27:43 +02:00
ae1fb2e921 Dead declaration
DetectFilter impl. removed in
2fcfebf3900ee4df2e2fe39e37d55ee87ab5d6cb.

Change-Id: Ia21199066ac00c1b0ddc40168bcc7f1406cb9ea0
2014-07-27 12:25:17 +03:00
0d78ad871e DBG_ASSERT->assert when followed by dereference
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-07 10:48:25 +01:00
d92aa2f445 remove SFX_APP() macro that was a mer wrapper for SfxGetApp()
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-27 17:08:04 +02:00
37e6631cc5 remove whitespace
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-25 05:41:10 +02:00
e2080e70fe new compilerplugin returnbyref
Find places where we are returning a pointer to something, where we can
be returning a reference.
e.g.
   class A {
     struct X x;
     public X* getX() { return &x; }
   }
which can be:
     public X& getX() { return x; }

Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-24 11:34:21 +02:00
82da02c107 Translate German comments, fix some ws
There were a lot of spurious \t's in the code.
I replaced them with a space.

Change-Id: I12b3207f0e4d217fb5d4e406e7b16a0d29f3bcaf
Reviewed-on: https://gerrit.libreoffice.org/9831
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-23 03:34:35 +00:00
1d38cb3655 fdo#71076, fdo#71767: Preserve number formats when charts are copied.
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19 14:46:56 -04:00
3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
45f533aee9 loplugin:staticcall
Change-Id: I670fbcd83e368f2821d37a392cbc007b1f4cd55e
2014-06-13 17:54:31 +02:00
bb761be472 Change SfxTabPage ctor SfxItemSet param from ref to pointer
...and also corresponding param of CreateTabPage function type and corresponding
Craete functions.  There were some call sites that passed undefined "null
pointer references" and SfxTabPage internally uses a pointer member pSet that is
checked for null anyway.

Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11 14:39:04 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
246aba2af9 coverity#735802 Unchecked dynamic_cast
Change-Id: I798d5a5f1e28e88b23f478d241a8fcd7519f905f
2014-06-06 11:32:54 +01:00
bab0c4fc0c bin obsolete CLOOK comments
Change-Id: I34f37587284893927463e214f0d7d1c3e914c7b2
2014-05-27 14:00:28 +02:00
81c492ef18 fdo#79011: Properly implement the search results dialog as modeless.
It's unfortunate that adding a modeless dialog is such a pain.  But we
still need to implemenet this properly else we'll leak at best, or end
up with tons of weird bugs at worst.

Change-Id: Ie03260f288fad76f994d0ca6a8b1feeade299ffd
2014-05-23 11:28:13 -04:00
0483124971 Following fdo#78838, let's make this part safe too
(Thank you Eike)

Change-Id: Icc7061c7f7296302d6ed21f0e74a48cbaa82011a
2014-05-20 20:50:44 +02:00
23e9f36a21 simplify and ensure valid miAutoPosColumn in all cases, fdo#78838 related
Unconditionally set miAutoPosColumn at the end of all operations so it
is also valid in case of pColumnData->clear() and no entries inserted
after pDoc->GetDataEntries().

Change-Id: I689632f696091fd9ce8e93c06d7918e5eaf05ab4
2014-05-20 11:43:45 +02:00
1df54514d7 Resolves: fdo#78838 past-the-end iterator
Inserting data in pColumnData invalidated miAutoPosColumn
See https://bugs.freedesktop.org/show_bug.cgi?id=78838#c6

Change-Id: Iece423cd8d14f5ae7bf382583c0369895a00f168
2014-05-20 07:35:25 +02:00
2fc4f5cd75 Register OpenGL windows to ScGridWindow upon file load.
Change-Id: I6fdce232ef41079f20a983dc72da032196078858
2014-05-19 16:03:28 -04:00
a4f32eec65 resolved fdo#78718 break the indefinite loop when entering ="
... introduced with the refactoring of
5a14766061f75e88791dc3134c9ec56e198144e2

Change-Id: Ic322c58cad749d136966cee08ca5a06be59897b7
2014-05-15 12:34:37 +02:00
584b415924 Keep only one class for toolbox color controls
instead of 5 (mostly identical) classes.

Also the following bugs were fixed:

* All pickers now use split buttons. (fdo#45671)
* Color palette now indicates the current color. (fdo#73891)
  (Previous changes related to that bug are reverted as part
  of this commit.)
* Selecting a color from a float panel now updates the
  button. (fdo#77683)
* For Font color/background color in Writer, the color
  that is shown on the button, is always the one that's
  actually used. (Can be a different color after hiding
  the toolbar.)
* For Font color/background color in Writer, the button
  now indicates when we're in the format paintbrush mode.
  (Removed in 085e8a07e61ef2d3a82e11094d8773ab17cfdb3c
  for some reason.)

Change-Id: Idb4829552240c52fb0882aca627c8177bbe2f839
2014-05-14 12:39:42 +03:00
5a14766061 distill copypasta
Change-Id: Ibb6e9e6f98041ddc81b3743f57c3335458be2cb0
2014-05-13 01:17:37 +02:00
ad8a7bf570 include parentheses replacement in functions' formula data, fdo#75264
... to actually make hitting Enter on a function tip work so the
parentheses are added and the cursor is placed in between and the
correct description is displayed.

Change-Id: I2cbe8f9e2b745a8331aeb8744b64d0baa1f0513e
2014-05-12 23:27:03 +02:00
ead754112a nitpick: avoid triple redirection inside loop, fdo#75264 related
Also, it's fdo#12345 instead of fdo12345 (just to provide better
"grep'ability").

Change-Id: Id1c1f849addcb96f71408ba38e2dde8e316271be
2014-05-12 23:27:02 +02:00
5b0b755324 fdo#75264 fix incorrect/missing function tips in Calc
Change-Id: Ibaed735ed1c8dd2dcaf69b82a4c089f1cb35b8cf
Reviewed-on: https://gerrit.libreoffice.org/8218
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-05-12 16:44:20 +00:00
2bac61013e fix-includes.pl: sc
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-05-11 01:55:39 +02:00
1e81a8f843 Translate German comments, fix some ws
Change-Id: If4bd2ece2a2f0bb208fafbb7a9cda9631dc8c1c4
Reviewed-on: https://gerrit.libreoffice.org/9304
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-10 23:39:12 +00:00
7263f4bb20 coverity#1209709 Dereference null return value
Change-Id: Ic5cf8a5f52a7219f32ec2ce9259e5aa0153da9bb
2014-05-09 10:44:22 +01:00
bc834d9780 Translate German comments, fix some ws
Change-Id: I73867affd44a9c252f6892fb36ae5a25289d4d10
Reviewed-on: https://gerrit.libreoffice.org/9263
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-05-08 07:55:22 +00:00
07f14bac2d Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part5
Change-Id: Iea68803e0889288d6d7f21e61e731284f0ad1011
2014-05-08 00:22:38 +02:00
fe451fb94a fdo#78054: Initialize drawing layer when the document contains notes.
Don't be fooled even when the document doesn't have a drawing layer
initialized.  Sometimes a note creates caption on demand later, but if
the drawing layer isn't there the caption will not get created, which
ultimately causes this crash.

Change-Id: I37f4902fa84de91c9f793dc352127d9345a725e3
2014-05-05 15:27:15 -04:00
4f9b21248f simplify ternary conditions "xxx ? yyy : false"
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-05-05 12:47:48 +02:00
56cce6fd81 Implement "fill single edit" mode and map it to Ctrl-' by default.
Excel does this apparently, and lots of people want it.

Change-Id: Ia741ebb84526197d28caa323d36709e38b8f1323
2014-05-02 15:43:46 -04:00
3ce1b10ba7 sc: Add F-Test to Statistics
Change-Id: I31281e863d82a211d7cca897f3e65a0ecfcb5f6b
2014-04-24 22:51:11 +02:00
6dda3d45c9 sc: sal_Bool->bool
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-23 11:11:51 +02:00
97a5ba4a71 remove comments why a file gets included
also remove some commented out code

Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-21 18:08:28 +02:00
b731d71c67 sfx2: Move InitInterface_Impl() method out of SFX_IMPL_INTERFACE.
SFX_IMPL_INTERFACE previously looked like a function; where in fact it is
several methods defined at once, and only the last one has a body.

This is extremely confusing and hard to read; let's kill that nonsense.

Change-Id: Ia4ae22eb58b1260c9c827c894f5345693bad49e7
2014-04-18 22:51:06 +02:00
8c3ab6093a sfx2: Kill SFX_STATUSBAR_REGISTRATION macro.
Change-Id: Iff0ffdb955892117a767e1f31c1f854a93feb560
2014-04-18 22:51:06 +02:00
7acb27081c sfx2: Kill SFX_OBJECTBAR_REGISTRATION macro.
Change-Id: Ic80e9bebba8c7e76a0400769a2f9d75301227194
2014-04-18 22:49:27 +02:00
8773d96958 callcatcher: update unused code
Change-Id: Ia88d83a209113fa4c351c0300d407da0c71baeac
2014-04-18 09:47:57 +01:00
e4181d9a0a typo: ULR -> URL 2014-04-14 12:32:30 +02:00