Commit Graph

196 Commits

Author SHA1 Message Date
945d6444ad coverity#1158491 Uninitialized pointer field
Change-Id: I618427793885f6dce918e432e5d532f30bed71ad
2014-08-07 18:00:47 +01:00
fe5463fb7b the dialog hierarchy changed iwith the ui format, fdo#81867
We need to be explicit now and can no longer rely on GetParent returning
the right object. Seems like sometimes you get punished for an ugly hack
a bit later than expected.

Change-Id: I145e97ae0ceee741c4128c29a6ca26fad2178cb5
2014-07-30 23:31:30 +02:00
37e6631cc5 remove whitespace
Change-Id: Ib15413e73409cc33de01fa92a47b9d1237cfc4b2
2014-06-25 05:41:10 +02:00
184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
3b8ce44eba -Werror,-Wunused-macros
Change-Id: If8685cf1cfcfb25fd611e385d0b32d0b7963cd21
2014-06-06 14:42:45 +02:00
5918209d28 Resolves: fdo#73675 tweak conversion to use SvSimpleTable
Change-Id: Ibfa5c806581c450a0b0407cb07751e06dd3a787e
2014-06-06 13:36:24 +01:00
c45c6e4116 RID_SCDLG_COND_FORMAT_MANAGER conversion to .ui
Change-Id: If3e0ac5afd73ed31f8c21ab68d0c3c765cb447f4
Reviewed-on: https://gerrit.libreoffice.org/9660
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-06 12:36:13 +00:00
b0a9f33a9b Resolves: fdo#79021 cannot delete ListBox from inside its own Select handler
Change-Id: I884e617b112397697a702216b62d0c1e17aae536
2014-06-05 16:41:02 +01:00
2bac61013e fix-includes.pl: sc
Change-Id: Iade3fedac5d2f8e978b7dd9c30f001d7d1564946
2014-05-11 01:55:39 +02:00
6dda3d45c9 sc: sal_Bool->bool
Change-Id: I70aad0b38979f45a313b8ac36890fb6c64d11bb0
2014-04-23 11:11:51 +02:00
b6e73c54c6 coverity#735804 Explicit null dereferenced
Change-Id: I78e1d0ada0728e07e8ea9985eec1ef7334598152
2014-04-07 10:14:50 +01:00
15c819987f coverity#735803 Explicit null dereferenced
Change-Id: Icc65234f1ba54b571097efc0b4e4537a7da99ea8
2014-04-07 10:14:50 +01:00
71c88f02a0 sc: prefer passing OUString by reference
Change-Id: I85e8823e872bf53182ce90576225e462edb1930a
2014-03-17 13:30:50 +02:00
5fe7ecc04f sfx2: sal_Bool->bool
Change-Id: I56a50ee4a169c8f82c830ebf498f7ead1335f0b5
2014-03-14 07:50:34 +02:00
68ec95b3f8 made ListBox handle more than 64k elements, fdo#61520 related
ListBox and related now handle up to sal_Int32 elements correctly.
sal_Int32 instead of sal_Size or size_t because of UNO and a11y API.
Also disentangled some of the mess of SvTreeList and other containers
regarding sal_uInt16, sal_uLong, long, size_t, ... type mixtures.

Change-Id: Idb6e0ae689dc5bc2cf980721972b57b0261e688a
Reviewed-on: https://gerrit.libreoffice.org/8460
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2014-03-05 07:31:19 -06:00
84862db95a Remove visual noise from sc
Conflicts:
	sc/source/ui/inc/docfunc.hxx

Change-Id: I9314437ed3dd60e84d28c08ac0a2d1ed7bd1daf8
Reviewed-on: https://gerrit.libreoffice.org/8301
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-03 11:04:44 -06:00
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
a18a1a4545 Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx
Added vcl/settings.hxx to all cxx files which require it.
This helps to speed up compilation after changes to the settings.

Conflicts:
	sc/source/ui/dbgui/pvlaydlg.cxx

Change-Id: I211a0735c47f72d6879f6f15339355abfe0e3cf4
Reviewed-on: https://gerrit.libreoffice.org/7933
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20 16:22:17 +00:00
12f1faf7bf svl: sal_Bool -> bool
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-20 08:17:00 +01:00
c6d9913782 sal_Bool->bool
Change-Id: I2357e07427778fdd7e53aaf964f5879a14937ddd
2014-02-14 14:15:20 +02:00
fb29c7787b coverity#1158491 Uninitialized pointer field
Change-Id: I6a055ef3146f4934e08d8be9af63e88c317fbeef
2014-01-23 16:02:12 +00:00
04683f1488 Window::Notify should return bool
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
34a94e6855 Resolves: rhbz#1047871 convert conditional formattting dialog to widget layout
the wrapper dialog not the list contained within

Change-Id: I4f4793888885ec5d991f1ab4218cc371726558e6
2014-01-16 12:03:36 +00:00
8548abbac5 Remove unnecessary use of OUString constructor in OUStringBuffer::append calls
Convert code like
  aStrBuffer.append(OUString(" AS "));
to
  aStrBuffer.append(" AS ");

Change-Id: I8c1884b5a875f40f0b5e511b6ef38c6c8eeee656
2013-12-17 11:49:04 +02:00
d933a10c74 Converted data bar options dialog to .ui
all right this time

Change-Id: I9168df3cd83cfa910e4a189b5330a28ad85773ac
2013-11-27 23:35:11 +01:00
b669e31252 Converted data bar options dialog to .ui
Change-Id: I6a1cd4bc3eb91e89c5d15a2281d5f3d4a978df4e
2013-11-27 22:58:58 +01:00
94efa17744 Converted data bar options dialog to .ui
Change-Id: I9168df3cd83cfa910e4a189b5330a28ad85773ac
2013-11-27 22:54:49 +01:00
dd28837249 vcl: mark more Image constructors as "explicit"
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22 14:42:17 +02:00
95ca5cc818 convert sc/source/ui/condformat/*.cxx from String to OUString
Change-Id: I4d615bd1b2138d31a7741d3d22ba65ae4bf38d15
2013-10-08 10:03:13 +02:00
72b9dd277b convert sc/inc/r*.hxx from String to OUString
Change-Id: Iaae69c0914917d9d5851f227be28ff5cd098da8b
2013-10-04 09:09:56 +02:00
568c45f37f convert sc/source/ui/inc/c*.hxx from String to OUString
Change-Id: I364aeba561a0f6688924fddc55634f83fe5045f6
2013-10-04 08:48:59 +02:00
74929bba73 Related: fdo#38838 remove UniString::ToUpperAscii
things got a little out of hand and I ended up
converting quite a bit of calc to OUString

Change-Id: I056326d37ffefa8c120cb2e564d166dd9f20f216
2013-08-30 11:39:01 +01:00
64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
def32c7e14 hide the style boxes to collapse the date entries fully
Change-Id: I58f06a57a05ef007afc203c737acfe29df6ea6a3
2013-06-29 05:46:18 +02:00
aa028cab4a update all style lists when a new style is added
Change-Id: Ib404958e2bc0e3bfe075d1c94f348e907ee004c8
2013-06-29 05:46:17 +02:00
a539cf2c09 use the local setting aware method for the UI, fdo#64754
Change-Id: Ie3117c26b347e1a8996ef9cbcb8b0d6ee561b5b3
2013-06-29 00:08:16 +02:00
f0596516b9 Resolves: fdo#51556 allow tab traversing into the conditional formatting list
Change-Id: Ie08a7312df0d42efc3697089cf766ceeefd623b0
2013-04-29 10:09:15 +01:00
62badf3828 Move to MPLv2 license headers, with ESC decision and author's permission. 2013-04-22 09:37:38 +01:00
02179ab7e7 stash the label widget for shrink mode in the edit, not the button
because we always have we a refedit, but sometimes not a refbutton, so set the
label widget to use for the dialog shrink mode on the refedit instead of the
refbutton. This way we get the shrunken dialog title bar updated with the label
contents regardless of using the shrink button or clicking in the editbox and
dragging the mouse around the spreadsheet triggering the shrink mode

Change-Id: Ifdff01a30d5c65aa964d4bf544017a2927757d67
2013-04-17 10:25:10 +01:00
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
9513e13686 fix above/below equal average ods import/export
Change-Id: I1c305c67772b46cede6b4da3e79578f2f1a8ee89
2013-03-23 08:38:17 +01:00
307b9bfd17 Reduce dependency on document.hxx. Prefer forward declaration.
Change-Id: I9b0c86735284ec435cceb3acd9bad97a6e523a74
2013-03-19 13:40:25 -04:00
213524cf5a make link RefButton and widget for shrunk dialog title explicit
Change-Id: Ia6dd6cc4cf89b067310639bc3da72abbc6fa1ad2
2013-03-08 13:42:32 +00:00
26e37ca4c7 doubled includes
Change-Id: I70ec796188e2388e1e4d699126f7ae817f5ff86e
2013-03-04 13:58:40 +01:00
76b3e61bb4 loplugin: unused variables
Change-Id: I07b82471f0f32e9e894d4eb392beedeafc6be0c7
2013-02-25 05:43:16 +01:00
de1c23bb7d respect local number format in cond format dlg, fdo#60574
Change-Id: Iec185ac6c6447176731619249cdda4457f1bb8a3
2013-02-20 16:28:26 +01:00
55b39ff42e Remove excessive inclusion of cell.hxx from other headers.
In favor of forward delaration and/or inclusion of more specialized
headers.

Change-Id: I75f727cc50228b8958b60173ce14e5ce1fb7e6f7
2013-02-12 13:06:31 -05:00
c842966fa4 remaining ui parts for conditional date formats
Conflicts:
	sc/inc/globstr.hrc
	sc/source/ui/condformat/condformatdlgentry.cxx

Change-Id: Ibc1dc80faa64d97e3d600ce40a97a716804cfac8
2013-01-28 13:47:27 +01:00
0367a2679b fix typo
Change-Id: I9ec827e0c4000844c495f788e6fc166d41bdb944
2013-01-26 00:49:16 +01:00